linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] staging: qlge: fix indentation
@ 2022-07-15 14:30 Louis Goyard
  2022-07-27  6:42 ` Greg Kroah-Hartman
  0 siblings, 1 reply; 2+ messages in thread
From: Louis Goyard @ 2022-07-15 14:30 UTC (permalink / raw)
  To: Manish Chopra, GR-Linux-NIC-Dev, Coiby Xu, Greg Kroah-Hartman,
	netdev, linux-staging, linux-kernel

From: Louis Goyard <louis.goyard@hashi.re>

Adhere to linux coding style. Reported by checkpatch:
WARNING: suspect code indent for conditional statements (16, 32)

Signed-off-by: Louis Goyard <louis.goyard@hashi.re>
---
  drivers/staging/qlge/qlge_main.c | 12 ++++++------
  1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/drivers/staging/qlge/qlge_main.c 
b/drivers/staging/qlge/qlge_main.c
index 1a378330d775..8eb0048c596d 100644
--- a/drivers/staging/qlge/qlge_main.c
+++ b/drivers/staging/qlge/qlge_main.c
@@ -3008,9 +3008,9 @@ static int qlge_start_rx_ring(struct qlge_adapter 
*qdev, struct rx_ring *rx_ring
  		base_indirect_ptr = rx_ring->lbq.base_indirect;

  		for (page_entries = 0; page_entries <
-			MAX_DB_PAGES_PER_BQ(QLGE_BQ_LEN); page_entries++)
-				base_indirect_ptr[page_entries] =
-					cpu_to_le64(tmp + (page_entries * DB_PAGE_SIZE));
+				MAX_DB_PAGES_PER_BQ(QLGE_BQ_LEN); page_entries++)
+			base_indirect_ptr[page_entries] =
+				cpu_to_le64(tmp + (page_entries * DB_PAGE_SIZE));
  		cqicb->lbq_addr = cpu_to_le64(rx_ring->lbq.base_indirect_dma);
  		cqicb->lbq_buf_size =
  			cpu_to_le16(QLGE_FIT16(qdev->lbq_buf_size));
@@ -3023,9 +3023,9 @@ static int qlge_start_rx_ring(struct qlge_adapter 
*qdev, struct rx_ring *rx_ring
  		base_indirect_ptr = rx_ring->sbq.base_indirect;

  		for (page_entries = 0; page_entries <
-			MAX_DB_PAGES_PER_BQ(QLGE_BQ_LEN); page_entries++)
-				base_indirect_ptr[page_entries] =
-					cpu_to_le64(tmp + (page_entries * DB_PAGE_SIZE));
+				MAX_DB_PAGES_PER_BQ(QLGE_BQ_LEN); page_entries++)
+			base_indirect_ptr[page_entries] =
+				cpu_to_le64(tmp + (page_entries * DB_PAGE_SIZE));
  		cqicb->sbq_addr =
  			cpu_to_le64(rx_ring->sbq.base_indirect_dma);
  		cqicb->sbq_buf_size = cpu_to_le16(SMALL_BUFFER_SIZE);
-- 
2.37.1

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] staging: qlge: fix indentation
  2022-07-15 14:30 [PATCH] staging: qlge: fix indentation Louis Goyard
@ 2022-07-27  6:42 ` Greg Kroah-Hartman
  0 siblings, 0 replies; 2+ messages in thread
From: Greg Kroah-Hartman @ 2022-07-27  6:42 UTC (permalink / raw)
  To: Louis Goyard
  Cc: Manish Chopra, GR-Linux-NIC-Dev, Coiby Xu, netdev, linux-staging,
	linux-kernel

On Fri, Jul 15, 2022 at 04:30:37PM +0200, Louis Goyard wrote:
> From: Louis Goyard <louis.goyard@hashi.re>
> 
> Adhere to linux coding style. Reported by checkpatch:
> WARNING: suspect code indent for conditional statements (16, 32)
> 
> Signed-off-by: Louis Goyard <louis.goyard@hashi.re>
> ---
>  drivers/staging/qlge/qlge_main.c | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/staging/qlge/qlge_main.c
> b/drivers/staging/qlge/qlge_main.c
> index 1a378330d775..8eb0048c596d 100644
> --- a/drivers/staging/qlge/qlge_main.c
> +++ b/drivers/staging/qlge/qlge_main.c
> @@ -3008,9 +3008,9 @@ static int qlge_start_rx_ring(struct qlge_adapter
> *qdev, struct rx_ring *rx_ring
>  		base_indirect_ptr = rx_ring->lbq.base_indirect;
> 
>  		for (page_entries = 0; page_entries <
> -			MAX_DB_PAGES_PER_BQ(QLGE_BQ_LEN); page_entries++)
> -				base_indirect_ptr[page_entries] =
> -					cpu_to_le64(tmp + (page_entries * DB_PAGE_SIZE));
> +				MAX_DB_PAGES_PER_BQ(QLGE_BQ_LEN); page_entries++)
> +			base_indirect_ptr[page_entries] =
> +				cpu_to_le64(tmp + (page_entries * DB_PAGE_SIZE));
>  		cqicb->lbq_addr = cpu_to_le64(rx_ring->lbq.base_indirect_dma);
>  		cqicb->lbq_buf_size =
>  			cpu_to_le16(QLGE_FIT16(qdev->lbq_buf_size));
> @@ -3023,9 +3023,9 @@ static int qlge_start_rx_ring(struct qlge_adapter
> *qdev, struct rx_ring *rx_ring
>  		base_indirect_ptr = rx_ring->sbq.base_indirect;
> 
>  		for (page_entries = 0; page_entries <
> -			MAX_DB_PAGES_PER_BQ(QLGE_BQ_LEN); page_entries++)
> -				base_indirect_ptr[page_entries] =
> -					cpu_to_le64(tmp + (page_entries * DB_PAGE_SIZE));
> +				MAX_DB_PAGES_PER_BQ(QLGE_BQ_LEN); page_entries++)
> +			base_indirect_ptr[page_entries] =
> +				cpu_to_le64(tmp + (page_entries * DB_PAGE_SIZE));
>  		cqicb->sbq_addr =
>  			cpu_to_le64(rx_ring->sbq.base_indirect_dma);
>  		cqicb->sbq_buf_size = cpu_to_le16(SMALL_BUFFER_SIZE);
> -- 
> 2.37.1

Hi,

This is the friendly patch-bot of Greg Kroah-Hartman.  You have sent him
a patch that has triggered this response.  He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created.  Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.

You are receiving this message because of the following common error(s)
as indicated below:

- Your patch is malformed (tabs converted to spaces, linewrapped, etc.)
  and can not be applied.  Please read the file,
  Documentation/email-clients.txt in order to fix this.


If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.

thanks,

greg k-h's patch email bot

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-07-27  6:42 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-15 14:30 [PATCH] staging: qlge: fix indentation Louis Goyard
2022-07-27  6:42 ` Greg Kroah-Hartman

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).