From: Artem Savkov <asavkov@redhat.com>
To: Jiri Olsa <olsajiri@gmail.com>
Cc: Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Andrii Nakryiko <andrii@kernel.org>,
bpf@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org,
Andrea Arcangeli <aarcange@redhat.com>,
Daniel Vacek <dvacek@redhat.com>, Song Liu <song@kernel.org>,
Daniel Xu <dxu@dxuuu.xyz>
Subject: Re: [PATCH bpf-next v2 2/3] bpf: export crash_kexec() as destructive kfunc
Date: Tue, 2 Aug 2022 16:01:30 +0200 [thread overview]
Message-ID: <YukuOj4CR3HgUv1S@sparkplug.usersys.redhat.com> (raw)
In-Reply-To: <YukAkjqdAqr9x2Bs@krava>
On Tue, Aug 02, 2022 at 12:46:42PM +0200, Jiri Olsa wrote:
> On Tue, Aug 02, 2022 at 11:10:29AM +0200, Artem Savkov wrote:
> > +static int __init crash_kfunc_init(void)
> > +{
> > + register_btf_kfunc_id_set(BPF_PROG_TYPE_TRACING, &kexec_kfunc_set);
> > + return 0;
>
> should we do 'return register_btf_kfunc_id_set(...' in here?
Maybe, but as far as I can tell the return value for init calls does
absolutely nothing except for showing up in a debug message. So I don't
think it will be worth a respin, but if there is one anyway I'll change
this.
--
Artem
next prev parent reply other threads:[~2022-08-02 14:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-02 9:10 [PATCH bpf-next v2 0/3] destructive bpf_kfuncs Artem Savkov
2022-08-02 9:10 ` [PATCH bpf-next v2 1/3] bpf: add destructive kfunc flag Artem Savkov
2022-08-02 9:10 ` [PATCH bpf-next v2 2/3] bpf: export crash_kexec() as destructive kfunc Artem Savkov
2022-08-02 10:46 ` Jiri Olsa
2022-08-02 14:01 ` Artem Savkov [this message]
2022-08-04 20:41 ` Alexei Starovoitov
2022-08-05 11:31 ` Artem Savkov
2022-08-02 9:10 ` [PATCH bpf-next v2 3/3] selftests/bpf: add destructive kfunc test Artem Savkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YukuOj4CR3HgUv1S@sparkplug.usersys.redhat.com \
--to=asavkov@redhat.com \
--cc=aarcange@redhat.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=dvacek@redhat.com \
--cc=dxu@dxuuu.xyz \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olsajiri@gmail.com \
--cc=song@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).