* [PATCH v5 1/2] dt-bindngs: i2c: update bindings for mt8188 soc
@ 2022-08-06 10:02 kewei.xu
2022-08-06 10:02 ` [PATCH v5 2/2] i2c: mediatek: add i2c compatible for MT8188 kewei.xu
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: kewei.xu @ 2022-08-06 10:02 UTC (permalink / raw)
To: wsa
Cc: matthias.bgg, robh+dt, linux-i2c, devicetree, linux-arm-kernel,
linux-kernel, linux-mediatek, srv_heupstream, leilk.liu,
qii.wang, liguo.zhang, caiyu.chen, housong.zhang, yuhan.wei,
kewei.xu, ryan-jh.yu, david-yh.chiu
From: Kewei Xu <kewei.xu@mediatek.com>
Add a DT binding documentation for the mt8188 soc.
Signed-off-by: Kewei Xu <kewei.xu@mediatek.com>
Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>
Acked-by: Rob Herring <robh@kernel.org>
---
v5: add Acked-by owner
v4: resend patch
v3: add reviewed-by owner
v2: no changes
---
Documentation/devicetree/bindings/i2c/i2c-mt65xx.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/i2c/i2c-mt65xx.yaml b/Documentation/devicetree/bindings/i2c/i2c-mt65xx.yaml
index 16a1a3118204..4e730fb7be56 100644
--- a/Documentation/devicetree/bindings/i2c/i2c-mt65xx.yaml
+++ b/Documentation/devicetree/bindings/i2c/i2c-mt65xx.yaml
@@ -27,6 +27,7 @@ properties:
- const: mediatek,mt8173-i2c
- const: mediatek,mt8183-i2c
- const: mediatek,mt8186-i2c
+ - const: mediatek,mt8188-i2c
- const: mediatek,mt8192-i2c
- items:
- enum:
--
2.18.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH v5 2/2] i2c: mediatek: add i2c compatible for MT8188
2022-08-06 10:02 [PATCH v5 1/2] dt-bindngs: i2c: update bindings for mt8188 soc kewei.xu
@ 2022-08-06 10:02 ` kewei.xu
2022-08-08 1:44 ` Qii Wang
2022-08-11 12:34 ` Wolfram Sang
2022-08-08 1:45 ` [PATCH v5 1/2] dt-bindngs: i2c: update bindings for mt8188 soc Qii Wang
2022-08-11 12:34 ` Wolfram Sang
2 siblings, 2 replies; 6+ messages in thread
From: kewei.xu @ 2022-08-06 10:02 UTC (permalink / raw)
To: wsa
Cc: matthias.bgg, robh+dt, linux-i2c, devicetree, linux-arm-kernel,
linux-kernel, linux-mediatek, srv_heupstream, leilk.liu,
qii.wang, liguo.zhang, caiyu.chen, housong.zhang, yuhan.wei,
kewei.xu, ryan-jh.yu, david-yh.chiu
From: Kewei Xu <kewei.xu@mediatek.com>
Add i2c compatible for MT8188 and added mt_i2c_regs_v3[], since
MT8188 i2c OFFSET_SLAVE_ADDR register changed from 0x04 to 0x94.
Signed-off-by: Kewei Xu <kewei.xu@mediatek.com>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
---
v5: modify the order of mt_i2c_regs_v3[] members and add Reviewed-by owner.
v4: no changes
V3: no changes
V2: added mt_i2c_regs_v3[] to replace slave_addr_version.
---
drivers/i2c/busses/i2c-mt65xx.c | 43 +++++++++++++++++++++++++++++++++
1 file changed, 43 insertions(+)
diff --git a/drivers/i2c/busses/i2c-mt65xx.c b/drivers/i2c/busses/i2c-mt65xx.c
index 8e6985354fd5..bd8abba3d1c9 100644
--- a/drivers/i2c/busses/i2c-mt65xx.c
+++ b/drivers/i2c/busses/i2c-mt65xx.c
@@ -229,6 +229,35 @@ static const u16 mt_i2c_regs_v2[] = {
[OFFSET_DCM_EN] = 0xf88,
};
+static const u16 mt_i2c_regs_v3[] = {
+ [OFFSET_DATA_PORT] = 0x0,
+ [OFFSET_INTR_MASK] = 0x8,
+ [OFFSET_INTR_STAT] = 0xc,
+ [OFFSET_CONTROL] = 0x10,
+ [OFFSET_TRANSFER_LEN] = 0x14,
+ [OFFSET_TRANSAC_LEN] = 0x18,
+ [OFFSET_DELAY_LEN] = 0x1c,
+ [OFFSET_TIMING] = 0x20,
+ [OFFSET_START] = 0x24,
+ [OFFSET_EXT_CONF] = 0x28,
+ [OFFSET_LTIMING] = 0x2c,
+ [OFFSET_HS] = 0x30,
+ [OFFSET_IO_CONFIG] = 0x34,
+ [OFFSET_FIFO_ADDR_CLR] = 0x38,
+ [OFFSET_SDA_TIMING] = 0x3c,
+ [OFFSET_TRANSFER_LEN_AUX] = 0x44,
+ [OFFSET_CLOCK_DIV] = 0x48,
+ [OFFSET_SOFTRESET] = 0x50,
+ [OFFSET_MULTI_DMA] = 0x8c,
+ [OFFSET_SCL_MIS_COMP_POINT] = 0x90,
+ [OFFSET_SLAVE_ADDR] = 0x94,
+ [OFFSET_DEBUGSTAT] = 0xe4,
+ [OFFSET_DEBUGCTRL] = 0xe8,
+ [OFFSET_FIFO_STAT] = 0xf4,
+ [OFFSET_FIFO_THRESH] = 0xf8,
+ [OFFSET_DCM_EN] = 0xf88,
+};
+
struct mtk_i2c_compatible {
const struct i2c_adapter_quirks *quirks;
const u16 *regs;
@@ -442,6 +471,19 @@ static const struct mtk_i2c_compatible mt8186_compat = {
.max_dma_support = 36,
};
+static const struct mtk_i2c_compatible mt8188_compat = {
+ .regs = mt_i2c_regs_v3,
+ .pmic_i2c = 0,
+ .dcm = 0,
+ .auto_restart = 1,
+ .aux_len_reg = 1,
+ .timing_adjust = 1,
+ .dma_sync = 0,
+ .ltiming_adjust = 1,
+ .apdma_sync = 1,
+ .max_dma_support = 36,
+};
+
static const struct mtk_i2c_compatible mt8192_compat = {
.quirks = &mt8183_i2c_quirks,
.regs = mt_i2c_regs_v2,
@@ -465,6 +507,7 @@ static const struct of_device_id mtk_i2c_of_match[] = {
{ .compatible = "mediatek,mt8173-i2c", .data = &mt8173_compat },
{ .compatible = "mediatek,mt8183-i2c", .data = &mt8183_compat },
{ .compatible = "mediatek,mt8186-i2c", .data = &mt8186_compat },
+ { .compatible = "mediatek,mt8188-i2c", .data = &mt8188_compat },
{ .compatible = "mediatek,mt8192-i2c", .data = &mt8192_compat },
{}
};
--
2.18.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH v5 2/2] i2c: mediatek: add i2c compatible for MT8188
2022-08-06 10:02 ` [PATCH v5 2/2] i2c: mediatek: add i2c compatible for MT8188 kewei.xu
@ 2022-08-08 1:44 ` Qii Wang
2022-08-11 12:34 ` Wolfram Sang
1 sibling, 0 replies; 6+ messages in thread
From: Qii Wang @ 2022-08-08 1:44 UTC (permalink / raw)
To: kewei.xu, wsa
Cc: matthias.bgg, robh+dt, linux-i2c, devicetree, linux-arm-kernel,
linux-kernel, linux-mediatek, srv_heupstream, leilk.liu,
liguo.zhang, caiyu.chen, housong.zhang, yuhan.wei, ryan-jh.yu,
david-yh.chiu
On Sat, 2022-08-06 at 18:02 +0800, kewei.xu@mediatek.com wrote:
> From: Kewei Xu <kewei.xu@mediatek.com>
>
> Add i2c compatible for MT8188 and added mt_i2c_regs_v3[], since
> MT8188 i2c OFFSET_SLAVE_ADDR register changed from 0x04 to 0x94.
>
> Signed-off-by: Kewei Xu <kewei.xu@mediatek.com>
> Reviewed-by: AngeloGioacchino Del Regno <
> angelogioacchino.delregno@collabora.com>
Reviewed-by: Qii Wang <qii.wang@mediatek.com>
> ---
> v5: modify the order of mt_i2c_regs_v3[] members and add Reviewed-by
> owner.
> v4: no changes
> V3: no changes
> V2: added mt_i2c_regs_v3[] to replace slave_addr_version.
> ---
> drivers/i2c/busses/i2c-mt65xx.c | 43
> +++++++++++++++++++++++++++++++++
> 1 file changed, 43 insertions(+)
>
> diff --git a/drivers/i2c/busses/i2c-mt65xx.c
> b/drivers/i2c/busses/i2c-mt65xx.c
> index 8e6985354fd5..bd8abba3d1c9 100644
> --- a/drivers/i2c/busses/i2c-mt65xx.c
> +++ b/drivers/i2c/busses/i2c-mt65xx.c
> @@ -229,6 +229,35 @@ static const u16 mt_i2c_regs_v2[] = {
> [OFFSET_DCM_EN] = 0xf88,
> };
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v5 1/2] dt-bindngs: i2c: update bindings for mt8188 soc
2022-08-06 10:02 [PATCH v5 1/2] dt-bindngs: i2c: update bindings for mt8188 soc kewei.xu
2022-08-06 10:02 ` [PATCH v5 2/2] i2c: mediatek: add i2c compatible for MT8188 kewei.xu
@ 2022-08-08 1:45 ` Qii Wang
2022-08-11 12:34 ` Wolfram Sang
2 siblings, 0 replies; 6+ messages in thread
From: Qii Wang @ 2022-08-08 1:45 UTC (permalink / raw)
To: kewei.xu, wsa
Cc: matthias.bgg, robh+dt, linux-i2c, devicetree, linux-arm-kernel,
linux-kernel, linux-mediatek, srv_heupstream, leilk.liu,
liguo.zhang, caiyu.chen, housong.zhang, yuhan.wei, ryan-jh.yu,
david-yh.chiu
On Sat, 2022-08-06 at 18:02 +0800, kewei.xu@mediatek.com wrote:
> From: Kewei Xu <kewei.xu@mediatek.com>
>
> Add a DT binding documentation for the mt8188 soc.
>
> Signed-off-by: Kewei Xu <kewei.xu@mediatek.com>
> Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>
> Acked-by: Rob Herring <robh@kernel.org>
Reviewed-by: Qii Wang <qii.wang@mediatek.com>
> ---
> v5: add Acked-by owner
> v4: resend patch
> v3: add reviewed-by owner
> v2: no changes
> ---
> Documentation/devicetree/bindings/i2c/i2c-mt65xx.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/i2c/i2c-mt65xx.yaml
> b/Documentation/devicetree/bindings/i2c/i2c-mt65xx.yaml
> index 16a1a3118204..4e730fb7be56 100644
> --- a/Documentation/devicetree/bindings/i2c/i2c-mt65xx.yaml
> +++ b/Documentation/devicetree/bindings/i2c/i2c-mt65xx.yaml
> @@ -27,6 +27,7 @@ properties:
> - const: mediatek,mt8173-i2c
> - const: mediatek,mt8183-i2c
> - const: mediatek,mt8186-i2c
> + - const: mediatek,mt8188-i2c
> - const: mediatek,mt8192-i2c
> - items:
> - enum:
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v5 1/2] dt-bindngs: i2c: update bindings for mt8188 soc
2022-08-06 10:02 [PATCH v5 1/2] dt-bindngs: i2c: update bindings for mt8188 soc kewei.xu
2022-08-06 10:02 ` [PATCH v5 2/2] i2c: mediatek: add i2c compatible for MT8188 kewei.xu
2022-08-08 1:45 ` [PATCH v5 1/2] dt-bindngs: i2c: update bindings for mt8188 soc Qii Wang
@ 2022-08-11 12:34 ` Wolfram Sang
2 siblings, 0 replies; 6+ messages in thread
From: Wolfram Sang @ 2022-08-11 12:34 UTC (permalink / raw)
To: kewei.xu
Cc: matthias.bgg, robh+dt, linux-i2c, devicetree, linux-arm-kernel,
linux-kernel, linux-mediatek, srv_heupstream, leilk.liu,
qii.wang, liguo.zhang, caiyu.chen, housong.zhang, yuhan.wei,
ryan-jh.yu, david-yh.chiu
[-- Attachment #1: Type: text/plain, Size: 365 bytes --]
On Sat, Aug 06, 2022 at 06:02:48PM +0800, kewei.xu@mediatek.com wrote:
> From: Kewei Xu <kewei.xu@mediatek.com>
>
> Add a DT binding documentation for the mt8188 soc.
>
> Signed-off-by: Kewei Xu <kewei.xu@mediatek.com>
> Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>
> Acked-by: Rob Herring <robh@kernel.org>
Applied to for-current, thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v5 2/2] i2c: mediatek: add i2c compatible for MT8188
2022-08-06 10:02 ` [PATCH v5 2/2] i2c: mediatek: add i2c compatible for MT8188 kewei.xu
2022-08-08 1:44 ` Qii Wang
@ 2022-08-11 12:34 ` Wolfram Sang
1 sibling, 0 replies; 6+ messages in thread
From: Wolfram Sang @ 2022-08-11 12:34 UTC (permalink / raw)
To: kewei.xu
Cc: matthias.bgg, robh+dt, linux-i2c, devicetree, linux-arm-kernel,
linux-kernel, linux-mediatek, srv_heupstream, leilk.liu,
qii.wang, liguo.zhang, caiyu.chen, housong.zhang, yuhan.wei,
ryan-jh.yu, david-yh.chiu
[-- Attachment #1: Type: text/plain, Size: 430 bytes --]
On Sat, Aug 06, 2022 at 06:02:49PM +0800, kewei.xu@mediatek.com wrote:
> From: Kewei Xu <kewei.xu@mediatek.com>
>
> Add i2c compatible for MT8188 and added mt_i2c_regs_v3[], since
> MT8188 i2c OFFSET_SLAVE_ADDR register changed from 0x04 to 0x94.
>
> Signed-off-by: Kewei Xu <kewei.xu@mediatek.com>
> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Applied to for-current, thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-08-11 12:34 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-06 10:02 [PATCH v5 1/2] dt-bindngs: i2c: update bindings for mt8188 soc kewei.xu
2022-08-06 10:02 ` [PATCH v5 2/2] i2c: mediatek: add i2c compatible for MT8188 kewei.xu
2022-08-08 1:44 ` Qii Wang
2022-08-11 12:34 ` Wolfram Sang
2022-08-08 1:45 ` [PATCH v5 1/2] dt-bindngs: i2c: update bindings for mt8188 soc Qii Wang
2022-08-11 12:34 ` Wolfram Sang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).