* [PATCH] fpga: microchip-spi: add missing module author entry
@ 2022-07-28 7:50 Conor Dooley
2022-07-28 12:29 ` Tom Rix
2022-07-28 18:46 ` Ivan Bornyakov
0 siblings, 2 replies; 5+ messages in thread
From: Conor Dooley @ 2022-07-28 7:50 UTC (permalink / raw)
To: Ivan Bornyakov, Moritz Fischer, Wu Hao, Xu Yilun, Tom Rix
Cc: Conor Dooley, linux-fpga, linux-kernel
Add the missing MODULE_AUTHOR entry for the Microchip spi-slave FPGA
programming driver.
Signed-off-by: Conor Dooley <conor.dooley@microchip.com>
---
drivers/fpga/microchip-spi.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/fpga/microchip-spi.c b/drivers/fpga/microchip-spi.c
index bd284c7b8dc9..7436976ea904 100644
--- a/drivers/fpga/microchip-spi.c
+++ b/drivers/fpga/microchip-spi.c
@@ -395,4 +395,5 @@ static struct spi_driver mpf_driver = {
module_spi_driver(mpf_driver);
MODULE_DESCRIPTION("Microchip Polarfire SPI FPGA Manager");
+MODULE_AUTHOR("Ivan Bornyakov <i.bornyakov@metrotek.ru>");
MODULE_LICENSE("GPL");
--
2.36.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] fpga: microchip-spi: add missing module author entry
2022-07-28 7:50 [PATCH] fpga: microchip-spi: add missing module author entry Conor Dooley
@ 2022-07-28 12:29 ` Tom Rix
2022-08-15 3:28 ` Xu Yilun
2022-07-28 18:46 ` Ivan Bornyakov
1 sibling, 1 reply; 5+ messages in thread
From: Tom Rix @ 2022-07-28 12:29 UTC (permalink / raw)
To: Conor Dooley, Ivan Bornyakov, Moritz Fischer, Wu Hao, Xu Yilun
Cc: linux-fpga, linux-kernel
On 7/28/22 12:50 AM, Conor Dooley wrote:
> Add the missing MODULE_AUTHOR entry for the Microchip spi-slave FPGA
> programming driver.
>
> Signed-off-by: Conor Dooley <conor.dooley@microchip.com>
Reviewed-by: Tom Rix <trix@redhat.com>
> ---
> drivers/fpga/microchip-spi.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/fpga/microchip-spi.c b/drivers/fpga/microchip-spi.c
> index bd284c7b8dc9..7436976ea904 100644
> --- a/drivers/fpga/microchip-spi.c
> +++ b/drivers/fpga/microchip-spi.c
> @@ -395,4 +395,5 @@ static struct spi_driver mpf_driver = {
> module_spi_driver(mpf_driver);
>
> MODULE_DESCRIPTION("Microchip Polarfire SPI FPGA Manager");
> +MODULE_AUTHOR("Ivan Bornyakov <i.bornyakov@metrotek.ru>");
> MODULE_LICENSE("GPL");
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] fpga: microchip-spi: add missing module author entry
2022-07-28 7:50 [PATCH] fpga: microchip-spi: add missing module author entry Conor Dooley
2022-07-28 12:29 ` Tom Rix
@ 2022-07-28 18:46 ` Ivan Bornyakov
2022-07-28 19:18 ` Conor.Dooley
1 sibling, 1 reply; 5+ messages in thread
From: Ivan Bornyakov @ 2022-07-28 18:46 UTC (permalink / raw)
To: Conor Dooley
Cc: Moritz Fischer, Wu Hao, Xu Yilun, Tom Rix, linux-fpga, linux-kernel
On Thu, Jul 28, 2022 at 08:50:13AM +0100, Conor Dooley wrote:
> Add the missing MODULE_AUTHOR entry for the Microchip spi-slave FPGA
> programming driver.
>
> Signed-off-by: Conor Dooley <conor.dooley@microchip.com>
> ---
> drivers/fpga/microchip-spi.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/fpga/microchip-spi.c b/drivers/fpga/microchip-spi.c
> index bd284c7b8dc9..7436976ea904 100644
> --- a/drivers/fpga/microchip-spi.c
> +++ b/drivers/fpga/microchip-spi.c
> @@ -395,4 +395,5 @@ static struct spi_driver mpf_driver = {
> module_spi_driver(mpf_driver);
>
> MODULE_DESCRIPTION("Microchip Polarfire SPI FPGA Manager");
> +MODULE_AUTHOR("Ivan Bornyakov <i.bornyakov@metrotek.ru>");
> MODULE_LICENSE("GPL");
> --
> 2.36.1
>
Acked-by: Ivan Bornyakov <i.bornyakov@metrotek.ru>
Yet, I'm wondering in what situations MODULE_AUTHOR is needed? I've
submitted a couple of other drivers without it, should I fix them?
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] fpga: microchip-spi: add missing module author entry
2022-07-28 18:46 ` Ivan Bornyakov
@ 2022-07-28 19:18 ` Conor.Dooley
0 siblings, 0 replies; 5+ messages in thread
From: Conor.Dooley @ 2022-07-28 19:18 UTC (permalink / raw)
To: i.bornyakov, Conor.Dooley
Cc: mdf, hao.wu, yilun.xu, trix, linux-fpga, linux-kernel
On 28/07/2022 19:46, Ivan Bornyakov wrote:
> On Thu, Jul 28, 2022 at 08:50:13AM +0100, Conor Dooley wrote:
>> Add the missing MODULE_AUTHOR entry for the Microchip spi-slave FPGA
>> programming driver.
>>
>> Signed-off-by: Conor Dooley <conor.dooley@microchip.com>
>> ---
>> drivers/fpga/microchip-spi.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/fpga/microchip-spi.c b/drivers/fpga/microchip-spi.c
>> index bd284c7b8dc9..7436976ea904 100644
>> --- a/drivers/fpga/microchip-spi.c
>> +++ b/drivers/fpga/microchip-spi.c
>> @@ -395,4 +395,5 @@ static struct spi_driver mpf_driver = {
>> module_spi_driver(mpf_driver);
>>
>> MODULE_DESCRIPTION("Microchip Polarfire SPI FPGA Manager");
>> +MODULE_AUTHOR("Ivan Bornyakov <i.bornyakov@metrotek.ru>");
>> MODULE_LICENSE("GPL");
>> --
>> 2.36.1
>>
>
> Acked-by: Ivan Bornyakov <i.bornyakov@metrotek.ru>
>
> Yet, I'm wondering in what situations MODULE_AUTHOR is needed? I've
> submitted a couple of other drivers without it, should I fix them?
>
It'll show up in modinfo. I don't think it's a big deal though.
/shrug
Conor.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] fpga: microchip-spi: add missing module author entry
2022-07-28 12:29 ` Tom Rix
@ 2022-08-15 3:28 ` Xu Yilun
0 siblings, 0 replies; 5+ messages in thread
From: Xu Yilun @ 2022-08-15 3:28 UTC (permalink / raw)
To: Tom Rix
Cc: Conor Dooley, Ivan Bornyakov, Moritz Fischer, Wu Hao, linux-fpga,
linux-kernel
On 2022-07-28 at 05:29:48 -0700, Tom Rix wrote:
>
> On 7/28/22 12:50 AM, Conor Dooley wrote:
> > Add the missing MODULE_AUTHOR entry for the Microchip spi-slave FPGA
> > programming driver.
> >
> > Signed-off-by: Conor Dooley <conor.dooley@microchip.com>
> Reviewed-by: Tom Rix <trix@redhat.com>
Acked-by: Xu Yilun <yilun.xu@intel.com>
Applied to for-next
> > ---
> > drivers/fpga/microchip-spi.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/fpga/microchip-spi.c b/drivers/fpga/microchip-spi.c
> > index bd284c7b8dc9..7436976ea904 100644
> > --- a/drivers/fpga/microchip-spi.c
> > +++ b/drivers/fpga/microchip-spi.c
> > @@ -395,4 +395,5 @@ static struct spi_driver mpf_driver = {
> > module_spi_driver(mpf_driver);
> > MODULE_DESCRIPTION("Microchip Polarfire SPI FPGA Manager");
> > +MODULE_AUTHOR("Ivan Bornyakov <i.bornyakov@metrotek.ru>");
> > MODULE_LICENSE("GPL");
>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-08-15 3:38 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-28 7:50 [PATCH] fpga: microchip-spi: add missing module author entry Conor Dooley
2022-07-28 12:29 ` Tom Rix
2022-08-15 3:28 ` Xu Yilun
2022-07-28 18:46 ` Ivan Bornyakov
2022-07-28 19:18 ` Conor.Dooley
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).