build failure of next-20220822 due to 4e6bedd3c396 ("ASoC: codecs: add support for the TI SRC4392 codec")

build failure of next-20220822 due to 4e6bedd3c396 ("ASoC: codecs: add support for the TI SRC4392 codec")

[Sudip Mukherjee (Codethink)]

Hi All,

Not sure if it has been reported, builds of arm64 with clang failed to
build next-20220822 with the error:

sound/soc/codecs/src4xxx.c:280:3: error: variable 'd' is used uninitialized whenever switch default is taken [-Werror,-Wsometimes-uninitialized]
                default:
                ^~~~~~~
sound/soc/codecs/src4xxx.c:298:59: note: uninitialized use occurs here
                ret = regmap_write(src4xxx->regmap, SRC4XXX_RCV_PLL_11, d);
                                                                        ^
sound/soc/codecs/src4xxx.c:223:20: note: initialize the variable 'd' to silence this warning
        int val, pj, jd, d;
                          ^
                           = 0
sound/soc/codecs/src4xxx.c:280:3: error: variable 'jd' is used uninitialized whenever switch default is taken [-Werror,-Wsometimes-uninitialized]
                default:
                ^~~~~~~
sound/soc/codecs/src4xxx.c:293:59: note: uninitialized use occurs here
                ret = regmap_write(src4xxx->regmap, SRC4XXX_RCV_PLL_10, jd);
                                                                        ^~
sound/soc/codecs/src4xxx.c:223:17: note: initialize the variable 'jd' to silence this warning
        int val, pj, jd, d;
                       ^
                        = 0
sound/soc/codecs/src4xxx.c:280:3: error: variable 'pj' is used uninitialized whenever switch default is taken [-Werror,-Wsometimes-uninitialized]
                default:
                ^~~~~~~
sound/soc/codecs/src4xxx.c:288:59: note: uninitialized use occurs here
                ret = regmap_write(src4xxx->regmap, SRC4XXX_RCV_PLL_0F, pj);
                                                                        ^~
sound/soc/codecs/src4xxx.c:223:13: note: initialize the variable 'pj' to silence this warning
        int val, pj, jd, d;
                   ^
                    = 0
3 errors generated.

git bisect pointed to 4e6bedd3c396 ("ASoC: codecs: add support for the TI SRC4392 codec").

I will be happy to test any patch or provide any extra log if needed.


--
Regards
Sudip

Re: build failure of next-20220822 due to 4e6bedd3c396 ("ASoC: codecs: add support for the TI SRC4392 codec")

[Nick Desaulniers]

On Mon, Aug 22, 2022 at 2:28 AM Sudip Mukherjee (Codethink)
<sudipm.mukherjee@gmail.com> wrote:
>
> Hi All,
>
> Not sure if it has been reported,

Hi Sudip,
Thanks for the report.  Two ways you can check if it's already been reported:
1. Check our issue tracker
(https://github.com/ClangBuiltLinux/linux/issues), you'll see that it
has been (https://github.com/ClangBuiltLinux/linux/issues/1691 ->
https://lore.kernel.org/all/YvvbKry5FVFbNdcI@dev-arch.thelio-3990X/)
2. Search for the warning message on lore.
(https://lore.kernel.org/all/ -> search for
"sound/soc/codecs/src4xxx.c Wsometimes" ->
https://lore.kernel.org/all/?q=sound%2Fsoc%2Fcodecs%2Fsrc4xxx.c+Wsometimes
and you'll see two reports from bots and two from humans).

> builds of arm64 with clang failed to
> build next-20220822 with the error:
>
> sound/soc/codecs/src4xxx.c:280:3: error: variable 'd' is used uninitialized whenever switch default is taken [-Werror,-Wsometimes-uninitialized]
>                 default:
>                 ^~~~~~~


-- 
Thanks,
~Nick Desaulniers