Re: [PATCH 2/2] clk: qcom: gcc-sc7280: Keep USB GDSC power domains on when USB wakeup is enabled

From: Johan Hovold <johan@kernel.org>
To: Matthias Kaehlcke <mka@chromium.org>
Cc: Andy Gross <agross@kernel.org>,
	Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konrad.dybcio@somainline.org>,
	Michael Turquette <mturquette@baylibre.com>,
	Stephen Boyd <sboyd@kernel.org>,
	linux-arm-msm@vger.kernel.org,
	Johan Hovold <johan+linaro@kernel.org>,
	Douglas Anderson <dianders@chromium.org>,
	Krishna Kurapati <quic_kriskura@quicinc.com>,
	linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org,
	Bjorn Andersson <bjorn.andersson@linaro.org>
Subject: Re: [PATCH 2/2] clk: qcom: gcc-sc7280: Keep USB GDSC power domains on when USB wakeup is enabled
Date: Tue, 23 Aug 2022 13:16:36 +0200	[thread overview]
Message-ID: <YwS3FCOqIeajMEgz@hovoldconsulting.com> (raw)
In-Reply-To: <20220822115246.2.If09027f73daa6e1ed95f5eab02326b543c67132e@changeid>

On Mon, Aug 22, 2022 at 11:53:11AM -0700, Matthias Kaehlcke wrote:
> Set GENPD_FLAG_ACTIVE_WAKEUP for the USB GDSC power domains of SC7280.
> 
> Suggested-by: Johan Hovold <johan+linaro@kernel.org>
> Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
> ---
> 
>  drivers/clk/qcom/gcc-sc7280.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/clk/qcom/gcc-sc7280.c b/drivers/clk/qcom/gcc-sc7280.c
> index 7ff64d4d5920..4ff855269467 100644
> --- a/drivers/clk/qcom/gcc-sc7280.c
> +++ b/drivers/clk/qcom/gcc-sc7280.c
> @@ -3125,6 +3125,7 @@ static struct gdsc gcc_usb30_prim_gdsc = {
>  	.gdscr = 0xf004,
>  	.pd = {
>  		.name = "gcc_usb30_prim_gdsc",
> +		.flags = GENPD_FLAG_ACTIVE_WAKEUP,

Have you verified that the power-domain doesn't need to remain on also
when USB isn't used for wakeup?

This is the case for sc8280xp and indicates that there are further
missing pieces here (at least for that platform).

Johan