From: Johan Hovold <johan@kernel.org>
To: Matthias Kaehlcke <mka@chromium.org>
Cc: Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@somainline.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
linux-arm-msm@vger.kernel.org,
Johan Hovold <johan+linaro@kernel.org>,
Douglas Anderson <dianders@chromium.org>,
Krishna Kurapati <quic_kriskura@quicinc.com>,
linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org,
Bjorn Andersson <bjorn.andersson@linaro.org>
Subject: Re: [PATCH 2/2] clk: qcom: gcc-sc7280: Keep USB GDSC power domains on when USB wakeup is enabled
Date: Fri, 26 Aug 2022 15:12:05 +0200 [thread overview]
Message-ID: <YwjGpSXOscDwbvQH@hovoldconsulting.com> (raw)
In-Reply-To: <YwjFD9uHnSxoZHvT@google.com>
On Fri, Aug 26, 2022 at 06:05:19AM -0700, Matthias Kaehlcke wrote:
> On Thu, Aug 25, 2022 at 03:16:58PM -0700, Matthias Kaehlcke wrote:
> > On Wed, Aug 24, 2022 at 10:47:44AM +0200, Johan Hovold wrote:
> > > The wakeup setting doesn't seem to have anything to do with the genpd
> > > issues on sc8280xp and the controller doesn't resume properly regardless
> > > of whether the PHYs have been disabled or not during suspend unless the
> > > PD is left on.
> >
> > I'm essentially seeing the same. USB is hosed after resume unless the PD
> > is left on.
> >
> > On Chrome OS we currently work around that with a version of commit
> > d9be8d5c5b03 ("usb: dwc3: qcom: Keep power domain on to retain controller
> > status") which was reverted upstream. I'm not sure whether USB worked after
> > resume before we enabled wakeup support. I would have sworn it did, but we
> > landed an old version of the wakeup patches a long time ago, so my
> > memory might be failing me.
>
> I need to remind myself that keeping the GDSC on is only needed when the PHYs
> are kept on. The PHYs were always off before wakeup support was added, which
> is why USB wasn't broken after suspend in the pre-wakeup days.
Ok, so to be clear: if you disable wakeup with my patches applied so
that the PD is actually turned off, USB still resumes with only
GENPD_FLAG_ACTIVE_WAKEUP set?
That is, you don't need to set ALWAYS_ON as I do with sc8280xp?
Johan
next prev parent reply other threads:[~2022-08-26 13:12 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-22 18:53 [PATCH 1/2] clk: qcom: gcc-sc7180: Keep USB GDSC power domain on when USB wakeup is enabled Matthias Kaehlcke
2022-08-22 18:53 ` [PATCH 2/2] clk: qcom: gcc-sc7280: Keep USB GDSC power domains " Matthias Kaehlcke
2022-08-23 11:16 ` Johan Hovold
2022-08-23 16:42 ` Matthias Kaehlcke
2022-08-24 8:47 ` Johan Hovold
2022-08-25 22:16 ` Matthias Kaehlcke
2022-08-26 7:12 ` Johan Hovold
2022-08-26 13:05 ` Matthias Kaehlcke
2022-08-26 13:12 ` Johan Hovold [this message]
2022-08-26 13:19 ` Matthias Kaehlcke
2022-08-26 13:24 ` Matthias Kaehlcke
2022-08-26 13:26 ` Johan Hovold
2022-08-26 13:33 ` Matthias Kaehlcke
2022-08-22 23:52 ` [PATCH 1/2] clk: qcom: gcc-sc7180: Keep USB GDSC power domain " Stephen Boyd
2022-08-23 19:05 ` Matthias Kaehlcke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YwjGpSXOscDwbvQH@hovoldconsulting.com \
--to=johan@kernel.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=dianders@chromium.org \
--cc=johan+linaro@kernel.org \
--cc=konrad.dybcio@somainline.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mka@chromium.org \
--cc=mturquette@baylibre.com \
--cc=quic_kriskura@quicinc.com \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).