From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Shi Hao <hao.shi@amlogic.com>
Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
mchehab@kernel.org, hans.verkuil@cisco.com,
hverkuil-cisco@xs4all.nl, ezequiel@vanguardiasur.com.ar,
sakari.ailus@linux.intel.com, ribalda@chromium.org,
stanimir.varbanov@linaro.org, nanxin.qin@amlogic.com
Subject: Re: [PATCH] [media] v4l2: Add AV1, AVS and AVS2 format
Date: Fri, 26 Aug 2022 12:15:28 +0300 [thread overview]
Message-ID: <YwiPMOyfXKM8lxIR@pendragon.ideasonboard.com> (raw)
In-Reply-To: <20220826030003.1066976-1-hao.shi@amlogic.com>
Hello Shi,
Thank you for the patch.
On Fri, Aug 26, 2022 at 11:00:03AM +0800, Shi Hao wrote:
> From: "hao.shi" <hao.shi@amlogic.com>
>
> Add AV1, AVS and AVS2 compressed pixel formats. They are
> the more common formats.
>
> Signed-off-by: Shi Hao <hao.shi@amlogic.com>
> ---
> drivers/media/v4l2-core/v4l2-ioctl.c | 3 +++
> include/uapi/linux/videodev2.h | 3 +++
The patch also needs to document the formats, in
Documentation/userspace-api/media/v4l/.
> 2 files changed, 6 insertions(+)
>
> diff --git a/drivers/media/v4l2-core/v4l2-ioctl.c b/drivers/media/v4l2-core/v4l2-ioctl.c
> index c314025d977e..7b102c2f59b1 100644
> --- a/drivers/media/v4l2-core/v4l2-ioctl.c
> +++ b/drivers/media/v4l2-core/v4l2-ioctl.c
> @@ -1497,6 +1497,9 @@ static void v4l_fill_fmtdesc(struct v4l2_fmtdesc *fmt)
> case V4L2_PIX_FMT_MT21C: descr = "Mediatek Compressed Format"; break;
> case V4L2_PIX_FMT_QC08C: descr = "QCOM Compressed 8-bit Format"; break;
> case V4L2_PIX_FMT_QC10C: descr = "QCOM Compressed 10-bit Format"; break;
> + case V4L2_PIX_FMT_AV1: descr = "AV1"; break;
> + case V4L2_PIX_FMT_AVS: descr = "AVS"; break;
> + case V4L2_PIX_FMT_AVS2: descr = "AVS2"; break;
> default:
> if (fmt->description[0])
> return;
> diff --git a/include/uapi/linux/videodev2.h b/include/uapi/linux/videodev2.h
> index 01e630f2ec78..fa8ec0ddde3d 100644
> --- a/include/uapi/linux/videodev2.h
> +++ b/include/uapi/linux/videodev2.h
> @@ -738,6 +738,9 @@ struct v4l2_pix_format {
> #define V4L2_PIX_FMT_FWHT_STATELESS v4l2_fourcc('S', 'F', 'W', 'H') /* Stateless FWHT (vicodec) */
> #define V4L2_PIX_FMT_H264_SLICE v4l2_fourcc('S', '2', '6', '4') /* H264 parsed slices */
> #define V4L2_PIX_FMT_HEVC_SLICE v4l2_fourcc('S', '2', '6', '5') /* HEVC parsed slices */
> +#define V4L2_PIX_FMT_AV1 v4l2_fourcc('A', 'V', '1', '0') /* AV1 */
> +#define V4L2_PIX_FMT_AVS v4l2_fourcc('A', 'V', 'S', '0') /* AVS */
> +#define V4L2_PIX_FMT_AVS2 v4l2_fourcc('A', 'V', 'S', '2') /* AVS2 */
>
> /* Vendor-specific formats */
> #define V4L2_PIX_FMT_CPIA1 v4l2_fourcc('C', 'P', 'I', 'A') /* cpia1 YUV */
>
> base-commit: 568035b01cfb107af8d2e4bd2fb9aea22cf5b868
--
Regards,
Laurent Pinchart
next parent reply other threads:[~2022-08-26 9:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20220826030003.1066976-1-hao.shi@amlogic.com>
2022-08-26 9:15 ` Laurent Pinchart [this message]
2022-08-26 18:12 ` [PATCH] [media] v4l2: Add AV1, AVS and AVS2 format Nicolas Dufresne
[not found] ` <202208271409184370088@amlogic.com>
2022-08-28 17:08 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YwiPMOyfXKM8lxIR@pendragon.ideasonboard.com \
--to=laurent.pinchart@ideasonboard.com \
--cc=ezequiel@vanguardiasur.com.ar \
--cc=hans.verkuil@cisco.com \
--cc=hao.shi@amlogic.com \
--cc=hverkuil-cisco@xs4all.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=nanxin.qin@amlogic.com \
--cc=ribalda@chromium.org \
--cc=sakari.ailus@linux.intel.com \
--cc=stanimir.varbanov@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).