linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* Re: [PATCH] [media] v4l2: Add AV1, AVS and AVS2 format
       [not found] <20220826030003.1066976-1-hao.shi@amlogic.com>
@ 2022-08-26  9:15 ` Laurent Pinchart
  2022-08-26 18:12   ` Nicolas Dufresne
  0 siblings, 1 reply; 3+ messages in thread
From: Laurent Pinchart @ 2022-08-26  9:15 UTC (permalink / raw)
  To: Shi Hao
  Cc: linux-media, linux-kernel, mchehab, hans.verkuil, hverkuil-cisco,
	ezequiel, sakari.ailus, ribalda, stanimir.varbanov, nanxin.qin

Hello Shi,

Thank you for the patch.

On Fri, Aug 26, 2022 at 11:00:03AM +0800, Shi Hao wrote:
> From: "hao.shi" <hao.shi@amlogic.com>
> 
> Add AV1, AVS and AVS2 compressed pixel formats. They are
> the more common formats.
> 
> Signed-off-by: Shi Hao <hao.shi@amlogic.com>
> ---
>  drivers/media/v4l2-core/v4l2-ioctl.c | 3 +++
>  include/uapi/linux/videodev2.h       | 3 +++

The patch also needs to document the formats, in
Documentation/userspace-api/media/v4l/.

>  2 files changed, 6 insertions(+)
> 
> diff --git a/drivers/media/v4l2-core/v4l2-ioctl.c b/drivers/media/v4l2-core/v4l2-ioctl.c
> index c314025d977e..7b102c2f59b1 100644
> --- a/drivers/media/v4l2-core/v4l2-ioctl.c
> +++ b/drivers/media/v4l2-core/v4l2-ioctl.c
> @@ -1497,6 +1497,9 @@ static void v4l_fill_fmtdesc(struct v4l2_fmtdesc *fmt)
>  		case V4L2_PIX_FMT_MT21C:	descr = "Mediatek Compressed Format"; break;
>  		case V4L2_PIX_FMT_QC08C:	descr = "QCOM Compressed 8-bit Format"; break;
>  		case V4L2_PIX_FMT_QC10C:	descr = "QCOM Compressed 10-bit Format"; break;
> +		case V4L2_PIX_FMT_AV1:		descr = "AV1"; break;
> +		case V4L2_PIX_FMT_AVS:		descr = "AVS"; break;
> +		case V4L2_PIX_FMT_AVS2:		descr = "AVS2"; break;
>  		default:
>  			if (fmt->description[0])
>  				return;
> diff --git a/include/uapi/linux/videodev2.h b/include/uapi/linux/videodev2.h
> index 01e630f2ec78..fa8ec0ddde3d 100644
> --- a/include/uapi/linux/videodev2.h
> +++ b/include/uapi/linux/videodev2.h
> @@ -738,6 +738,9 @@ struct v4l2_pix_format {
>  #define V4L2_PIX_FMT_FWHT_STATELESS     v4l2_fourcc('S', 'F', 'W', 'H') /* Stateless FWHT (vicodec) */
>  #define V4L2_PIX_FMT_H264_SLICE v4l2_fourcc('S', '2', '6', '4') /* H264 parsed slices */
>  #define V4L2_PIX_FMT_HEVC_SLICE v4l2_fourcc('S', '2', '6', '5') /* HEVC parsed slices */
> +#define V4L2_PIX_FMT_AV1      v4l2_fourcc('A', 'V', '1', '0') /* AV1 */
> +#define V4L2_PIX_FMT_AVS      v4l2_fourcc('A', 'V', 'S', '0') /* AVS */
> +#define V4L2_PIX_FMT_AVS2     v4l2_fourcc('A', 'V', 'S', '2') /* AVS2 */
>  
>  /*  Vendor-specific formats   */
>  #define V4L2_PIX_FMT_CPIA1    v4l2_fourcc('C', 'P', 'I', 'A') /* cpia1 YUV */
> 
> base-commit: 568035b01cfb107af8d2e4bd2fb9aea22cf5b868

-- 
Regards,

Laurent Pinchart

^ permalink raw reply	[flat|nested] 3+ messages in thread
* Re: [PATCH] [media] v4l2: Add AV1, AVS and AVS2 format
  2022-08-26  9:15 ` [PATCH] [media] v4l2: Add AV1, AVS and AVS2 format Laurent Pinchart
@ 2022-08-26 18:12   ` Nicolas Dufresne
       [not found]     ` <202208271409184370088@amlogic.com>
  0 siblings, 1 reply; 3+ messages in thread
From: Nicolas Dufresne @ 2022-08-26 18:12 UTC (permalink / raw)
  To: Laurent Pinchart, Shi Hao
  Cc: linux-media, linux-kernel, mchehab, hans.verkuil, hverkuil-cisco,
	ezequiel, sakari.ailus, ribalda, stanimir.varbanov, nanxin.qin

Le vendredi 26 août 2022 à 12:15 +0300, Laurent Pinchart a écrit :
> Hello Shi,
> 
> Thank you for the patch.
> 
> On Fri, Aug 26, 2022 at 11:00:03AM +0800, Shi Hao wrote:
> > From: "hao.shi" <hao.shi@amlogic.com>
> > 
> > Add AV1, AVS and AVS2 compressed pixel formats. They are
> > the more common formats.
> > 
> > Signed-off-by: Shi Hao <hao.shi@amlogic.com>
> > ---
> >  drivers/media/v4l2-core/v4l2-ioctl.c | 3 +++
> >  include/uapi/linux/videodev2.h       | 3 +++
> 
> The patch also needs to document the formats, in
> Documentation/userspace-api/media/v4l/.
> 
> >  2 files changed, 6 insertions(+)
> > 
> > diff --git a/drivers/media/v4l2-core/v4l2-ioctl.c b/drivers/media/v4l2-core/v4l2-ioctl.c
> > index c314025d977e..7b102c2f59b1 100644
> > --- a/drivers/media/v4l2-core/v4l2-ioctl.c
> > +++ b/drivers/media/v4l2-core/v4l2-ioctl.c
> > @@ -1497,6 +1497,9 @@ static void v4l_fill_fmtdesc(struct v4l2_fmtdesc *fmt)
> >  		case V4L2_PIX_FMT_MT21C:	descr = "Mediatek Compressed Format"; break;
> >  		case V4L2_PIX_FMT_QC08C:	descr = "QCOM Compressed 8-bit Format"; break;
> >  		case V4L2_PIX_FMT_QC10C:	descr = "QCOM Compressed 10-bit Format"; break;
> > +		case V4L2_PIX_FMT_AV1:		descr = "AV1"; break;

A recommendation while adding proper spec/doc. AV1 have multiple representation,
the exact expected representation should be specified in the doc. This will
avoid similar issues we had with H.264 (Annex B. vs AVCc formats).

> > +		case V4L2_PIX_FMT_AVS:		descr = "AVS"; break;
> > +		case V4L2_PIX_FMT_AVS2:		descr = "AVS2"; break;

Same things should be checked for these two, they aren't very common outside of
China, at least I didn't had a chance to play with these so far.

cheers,
Nicolas

> >  		default:
> >  			if (fmt->description[0])
> >  				return;
> > diff --git a/include/uapi/linux/videodev2.h b/include/uapi/linux/videodev2.h
> > index 01e630f2ec78..fa8ec0ddde3d 100644
> > --- a/include/uapi/linux/videodev2.h
> > +++ b/include/uapi/linux/videodev2.h
> > @@ -738,6 +738,9 @@ struct v4l2_pix_format {
> >  #define V4L2_PIX_FMT_FWHT_STATELESS     v4l2_fourcc('S', 'F', 'W', 'H') /* Stateless FWHT (vicodec) */
> >  #define V4L2_PIX_FMT_H264_SLICE v4l2_fourcc('S', '2', '6', '4') /* H264 parsed slices */
> >  #define V4L2_PIX_FMT_HEVC_SLICE v4l2_fourcc('S', '2', '6', '5') /* HEVC parsed slices */
> > +#define V4L2_PIX_FMT_AV1      v4l2_fourcc('A', 'V', '1', '0') /* AV1 */
> > +#define V4L2_PIX_FMT_AVS      v4l2_fourcc('A', 'V', 'S', '0') /* AVS */
> > +#define V4L2_PIX_FMT_AVS2     v4l2_fourcc('A', 'V', 'S', '2') /* AVS2 */
> >  
> >  /*  Vendor-specific formats   */
> >  #define V4L2_PIX_FMT_CPIA1    v4l2_fourcc('C', 'P', 'I', 'A') /* cpia1 YUV */
> > 
> > base-commit: 568035b01cfb107af8d2e4bd2fb9aea22cf5b868
> 


^ permalink raw reply	[flat|nested] 3+ messages in thread
* Re: Re: [PATCH] [media] v4l2: Add AV1, AVS and AVS2 format
       [not found]     ` <202208271409184370088@amlogic.com>
@ 2022-08-28 17:08       ` Laurent Pinchart
  0 siblings, 0 replies; 3+ messages in thread
From: Laurent Pinchart @ 2022-08-28 17:08 UTC (permalink / raw)
  To: nanxin.qin
  Cc: Nicolas Dufresne, hao.shi, linux-media, linux-kernel, mchehab,
	hans.verkuil, Hans Verkuil, ezequiel, sakari.ailus, ribalda,
	stanimir.varbanov, Hui.Zhang

On Sat, Aug 27, 2022 at 02:09:18PM +0800, nanxin.qin@amlogic.com wrote:
> Dear Nicolas
> 
> Thanks for the review of our CL, we found that AV1 has not been submitted to
> the kernel tree. Due to the urgency of the project, we intend to submit the public
> changes to the kernel mainline. However, it may be more suitable for the coding
> protocol working group to submit. 
> 
> I have a doubt about the reply, can we just add a description of AV1
> in pixfmt-compressed.rst? Just like declaring vp9.

Referring to the corresponding standard is fine. If the standard, or the
V4L2 API, supports multiple formats (e.g. H.264 with or without start
codes, or formats that contain different metadata for stateful or
stateless codecs), the documentation should also indicate which variant
the format refers to.

> In addition, avs and avs2 are Chinese audio and video coding standards, 
> which are mandatory for TV set-top boxes sold in China. I think it is necessary
> to submit them to the main branch. 
> 
> Then there is whether it is appropriate to submit AV1 and AVS together. 
> If it is not good, we can submit it separately. 
> 
> Please correct me if you have any suggestions or comments. thanks.
> 
> nanxin.qin@amlogic.com
>  
> From: Nicolas Dufresne
> Date: 2022-08-27 02:12
> To: Laurent Pinchart; Shi Hao
> CC: linux-media; linux-kernel; mchehab; hans.verkuil; hverkuil-cisco; ezequiel; sakari.ailus; ribalda; stanimir.varbanov; nanxin.qin
> Subject: Re: [PATCH] [media] v4l2: Add AV1, AVS and AVS2 format
> [ EXTERNAL EMAIL ]
>  
> Le vendredi 26 août 2022 à 12:15 +0300, Laurent Pinchart a écrit :
> > Hello Shi,
> > 
> > Thank you for the patch.
> > 
> > On Fri, Aug 26, 2022 at 11:00:03AM +0800, Shi Hao wrote:
> > > From: "hao.shi" <hao.shi@amlogic.com>
> > > 
> > > Add AV1, AVS and AVS2 compressed pixel formats. They are
> > > the more common formats.
> > > 
> > > Signed-off-by: Shi Hao <hao.shi@amlogic.com>
> > > ---
> > >  drivers/media/v4l2-core/v4l2-ioctl.c | 3 +++
> > >  include/uapi/linux/videodev2.h       | 3 +++
> > 
> > The patch also needs to document the formats, in
> > Documentation/userspace-api/media/v4l/.
> > 
> > >  2 files changed, 6 insertions(+)
> > > 
> > > diff --git a/drivers/media/v4l2-core/v4l2-ioctl.c b/drivers/media/v4l2-core/v4l2-ioctl.c
> > > index c314025d977e..7b102c2f59b1 100644
> > > --- a/drivers/media/v4l2-core/v4l2-ioctl.c
> > > +++ b/drivers/media/v4l2-core/v4l2-ioctl.c
> > > @@ -1497,6 +1497,9 @@ static void v4l_fill_fmtdesc(struct v4l2_fmtdesc *fmt)
> > >  case V4L2_PIX_FMT_MT21C: descr = "Mediatek Compressed Format"; break;
> > >  case V4L2_PIX_FMT_QC08C: descr = "QCOM Compressed 8-bit Format"; break;
> > >  case V4L2_PIX_FMT_QC10C: descr = "QCOM Compressed 10-bit Format"; break;
> > > + case V4L2_PIX_FMT_AV1: descr = "AV1"; break;
>  
> A recommendation while adding proper spec/doc. AV1 have multiple representation,
> the exact expected representation should be specified in the doc. This will
> avoid similar issues we had with H.264 (Annex B. vs AVCc formats).
>  
> > > + case V4L2_PIX_FMT_AVS: descr = "AVS"; break;
> > > + case V4L2_PIX_FMT_AVS2: descr = "AVS2"; break;
>  
> Same things should be checked for these two, they aren't very common outside of
> China, at least I didn't had a chance to play with these so far.
>  
> cheers,
> Nicolas
>  
> > >  default:
> > >  if (fmt->description[0])
> > >  return;
> > > diff --git a/include/uapi/linux/videodev2.h b/include/uapi/linux/videodev2.h
> > > index 01e630f2ec78..fa8ec0ddde3d 100644
> > > --- a/include/uapi/linux/videodev2.h
> > > +++ b/include/uapi/linux/videodev2.h
> > > @@ -738,6 +738,9 @@ struct v4l2_pix_format {
> > >  #define V4L2_PIX_FMT_FWHT_STATELESS     v4l2_fourcc('S', 'F', 'W', 'H') /* Stateless FWHT (vicodec) */
> > >  #define V4L2_PIX_FMT_H264_SLICE v4l2_fourcc('S', '2', '6', '4') /* H264 parsed slices */
> > >  #define V4L2_PIX_FMT_HEVC_SLICE v4l2_fourcc('S', '2', '6', '5') /* HEVC parsed slices */
> > > +#define V4L2_PIX_FMT_AV1      v4l2_fourcc('A', 'V', '1', '0') /* AV1 */
> > > +#define V4L2_PIX_FMT_AVS      v4l2_fourcc('A', 'V', 'S', '0') /* AVS */
> > > +#define V4L2_PIX_FMT_AVS2     v4l2_fourcc('A', 'V', 'S', '2') /* AVS2 */
> > >  
> > >  /*  Vendor-specific formats   */
> > >  #define V4L2_PIX_FMT_CPIA1    v4l2_fourcc('C', 'P', 'I', 'A') /* cpia1 YUV */
> > > 
> > > base-commit: 568035b01cfb107af8d2e4bd2fb9aea22cf5b868

-- 
Regards,

Laurent Pinchart

^ permalink raw reply	[flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-08-28 17:08 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <20220826030003.1066976-1-hao.shi@amlogic.com>
2022-08-26  9:15 ` [PATCH] [media] v4l2: Add AV1, AVS and AVS2 format Laurent Pinchart
2022-08-26 18:12   ` Nicolas Dufresne
     [not found]     ` <202208271409184370088@amlogic.com>
2022-08-28 17:08       ` Laurent Pinchart

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).