* [PATCH v3] crypto: aspeed: fix format unexpected build warning
@ 2022-09-07 3:34 Neal Liu
2022-09-07 6:12 ` Herbert Xu
0 siblings, 1 reply; 2+ messages in thread
From: Neal Liu @ 2022-09-07 3:34 UTC (permalink / raw)
To: Randy Dunlap, Herbert Xu, David S . Miller, Joel Stanley, Andrew Jeffery
Cc: linux-aspeed, linux-crypto, linux-arm-kernel, linux-kernel,
BMC-SW, kernel test robot
This fixes the following similar build warning when
enabling compile test:
aspeed-hace-hash.c:188:9: warning: format '%x' expects argument of type
'unsigned int', but argument 7 has type 'size_t' {aka 'long unsigned int'}
[-Wformat=]
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Neal Liu <neal_liu@aspeedtech.com>
Acked-by: Randy Dunlap <rdunlap@infradead.org>
---
v3: Use "%pad" to print dma_addr_t type.
v2: Use "%zu" format to print size_t.
drivers/crypto/aspeed/aspeed-hace-hash.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/crypto/aspeed/aspeed-hace-hash.c b/drivers/crypto/aspeed/aspeed-hace-hash.c
index 0a44ffc0e13b..5a8a3a611dd4 100644
--- a/drivers/crypto/aspeed/aspeed-hace-hash.c
+++ b/drivers/crypto/aspeed/aspeed-hace-hash.c
@@ -185,7 +185,7 @@ static int aspeed_ahash_dma_prepare_sg(struct aspeed_hace_dev *hace_dev)
remain = (rctx->total + rctx->bufcnt) % rctx->block_size;
length = rctx->total + rctx->bufcnt - remain;
- AHASH_DBG(hace_dev, "%s:0x%x, %s:0x%x, %s:0x%x, %s:0x%x\n",
+ AHASH_DBG(hace_dev, "%s:0x%x, %s:%zu, %s:0x%x, %s:0x%x\n",
"rctx total", rctx->total, "bufcnt", rctx->bufcnt,
"length", length, "remain", remain);
@@ -324,8 +324,8 @@ static int aspeed_hace_ahash_trigger(struct aspeed_hace_dev *hace_dev,
struct ahash_request *req = hash_engine->req;
struct aspeed_sham_reqctx *rctx = ahash_request_ctx(req);
- AHASH_DBG(hace_dev, "src_dma:0x%x, digest_dma:0x%x, length:0x%x\n",
- hash_engine->src_dma, hash_engine->digest_dma,
+ AHASH_DBG(hace_dev, "src_dma:%pad, digest_dma:%pad, length:%zu\n",
+ &hash_engine->src_dma, &hash_engine->digest_dma,
hash_engine->src_length);
rctx->cmd |= HASH_CMD_INT_ENABLE;
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v3] crypto: aspeed: fix format unexpected build warning
2022-09-07 3:34 [PATCH v3] crypto: aspeed: fix format unexpected build warning Neal Liu
@ 2022-09-07 6:12 ` Herbert Xu
0 siblings, 0 replies; 2+ messages in thread
From: Herbert Xu @ 2022-09-07 6:12 UTC (permalink / raw)
To: Neal Liu
Cc: Randy Dunlap, David S . Miller, Joel Stanley, Andrew Jeffery,
linux-aspeed, linux-crypto, linux-arm-kernel, linux-kernel,
BMC-SW, kernel test robot
On Wed, Sep 07, 2022 at 11:34:31AM +0800, Neal Liu wrote:
> This fixes the following similar build warning when
> enabling compile test:
>
> aspeed-hace-hash.c:188:9: warning: format '%x' expects argument of type
> 'unsigned int', but argument 7 has type 'size_t' {aka 'long unsigned int'}
> [-Wformat=]
>
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Neal Liu <neal_liu@aspeedtech.com>
> Acked-by: Randy Dunlap <rdunlap@infradead.org>
> ---
> v3: Use "%pad" to print dma_addr_t type.
> v2: Use "%zu" format to print size_t.
>
> drivers/crypto/aspeed/aspeed-hace-hash.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-09-07 6:13 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-07 3:34 [PATCH v3] crypto: aspeed: fix format unexpected build warning Neal Liu
2022-09-07 6:12 ` Herbert Xu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).