RE: [PATCH v9 0/6] thunderbolt: Add support for ASMedia NVM firmware image format

RE: [PATCH v9 0/6] thunderbolt: Add support for ASMedia NVM firmware image format

[Szuying Chen]

From: Szuying Chen <Chloe_Chen@asmedia.com.tw>

Hi,

> Hi all,
> 
> This series adds support for ASMedia NVM images. It is based on the
> work of Szuying Chen with a couple of changes from me. The first
> patches move Intel specific NVM validation into nvm.c and >adds a
> vendor table for both routers and retimers that can be extended to
> support different >vendor NVM image formats. Once that is done the
> ASMedia NVM image format support is added.
> 
> The previous version of the patch series can be found here:
> 
>   https://lore.kernel.org/linux-usb/20220902094010.2170-1-chensiying21@gmail.com/
> 
> Changes from the previous version:
> 
>   * Shuffled the ordering of the patches a bit
>   * Add tb_retimer_nvm_read() and tb_switch_nvm_read()
>   * Add ->write_headers() callback that is used with Thunderbolt 2
>     routers
>   * Cover retimers too
>   * Minor cleanups and tweaks
> 
> I have tested this on Intel Thunderbolt 3 and Thunderbolt 4 routers.
> ASMedia folks, can you try this also on your side and let me know if it works or not?

I send a comments in separate email please help to modify it.
I have tested this on ASMedia USB4 router. It work well.

> 
> Mika Westerberg (1):
>   thunderbolt: Provide tb_retimer_nvm_read() analogous to tb_switch_nvm_read()
> 
> Szuying Chen (5):
>   thunderbolt: Allow NVM upgrade of USB4 host routers
>   thunderbolt: Extend NVM version fields to 32-bits
>   thunderbolt: Rename and make nvm_read() available for other files
>   thunderbolt: Move vendor specific NVM handling into nvm.c
>   thunderbolt: Add support for ASMedia NVM image format
> 
>  drivers/thunderbolt/nvm.c     | 385 +++++++++++++++++++++++++++++++++-
>  drivers/thunderbolt/retimer.c | 105 ++++------  drivers/thunderbolt/switch.c  | 162 +++++---------
>  drivers/thunderbolt/tb.c      |   5 +-
>  drivers/thunderbolt/tb.h      |  30 ++-
>  5 files changed, 498 insertions(+), 189 deletions(-)

Thanks!

<p></p>

Re: [PATCH v9 0/6] thunderbolt: Add support for ASMedia NVM firmware image format

[Mika Westerberg]

Hi,

On Tue, Sep 06, 2022 at 06:12:45PM +0800, Szuying Chen wrote:
> From: Szuying Chen <Chloe_Chen@asmedia.com.tw>
> 
> Hi,
> 
> > Hi all,
> > 
> > This series adds support for ASMedia NVM images. It is based on the
> > work of Szuying Chen with a couple of changes from me. The first
> > patches move Intel specific NVM validation into nvm.c and >adds a
> > vendor table for both routers and retimers that can be extended to
> > support different >vendor NVM image formats. Once that is done the
> > ASMedia NVM image format support is added.
> > 
> > The previous version of the patch series can be found here:
> > 
> >   https://lore.kernel.org/linux-usb/20220902094010.2170-1-chensiying21@gmail.com/
> > 
> > Changes from the previous version:
> > 
> >   * Shuffled the ordering of the patches a bit
> >   * Add tb_retimer_nvm_read() and tb_switch_nvm_read()
> >   * Add ->write_headers() callback that is used with Thunderbolt 2
> >     routers
> >   * Cover retimers too
> >   * Minor cleanups and tweaks
> > 
> > I have tested this on Intel Thunderbolt 3 and Thunderbolt 4 routers.
> > ASMedia folks, can you try this also on your side and let me know if it works or not?
> 
> I send a comments in separate email please help to modify it.
> I have tested this on ASMedia USB4 router. It work well.

I fixed the copy paste issue and applied all to thunderbolt.git/next,
thanks!