* [PATCH] Input: twl4030-vibra - Drop legacy, non DT boot support
@ 2022-06-16 15:33 Peter Ujfalusi
2022-09-25 5:37 ` Dmitry Torokhov
0 siblings, 1 reply; 3+ messages in thread
From: Peter Ujfalusi @ 2022-06-16 15:33 UTC (permalink / raw)
To: dmitry.torokhov; +Cc: tony, linux-omap, linux-kernel, linux-input
Legacy or non DT boot is no longer possible on systems where the
tw4030/5030 is used.
Drop the support for handling legacy pdata.
Signed-off-by: Peter Ujfalusi <peter.ujfalusi@gmail.com>
---
drivers/input/misc/twl4030-vibra.c | 13 ++++---------
1 file changed, 4 insertions(+), 9 deletions(-)
diff --git a/drivers/input/misc/twl4030-vibra.c b/drivers/input/misc/twl4030-vibra.c
index e0ff616fb857..5619996da86f 100644
--- a/drivers/input/misc/twl4030-vibra.c
+++ b/drivers/input/misc/twl4030-vibra.c
@@ -163,14 +163,10 @@ static int __maybe_unused twl4030_vibra_resume(struct device *dev)
static SIMPLE_DEV_PM_OPS(twl4030_vibra_pm_ops,
twl4030_vibra_suspend, twl4030_vibra_resume);
-static bool twl4030_vibra_check_coexist(struct twl4030_vibra_data *pdata,
- struct device_node *parent)
+static bool twl4030_vibra_check_coexist(struct device_node *parent)
{
struct device_node *node;
- if (pdata && pdata->coexist)
- return true;
-
node = of_get_child_by_name(parent, "codec");
if (node) {
of_node_put(node);
@@ -182,13 +178,12 @@ static bool twl4030_vibra_check_coexist(struct twl4030_vibra_data *pdata,
static int twl4030_vibra_probe(struct platform_device *pdev)
{
- struct twl4030_vibra_data *pdata = dev_get_platdata(&pdev->dev);
struct device_node *twl4030_core_node = pdev->dev.parent->of_node;
struct vibra_info *info;
int ret;
- if (!pdata && !twl4030_core_node) {
- dev_dbg(&pdev->dev, "platform_data not available\n");
+ if (!twl4030_core_node) {
+ dev_dbg(&pdev->dev, "twl4030 OF node is missing\n");
return -EINVAL;
}
@@ -197,7 +192,7 @@ static int twl4030_vibra_probe(struct platform_device *pdev)
return -ENOMEM;
info->dev = &pdev->dev;
- info->coexist = twl4030_vibra_check_coexist(pdata, twl4030_core_node);
+ info->coexist = twl4030_vibra_check_coexist(twl4030_core_node);
INIT_WORK(&info->play_work, vibra_play_work);
info->input_dev = devm_input_allocate_device(&pdev->dev);
--
2.36.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] Input: twl4030-vibra - Drop legacy, non DT boot support
2022-06-16 15:33 [PATCH] Input: twl4030-vibra - Drop legacy, non DT boot support Peter Ujfalusi
@ 2022-09-25 5:37 ` Dmitry Torokhov
2022-09-26 18:09 ` Péter Ujfalusi
0 siblings, 1 reply; 3+ messages in thread
From: Dmitry Torokhov @ 2022-09-25 5:37 UTC (permalink / raw)
To: Peter Ujfalusi; +Cc: tony, linux-omap, linux-kernel, linux-input
On Thu, Jun 16, 2022 at 06:33:23PM +0300, Peter Ujfalusi wrote:
> Legacy or non DT boot is no longer possible on systems where the
> tw4030/5030 is used.
>
> Drop the support for handling legacy pdata.
>
> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@gmail.com>
Applied, thank you.
I suppose you will be dropping definition of struct twl4030_vibra_data
from include/linux/mfd/twl.h as well?
Thanks.
--
Dmitry
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Input: twl4030-vibra - Drop legacy, non DT boot support
2022-09-25 5:37 ` Dmitry Torokhov
@ 2022-09-26 18:09 ` Péter Ujfalusi
0 siblings, 0 replies; 3+ messages in thread
From: Péter Ujfalusi @ 2022-09-26 18:09 UTC (permalink / raw)
To: Dmitry Torokhov; +Cc: tony, linux-omap, linux-kernel, linux-input
On 9/25/22 08:37, Dmitry Torokhov wrote:
> On Thu, Jun 16, 2022 at 06:33:23PM +0300, Peter Ujfalusi wrote:
>> Legacy or non DT boot is no longer possible on systems where the
>> tw4030/5030 is used.
>>
>> Drop the support for handling legacy pdata.
>>
>> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@gmail.com>
>
> Applied, thank you.
>
> I suppose you will be dropping definition of struct twl4030_vibra_data
> from include/linux/mfd/twl.h as well?
Yes, that is the plan after all drivers have been cleaned up.
--
Péter
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-09-26 18:12 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-16 15:33 [PATCH] Input: twl4030-vibra - Drop legacy, non DT boot support Peter Ujfalusi
2022-09-25 5:37 ` Dmitry Torokhov
2022-09-26 18:09 ` Péter Ujfalusi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).