* [PATCH -next] ARM: kexec: Make machine_crash_nonpanic_core() static
@ 2022-08-16 7:42 Chen Lifu
2022-09-28 6:52 ` Baoquan He
0 siblings, 1 reply; 2+ messages in thread
From: Chen Lifu @ 2022-08-16 7:42 UTC (permalink / raw)
To: linux, akpm, bhe, pmladek, kexec, linux-arm-kernel; +Cc: linux-kernel, chenlifu
This symbol is not used outside of the file, so mark it static.
Fixes the following warning:
arch/arm/kernel/machine_kexec.c:76:6: warning: symbol 'machine_crash_nonpanic_core' was not declared. Should it be static?
Signed-off-by: Chen Lifu <chenlifu@huawei.com>
---
arch/arm/kernel/machine_kexec.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/kernel/machine_kexec.c b/arch/arm/kernel/machine_kexec.c
index f567032a09c0..a2e9ac763a9f 100644
--- a/arch/arm/kernel/machine_kexec.c
+++ b/arch/arm/kernel/machine_kexec.c
@@ -71,11 +71,11 @@ int machine_kexec_prepare(struct kimage *image)
void machine_kexec_cleanup(struct kimage *image)
{
}
-void machine_crash_nonpanic_core(void *unused)
+static void machine_crash_nonpanic_core(void *unused)
{
struct pt_regs regs;
crash_setup_regs(®s, get_irq_regs());
printk(KERN_DEBUG "CPU %u will stop doing anything useful since another CPU has crashed\n",
--
2.37.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next] ARM: kexec: Make machine_crash_nonpanic_core() static
2022-08-16 7:42 [PATCH -next] ARM: kexec: Make machine_crash_nonpanic_core() static Chen Lifu
@ 2022-09-28 6:52 ` Baoquan He
0 siblings, 0 replies; 2+ messages in thread
From: Baoquan He @ 2022-09-28 6:52 UTC (permalink / raw)
To: Chen Lifu; +Cc: linux, akpm, pmladek, kexec, linux-arm-kernel, linux-kernel
On 08/16/22 at 03:42pm, Chen Lifu wrote:
> This symbol is not used outside of the file, so mark it static.
>
> Fixes the following warning:
>
> arch/arm/kernel/machine_kexec.c:76:6: warning: symbol 'machine_crash_nonpanic_core' was not declared. Should it be static?
>
> Signed-off-by: Chen Lifu <chenlifu@huawei.com>
LGTM,
Acked-by: Baoquan He <bhe@redhat.com>
> ---
> arch/arm/kernel/machine_kexec.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/kernel/machine_kexec.c b/arch/arm/kernel/machine_kexec.c
> index f567032a09c0..a2e9ac763a9f 100644
> --- a/arch/arm/kernel/machine_kexec.c
> +++ b/arch/arm/kernel/machine_kexec.c
> @@ -71,11 +71,11 @@ int machine_kexec_prepare(struct kimage *image)
>
> void machine_kexec_cleanup(struct kimage *image)
> {
> }
>
> -void machine_crash_nonpanic_core(void *unused)
> +static void machine_crash_nonpanic_core(void *unused)
> {
> struct pt_regs regs;
>
> crash_setup_regs(®s, get_irq_regs());
> printk(KERN_DEBUG "CPU %u will stop doing anything useful since another CPU has crashed\n",
> --
> 2.37.1
>
>
> _______________________________________________
> kexec mailing list
> kexec@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/kexec
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-09-28 6:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-16 7:42 [PATCH -next] ARM: kexec: Make machine_crash_nonpanic_core() static Chen Lifu
2022-09-28 6:52 ` Baoquan He
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).