* [PATCH] mfd: da9061: Fix Failed to set Two-Wire Bus Mode.
@ 2022-09-15 9:20 Jens Hillenstedt
2022-09-15 14:23 ` DLG Adam Ward
2022-09-28 10:38 ` Lee Jones
0 siblings, 2 replies; 3+ messages in thread
From: Jens Hillenstedt @ 2022-09-15 9:20 UTC (permalink / raw)
To: support.opensource, lee; +Cc: Jens Hillenstedt, linux-kernel
In da9062_i2c_probe() regmap_clear_bits() tries to access CONFIG_J
register. As CONFIG_J is not present in da9061_aa_writeable_ranges[] probe
of da9061 fails:
da9062 2-0058: Entering I2C mode!
da9062 2-0058: Failed to set Two-Wire Bus Mode.
da9062: probe of 2-0058 failed with error -5
Add CONFIG_J register to da9061_aa_writeable_ranges[].
Fixes: 5c6f0f456351 ("mfd: da9062: Support SMBus and I2C mode")
Signed-off-by: Jens Hillenstedt <jens.hillenstedt@ise.de>
---
drivers/mfd/da9062-core.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/mfd/da9062-core.c b/drivers/mfd/da9062-core.c
index 2774b2cbaea6..c2acdbcd5d6b 100644
--- a/drivers/mfd/da9062-core.c
+++ b/drivers/mfd/da9062-core.c
@@ -453,6 +453,7 @@ static const struct regmap_range da9061_aa_writeable_ranges[] = {
regmap_reg_range(DA9062AA_VBUCK1_B, DA9062AA_VBUCK4_B),
regmap_reg_range(DA9062AA_VBUCK3_B, DA9062AA_VBUCK3_B),
regmap_reg_range(DA9062AA_VLDO1_B, DA9062AA_VLDO4_B),
+ regmap_reg_range(DA9062AA_CONFIG_J, DA9062AA_CONFIG_J),
regmap_reg_range(DA9062AA_GP_ID_0, DA9062AA_GP_ID_19),
};
--
2.30.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* RE: [PATCH] mfd: da9061: Fix Failed to set Two-Wire Bus Mode.
2022-09-15 9:20 [PATCH] mfd: da9061: Fix Failed to set Two-Wire Bus Mode Jens Hillenstedt
@ 2022-09-15 14:23 ` DLG Adam Ward
2022-09-28 10:38 ` Lee Jones
1 sibling, 0 replies; 3+ messages in thread
From: DLG Adam Ward @ 2022-09-15 14:23 UTC (permalink / raw)
To: Jens Hillenstedt, support.opensource, lee; +Cc: linux-kernel
On 15 September 2022 10:20 Jens Hillenstedt wrote:
>In da9062_i2c_probe() regmap_clear_bits() tries to access CONFIG_J register. As CONFIG_J is not present in da9061_aa_writeable_ranges[] probe of da9061 fails:
Thanks!
Reviewed-by: Adam Ward <DLG-Adam.Ward.opensource@dm.renesas.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] mfd: da9061: Fix Failed to set Two-Wire Bus Mode.
2022-09-15 9:20 [PATCH] mfd: da9061: Fix Failed to set Two-Wire Bus Mode Jens Hillenstedt
2022-09-15 14:23 ` DLG Adam Ward
@ 2022-09-28 10:38 ` Lee Jones
1 sibling, 0 replies; 3+ messages in thread
From: Lee Jones @ 2022-09-28 10:38 UTC (permalink / raw)
To: Jens Hillenstedt; +Cc: support.opensource, linux-kernel
On Thu, 15 Sep 2022, Jens Hillenstedt wrote:
> In da9062_i2c_probe() regmap_clear_bits() tries to access CONFIG_J
> register. As CONFIG_J is not present in da9061_aa_writeable_ranges[] probe
> of da9061 fails:
>
> da9062 2-0058: Entering I2C mode!
> da9062 2-0058: Failed to set Two-Wire Bus Mode.
> da9062: probe of 2-0058 failed with error -5
>
> Add CONFIG_J register to da9061_aa_writeable_ranges[].
>
> Fixes: 5c6f0f456351 ("mfd: da9062: Support SMBus and I2C mode")
> Signed-off-by: Jens Hillenstedt <jens.hillenstedt@ise.de>
> ---
> drivers/mfd/da9062-core.c | 1 +
> 1 file changed, 1 insertion(+)
Applied, thanks.
--
Lee Jones [李琼斯]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-09-28 10:39 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-15 9:20 [PATCH] mfd: da9061: Fix Failed to set Two-Wire Bus Mode Jens Hillenstedt
2022-09-15 14:23 ` DLG Adam Ward
2022-09-28 10:38 ` Lee Jones
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).