* [PATCH] nfc: mrvl: Use of_property_read_bool() for boolean properties
@ 2023-03-10 14:47 Rob Herring
2023-03-11 11:41 ` Simon Horman
2023-03-13 6:53 ` Krzysztof Kozlowski
0 siblings, 2 replies; 3+ messages in thread
From: Rob Herring @ 2023-03-10 14:47 UTC (permalink / raw)
To: Krzysztof Kozlowski; +Cc: devicetree, netdev, linux-kernel
It is preferred to use typed property access functions (i.e.
of_property_read_<type> functions) rather than low-level
of_get_property/of_find_property functions for reading properties.
Convert reading boolean properties to to of_property_read_bool().
Signed-off-by: Rob Herring <robh@kernel.org>
---
drivers/nfc/nfcmrvl/i2c.c | 2 +-
drivers/nfc/nfcmrvl/main.c | 6 +-----
drivers/nfc/nfcmrvl/uart.c | 11 ++---------
3 files changed, 4 insertions(+), 15 deletions(-)
diff --git a/drivers/nfc/nfcmrvl/i2c.c b/drivers/nfc/nfcmrvl/i2c.c
index e74342b0b728..164e2ab859fd 100644
--- a/drivers/nfc/nfcmrvl/i2c.c
+++ b/drivers/nfc/nfcmrvl/i2c.c
@@ -168,7 +168,7 @@ static int nfcmrvl_i2c_parse_dt(struct device_node *node,
return ret;
}
- if (of_find_property(node, "i2c-int-falling", NULL))
+ if (of_property_read_bool(node, "i2c-int-falling"))
pdata->irq_polarity = IRQF_TRIGGER_FALLING;
else
pdata->irq_polarity = IRQF_TRIGGER_RISING;
diff --git a/drivers/nfc/nfcmrvl/main.c b/drivers/nfc/nfcmrvl/main.c
index 1a5284de4341..141bc4b66dcb 100644
--- a/drivers/nfc/nfcmrvl/main.c
+++ b/drivers/nfc/nfcmrvl/main.c
@@ -261,11 +261,7 @@ int nfcmrvl_parse_dt(struct device_node *node,
return reset_n_io;
}
pdata->reset_n_io = reset_n_io;
-
- if (of_find_property(node, "hci-muxed", NULL))
- pdata->hci_muxed = 1;
- else
- pdata->hci_muxed = 0;
+ pdata->hci_muxed = of_property_read_bool(node, "hci-muxed");
return 0;
}
diff --git a/drivers/nfc/nfcmrvl/uart.c b/drivers/nfc/nfcmrvl/uart.c
index 9c92cbdc42f0..956ae92f7573 100644
--- a/drivers/nfc/nfcmrvl/uart.c
+++ b/drivers/nfc/nfcmrvl/uart.c
@@ -76,15 +76,8 @@ static int nfcmrvl_uart_parse_dt(struct device_node *node,
return ret;
}
- if (of_find_property(matched_node, "flow-control", NULL))
- pdata->flow_control = 1;
- else
- pdata->flow_control = 0;
-
- if (of_find_property(matched_node, "break-control", NULL))
- pdata->break_control = 1;
- else
- pdata->break_control = 0;
+ pdata->flow_control = of_property_read_bool(matched_node, "flow-control");
+ pdata->break_control = of_property_read_bool(matched_node, "break-control");
of_node_put(matched_node);
--
2.39.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] nfc: mrvl: Use of_property_read_bool() for boolean properties
2023-03-10 14:47 [PATCH] nfc: mrvl: Use of_property_read_bool() for boolean properties Rob Herring
@ 2023-03-11 11:41 ` Simon Horman
2023-03-13 6:53 ` Krzysztof Kozlowski
1 sibling, 0 replies; 3+ messages in thread
From: Simon Horman @ 2023-03-11 11:41 UTC (permalink / raw)
To: Rob Herring; +Cc: Krzysztof Kozlowski, devicetree, netdev, linux-kernel
On Fri, Mar 10, 2023 at 08:47:18AM -0600, Rob Herring wrote:
> It is preferred to use typed property access functions (i.e.
> of_property_read_<type> functions) rather than low-level
> of_get_property/of_find_property functions for reading properties.
> Convert reading boolean properties to to of_property_read_bool().
>
> Signed-off-by: Rob Herring <robh@kernel.org>
Reviewed-by: Simon Horman <simon.horman@corigine.com>
> ---
> drivers/nfc/nfcmrvl/i2c.c | 2 +-
> drivers/nfc/nfcmrvl/main.c | 6 +-----
> drivers/nfc/nfcmrvl/uart.c | 11 ++---------
> 3 files changed, 4 insertions(+), 15 deletions(-)
...
> diff --git a/drivers/nfc/nfcmrvl/main.c b/drivers/nfc/nfcmrvl/main.c
> index 1a5284de4341..141bc4b66dcb 100644
> --- a/drivers/nfc/nfcmrvl/main.c
> +++ b/drivers/nfc/nfcmrvl/main.c
> @@ -261,11 +261,7 @@ int nfcmrvl_parse_dt(struct device_node *node,
> return reset_n_io;
> }
> pdata->reset_n_io = reset_n_io;
> -
> - if (of_find_property(node, "hci-muxed", NULL))
> - pdata->hci_muxed = 1;
> - else
> - pdata->hci_muxed = 0;
> + pdata->hci_muxed = of_property_read_bool(node, "hci-muxed");
FWIIW, I'm not entirely excited by assigning a bool value
to an integer variable. But I guess that is a challenge for another day.
>
> return 0;
> }
> diff --git a/drivers/nfc/nfcmrvl/uart.c b/drivers/nfc/nfcmrvl/uart.c
> index 9c92cbdc42f0..956ae92f7573 100644
> --- a/drivers/nfc/nfcmrvl/uart.c
> +++ b/drivers/nfc/nfcmrvl/uart.c
> @@ -76,15 +76,8 @@ static int nfcmrvl_uart_parse_dt(struct device_node *node,
> return ret;
> }
>
> - if (of_find_property(matched_node, "flow-control", NULL))
> - pdata->flow_control = 1;
> - else
> - pdata->flow_control = 0;
> -
> - if (of_find_property(matched_node, "break-control", NULL))
> - pdata->break_control = 1;
> - else
> - pdata->break_control = 0;
> + pdata->flow_control = of_property_read_bool(matched_node, "flow-control");
> + pdata->break_control = of_property_read_bool(matched_node, "break-control");
Likewise, here.
> of_node_put(matched_node);
>
> --
> 2.39.2
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] nfc: mrvl: Use of_property_read_bool() for boolean properties
2023-03-10 14:47 [PATCH] nfc: mrvl: Use of_property_read_bool() for boolean properties Rob Herring
2023-03-11 11:41 ` Simon Horman
@ 2023-03-13 6:53 ` Krzysztof Kozlowski
1 sibling, 0 replies; 3+ messages in thread
From: Krzysztof Kozlowski @ 2023-03-13 6:53 UTC (permalink / raw)
To: Rob Herring; +Cc: devicetree, netdev, linux-kernel
On 10/03/2023 15:47, Rob Herring wrote:
> It is preferred to use typed property access functions (i.e.
> of_property_read_<type> functions) rather than low-level
> of_get_property/of_find_property functions for reading properties.
> Convert reading boolean properties to to of_property_read_bool().
>
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-03-13 6:53 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-10 14:47 [PATCH] nfc: mrvl: Use of_property_read_bool() for boolean properties Rob Herring
2023-03-11 11:41 ` Simon Horman
2023-03-13 6:53 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).