* [PATCH v3] usb: gadget: udc: renesas_usb3: Fix use after free bug in renesas_usb3_remove due to race condition
@ 2023-03-13 16:51 Zheng Wang
2023-03-14 0:16 ` Yoshihiro Shimoda
2023-03-16 10:55 ` Greg KH
0 siblings, 2 replies; 8+ messages in thread
From: Zheng Wang @ 2023-03-13 16:51 UTC (permalink / raw)
To: gregkh
Cc: p.zabel, biju.das.jz, phil.edworthy, linux-usb, linux-kernel,
hackerzheng666, 1395428693sheep, alex000young,
yoshihiro.shimoda.uh, Zheng Wang
In renesas_usb3_probe, &usb3->role_work is bound with
renesas_usb3_role_work. renesas_usb3_start will be called
to start the work.
If we remove the driver which will call usbhs_remove, there may be
an unfinished work. The possible sequence is as follows:
Fix it by canceling the work before cleanup in the renesas_usb3_remove
CPU0 CPU1
|renesas_usb3_role_work
renesas_usb3_remove |
usb_role_switch_unregister |
device_unregister |
kfree(sw) |
free usb3->role_sw |
| usb_role_switch_set_role
| //use usb3->role_sw
Fixes: 39facfa01c9f ("usb: gadget: udc: renesas_usb3: Add register of usb role switch")
Reviewed-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Signed-off-by: Zheng Wang <zyytlz.wz@163.com>
---
v3:
- modify the commit message to make it clearer suggested by Yoshihiro Shimoda
v2:
- fix typo, use clearer commit message and only cancel the UAF-related work suggested by Yoshihiro Shimoda
---
drivers/usb/gadget/udc/renesas_usb3.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/usb/gadget/udc/renesas_usb3.c b/drivers/usb/gadget/udc/renesas_usb3.c
index bee6bceafc4f..a301af66bd91 100644
--- a/drivers/usb/gadget/udc/renesas_usb3.c
+++ b/drivers/usb/gadget/udc/renesas_usb3.c
@@ -2661,6 +2661,7 @@ static int renesas_usb3_remove(struct platform_device *pdev)
debugfs_remove_recursive(usb3->dentry);
device_remove_file(&pdev->dev, &dev_attr_role);
+ cancel_work_sync(&usb3->role_work);
usb_role_switch_unregister(usb3->role_sw);
usb_del_gadget_udc(&usb3->gadget);
--
2.25.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* RE: [PATCH v3] usb: gadget: udc: renesas_usb3: Fix use after free bug in renesas_usb3_remove due to race condition
2023-03-13 16:51 [PATCH v3] usb: gadget: udc: renesas_usb3: Fix use after free bug in renesas_usb3_remove due to race condition Zheng Wang
@ 2023-03-14 0:16 ` Yoshihiro Shimoda
2023-03-14 2:20 ` Zheng Hacker
2023-03-16 10:55 ` Greg KH
1 sibling, 1 reply; 8+ messages in thread
From: Yoshihiro Shimoda @ 2023-03-14 0:16 UTC (permalink / raw)
To: Zheng Wang, gregkh
Cc: p.zabel, Biju Das, phil.edworthy, linux-usb, linux-kernel,
hackerzheng666, 1395428693sheep, alex000young
Hi Zheng,
> From: Zheng Wang, Sent: Tuesday, March 14, 2023 1:51 AM
> Subject: [PATCH v3] usb: gadget: udc: renesas_usb3: Fix use after free bug in renesas_usb3_remove due to race condition
>
> In renesas_usb3_probe, &usb3->role_work is bound with
> renesas_usb3_role_work. renesas_usb3_start will be called
> to start the work.
>
> If we remove the driver which will call usbhs_remove, there may be
> an unfinished work. The possible sequence is as follows:
>
> Fix it by canceling the work before cleanup in the renesas_usb3_remove
>
> CPU0 CPU1
>
> |renesas_usb3_role_work
> renesas_usb3_remove |
> usb_role_switch_unregister |
> device_unregister |
> kfree(sw) |
> free usb3->role_sw |
> | usb_role_switch_set_role
> | //use usb3->role_sw
>
> Fixes: 39facfa01c9f ("usb: gadget: udc: renesas_usb3: Add register of usb role switch")
> Reviewed-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
> Signed-off-by: Zheng Wang <zyytlz.wz@163.com>
JFYI, but IIUC,
- In general, my Reviewed-by is described here, not top of your Signed-off-by.
- Also, you don't need to submit such this patch. If you would like to submit
such a patch for some reason (ping or so on), incrementing patch version is
better because original v3 [1] doesn't have my Reviewed-by tag.
[1]
https://lore.kernel.org/all/20230313094852.3344288-1-zyytlz.wz@163.com/
Best regards,
Yoshihiro Shimoda
> ---
> v3:
> - modify the commit message to make it clearer suggested by Yoshihiro Shimoda
> v2:
> - fix typo, use clearer commit message and only cancel the UAF-related work suggested by Yoshihiro Shimoda
> ---
> drivers/usb/gadget/udc/renesas_usb3.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/usb/gadget/udc/renesas_usb3.c b/drivers/usb/gadget/udc/renesas_usb3.c
> index bee6bceafc4f..a301af66bd91 100644
> --- a/drivers/usb/gadget/udc/renesas_usb3.c
> +++ b/drivers/usb/gadget/udc/renesas_usb3.c
> @@ -2661,6 +2661,7 @@ static int renesas_usb3_remove(struct platform_device *pdev)
> debugfs_remove_recursive(usb3->dentry);
> device_remove_file(&pdev->dev, &dev_attr_role);
>
> + cancel_work_sync(&usb3->role_work);
> usb_role_switch_unregister(usb3->role_sw);
>
> usb_del_gadget_udc(&usb3->gadget);
> --
> 2.25.1
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v3] usb: gadget: udc: renesas_usb3: Fix use after free bug in renesas_usb3_remove due to race condition
2023-03-14 0:16 ` Yoshihiro Shimoda
@ 2023-03-14 2:20 ` Zheng Hacker
0 siblings, 0 replies; 8+ messages in thread
From: Zheng Hacker @ 2023-03-14 2:20 UTC (permalink / raw)
To: Yoshihiro Shimoda
Cc: Zheng Wang, gregkh, p.zabel, Biju Das, phil.edworthy, linux-usb,
linux-kernel, 1395428693sheep, alex000young
Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> 于2023年3月14日周二 08:16写道:
>
> Hi Zheng,
>
> > From: Zheng Wang, Sent: Tuesday, March 14, 2023 1:51 AM
> > Subject: [PATCH v3] usb: gadget: udc: renesas_usb3: Fix use after free bug in renesas_usb3_remove due to race condition
> >
> > In renesas_usb3_probe, &usb3->role_work is bound with
> > renesas_usb3_role_work. renesas_usb3_start will be called
> > to start the work.
> >
> > If we remove the driver which will call usbhs_remove, there may be
> > an unfinished work. The possible sequence is as follows:
> >
> > Fix it by canceling the work before cleanup in the renesas_usb3_remove
> >
> > CPU0 CPU1
> >
> > |renesas_usb3_role_work
> > renesas_usb3_remove |
> > usb_role_switch_unregister |
> > device_unregister |
> > kfree(sw) |
> > free usb3->role_sw |
> > | usb_role_switch_set_role
> > | //use usb3->role_sw
> >
> > Fixes: 39facfa01c9f ("usb: gadget: udc: renesas_usb3: Add register of usb role switch")
> > Reviewed-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
> > Signed-off-by: Zheng Wang <zyytlz.wz@163.com>
>
> JFYI, but IIUC,
> - In general, my Reviewed-by is described here, not top of your Signed-off-by.
> - Also, you don't need to submit such this patch. If you would like to submit
> such a patch for some reason (ping or so on), incrementing patch version is
> better because original v3 [1] doesn't have my Reviewed-by tag.
>
> [1]
> https://lore.kernel.org/all/20230313094852.3344288-1-zyytlz.wz@163.com/
>
Dear Yoshihir,
Thanks for your advice. I am not familiar with the submission rules, thanks for
your kind reminder. I'll keep that in mind in the future. Have a good day :)
Best regards,
Zheng
> Best regards,
> Yoshihiro Shimoda
>
> > ---
> > v3:
> > - modify the commit message to make it clearer suggested by Yoshihiro Shimoda
> > v2:
> > - fix typo, use clearer commit message and only cancel the UAF-related work suggested by Yoshihiro Shimoda
> > ---
> > drivers/usb/gadget/udc/renesas_usb3.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/usb/gadget/udc/renesas_usb3.c b/drivers/usb/gadget/udc/renesas_usb3.c
> > index bee6bceafc4f..a301af66bd91 100644
> > --- a/drivers/usb/gadget/udc/renesas_usb3.c
> > +++ b/drivers/usb/gadget/udc/renesas_usb3.c
> > @@ -2661,6 +2661,7 @@ static int renesas_usb3_remove(struct platform_device *pdev)
> > debugfs_remove_recursive(usb3->dentry);
> > device_remove_file(&pdev->dev, &dev_attr_role);
> >
> > + cancel_work_sync(&usb3->role_work);
> > usb_role_switch_unregister(usb3->role_sw);
> >
> > usb_del_gadget_udc(&usb3->gadget);
> > --
> > 2.25.1
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v3] usb: gadget: udc: renesas_usb3: Fix use after free bug in renesas_usb3_remove due to race condition
2023-03-13 16:51 [PATCH v3] usb: gadget: udc: renesas_usb3: Fix use after free bug in renesas_usb3_remove due to race condition Zheng Wang
2023-03-14 0:16 ` Yoshihiro Shimoda
@ 2023-03-16 10:55 ` Greg KH
2023-03-16 13:28 ` Zheng Hacker
1 sibling, 1 reply; 8+ messages in thread
From: Greg KH @ 2023-03-16 10:55 UTC (permalink / raw)
To: Zheng Wang
Cc: p.zabel, biju.das.jz, phil.edworthy, linux-usb, linux-kernel,
hackerzheng666, 1395428693sheep, alex000young,
yoshihiro.shimoda.uh
On Tue, Mar 14, 2023 at 12:51:28AM +0800, Zheng Wang wrote:
> In renesas_usb3_probe, &usb3->role_work is bound with
> renesas_usb3_role_work. renesas_usb3_start will be called
> to start the work.
>
> If we remove the driver which will call usbhs_remove, there may be
> an unfinished work. The possible sequence is as follows:
>
> Fix it by canceling the work before cleanup in the renesas_usb3_remove
>
> CPU0 CPU1
>
> |renesas_usb3_role_work
> renesas_usb3_remove |
> usb_role_switch_unregister |
> device_unregister |
> kfree(sw) |
> free usb3->role_sw |
> | usb_role_switch_set_role
> | //use usb3->role_sw
>
> Fixes: 39facfa01c9f ("usb: gadget: udc: renesas_usb3: Add register of usb role switch")
> Reviewed-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
> Signed-off-by: Zheng Wang <zyytlz.wz@163.com>
> ---
> v3:
> - modify the commit message to make it clearer suggested by Yoshihiro Shimoda
I see 2 v3 patches in the mailing list, which is obviously not correct.
Please resubmit a v4 properly.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v3] usb: gadget: udc: renesas_usb3: Fix use after free bug in renesas_usb3_remove due to race condition
2023-03-16 10:55 ` Greg KH
@ 2023-03-16 13:28 ` Zheng Hacker
0 siblings, 0 replies; 8+ messages in thread
From: Zheng Hacker @ 2023-03-16 13:28 UTC (permalink / raw)
To: Greg KH
Cc: Zheng Wang, p.zabel, biju.das.jz, phil.edworthy, linux-usb,
linux-kernel, 1395428693sheep, alex000young,
yoshihiro.shimoda.uh
Greg KH <gregkh@linuxfoundation.org> 于2023年3月16日周四 18:55写道:
>
> On Tue, Mar 14, 2023 at 12:51:28AM +0800, Zheng Wang wrote:
> > In renesas_usb3_probe, &usb3->role_work is bound with
> > renesas_usb3_role_work. renesas_usb3_start will be called
> > to start the work.
> >
> > If we remove the driver which will call usbhs_remove, there may be
> > an unfinished work. The possible sequence is as follows:
> >
> > Fix it by canceling the work before cleanup in the renesas_usb3_remove
> >
> > CPU0 CPU1
> >
> > |renesas_usb3_role_work
> > renesas_usb3_remove |
> > usb_role_switch_unregister |
> > device_unregister |
> > kfree(sw) |
> > free usb3->role_sw |
> > | usb_role_switch_set_role
> > | //use usb3->role_sw
> >
> > Fixes: 39facfa01c9f ("usb: gadget: udc: renesas_usb3: Add register of usb role switch")
> > Reviewed-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
> > Signed-off-by: Zheng Wang <zyytlz.wz@163.com>
> > ---
> > v3:
> > - modify the commit message to make it clearer suggested by Yoshihiro Shimoda
>
> I see 2 v3 patches in the mailing list, which is obviously not correct.
>
> Please resubmit a v4 properly.
>
Hi Greg,
Thanks for your kind reminder. I'll resubmit a v4 patch later.
Best regards,
Zheng
> thanks,
>
> greg k-h
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v3] usb: gadget: udc: renesas_usb3: Fix use after free bug in renesas_usb3_remove due to race condition
2023-03-13 12:56 ` Yoshihiro Shimoda
@ 2023-03-13 16:51 ` Zheng Hacker
0 siblings, 0 replies; 8+ messages in thread
From: Zheng Hacker @ 2023-03-13 16:51 UTC (permalink / raw)
To: Yoshihiro Shimoda
Cc: Zheng Wang, gregkh, p.zabel, Biju Das, phil.edworthy, linux-usb,
linux-kernel, 1395428693sheep, alex000young
Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> 于2023年3月13日周一 20:56写道:
>
> Hi Zheng,
>
> > From: Zheng Wang, Sent: Monday, March 13, 2023 6:49 PM
> >
> > In renesas_usb3_probe, &usb3->role_work is bound with
> > renesas_usb3_role_work. renesas_usb3_start will be called
> > to start the work.
> >
> > If we remove the driver which will call usbhs_remove, there may be
> > an unfinished work. The possible sequence is as follows:
> >
> > Fix it by canceling the work before cleanup in the renesas_usb3_remove
> >
> > CPU0 CPU1
> >
> > |renesas_usb3_role_work
> > renesas_usb3_remove |
> > usb_role_switch_unregister |
> > device_unregister |
> > kfree(sw) |
> > free usb3->role_sw |
> > | usb_role_switch_set_role
> > | //use usb3->role_sw
> >
> > Fixes: 39facfa01c9f ("usb: gadget: udc: renesas_usb3: Add register of usb role switch")
> > Signed-off-by: Zheng Wang <zyytlz.wz@163.com>
>
> Thank you for the patch!
>
> Reviewed-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
>
Thanks for the detailed review :)
Best regards,
Zheng
>
> > ---
> > v3:
> > - modify the commit message to make it clearer suggested by Yoshihiro Shimoda
> > v2:
> > - fix typo, use clearer commit message and only cancel the UAF-related work suggested by Yoshihiro Shimoda
> > ---
> > drivers/usb/gadget/udc/renesas_usb3.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/usb/gadget/udc/renesas_usb3.c b/drivers/usb/gadget/udc/renesas_usb3.c
> > index bee6bceafc4f..a301af66bd91 100644
> > --- a/drivers/usb/gadget/udc/renesas_usb3.c
> > +++ b/drivers/usb/gadget/udc/renesas_usb3.c
> > @@ -2661,6 +2661,7 @@ static int renesas_usb3_remove(struct platform_device *pdev)
> > debugfs_remove_recursive(usb3->dentry);
> > device_remove_file(&pdev->dev, &dev_attr_role);
> >
> > + cancel_work_sync(&usb3->role_work);
> > usb_role_switch_unregister(usb3->role_sw);
> >
> > usb_del_gadget_udc(&usb3->gadget);
> > --
> > 2.25.1
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* RE: [PATCH v3] usb: gadget: udc: renesas_usb3: Fix use after free bug in renesas_usb3_remove due to race condition
2023-03-13 9:48 Zheng Wang
@ 2023-03-13 12:56 ` Yoshihiro Shimoda
2023-03-13 16:51 ` Zheng Hacker
0 siblings, 1 reply; 8+ messages in thread
From: Yoshihiro Shimoda @ 2023-03-13 12:56 UTC (permalink / raw)
To: Zheng Wang, gregkh
Cc: p.zabel, Biju Das, phil.edworthy, linux-usb, linux-kernel,
hackerzheng666, 1395428693sheep, alex000young
Hi Zheng,
> From: Zheng Wang, Sent: Monday, March 13, 2023 6:49 PM
>
> In renesas_usb3_probe, &usb3->role_work is bound with
> renesas_usb3_role_work. renesas_usb3_start will be called
> to start the work.
>
> If we remove the driver which will call usbhs_remove, there may be
> an unfinished work. The possible sequence is as follows:
>
> Fix it by canceling the work before cleanup in the renesas_usb3_remove
>
> CPU0 CPU1
>
> |renesas_usb3_role_work
> renesas_usb3_remove |
> usb_role_switch_unregister |
> device_unregister |
> kfree(sw) |
> free usb3->role_sw |
> | usb_role_switch_set_role
> | //use usb3->role_sw
>
> Fixes: 39facfa01c9f ("usb: gadget: udc: renesas_usb3: Add register of usb role switch")
> Signed-off-by: Zheng Wang <zyytlz.wz@163.com>
Thank you for the patch!
Reviewed-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Best regards,
Yoshihiro Shimoda
> ---
> v3:
> - modify the commit message to make it clearer suggested by Yoshihiro Shimoda
> v2:
> - fix typo, use clearer commit message and only cancel the UAF-related work suggested by Yoshihiro Shimoda
> ---
> drivers/usb/gadget/udc/renesas_usb3.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/usb/gadget/udc/renesas_usb3.c b/drivers/usb/gadget/udc/renesas_usb3.c
> index bee6bceafc4f..a301af66bd91 100644
> --- a/drivers/usb/gadget/udc/renesas_usb3.c
> +++ b/drivers/usb/gadget/udc/renesas_usb3.c
> @@ -2661,6 +2661,7 @@ static int renesas_usb3_remove(struct platform_device *pdev)
> debugfs_remove_recursive(usb3->dentry);
> device_remove_file(&pdev->dev, &dev_attr_role);
>
> + cancel_work_sync(&usb3->role_work);
> usb_role_switch_unregister(usb3->role_sw);
>
> usb_del_gadget_udc(&usb3->gadget);
> --
> 2.25.1
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH v3] usb: gadget: udc: renesas_usb3: Fix use after free bug in renesas_usb3_remove due to race condition
@ 2023-03-13 9:48 Zheng Wang
2023-03-13 12:56 ` Yoshihiro Shimoda
0 siblings, 1 reply; 8+ messages in thread
From: Zheng Wang @ 2023-03-13 9:48 UTC (permalink / raw)
To: gregkh
Cc: p.zabel, biju.das.jz, phil.edworthy, linux-usb, linux-kernel,
hackerzheng666, 1395428693sheep, alex000young,
yoshihiro.shimoda.uh, Zheng Wang
In renesas_usb3_probe, &usb3->role_work is bound with
renesas_usb3_role_work. renesas_usb3_start will be called
to start the work.
If we remove the driver which will call usbhs_remove, there may be
an unfinished work. The possible sequence is as follows:
Fix it by canceling the work before cleanup in the renesas_usb3_remove
CPU0 CPU1
|renesas_usb3_role_work
renesas_usb3_remove |
usb_role_switch_unregister |
device_unregister |
kfree(sw) |
free usb3->role_sw |
| usb_role_switch_set_role
| //use usb3->role_sw
Fixes: 39facfa01c9f ("usb: gadget: udc: renesas_usb3: Add register of usb role switch")
Signed-off-by: Zheng Wang <zyytlz.wz@163.com>
---
v3:
- modify the commit message to make it clearer suggested by Yoshihiro Shimoda
v2:
- fix typo, use clearer commit message and only cancel the UAF-related work suggested by Yoshihiro Shimoda
---
drivers/usb/gadget/udc/renesas_usb3.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/usb/gadget/udc/renesas_usb3.c b/drivers/usb/gadget/udc/renesas_usb3.c
index bee6bceafc4f..a301af66bd91 100644
--- a/drivers/usb/gadget/udc/renesas_usb3.c
+++ b/drivers/usb/gadget/udc/renesas_usb3.c
@@ -2661,6 +2661,7 @@ static int renesas_usb3_remove(struct platform_device *pdev)
debugfs_remove_recursive(usb3->dentry);
device_remove_file(&pdev->dev, &dev_attr_role);
+ cancel_work_sync(&usb3->role_work);
usb_role_switch_unregister(usb3->role_sw);
usb_del_gadget_udc(&usb3->gadget);
--
2.25.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
end of thread, other threads:[~2023-03-16 13:28 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-13 16:51 [PATCH v3] usb: gadget: udc: renesas_usb3: Fix use after free bug in renesas_usb3_remove due to race condition Zheng Wang
2023-03-14 0:16 ` Yoshihiro Shimoda
2023-03-14 2:20 ` Zheng Hacker
2023-03-16 10:55 ` Greg KH
2023-03-16 13:28 ` Zheng Hacker
-- strict thread matches above, loose matches on Subject: below --
2023-03-13 9:48 Zheng Wang
2023-03-13 12:56 ` Yoshihiro Shimoda
2023-03-13 16:51 ` Zheng Hacker
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).