* [PATCH] ptp: ptp_clock: Fix coding style issues in ptp_clock
@ 2023-03-25 16:42 Shinu Chandran
2023-03-28 3:30 ` Richard Cochran
0 siblings, 1 reply; 2+ messages in thread
From: Shinu Chandran @ 2023-03-25 16:42 UTC (permalink / raw)
To: richardcochran; +Cc: netdev, linux-kernel, Shinu Chandran
Fixed coding style issues in ptp_clock.c
Signed-off-by: Shinu Chandran <shinucha@cisco.com>
---
drivers/ptp/ptp_clock.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/ptp/ptp_clock.c b/drivers/ptp/ptp_clock.c
index 62d4d29e7c05..8fe7f2ce9705 100644
--- a/drivers/ptp/ptp_clock.c
+++ b/drivers/ptp/ptp_clock.c
@@ -129,6 +129,7 @@ static int ptp_clock_adjtime(struct posix_clock *pc, struct __kernel_timex *tx)
err = ops->adjtime(ops, delta);
} else if (tx->modes & ADJ_FREQUENCY) {
long ppb = scaled_ppm_to_ppb(tx->freq);
+
if (ppb > ops->max_adj || ppb < -ops->max_adj)
return -ERANGE;
err = ops->adjfine(ops, tx->freq);
@@ -278,11 +279,13 @@ struct ptp_clock *ptp_clock_register(struct ptp_clock_info *info,
/* Register a new PPS source. */
if (info->pps) {
struct pps_source_info pps;
+
memset(&pps, 0, sizeof(pps));
snprintf(pps.name, PPS_MAX_NAME_LEN, "ptp%d", index);
pps.mode = PTP_PPS_MODE;
pps.owner = info->owner;
ptp->pps_source = pps_register_source(&pps, PTP_PPS_DEFAULTS);
+
if (IS_ERR(ptp->pps_source)) {
err = PTR_ERR(ptp->pps_source);
pr_err("failed to register pps source\n");
@@ -347,9 +350,8 @@ static int unregister_vclock(struct device *dev, void *data)
int ptp_clock_unregister(struct ptp_clock *ptp)
{
- if (ptp_vclock_in_use(ptp)) {
+ if (ptp_vclock_in_use(ptp))
device_for_each_child(&ptp->dev, NULL, unregister_vclock);
- }
ptp->defunct = 1;
wake_up_interruptible(&ptp->tsev_wq);
--
2.35.6
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ptp: ptp_clock: Fix coding style issues in ptp_clock
2023-03-25 16:42 [PATCH] ptp: ptp_clock: Fix coding style issues in ptp_clock Shinu Chandran
@ 2023-03-28 3:30 ` Richard Cochran
0 siblings, 0 replies; 2+ messages in thread
From: Richard Cochran @ 2023-03-28 3:30 UTC (permalink / raw)
To: Shinu Chandran; +Cc: netdev, linux-kernel
On Sat, Mar 25, 2023 at 10:12:32PM +0530, Shinu Chandran wrote:
> Fixed coding style issues in ptp_clock.c
>
> Signed-off-by: Shinu Chandran <shinucha@cisco.com>
NAK.
(No) Thanks,
Richard
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-03-28 3:31 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-25 16:42 [PATCH] ptp: ptp_clock: Fix coding style issues in ptp_clock Shinu Chandran
2023-03-28 3:30 ` Richard Cochran
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).