* [PATCH] i2c: wmt: Use devm_platform_get_and_ioremap_resource()
@ 2023-01-28 6:51 ye.xingchen
2023-06-10 13:42 ` Andi Shyti
2023-06-14 8:41 ` Wolfram Sang
0 siblings, 2 replies; 3+ messages in thread
From: ye.xingchen @ 2023-01-28 6:51 UTC (permalink / raw)
To: wsa+renesas; +Cc: linux-arm-kernel, linux-i2c, linux-kernel
From: ye xingchen <ye.xingchen@zte.com.cn>
Convert platform_get_resource(), devm_ioremap_resource() to a single
call to devm_platform_get_and_ioremap_resource(), as this is exactly
what this function does.
Signed-off-by: ye xingchen <ye.xingchen@zte.com.cn>
---
drivers/i2c/busses/i2c-wmt.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/i2c/busses/i2c-wmt.c b/drivers/i2c/busses/i2c-wmt.c
index 7d4bc8736079..4a3e3985e418 100644
--- a/drivers/i2c/busses/i2c-wmt.c
+++ b/drivers/i2c/busses/i2c-wmt.c
@@ -372,7 +372,6 @@ static int wmt_i2c_probe(struct platform_device *pdev)
struct device_node *np = pdev->dev.of_node;
struct wmt_i2c_dev *i2c_dev;
struct i2c_adapter *adap;
- struct resource *res;
int err;
u32 clk_rate;
@@ -380,8 +379,7 @@ static int wmt_i2c_probe(struct platform_device *pdev)
if (!i2c_dev)
return -ENOMEM;
- res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- i2c_dev->base = devm_ioremap_resource(&pdev->dev, res);
+ i2c_dev->base = devm_platform_get_and_ioremap_resource(pdev, 0, NULL);
if (IS_ERR(i2c_dev->base))
return PTR_ERR(i2c_dev->base);
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] i2c: wmt: Use devm_platform_get_and_ioremap_resource()
2023-01-28 6:51 [PATCH] i2c: wmt: Use devm_platform_get_and_ioremap_resource() ye.xingchen
@ 2023-06-10 13:42 ` Andi Shyti
2023-06-14 8:41 ` Wolfram Sang
1 sibling, 0 replies; 3+ messages in thread
From: Andi Shyti @ 2023-06-10 13:42 UTC (permalink / raw)
To: ye.xingchen; +Cc: wsa+renesas, linux-arm-kernel, linux-i2c, linux-kernel
Hi Ye,
On Sat, Jan 28, 2023 at 02:51:44PM +0800, ye.xingchen@zte.com.cn wrote:
> From: ye xingchen <ye.xingchen@zte.com.cn>
>
> Convert platform_get_resource(), devm_ioremap_resource() to a single
> call to devm_platform_get_and_ioremap_resource(), as this is exactly
> what this function does.
>
> Signed-off-by: ye xingchen <ye.xingchen@zte.com.cn>
> ---
> drivers/i2c/busses/i2c-wmt.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/i2c/busses/i2c-wmt.c b/drivers/i2c/busses/i2c-wmt.c
> index 7d4bc8736079..4a3e3985e418 100644
> --- a/drivers/i2c/busses/i2c-wmt.c
> +++ b/drivers/i2c/busses/i2c-wmt.c
> @@ -372,7 +372,6 @@ static int wmt_i2c_probe(struct platform_device *pdev)
> struct device_node *np = pdev->dev.of_node;
> struct wmt_i2c_dev *i2c_dev;
> struct i2c_adapter *adap;
> - struct resource *res;
> int err;
> u32 clk_rate;
>
> @@ -380,8 +379,7 @@ static int wmt_i2c_probe(struct platform_device *pdev)
> if (!i2c_dev)
> return -ENOMEM;
>
> - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - i2c_dev->base = devm_ioremap_resource(&pdev->dev, res);
> + i2c_dev->base = devm_platform_get_and_ioremap_resource(pdev, 0, NULL);
It's also a cleaner way to handle the error when res is NULL.
Reviewed-by: Andi Shyti <andi.shyti@kernel.org>
Thanks,
Andi
> if (IS_ERR(i2c_dev->base))
> return PTR_ERR(i2c_dev->base);
>
> --
> 2.25.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] i2c: wmt: Use devm_platform_get_and_ioremap_resource()
2023-01-28 6:51 [PATCH] i2c: wmt: Use devm_platform_get_and_ioremap_resource() ye.xingchen
2023-06-10 13:42 ` Andi Shyti
@ 2023-06-14 8:41 ` Wolfram Sang
1 sibling, 0 replies; 3+ messages in thread
From: Wolfram Sang @ 2023-06-14 8:41 UTC (permalink / raw)
To: ye.xingchen; +Cc: linux-arm-kernel, linux-i2c, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 388 bytes --]
On Sat, Jan 28, 2023 at 02:51:44PM +0800, ye.xingchen@zte.com.cn wrote:
> From: ye xingchen <ye.xingchen@zte.com.cn>
>
> Convert platform_get_resource(), devm_ioremap_resource() to a single
> call to devm_platform_get_and_ioremap_resource(), as this is exactly
> what this function does.
>
> Signed-off-by: ye xingchen <ye.xingchen@zte.com.cn>
Applied to for-next, thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-06-14 8:42 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-28 6:51 [PATCH] i2c: wmt: Use devm_platform_get_and_ioremap_resource() ye.xingchen
2023-06-10 13:42 ` Andi Shyti
2023-06-14 8:41 ` Wolfram Sang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).