From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Wei Chin Tsai <Wei-chin.Tsai@mediatek.com>
Cc: lkp@intel.com, angelogioacchino.delregno@collabora.com,
ivan.tseng@mediatek.com, linux-arm-kernel@lists.infradead.org,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-mediatek@lists.infradead.org, matthias.bgg@gmail.com,
mel.lee@mediatek.com, oe-kbuild-all@lists.linux.dev,
wsd_upstream@mediatek.com
Subject: Re: [PATCH v3 1/1] memory: Fix export symbol twice compiler error for "export symbols for memory related functions" patch
Date: Wed, 14 Jun 2023 17:24:02 +0100 [thread overview]
Message-ID: <ZInpooYdKnhdm3SW@shell.armlinux.org.uk> (raw)
In-Reply-To: <20230614153902.26206-1-Wei-chin.Tsai@mediatek.com>
On Wed, Jun 14, 2023 at 11:39:02PM +0800, Wei Chin Tsai wrote:
> User could not add the export symbol "arch_vma_name"
> in arch/arm/kernel/process.c and kernel/signal.c both.
> It would cause the export symbol twice compiler error
> Reported-by: kernel test robot <lkp@intel.com>
>
> Signed-off-by: Wei Chin Tsai <Wei-chin.Tsai@mediatek.com>
I'm sorry, but this patch is silly.
> diff --git a/arch/arm/kernel/process.c b/arch/arm/kernel/process.c
> index df91412a1069..d71a9bafb584 100644
> --- a/arch/arm/kernel/process.c
> +++ b/arch/arm/kernel/process.c
> @@ -343,7 +343,10 @@ const char *arch_vma_name(struct vm_area_struct *vma)
> {
> return is_gate_vma(vma) ? "[vectors]" : NULL;
> }
> +
> +#ifdef CONFIG_ARM
> EXPORT_SYMBOL_GPL(arch_vma_name);
> +#endif
CONFIG_ARM will always be set here, so adding this ifdef is useless.
> diff --git a/kernel/signal.c b/kernel/signal.c
> index a1abe77fcdc3..f7d03450781e 100644
> --- a/kernel/signal.c
> +++ b/kernel/signal.c
> @@ -4700,7 +4700,10 @@ __weak const char *arch_vma_name(struct vm_area_struct *vma)
> {
> return NULL;
> }
> +
> +#ifdef CONFIG_ARM64
> EXPORT_SYMBOL_GPL(arch_vma_name);
> +#endif
Sorry, but no.
Please do the research I've now twice asked for.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
next prev parent reply other threads:[~2023-06-14 16:24 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-14 3:20 [PATCH v2 0/3] export symbols for process and memory related functions Wei Chin Tsai
2023-06-14 3:20 ` [PATCH v2 1/3] kernel : process fork/exit: export symbol for fork/exit tracing functions Wei Chin Tsai
2023-06-14 3:20 ` [PATCH v2 2/3] memory: export symbols for memory related functions Wei Chin Tsai
2023-06-14 7:16 ` Russell King (Oracle)
2023-06-14 9:59 ` Wei-chin Tsai (蔡維晉)
2023-06-14 12:11 ` AngeloGioacchino Del Regno
2023-06-14 15:53 ` Wei-chin Tsai (蔡維晉)
2023-06-14 16:21 ` Russell King (Oracle)
2023-06-14 17:11 ` Matthew Wilcox
2023-06-15 2:08 ` Wei-chin Tsai (蔡維晉)
2023-06-14 8:42 ` kernel test robot
2023-06-14 10:05 ` kernel test robot
2023-06-14 13:05 ` kernel test robot
2023-06-14 15:39 ` [PATCH v3 1/1] memory: Fix export symbol twice compiler error for "export symbols for memory related functions" patch Wei Chin Tsai
2023-06-14 16:24 ` Russell King (Oracle) [this message]
2023-06-14 3:20 ` [PATCH v2 3/3] misc : mediatek_mbraink : Collect the system process and memory data Wei Chin Tsai
2023-06-14 11:14 ` AngeloGioacchino Del Regno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZInpooYdKnhdm3SW@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=Wei-chin.Tsai@mediatek.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=ivan.tseng@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=lkp@intel.com \
--cc=matthias.bgg@gmail.com \
--cc=mel.lee@mediatek.com \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=wsd_upstream@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).