linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] media: staging: max96712: fix copy-paste error
@ 2023-10-14 14:38 ihor.matushchak
  2023-10-14 15:51 ` Niklas Söderlund
  0 siblings, 1 reply; 8+ messages in thread
From: ihor.matushchak @ 2023-10-14 14:38 UTC (permalink / raw)
  To: niklas.soderlund
  Cc: mchehab, gregkh, linux-media, linux-staging, linux-kernel,
	ihor.matushchak

From: Ihor Matushchak <ihor.matushchak@foobox.net>

Signed-off-by: Ihor Matushchak <ihor.matushchak@foobox.net>
---
 drivers/staging/media/max96712/max96712.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/media/max96712/max96712.c b/drivers/staging/media/max96712/max96712.c
index c44145284aa1..ea67bcf69c9d 100644
--- a/drivers/staging/media/max96712/max96712.c
+++ b/drivers/staging/media/max96712/max96712.c
@@ -1,6 +1,6 @@
 // SPDX-License-Identifier: GPL-2.0
 /*
- * Maxim MAX9286 Quad GMSL2 Deserializer Driver
+ * Maxim MAX96712 Quad GMSL2 Deserializer Driver
  *
  * Copyright (C) 2021 Renesas Electronics Corporation
  * Copyright (C) 2021 Niklas Söderlund
-- 
2.30.2


^ permalink raw reply related	[flat|nested] 8+ messages in thread
* Re: [PATCH] media: staging: max96712: fix copy-paste error
  2023-10-14 14:38 [PATCH] media: staging: max96712: fix copy-paste error ihor.matushchak
@ 2023-10-14 15:51 ` Niklas Söderlund
  2023-10-15 21:24   ` [PATCH v2] " ihor.matushchak
  0 siblings, 1 reply; 8+ messages in thread
From: Niklas Söderlund @ 2023-10-14 15:51 UTC (permalink / raw)
  To: ihor.matushchak; +Cc: mchehab, gregkh, linux-media, linux-staging, linux-kernel

Hi Ihor,

Thanks for your work.

On 2023-10-14 15:38:43 +0100, ihor.matushchak@foobox.net wrote:
> From: Ihor Matushchak <ihor.matushchak@foobox.net>

I agree this is a copy-past error and the fix is correct. But you need 
to add a commit message describing this. I know it can feel a bit silly 
for a simple fix like this, but we can't have an empty commit message.

> 
> Signed-off-by: Ihor Matushchak <ihor.matushchak@foobox.net>
> ---
>  drivers/staging/media/max96712/max96712.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/media/max96712/max96712.c b/drivers/staging/media/max96712/max96712.c
> index c44145284aa1..ea67bcf69c9d 100644
> --- a/drivers/staging/media/max96712/max96712.c
> +++ b/drivers/staging/media/max96712/max96712.c
> @@ -1,6 +1,6 @@
>  // SPDX-License-Identifier: GPL-2.0
>  /*
> - * Maxim MAX9286 Quad GMSL2 Deserializer Driver
> + * Maxim MAX96712 Quad GMSL2 Deserializer Driver
>   *
>   * Copyright (C) 2021 Renesas Electronics Corporation
>   * Copyright (C) 2021 Niklas Söderlund
> -- 
> 2.30.2
> 

-- 
Kind Regards,
Niklas Söderlund

^ permalink raw reply	[flat|nested] 8+ messages in thread
* [PATCH v2] media: staging: max96712: fix copy-paste error
  2023-10-14 15:51 ` Niklas Söderlund
@ 2023-10-15 21:24   ` ihor.matushchak
  2023-10-16 12:47     ` Niklas Söderlund
  0 siblings, 1 reply; 8+ messages in thread
From: ihor.matushchak @ 2023-10-15 21:24 UTC (permalink / raw)
  To: niklas.soderlund
  Cc: mchehab, gregkh, linux-media, linux-staging, linux-kernel,
	ihor.matushchak

From: Ihor Matushchak <ihor.matushchak@foobox.net>

Fix the device model name in driver description,
which appears to be a copy-paste error

Signed-off-by: Ihor Matushchak <ihor.matushchak@foobox.net>
---
 Changes in v2:
 Add commit message describing the change;

 drivers/staging/media/max96712/max96712.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/media/max96712/max96712.c b/drivers/staging/media/max96712/max96712.c
index c44145284aa1..ea67bcf69c9d 100644
--- a/drivers/staging/media/max96712/max96712.c
+++ b/drivers/staging/media/max96712/max96712.c
@@ -1,6 +1,6 @@
 // SPDX-License-Identifier: GPL-2.0
 /*
- * Maxim MAX9286 Quad GMSL2 Deserializer Driver
+ * Maxim MAX96712 Quad GMSL2 Deserializer Driver
  *
  * Copyright (C) 2021 Renesas Electronics Corporation
  * Copyright (C) 2021 Niklas Söderlund
-- 
2.30.2


^ permalink raw reply related	[flat|nested] 8+ messages in thread
* Re: [PATCH v2] media: staging: max96712: fix copy-paste error
  2023-10-15 21:24   ` [PATCH v2] " ihor.matushchak
@ 2023-10-16 12:47     ` Niklas Söderlund
  2023-10-17 18:46       ` [PATCH] media: staging: max96712: Fix device name in description ihor.matushchak
  0 siblings, 1 reply; 8+ messages in thread
From: Niklas Söderlund @ 2023-10-16 12:47 UTC (permalink / raw)
  To: ihor.matushchak; +Cc: mchehab, gregkh, linux-media, linux-staging, linux-kernel

HI Ihor,

Thanks for your work.

Maybe use a more descriptive commit title? The idea is to describe the 
issue a patch addresses in the title. Not the reason why the issue was 
introduced, this goes into the commit message. Imagine another 
copy-paste error is found in the driver, then we would have two commits 
with the same title.

How about?

  'media: staging: max96712: Fix device name in description'

On 2023-10-15 22:24:47 +0100, ihor.matushchak@foobox.net wrote:
> From: Ihor Matushchak <ihor.matushchak@foobox.net>
> 
> Fix the device model name in driver description,
> which appears to be a copy-paste error

Super-nit: Missing trailing dot.

> 
> Signed-off-by: Ihor Matushchak <ihor.matushchak@foobox.net>
> ---
>  Changes in v2:
>  Add commit message describing the change;
> 
>  drivers/staging/media/max96712/max96712.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/media/max96712/max96712.c b/drivers/staging/media/max96712/max96712.c
> index c44145284aa1..ea67bcf69c9d 100644
> --- a/drivers/staging/media/max96712/max96712.c
> +++ b/drivers/staging/media/max96712/max96712.c
> @@ -1,6 +1,6 @@
>  // SPDX-License-Identifier: GPL-2.0
>  /*
> - * Maxim MAX9286 Quad GMSL2 Deserializer Driver
> + * Maxim MAX96712 Quad GMSL2 Deserializer Driver
>   *
>   * Copyright (C) 2021 Renesas Electronics Corporation
>   * Copyright (C) 2021 Niklas Söderlund
> -- 
> 2.30.2
> 

-- 
Kind Regards,
Niklas Söderlund

^ permalink raw reply	[flat|nested] 8+ messages in thread
* [PATCH] media: staging: max96712: Fix device name in description
  2023-10-16 12:47     ` Niklas Söderlund
@ 2023-10-17 18:46       ` ihor.matushchak
  2023-10-17 19:16         ` Niklas Söderlund
  0 siblings, 1 reply; 8+ messages in thread
From: ihor.matushchak @ 2023-10-17 18:46 UTC (permalink / raw)
  To: niklas.soderlund
  Cc: mchehab, gregkh, linux-media, linux-staging, linux-kernel,
	ihor.matushchak

From: Ihor Matushchak <ihor.matushchak@foobox.net>

Fix the device model name in driver description,
which appears to be a copy-paste error

Signed-off-by: Ihor Matushchak <ihor.matushchak@foobox.net>
---
 drivers/staging/media/max96712/max96712.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/media/max96712/max96712.c b/drivers/staging/media/max96712/max96712.c
index c44145284aa1..ea67bcf69c9d 100644
--- a/drivers/staging/media/max96712/max96712.c
+++ b/drivers/staging/media/max96712/max96712.c
@@ -1,6 +1,6 @@
 // SPDX-License-Identifier: GPL-2.0
 /*
- * Maxim MAX9286 Quad GMSL2 Deserializer Driver
+ * Maxim MAX96712 Quad GMSL2 Deserializer Driver
  *
  * Copyright (C) 2021 Renesas Electronics Corporation
  * Copyright (C) 2021 Niklas Söderlund
-- 
2.30.2


^ permalink raw reply related	[flat|nested] 8+ messages in thread
* Re: [PATCH] media: staging: max96712: Fix device name in description
  2023-10-17 18:46       ` [PATCH] media: staging: max96712: Fix device name in description ihor.matushchak
@ 2023-10-17 19:16         ` Niklas Söderlund
  2023-10-17 20:02           ` ihor.matushchak
  0 siblings, 1 reply; 8+ messages in thread
From: Niklas Söderlund @ 2023-10-17 19:16 UTC (permalink / raw)
  To: ihor.matushchak; +Cc: mchehab, gregkh, linux-media, linux-staging, linux-kernel

Hi Ihor,

Thanks for your work.

On 2023-10-17 19:46:54 +0100, ihor.matushchak@foobox.net wrote:
> From: Ihor Matushchak <ihor.matushchak@foobox.net>
> 
> Fix the device model name in driver description,
> which appears to be a copy-paste error

Super-nit: You are still missing a trailing dot here.

> 
> Signed-off-by: Ihor Matushchak <ihor.matushchak@foobox.net>

Reviewed-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>

> ---
>  drivers/staging/media/max96712/max96712.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/media/max96712/max96712.c b/drivers/staging/media/max96712/max96712.c
> index c44145284aa1..ea67bcf69c9d 100644
> --- a/drivers/staging/media/max96712/max96712.c
> +++ b/drivers/staging/media/max96712/max96712.c
> @@ -1,6 +1,6 @@
>  // SPDX-License-Identifier: GPL-2.0
>  /*
> - * Maxim MAX9286 Quad GMSL2 Deserializer Driver
> + * Maxim MAX96712 Quad GMSL2 Deserializer Driver
>   *
>   * Copyright (C) 2021 Renesas Electronics Corporation
>   * Copyright (C) 2021 Niklas Söderlund
> -- 
> 2.30.2
> 

-- 
Kind Regards,
Niklas Söderlund

^ permalink raw reply	[flat|nested] 8+ messages in thread
* [PATCH] media: staging: max96712: Fix device name in description
  2023-10-17 19:16         ` Niklas Söderlund
@ 2023-10-17 20:02           ` ihor.matushchak
  2023-10-18 13:07             ` Niklas Söderlund
  0 siblings, 1 reply; 8+ messages in thread
From: ihor.matushchak @ 2023-10-17 20:02 UTC (permalink / raw)
  To: niklas.soderlund
  Cc: mchehab, gregkh, linux-media, linux-staging, linux-kernel,
	ihor.matushchak

From: Ihor Matushchak <ihor.matushchak@foobox.net>

Fix the device model name in driver description,
which appears to be a copy-paste error.

Signed-off-by: Ihor Matushchak <ihor.matushchak@foobox.net>
---
 drivers/staging/media/max96712/max96712.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/media/max96712/max96712.c b/drivers/staging/media/max96712/max96712.c
index c44145284aa1..ea67bcf69c9d 100644
--- a/drivers/staging/media/max96712/max96712.c
+++ b/drivers/staging/media/max96712/max96712.c
@@ -1,6 +1,6 @@
 // SPDX-License-Identifier: GPL-2.0
 /*
- * Maxim MAX9286 Quad GMSL2 Deserializer Driver
+ * Maxim MAX96712 Quad GMSL2 Deserializer Driver
  *
  * Copyright (C) 2021 Renesas Electronics Corporation
  * Copyright (C) 2021 Niklas Söderlund
-- 
2.30.2


^ permalink raw reply related	[flat|nested] 8+ messages in thread
* Re: [PATCH] media: staging: max96712: Fix device name in description
  2023-10-17 20:02           ` ihor.matushchak
@ 2023-10-18 13:07             ` Niklas Söderlund
  0 siblings, 0 replies; 8+ messages in thread
From: Niklas Söderlund @ 2023-10-18 13:07 UTC (permalink / raw)
  To: ihor.matushchak; +Cc: mchehab, gregkh, linux-media, linux-staging, linux-kernel

Hi Ihor,

Thanks for your work and taking the time to work thru the review.

On 2023-10-17 21:02:39 +0100, ihor.matushchak@foobox.net wrote:
> From: Ihor Matushchak <ihor.matushchak@foobox.net>
> 
> Fix the device model name in driver description,
> which appears to be a copy-paste error.
> 
> Signed-off-by: Ihor Matushchak <ihor.matushchak@foobox.net>

Reviewed-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>

Small note, in future remember to increase the patch version for each 
new posting. You did this correctly between v1 and v2.

> ---
>  drivers/staging/media/max96712/max96712.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/media/max96712/max96712.c b/drivers/staging/media/max96712/max96712.c
> index c44145284aa1..ea67bcf69c9d 100644
> --- a/drivers/staging/media/max96712/max96712.c
> +++ b/drivers/staging/media/max96712/max96712.c
> @@ -1,6 +1,6 @@
>  // SPDX-License-Identifier: GPL-2.0
>  /*
> - * Maxim MAX9286 Quad GMSL2 Deserializer Driver
> + * Maxim MAX96712 Quad GMSL2 Deserializer Driver
>   *
>   * Copyright (C) 2021 Renesas Electronics Corporation
>   * Copyright (C) 2021 Niklas Söderlund
> -- 
> 2.30.2
> 

-- 
Kind Regards,
Niklas Söderlund

^ permalink raw reply	[flat|nested] 8+ messages in thread
end of thread, other threads:[~2023-10-18 13:07 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-10-14 14:38 [PATCH] media: staging: max96712: fix copy-paste error ihor.matushchak
2023-10-14 15:51 ` Niklas Söderlund
2023-10-15 21:24   ` [PATCH v2] " ihor.matushchak
2023-10-16 12:47     ` Niklas Söderlund
2023-10-17 18:46       ` [PATCH] media: staging: max96712: Fix device name in description ihor.matushchak
2023-10-17 19:16         ` Niklas Söderlund
2023-10-17 20:02           ` ihor.matushchak
2023-10-18 13:07             ` Niklas Söderlund

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).