* [PATCH] crypto: qcom-rng - Add missing dependency on hw_random
@ 2023-10-16 17:45 André Apitzsch
2023-10-17 7:12 ` Neil Armstrong
2023-10-20 5:58 ` Herbert Xu
0 siblings, 2 replies; 3+ messages in thread
From: André Apitzsch @ 2023-10-16 17:45 UTC (permalink / raw)
To: Herbert Xu, David S. Miller
Cc: linux-crypto, linux-arm-msm, linux-kernel, André Apitzsch
This should fix the undefined reference:
> /usr/bin/aarch64-alpine-linux-musl-ld: Unexpected GOT/PLT entries detected!
> /usr/bin/aarch64-alpine-linux-musl-ld: Unexpected run-time procedure linkages detected!
> /usr/bin/aarch64-alpine-linux-musl-ld: drivers/crypto/qcom-rng.o: in function `qcom_rng_probe':
> qcom-rng.c:(.text+0x130): undefined reference to `devm_hwrng_register'
Fixes: f29cd5bb64c2 ("crypto: qcom-rng - Add hw_random interface support")
Signed-off-by: André Apitzsch <git@apitzsch.eu>
---
drivers/crypto/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/crypto/Kconfig b/drivers/crypto/Kconfig
index c761952f0dc6..79c3bb9c99c3 100644
--- a/drivers/crypto/Kconfig
+++ b/drivers/crypto/Kconfig
@@ -601,6 +601,7 @@ config CRYPTO_DEV_QCE_SW_MAX_LEN
config CRYPTO_DEV_QCOM_RNG
tristate "Qualcomm Random Number Generator Driver"
depends on ARCH_QCOM || COMPILE_TEST
+ depends on HW_RANDOM
select CRYPTO_RNG
help
This driver provides support for the Random Number
---
base-commit: 4d0515b235dec789578d135a5db586b25c5870cb
change-id: 20231016-qcom_rng-e46c8a8628bb
Best regards,
--
André Apitzsch <git@apitzsch.eu>
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] crypto: qcom-rng - Add missing dependency on hw_random
2023-10-16 17:45 [PATCH] crypto: qcom-rng - Add missing dependency on hw_random André Apitzsch
@ 2023-10-17 7:12 ` Neil Armstrong
2023-10-20 5:58 ` Herbert Xu
1 sibling, 0 replies; 3+ messages in thread
From: Neil Armstrong @ 2023-10-17 7:12 UTC (permalink / raw)
To: André Apitzsch, Herbert Xu, David S. Miller
Cc: linux-crypto, linux-arm-msm, linux-kernel
On 16/10/2023 19:45, André Apitzsch wrote:
> This should fix the undefined reference:
>
>> /usr/bin/aarch64-alpine-linux-musl-ld: Unexpected GOT/PLT entries detected!
>> /usr/bin/aarch64-alpine-linux-musl-ld: Unexpected run-time procedure linkages detected!
>> /usr/bin/aarch64-alpine-linux-musl-ld: drivers/crypto/qcom-rng.o: in function `qcom_rng_probe':
>> qcom-rng.c:(.text+0x130): undefined reference to `devm_hwrng_register'
>
> Fixes: f29cd5bb64c2 ("crypto: qcom-rng - Add hw_random interface support")
> Signed-off-by: André Apitzsch <git@apitzsch.eu>
> ---
> drivers/crypto/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/crypto/Kconfig b/drivers/crypto/Kconfig
> index c761952f0dc6..79c3bb9c99c3 100644
> --- a/drivers/crypto/Kconfig
> +++ b/drivers/crypto/Kconfig
> @@ -601,6 +601,7 @@ config CRYPTO_DEV_QCE_SW_MAX_LEN
> config CRYPTO_DEV_QCOM_RNG
> tristate "Qualcomm Random Number Generator Driver"
> depends on ARCH_QCOM || COMPILE_TEST
> + depends on HW_RANDOM
> select CRYPTO_RNG
> help
> This driver provides support for the Random Number
>
> ---
> base-commit: 4d0515b235dec789578d135a5db586b25c5870cb
> change-id: 20231016-qcom_rng-e46c8a8628bb
>
> Best regards,
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] crypto: qcom-rng - Add missing dependency on hw_random
2023-10-16 17:45 [PATCH] crypto: qcom-rng - Add missing dependency on hw_random André Apitzsch
2023-10-17 7:12 ` Neil Armstrong
@ 2023-10-20 5:58 ` Herbert Xu
1 sibling, 0 replies; 3+ messages in thread
From: Herbert Xu @ 2023-10-20 5:58 UTC (permalink / raw)
To: André Apitzsch; +Cc: davem, linux-crypto, linux-arm-msm, linux-kernel, git
André Apitzsch <git@apitzsch.eu> wrote:
> This should fix the undefined reference:
>
>> /usr/bin/aarch64-alpine-linux-musl-ld: Unexpected GOT/PLT entries detected!
>> /usr/bin/aarch64-alpine-linux-musl-ld: Unexpected run-time procedure linkages detected!
>> /usr/bin/aarch64-alpine-linux-musl-ld: drivers/crypto/qcom-rng.o: in function `qcom_rng_probe':
>> qcom-rng.c:(.text+0x130): undefined reference to `devm_hwrng_register'
>
> Fixes: f29cd5bb64c2 ("crypto: qcom-rng - Add hw_random interface support")
> Signed-off-by: André Apitzsch <git@apitzsch.eu>
> ---
> drivers/crypto/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-10-20 5:58 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-10-16 17:45 [PATCH] crypto: qcom-rng - Add missing dependency on hw_random André Apitzsch
2023-10-17 7:12 ` Neil Armstrong
2023-10-20 5:58 ` Herbert Xu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).