* [PATCH] crypto: hisilicon/qm - remove incorrect type cast
@ 2023-10-28 10:40 Weili Qian
2023-10-28 10:40 ` Weili Qian
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Weili Qian @ 2023-10-28 10:40 UTC (permalink / raw)
To: herbert; +Cc: linux-crypto, linux-kernel, liulongfang
The 'offset' type is unsigned long in 'struct debugfs_reg32',
so type of values casts to unsigned long long is incorrect, and the
values do not require type cast, remove them.
Signed-off-by: Weili Qian <qianweili@huawei.com>
---
drivers/crypto/hisilicon/debugfs.c | 50 +++++++++++------------
drivers/crypto/hisilicon/zip/zip_main.c | 54 ++++++++++++-------------
2 files changed, 52 insertions(+), 52 deletions(-)
diff --git a/drivers/crypto/hisilicon/debugfs.c b/drivers/crypto/hisilicon/debugfs.c
index 7e8186fe0512..415139b4abc1 100644
--- a/drivers/crypto/hisilicon/debugfs.c
+++ b/drivers/crypto/hisilicon/debugfs.c
@@ -53,34 +53,34 @@ static struct qm_dfx_item qm_dfx_files[] = {
#define CNT_CYC_REGS_NUM 10
static const struct debugfs_reg32 qm_dfx_regs[] = {
/* XXX_CNT are reading clear register */
- {"QM_ECC_1BIT_CNT ", 0x104000ull},
- {"QM_ECC_MBIT_CNT ", 0x104008ull},
- {"QM_DFX_MB_CNT ", 0x104018ull},
- {"QM_DFX_DB_CNT ", 0x104028ull},
- {"QM_DFX_SQE_CNT ", 0x104038ull},
- {"QM_DFX_CQE_CNT ", 0x104048ull},
- {"QM_DFX_SEND_SQE_TO_ACC_CNT ", 0x104050ull},
- {"QM_DFX_WB_SQE_FROM_ACC_CNT ", 0x104058ull},
- {"QM_DFX_ACC_FINISH_CNT ", 0x104060ull},
- {"QM_DFX_CQE_ERR_CNT ", 0x1040b4ull},
- {"QM_DFX_FUNS_ACTIVE_ST ", 0x200ull},
- {"QM_ECC_1BIT_INF ", 0x104004ull},
- {"QM_ECC_MBIT_INF ", 0x10400cull},
- {"QM_DFX_ACC_RDY_VLD0 ", 0x1040a0ull},
- {"QM_DFX_ACC_RDY_VLD1 ", 0x1040a4ull},
- {"QM_DFX_AXI_RDY_VLD ", 0x1040a8ull},
- {"QM_DFX_FF_ST0 ", 0x1040c8ull},
- {"QM_DFX_FF_ST1 ", 0x1040ccull},
- {"QM_DFX_FF_ST2 ", 0x1040d0ull},
- {"QM_DFX_FF_ST3 ", 0x1040d4ull},
- {"QM_DFX_FF_ST4 ", 0x1040d8ull},
- {"QM_DFX_FF_ST5 ", 0x1040dcull},
- {"QM_DFX_FF_ST6 ", 0x1040e0ull},
- {"QM_IN_IDLE_ST ", 0x1040e4ull},
+ {"QM_ECC_1BIT_CNT ", 0x104000},
+ {"QM_ECC_MBIT_CNT ", 0x104008},
+ {"QM_DFX_MB_CNT ", 0x104018},
+ {"QM_DFX_DB_CNT ", 0x104028},
+ {"QM_DFX_SQE_CNT ", 0x104038},
+ {"QM_DFX_CQE_CNT ", 0x104048},
+ {"QM_DFX_SEND_SQE_TO_ACC_CNT ", 0x104050},
+ {"QM_DFX_WB_SQE_FROM_ACC_CNT ", 0x104058},
+ {"QM_DFX_ACC_FINISH_CNT ", 0x104060},
+ {"QM_DFX_CQE_ERR_CNT ", 0x1040b4},
+ {"QM_DFX_FUNS_ACTIVE_ST ", 0x200},
+ {"QM_ECC_1BIT_INF ", 0x104004},
+ {"QM_ECC_MBIT_INF ", 0x10400c},
+ {"QM_DFX_ACC_RDY_VLD0 ", 0x1040a0},
+ {"QM_DFX_ACC_RDY_VLD1 ", 0x1040a4},
+ {"QM_DFX_AXI_RDY_VLD ", 0x1040a8},
+ {"QM_DFX_FF_ST0 ", 0x1040c8},
+ {"QM_DFX_FF_ST1 ", 0x1040cc},
+ {"QM_DFX_FF_ST2 ", 0x1040d0},
+ {"QM_DFX_FF_ST3 ", 0x1040d4},
+ {"QM_DFX_FF_ST4 ", 0x1040d8},
+ {"QM_DFX_FF_ST5 ", 0x1040dc},
+ {"QM_DFX_FF_ST6 ", 0x1040e0},
+ {"QM_IN_IDLE_ST ", 0x1040e4},
};
static const struct debugfs_reg32 qm_vf_dfx_regs[] = {
- {"QM_DFX_FUNS_ACTIVE_ST ", 0x200ull},
+ {"QM_DFX_FUNS_ACTIVE_ST ", 0x200},
};
/* define the QM's dfx regs region and region length */
diff --git a/drivers/crypto/hisilicon/zip/zip_main.c b/drivers/crypto/hisilicon/zip/zip_main.c
index db4c964cd649..d6672b777efc 100644
--- a/drivers/crypto/hisilicon/zip/zip_main.c
+++ b/drivers/crypto/hisilicon/zip/zip_main.c
@@ -270,28 +270,28 @@ static const u64 core_offsets[] = {
};
static const struct debugfs_reg32 hzip_dfx_regs[] = {
- {"HZIP_GET_BD_NUM ", 0x00ull},
- {"HZIP_GET_RIGHT_BD ", 0x04ull},
- {"HZIP_GET_ERROR_BD ", 0x08ull},
- {"HZIP_DONE_BD_NUM ", 0x0cull},
- {"HZIP_WORK_CYCLE ", 0x10ull},
- {"HZIP_IDLE_CYCLE ", 0x18ull},
- {"HZIP_MAX_DELAY ", 0x20ull},
- {"HZIP_MIN_DELAY ", 0x24ull},
- {"HZIP_AVG_DELAY ", 0x28ull},
- {"HZIP_MEM_VISIBLE_DATA ", 0x30ull},
- {"HZIP_MEM_VISIBLE_ADDR ", 0x34ull},
- {"HZIP_CONSUMED_BYTE ", 0x38ull},
- {"HZIP_PRODUCED_BYTE ", 0x40ull},
- {"HZIP_COMP_INF ", 0x70ull},
- {"HZIP_PRE_OUT ", 0x78ull},
- {"HZIP_BD_RD ", 0x7cull},
- {"HZIP_BD_WR ", 0x80ull},
- {"HZIP_GET_BD_AXI_ERR_NUM ", 0x84ull},
- {"HZIP_GET_BD_PARSE_ERR_NUM ", 0x88ull},
- {"HZIP_ADD_BD_AXI_ERR_NUM ", 0x8cull},
- {"HZIP_DECOMP_STF_RELOAD_CURR_ST ", 0x94ull},
- {"HZIP_DECOMP_LZ77_CURR_ST ", 0x9cull},
+ {"HZIP_GET_BD_NUM ", 0x00},
+ {"HZIP_GET_RIGHT_BD ", 0x04},
+ {"HZIP_GET_ERROR_BD ", 0x08},
+ {"HZIP_DONE_BD_NUM ", 0x0c},
+ {"HZIP_WORK_CYCLE ", 0x10},
+ {"HZIP_IDLE_CYCLE ", 0x18},
+ {"HZIP_MAX_DELAY ", 0x20},
+ {"HZIP_MIN_DELAY ", 0x24},
+ {"HZIP_AVG_DELAY ", 0x28},
+ {"HZIP_MEM_VISIBLE_DATA ", 0x30},
+ {"HZIP_MEM_VISIBLE_ADDR ", 0x34},
+ {"HZIP_CONSUMED_BYTE ", 0x38},
+ {"HZIP_PRODUCED_BYTE ", 0x40},
+ {"HZIP_COMP_INF ", 0x70},
+ {"HZIP_PRE_OUT ", 0x78},
+ {"HZIP_BD_RD ", 0x7c},
+ {"HZIP_BD_WR ", 0x80},
+ {"HZIP_GET_BD_AXI_ERR_NUM ", 0x84},
+ {"HZIP_GET_BD_PARSE_ERR_NUM ", 0x88},
+ {"HZIP_ADD_BD_AXI_ERR_NUM ", 0x8c},
+ {"HZIP_DECOMP_STF_RELOAD_CURR_ST ", 0x94},
+ {"HZIP_DECOMP_LZ77_CURR_ST ", 0x9c},
};
static const struct debugfs_reg32 hzip_com_dfx_regs[] = {
@@ -303,11 +303,11 @@ static const struct debugfs_reg32 hzip_com_dfx_regs[] = {
};
static const struct debugfs_reg32 hzip_dump_dfx_regs[] = {
- {"HZIP_GET_BD_NUM ", 0x00ull},
- {"HZIP_GET_RIGHT_BD ", 0x04ull},
- {"HZIP_GET_ERROR_BD ", 0x08ull},
- {"HZIP_DONE_BD_NUM ", 0x0cull},
- {"HZIP_MAX_DELAY ", 0x20ull},
+ {"HZIP_GET_BD_NUM ", 0x00},
+ {"HZIP_GET_RIGHT_BD ", 0x04},
+ {"HZIP_GET_ERROR_BD ", 0x08},
+ {"HZIP_DONE_BD_NUM ", 0x0c},
+ {"HZIP_MAX_DELAY ", 0x20},
};
/* define the ZIP's dfx regs region and region length */
--
2.33.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] crypto: hisilicon/qm - remove incorrect type cast
2023-10-28 10:40 [PATCH] crypto: hisilicon/qm - remove incorrect type cast Weili Qian
@ 2023-10-28 10:40 ` Weili Qian
2023-10-28 10:56 ` Weili Qian
2023-11-17 11:21 ` Herbert Xu
2 siblings, 0 replies; 4+ messages in thread
From: Weili Qian @ 2023-10-28 10:40 UTC (permalink / raw)
To: herbert; +Cc: linux-crypto, linux-kernel, liulongfang
The 'offset' type is unsigned long in 'struct debugfs_reg32',
so type of values casts to unsigned long long is incorrect, and the
values do not require type cast, remove them.
Signed-off-by: Weili Qian <qianweili@huawei.com>
---
drivers/crypto/hisilicon/debugfs.c | 50 +++++++++++------------
drivers/crypto/hisilicon/zip/zip_main.c | 54 ++++++++++++-------------
2 files changed, 52 insertions(+), 52 deletions(-)
diff --git a/drivers/crypto/hisilicon/debugfs.c b/drivers/crypto/hisilicon/debugfs.c
index 7e8186fe0512..415139b4abc1 100644
--- a/drivers/crypto/hisilicon/debugfs.c
+++ b/drivers/crypto/hisilicon/debugfs.c
@@ -53,34 +53,34 @@ static struct qm_dfx_item qm_dfx_files[] = {
#define CNT_CYC_REGS_NUM 10
static const struct debugfs_reg32 qm_dfx_regs[] = {
/* XXX_CNT are reading clear register */
- {"QM_ECC_1BIT_CNT ", 0x104000ull},
- {"QM_ECC_MBIT_CNT ", 0x104008ull},
- {"QM_DFX_MB_CNT ", 0x104018ull},
- {"QM_DFX_DB_CNT ", 0x104028ull},
- {"QM_DFX_SQE_CNT ", 0x104038ull},
- {"QM_DFX_CQE_CNT ", 0x104048ull},
- {"QM_DFX_SEND_SQE_TO_ACC_CNT ", 0x104050ull},
- {"QM_DFX_WB_SQE_FROM_ACC_CNT ", 0x104058ull},
- {"QM_DFX_ACC_FINISH_CNT ", 0x104060ull},
- {"QM_DFX_CQE_ERR_CNT ", 0x1040b4ull},
- {"QM_DFX_FUNS_ACTIVE_ST ", 0x200ull},
- {"QM_ECC_1BIT_INF ", 0x104004ull},
- {"QM_ECC_MBIT_INF ", 0x10400cull},
- {"QM_DFX_ACC_RDY_VLD0 ", 0x1040a0ull},
- {"QM_DFX_ACC_RDY_VLD1 ", 0x1040a4ull},
- {"QM_DFX_AXI_RDY_VLD ", 0x1040a8ull},
- {"QM_DFX_FF_ST0 ", 0x1040c8ull},
- {"QM_DFX_FF_ST1 ", 0x1040ccull},
- {"QM_DFX_FF_ST2 ", 0x1040d0ull},
- {"QM_DFX_FF_ST3 ", 0x1040d4ull},
- {"QM_DFX_FF_ST4 ", 0x1040d8ull},
- {"QM_DFX_FF_ST5 ", 0x1040dcull},
- {"QM_DFX_FF_ST6 ", 0x1040e0ull},
- {"QM_IN_IDLE_ST ", 0x1040e4ull},
+ {"QM_ECC_1BIT_CNT ", 0x104000},
+ {"QM_ECC_MBIT_CNT ", 0x104008},
+ {"QM_DFX_MB_CNT ", 0x104018},
+ {"QM_DFX_DB_CNT ", 0x104028},
+ {"QM_DFX_SQE_CNT ", 0x104038},
+ {"QM_DFX_CQE_CNT ", 0x104048},
+ {"QM_DFX_SEND_SQE_TO_ACC_CNT ", 0x104050},
+ {"QM_DFX_WB_SQE_FROM_ACC_CNT ", 0x104058},
+ {"QM_DFX_ACC_FINISH_CNT ", 0x104060},
+ {"QM_DFX_CQE_ERR_CNT ", 0x1040b4},
+ {"QM_DFX_FUNS_ACTIVE_ST ", 0x200},
+ {"QM_ECC_1BIT_INF ", 0x104004},
+ {"QM_ECC_MBIT_INF ", 0x10400c},
+ {"QM_DFX_ACC_RDY_VLD0 ", 0x1040a0},
+ {"QM_DFX_ACC_RDY_VLD1 ", 0x1040a4},
+ {"QM_DFX_AXI_RDY_VLD ", 0x1040a8},
+ {"QM_DFX_FF_ST0 ", 0x1040c8},
+ {"QM_DFX_FF_ST1 ", 0x1040cc},
+ {"QM_DFX_FF_ST2 ", 0x1040d0},
+ {"QM_DFX_FF_ST3 ", 0x1040d4},
+ {"QM_DFX_FF_ST4 ", 0x1040d8},
+ {"QM_DFX_FF_ST5 ", 0x1040dc},
+ {"QM_DFX_FF_ST6 ", 0x1040e0},
+ {"QM_IN_IDLE_ST ", 0x1040e4},
};
static const struct debugfs_reg32 qm_vf_dfx_regs[] = {
- {"QM_DFX_FUNS_ACTIVE_ST ", 0x200ull},
+ {"QM_DFX_FUNS_ACTIVE_ST ", 0x200},
};
/* define the QM's dfx regs region and region length */
diff --git a/drivers/crypto/hisilicon/zip/zip_main.c b/drivers/crypto/hisilicon/zip/zip_main.c
index db4c964cd649..d6672b777efc 100644
--- a/drivers/crypto/hisilicon/zip/zip_main.c
+++ b/drivers/crypto/hisilicon/zip/zip_main.c
@@ -270,28 +270,28 @@ static const u64 core_offsets[] = {
};
static const struct debugfs_reg32 hzip_dfx_regs[] = {
- {"HZIP_GET_BD_NUM ", 0x00ull},
- {"HZIP_GET_RIGHT_BD ", 0x04ull},
- {"HZIP_GET_ERROR_BD ", 0x08ull},
- {"HZIP_DONE_BD_NUM ", 0x0cull},
- {"HZIP_WORK_CYCLE ", 0x10ull},
- {"HZIP_IDLE_CYCLE ", 0x18ull},
- {"HZIP_MAX_DELAY ", 0x20ull},
- {"HZIP_MIN_DELAY ", 0x24ull},
- {"HZIP_AVG_DELAY ", 0x28ull},
- {"HZIP_MEM_VISIBLE_DATA ", 0x30ull},
- {"HZIP_MEM_VISIBLE_ADDR ", 0x34ull},
- {"HZIP_CONSUMED_BYTE ", 0x38ull},
- {"HZIP_PRODUCED_BYTE ", 0x40ull},
- {"HZIP_COMP_INF ", 0x70ull},
- {"HZIP_PRE_OUT ", 0x78ull},
- {"HZIP_BD_RD ", 0x7cull},
- {"HZIP_BD_WR ", 0x80ull},
- {"HZIP_GET_BD_AXI_ERR_NUM ", 0x84ull},
- {"HZIP_GET_BD_PARSE_ERR_NUM ", 0x88ull},
- {"HZIP_ADD_BD_AXI_ERR_NUM ", 0x8cull},
- {"HZIP_DECOMP_STF_RELOAD_CURR_ST ", 0x94ull},
- {"HZIP_DECOMP_LZ77_CURR_ST ", 0x9cull},
+ {"HZIP_GET_BD_NUM ", 0x00},
+ {"HZIP_GET_RIGHT_BD ", 0x04},
+ {"HZIP_GET_ERROR_BD ", 0x08},
+ {"HZIP_DONE_BD_NUM ", 0x0c},
+ {"HZIP_WORK_CYCLE ", 0x10},
+ {"HZIP_IDLE_CYCLE ", 0x18},
+ {"HZIP_MAX_DELAY ", 0x20},
+ {"HZIP_MIN_DELAY ", 0x24},
+ {"HZIP_AVG_DELAY ", 0x28},
+ {"HZIP_MEM_VISIBLE_DATA ", 0x30},
+ {"HZIP_MEM_VISIBLE_ADDR ", 0x34},
+ {"HZIP_CONSUMED_BYTE ", 0x38},
+ {"HZIP_PRODUCED_BYTE ", 0x40},
+ {"HZIP_COMP_INF ", 0x70},
+ {"HZIP_PRE_OUT ", 0x78},
+ {"HZIP_BD_RD ", 0x7c},
+ {"HZIP_BD_WR ", 0x80},
+ {"HZIP_GET_BD_AXI_ERR_NUM ", 0x84},
+ {"HZIP_GET_BD_PARSE_ERR_NUM ", 0x88},
+ {"HZIP_ADD_BD_AXI_ERR_NUM ", 0x8c},
+ {"HZIP_DECOMP_STF_RELOAD_CURR_ST ", 0x94},
+ {"HZIP_DECOMP_LZ77_CURR_ST ", 0x9c},
};
static const struct debugfs_reg32 hzip_com_dfx_regs[] = {
@@ -303,11 +303,11 @@ static const struct debugfs_reg32 hzip_com_dfx_regs[] = {
};
static const struct debugfs_reg32 hzip_dump_dfx_regs[] = {
- {"HZIP_GET_BD_NUM ", 0x00ull},
- {"HZIP_GET_RIGHT_BD ", 0x04ull},
- {"HZIP_GET_ERROR_BD ", 0x08ull},
- {"HZIP_DONE_BD_NUM ", 0x0cull},
- {"HZIP_MAX_DELAY ", 0x20ull},
+ {"HZIP_GET_BD_NUM ", 0x00},
+ {"HZIP_GET_RIGHT_BD ", 0x04},
+ {"HZIP_GET_ERROR_BD ", 0x08},
+ {"HZIP_DONE_BD_NUM ", 0x0c},
+ {"HZIP_MAX_DELAY ", 0x20},
};
/* define the ZIP's dfx regs region and region length */
--
2.33.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] crypto: hisilicon/qm - remove incorrect type cast
2023-10-28 10:40 [PATCH] crypto: hisilicon/qm - remove incorrect type cast Weili Qian
2023-10-28 10:40 ` Weili Qian
@ 2023-10-28 10:56 ` Weili Qian
2023-11-17 11:21 ` Herbert Xu
2 siblings, 0 replies; 4+ messages in thread
From: Weili Qian @ 2023-10-28 10:56 UTC (permalink / raw)
To: herbert; +Cc: linux-crypto, linux-kernel, liulongfang
Please ignore this one，this patch has been sent repeatedly. Sorry for it.
Thanks,
Weili
On 2023/10/28 18:40, Weili Qian wrote:
> The 'offset' type is unsigned long in 'struct debugfs_reg32',
> so type of values casts to unsigned long long is incorrect, and the
> values do not require type cast, remove them.
>
> Signed-off-by: Weili Qian <qianweili@huawei.com>
> ---
> drivers/crypto/hisilicon/debugfs.c | 50 +++++++++++------------
> drivers/crypto/hisilicon/zip/zip_main.c | 54 ++++++++++++-------------
> 2 files changed, 52 insertions(+), 52 deletions(-)
>
> diff --git a/drivers/crypto/hisilicon/debugfs.c b/drivers/crypto/hisilicon/debugfs.c
> index 7e8186fe0512..415139b4abc1 100644
> --- a/drivers/crypto/hisilicon/debugfs.c
> +++ b/drivers/crypto/hisilicon/debugfs.c
> @@ -53,34 +53,34 @@ static struct qm_dfx_item qm_dfx_files[] = {
> #define CNT_CYC_REGS_NUM 10
> static const struct debugfs_reg32 qm_dfx_regs[] = {
> /* XXX_CNT are reading clear register */
> - {"QM_ECC_1BIT_CNT ", 0x104000ull},
> - {"QM_ECC_MBIT_CNT ", 0x104008ull},
> - {"QM_DFX_MB_CNT ", 0x104018ull},
> - {"QM_DFX_DB_CNT ", 0x104028ull},
> - {"QM_DFX_SQE_CNT ", 0x104038ull},
> - {"QM_DFX_CQE_CNT ", 0x104048ull},
> - {"QM_DFX_SEND_SQE_TO_ACC_CNT ", 0x104050ull},
> - {"QM_DFX_WB_SQE_FROM_ACC_CNT ", 0x104058ull},
> - {"QM_DFX_ACC_FINISH_CNT ", 0x104060ull},
> - {"QM_DFX_CQE_ERR_CNT ", 0x1040b4ull},
> - {"QM_DFX_FUNS_ACTIVE_ST ", 0x200ull},
> - {"QM_ECC_1BIT_INF ", 0x104004ull},
> - {"QM_ECC_MBIT_INF ", 0x10400cull},
> - {"QM_DFX_ACC_RDY_VLD0 ", 0x1040a0ull},
> - {"QM_DFX_ACC_RDY_VLD1 ", 0x1040a4ull},
> - {"QM_DFX_AXI_RDY_VLD ", 0x1040a8ull},
> - {"QM_DFX_FF_ST0 ", 0x1040c8ull},
> - {"QM_DFX_FF_ST1 ", 0x1040ccull},
> - {"QM_DFX_FF_ST2 ", 0x1040d0ull},
> - {"QM_DFX_FF_ST3 ", 0x1040d4ull},
> - {"QM_DFX_FF_ST4 ", 0x1040d8ull},
> - {"QM_DFX_FF_ST5 ", 0x1040dcull},
> - {"QM_DFX_FF_ST6 ", 0x1040e0ull},
> - {"QM_IN_IDLE_ST ", 0x1040e4ull},
> + {"QM_ECC_1BIT_CNT ", 0x104000},
> + {"QM_ECC_MBIT_CNT ", 0x104008},
> + {"QM_DFX_MB_CNT ", 0x104018},
> + {"QM_DFX_DB_CNT ", 0x104028},
> + {"QM_DFX_SQE_CNT ", 0x104038},
> + {"QM_DFX_CQE_CNT ", 0x104048},
> + {"QM_DFX_SEND_SQE_TO_ACC_CNT ", 0x104050},
> + {"QM_DFX_WB_SQE_FROM_ACC_CNT ", 0x104058},
> + {"QM_DFX_ACC_FINISH_CNT ", 0x104060},
> + {"QM_DFX_CQE_ERR_CNT ", 0x1040b4},
> + {"QM_DFX_FUNS_ACTIVE_ST ", 0x200},
> + {"QM_ECC_1BIT_INF ", 0x104004},
> + {"QM_ECC_MBIT_INF ", 0x10400c},
> + {"QM_DFX_ACC_RDY_VLD0 ", 0x1040a0},
> + {"QM_DFX_ACC_RDY_VLD1 ", 0x1040a4},
> + {"QM_DFX_AXI_RDY_VLD ", 0x1040a8},
> + {"QM_DFX_FF_ST0 ", 0x1040c8},
> + {"QM_DFX_FF_ST1 ", 0x1040cc},
> + {"QM_DFX_FF_ST2 ", 0x1040d0},
> + {"QM_DFX_FF_ST3 ", 0x1040d4},
> + {"QM_DFX_FF_ST4 ", 0x1040d8},
> + {"QM_DFX_FF_ST5 ", 0x1040dc},
> + {"QM_DFX_FF_ST6 ", 0x1040e0},
> + {"QM_IN_IDLE_ST ", 0x1040e4},
> };
>
> static const struct debugfs_reg32 qm_vf_dfx_regs[] = {
> - {"QM_DFX_FUNS_ACTIVE_ST ", 0x200ull},
> + {"QM_DFX_FUNS_ACTIVE_ST ", 0x200},
> };
>
> /* define the QM's dfx regs region and region length */
> diff --git a/drivers/crypto/hisilicon/zip/zip_main.c b/drivers/crypto/hisilicon/zip/zip_main.c
> index db4c964cd649..d6672b777efc 100644
> --- a/drivers/crypto/hisilicon/zip/zip_main.c
> +++ b/drivers/crypto/hisilicon/zip/zip_main.c
> @@ -270,28 +270,28 @@ static const u64 core_offsets[] = {
> };
>
> static const struct debugfs_reg32 hzip_dfx_regs[] = {
> - {"HZIP_GET_BD_NUM ", 0x00ull},
> - {"HZIP_GET_RIGHT_BD ", 0x04ull},
> - {"HZIP_GET_ERROR_BD ", 0x08ull},
> - {"HZIP_DONE_BD_NUM ", 0x0cull},
> - {"HZIP_WORK_CYCLE ", 0x10ull},
> - {"HZIP_IDLE_CYCLE ", 0x18ull},
> - {"HZIP_MAX_DELAY ", 0x20ull},
> - {"HZIP_MIN_DELAY ", 0x24ull},
> - {"HZIP_AVG_DELAY ", 0x28ull},
> - {"HZIP_MEM_VISIBLE_DATA ", 0x30ull},
> - {"HZIP_MEM_VISIBLE_ADDR ", 0x34ull},
> - {"HZIP_CONSUMED_BYTE ", 0x38ull},
> - {"HZIP_PRODUCED_BYTE ", 0x40ull},
> - {"HZIP_COMP_INF ", 0x70ull},
> - {"HZIP_PRE_OUT ", 0x78ull},
> - {"HZIP_BD_RD ", 0x7cull},
> - {"HZIP_BD_WR ", 0x80ull},
> - {"HZIP_GET_BD_AXI_ERR_NUM ", 0x84ull},
> - {"HZIP_GET_BD_PARSE_ERR_NUM ", 0x88ull},
> - {"HZIP_ADD_BD_AXI_ERR_NUM ", 0x8cull},
> - {"HZIP_DECOMP_STF_RELOAD_CURR_ST ", 0x94ull},
> - {"HZIP_DECOMP_LZ77_CURR_ST ", 0x9cull},
> + {"HZIP_GET_BD_NUM ", 0x00},
> + {"HZIP_GET_RIGHT_BD ", 0x04},
> + {"HZIP_GET_ERROR_BD ", 0x08},
> + {"HZIP_DONE_BD_NUM ", 0x0c},
> + {"HZIP_WORK_CYCLE ", 0x10},
> + {"HZIP_IDLE_CYCLE ", 0x18},
> + {"HZIP_MAX_DELAY ", 0x20},
> + {"HZIP_MIN_DELAY ", 0x24},
> + {"HZIP_AVG_DELAY ", 0x28},
> + {"HZIP_MEM_VISIBLE_DATA ", 0x30},
> + {"HZIP_MEM_VISIBLE_ADDR ", 0x34},
> + {"HZIP_CONSUMED_BYTE ", 0x38},
> + {"HZIP_PRODUCED_BYTE ", 0x40},
> + {"HZIP_COMP_INF ", 0x70},
> + {"HZIP_PRE_OUT ", 0x78},
> + {"HZIP_BD_RD ", 0x7c},
> + {"HZIP_BD_WR ", 0x80},
> + {"HZIP_GET_BD_AXI_ERR_NUM ", 0x84},
> + {"HZIP_GET_BD_PARSE_ERR_NUM ", 0x88},
> + {"HZIP_ADD_BD_AXI_ERR_NUM ", 0x8c},
> + {"HZIP_DECOMP_STF_RELOAD_CURR_ST ", 0x94},
> + {"HZIP_DECOMP_LZ77_CURR_ST ", 0x9c},
> };
>
> static const struct debugfs_reg32 hzip_com_dfx_regs[] = {
> @@ -303,11 +303,11 @@ static const struct debugfs_reg32 hzip_com_dfx_regs[] = {
> };
>
> static const struct debugfs_reg32 hzip_dump_dfx_regs[] = {
> - {"HZIP_GET_BD_NUM ", 0x00ull},
> - {"HZIP_GET_RIGHT_BD ", 0x04ull},
> - {"HZIP_GET_ERROR_BD ", 0x08ull},
> - {"HZIP_DONE_BD_NUM ", 0x0cull},
> - {"HZIP_MAX_DELAY ", 0x20ull},
> + {"HZIP_GET_BD_NUM ", 0x00},
> + {"HZIP_GET_RIGHT_BD ", 0x04},
> + {"HZIP_GET_ERROR_BD ", 0x08},
> + {"HZIP_DONE_BD_NUM ", 0x0c},
> + {"HZIP_MAX_DELAY ", 0x20},
> };
>
> /* define the ZIP's dfx regs region and region length */
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] crypto: hisilicon/qm - remove incorrect type cast
2023-10-28 10:40 [PATCH] crypto: hisilicon/qm - remove incorrect type cast Weili Qian
2023-10-28 10:40 ` Weili Qian
2023-10-28 10:56 ` Weili Qian
@ 2023-11-17 11:21 ` Herbert Xu
2 siblings, 0 replies; 4+ messages in thread
From: Herbert Xu @ 2023-11-17 11:21 UTC (permalink / raw)
To: Weili Qian; +Cc: linux-crypto, linux-kernel, liulongfang
On Sat, Oct 28, 2023 at 06:40:11PM +0800, Weili Qian wrote:
> The 'offset' type is unsigned long in 'struct debugfs_reg32',
> so type of values casts to unsigned long long is incorrect, and the
> values do not require type cast, remove them.
>
> Signed-off-by: Weili Qian <qianweili@huawei.com>
> ---
> drivers/crypto/hisilicon/debugfs.c | 50 +++++++++++------------
> drivers/crypto/hisilicon/zip/zip_main.c | 54 ++++++++++++-------------
> 2 files changed, 52 insertions(+), 52 deletions(-)
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-11-17 11:21 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-10-28 10:40 [PATCH] crypto: hisilicon/qm - remove incorrect type cast Weili Qian
2023-10-28 10:40 ` Weili Qian
2023-10-28 10:56 ` Weili Qian
2023-11-17 11:21 ` Herbert Xu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).