[PATCH v2 1/5] ASoC: dt-bindings: remove tas2563 from yaml

[PATCH v2 1/5] ASoC: dt-bindings: remove tas2563 from yaml

[Shenghao Ding]

Remove tas2563 from tas2562, it will be supported in tas2781 to better
support dsp mode.

Signed-off-by: Shenghao Ding <shenghao-ding@ti.com>

---
Change in v2:
 - remove tas2563, which will be move to tas2781 driver
---
 Documentation/devicetree/bindings/sound/tas2562.yaml | 2 --
 1 file changed, 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/sound/tas2562.yaml b/Documentation/devicetree/bindings/sound/tas2562.yaml
index f01c0dde0cf7..d28c102c0ce7 100644
--- a/Documentation/devicetree/bindings/sound/tas2562.yaml
+++ b/Documentation/devicetree/bindings/sound/tas2562.yaml
@@ -18,7 +18,6 @@ description: |
 
   Specifications about the audio amplifier can be found at:
     https://www.ti.com/lit/gpn/tas2562
-    https://www.ti.com/lit/gpn/tas2563
     https://www.ti.com/lit/gpn/tas2564
     https://www.ti.com/lit/gpn/tas2110
 
@@ -29,7 +28,6 @@ properties:
   compatible:
     enum:
       - ti,tas2562
-      - ti,tas2563
       - ti,tas2564
       - ti,tas2110
 
-- 
2.34.1

[PATCH v2 2/5] ASoC: tas2562: remove tas2563 into driver

[Shenghao Ding]

Remove tas2563 from tas2562, it will be supported in tas2781 to better
support dsp mode.

Signed-off-by: Shenghao Ding <shenghao-ding@ti.com>

---
Change in v2:
 - remove tas2563, which will be move to tas2781 driver
---
 sound/soc/codecs/tas2562.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/sound/soc/codecs/tas2562.c b/sound/soc/codecs/tas2562.c
index 962c2cdfa017..54561ae598b8 100644
--- a/sound/soc/codecs/tas2562.c
+++ b/sound/soc/codecs/tas2562.c
@@ -59,7 +59,6 @@ struct tas2562_data {
 
 enum tas256x_model {
 	TAS2562,
-	TAS2563,
 	TAS2564,
 	TAS2110,
 };
@@ -721,7 +720,6 @@ static int tas2562_parse_dt(struct tas2562_data *tas2562)
 
 static const struct i2c_device_id tas2562_id[] = {
 	{ "tas2562", TAS2562 },
-	{ "tas2563", TAS2563 },
 	{ "tas2564", TAS2564 },
 	{ "tas2110", TAS2110 },
 	{ }
@@ -770,7 +768,6 @@ static int tas2562_probe(struct i2c_client *client)
 #ifdef CONFIG_OF
 static const struct of_device_id tas2562_of_match[] = {
 	{ .compatible = "ti,tas2562", },
-	{ .compatible = "ti,tas2563", },
 	{ .compatible = "ti,tas2564", },
 	{ .compatible = "ti,tas2110", },
 	{ },
-- 
2.34.1

[PATCH v2 3/5] ASoC: tas2781: Add tas2563 into header file for dsp mode

[Shenghao Ding]

Support dsp mode for tas2563.

Signed-off-by: Shenghao Ding <shenghao-ding@ti.com>

---
Change in v2:
 - Move tas2563 to tas2781 driver
---
 include/sound/tas2781.h | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/include/sound/tas2781.h b/include/sound/tas2781.h
index a6c808b22318..45be543110ac 100644
--- a/include/sound/tas2781.h
+++ b/include/sound/tas2781.h
@@ -1,13 +1,13 @@
 /* SPDX-License-Identifier: GPL-2.0 */
 //
-// ALSA SoC Texas Instruments TAS2781 Audio Smart Amplifier
+// ALSA SoC Texas Instruments TAS2781/TAS2563 Audio Smart Amplifier
 //
 // Copyright (C) 2022 - 2023 Texas Instruments Incorporated
 // https://www.ti.com
 //
-// The TAS2781 driver implements a flexible and configurable
+// The TAS2781/TAS2563 driver implements a flexible and configurable
 // algo coefficient setting for one, two, or even multiple
-// TAS2781 chips.
+// TAS2781/TAS2563 chips.
 //
 // Author: Shenghao Ding <shenghao-ding@ti.com>
 // Author: Kevin Lu <kevin-lu@ti.com>
@@ -60,6 +60,7 @@
 
 enum audio_device {
 	TAS2781	= 0,
+	TAS2563
 };
 
 enum device_catlog_id {
-- 
2.34.1

[PATCH v2 4/5] ASoC: tas2781: Add tas2563 into driver

[Shenghao Ding]

Add tas2563 to better support dsp mode.

Signed-off-by: Shenghao Ding <shenghao-ding@ti.com>

---
Change in v2:
 - Move tas2563 to tas2781 driver
---
 sound/soc/codecs/tas2781-i2c.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/sound/soc/codecs/tas2781-i2c.c b/sound/soc/codecs/tas2781-i2c.c
index 55cd5e3c23a5..c6afc87f2c69 100644
--- a/sound/soc/codecs/tas2781-i2c.c
+++ b/sound/soc/codecs/tas2781-i2c.c
@@ -5,9 +5,9 @@
 // Copyright (C) 2022 - 2023 Texas Instruments Incorporated
 // https://www.ti.com
 //
-// The TAS2781 driver implements a flexible and configurable
+// The TAS2781/TAS2563 driver implements a flexible and configurable
 // algo coefficient setting for one, two, or even multiple
-// TAS2781 chips.
+// TAS2781/TAS2563 chips.
 //
 // Author: Shenghao Ding <shenghao-ding@ti.com>
 // Author: Kevin Lu <kevin-lu@ti.com>
@@ -33,6 +33,7 @@
 
 static const struct i2c_device_id tasdevice_id[] = {
 	{ "tas2781", TAS2781 },
+	{ "tas2563", TAS2563 },
 	{}
 };
 MODULE_DEVICE_TABLE(i2c, tasdevice_id);
@@ -40,6 +41,7 @@ MODULE_DEVICE_TABLE(i2c, tasdevice_id);
 #ifdef CONFIG_OF
 static const struct of_device_id tasdevice_of_match[] = {
 	{ .compatible = "ti,tas2781" },
+	{ .compatible = "ti,tas2563" },
 	{},
 };
 MODULE_DEVICE_TABLE(of, tasdevice_of_match);
-- 
2.34.1

[PATCH v2 5/5] ASoC: dt-bindings: Add tas2563 into ti,ta2781.yaml to support dsp mode better

[Shenghao Ding]

Add tas2563 to better support dsp mode.

Signed-off-by: Shenghao Ding <shenghao-ding@ti.com>

---
Change in v2:
 - Add devicetree list and other list of necessary people and lists to CC
 - Express Compatibility in the bindings
---
 .../devicetree/bindings/sound/ti,tas2781.yaml | 61 +++++++++++++------
 1 file changed, 43 insertions(+), 18 deletions(-)

diff --git a/Documentation/devicetree/bindings/sound/ti,tas2781.yaml b/Documentation/devicetree/bindings/sound/ti,tas2781.yaml
index a69e6c223308..76d4357117d5 100644
--- a/Documentation/devicetree/bindings/sound/ti,tas2781.yaml
+++ b/Documentation/devicetree/bindings/sound/ti,tas2781.yaml
@@ -5,36 +5,33 @@
 $id: http://devicetree.org/schemas/sound/ti,tas2781.yaml#
 $schema: http://devicetree.org/meta-schemas/core.yaml#
 
-title: Texas Instruments TAS2781 SmartAMP
+title: Texas Instruments TAS2781/TAS2563 SmartAMP
 
 maintainers:
   - Shenghao Ding <shenghao-ding@ti.com>
 
 description:
-  The TAS2781 is a mono, digital input Class-D audio amplifier
-  optimized for efficiently driving high peak power into small
-  loudspeakers. An integrated on-chip DSP supports Texas Instruments
-  Smart Amp speaker protection algorithm. The integrated speaker
-  voltage and current sense provides for real time
+  The TAS2781/TAS2563 is a mono, digital input Class-D audio
+  amplifier optimized for efficiently driving high peak power into
+  small loudspeakers. An integrated on-chip DSP supports Texas
+  Instruments Smart Amp speaker protection algorithm. The
+  integrated speaker voltage and current sense provides for real time
   monitoring of loudspeaker behavior.
 
-allOf:
-  - $ref: dai-common.yaml#
-
 properties:
   compatible:
+    description: |
+      ti,tas2781: 24-V Class-D Amplifier with Real Time Integrated Speaker
+      Protection and Audio Processing, 16/20/24/32bit stereo I2S or
+      multichannel TDM.
+
+      ti,tas2563: 6.1-W Boosted Class-D Audio Amplifier With Integrated
+      DSP and IV Sense, 16/20/24/32bit stereo I2S or multichannel TDM.
     enum:
       - ti,tas2781
+      - ti,tas2563          # fallback compatible
 
-  reg:
-    description:
-      I2C address, in multiple tas2781s case, all the i2c address
-      aggregate as one Audio Device to support multiple audio slots.
-    maxItems: 8
-    minItems: 1
-    items:
-      minimum: 0x38
-      maximum: 0x3f
+  reg: true
 
   reset-gpios:
     maxItems: 1
@@ -49,6 +46,34 @@ required:
   - compatible
   - reg
 
+allOf:
+  - $ref: dai-common.yaml#
+  - if:
+      properties:
+        compatible:
+          contains:
+            enum:
+              - ti,tas2781
+    then:
+      properties:
+        reg:
+          description:
+            I2C address, in multiple AMP case, all the i2c address
+            aggregate as one Audio Device to support multiple audio slots.
+          maxItems: 8
+          minItems: 1
+          items:
+            minimum: 0x38
+            maximum: 0x3f
+    else:
+      properties:
+        reg:
+          maxItems: 4
+          minItems: 1
+          items:
+            minimum: 0x4c
+            maximum: 0x4f
+
 additionalProperties: false
 
 examples:
-- 
2.34.1

Re: [PATCH v2 1/5] ASoC: dt-bindings: remove tas2563 from yaml

[Andy Shevchenko]

On Thu, Dec 21, 2023 at 06:13:41PM +0800, Shenghao Ding wrote:
> Remove tas2563 from tas2562, it will be supported in tas2781 to better
> support dsp mode.

DSP

Shouldn't this patch go after the actual change happen?
I don't know the answer myself, I would like to hear DT
people on this.


-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH v2 2/5] ASoC: tas2562: remove tas2563 into driver

[Andy Shevchenko]

On Thu, Dec 21, 2023 at 06:13:42PM +0800, Shenghao Ding wrote:
> Remove tas2563 from tas2562, it will be supported in tas2781 to better
> support dsp mode.

DSP

...

After this patch the support gone --> regression for the current users.
The commit message does not explain why it's not a problem.

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH v2 3/5] ASoC: tas2781: Add tas2563 into header file for dsp mode

[Andy Shevchenko]

On Thu, Dec 21, 2023 at 06:13:43PM +0800, Shenghao Ding wrote:
> Support dsp mode for tas2563.

DSP

...

> +// ALSA SoC Texas Instruments TAS2781/TAS2563 Audio Smart Amplifier

Why not ordered?

...

> +// The TAS2781/TAS2563 driver implements a flexible and configurable

Ditto.

...

> +// TAS2781/TAS2563 chips.

Ditto.

...

>  enum audio_device {
>  	TAS2781	= 0,
> +	TAS2563

Missing comma as this is not a terminator.

>  };

Ditto.

...

I would expect here

enum audio_device {
	TAS2563,
	TAS2781,
};

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH v2 4/5] ASoC: tas2781: Add tas2563 into driver

[Andy Shevchenko]

On Thu, Dec 21, 2023 at 06:13:44PM +0800, Shenghao Ding wrote:
> Add tas2563 to better support dsp mode.

DSP

...

> +// The TAS2781/TAS2563 driver implements a flexible and configurable

Ordered?

...

> +// TAS2781/TAS2563 chips.

Ditto.

...

>  static const struct i2c_device_id tasdevice_id[] = {
>  	{ "tas2781", TAS2781 },
> +	{ "tas2563", TAS2563 },

Ditto

>  	{}
>  };

...

>  static const struct of_device_id tasdevice_of_match[] = {
>  	{ .compatible = "ti,tas2781" },
> +	{ .compatible = "ti,tas2563" },

Ditto.

>  	{},
>  };

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH v2 5/5] ASoC: dt-bindings: Add tas2563 into ti,ta2781.yaml to support dsp mode better

[Krzysztof Kozlowski]

On 21/12/2023 11:13, Shenghao Ding wrote:
> Add tas2563 to better support dsp mode.
> 
> Signed-off-by: Shenghao Ding <shenghao-ding@ti.com>
> 
> ---
> Change in v2:
>  - Add devicetree list and other list of necessary people and lists to CC
>  - Express Compatibility in the bindings

Nothing changed in that matter - no compatibility was expressed.

...

>  
> -allOf:
> -  - $ref: dai-common.yaml#
> -
>  properties:
>    compatible:
> +    description: |
> +      ti,tas2781: 24-V Class-D Amplifier with Real Time Integrated Speaker
> +      Protection and Audio Processing, 16/20/24/32bit stereo I2S or
> +      multichannel TDM.
> +
> +      ti,tas2563: 6.1-W Boosted Class-D Audio Amplifier With Integrated
> +      DSP and IV Sense, 16/20/24/32bit stereo I2S or multichannel TDM.
>      enum:
>        - ti,tas2781
> +      - ti,tas2563          # fallback compatible

I don't see any use of fallback. The comment is meaningless. Open
example-schema and see how it is done there.

>  
> -  reg:
> -    description:
> -      I2C address, in multiple tas2781s case, all the i2c address
> -      aggregate as one Audio Device to support multiple audio slots.
> -    maxItems: 8
> -    minItems: 1
> -    items:
> -      minimum: 0x38
> -      maximum: 0x3f
> +  reg: true

No, why? Keep min/maxItems.

>  
>    reset-gpios:
>      maxItems: 1
> @@ -49,6 +46,34 @@ required:
>    - compatible
>    - reg
>  
> +allOf:
> +  - $ref: dai-common.yaml#
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            enum:
> +              - ti,tas2781
> +    then:
> +      properties:
> +        reg:
> +          description:
> +            I2C address, in multiple AMP case, all the i2c address
> +            aggregate as one Audio Device to support multiple audio slots.

Description applies to second case as well, so keep it in top-level.



Best regards,
Krzysztof

Re: [PATCH v2 1/5] ASoC: dt-bindings: remove tas2563 from yaml

[Krzysztof Kozlowski]

On 21/12/2023 11:13, Shenghao Ding wrote:
> Remove tas2563 from tas2562, it will be supported in tas2781 to better
> support dsp mode.

Please provide rationale in terms of bindings and hardware, not in terms
of driver. Or at least not only. For example "supported in tas2781" does
not fit hardware part, so you sure must be talking about drivers thus
why driver change would affect bindings?



Best regards,
Krzysztof

Re: [PATCH v2 1/5] ASoC: dt-bindings: remove tas2563 from yaml

[Krzysztof Kozlowski]

On 21/12/2023 16:50, Andy Shevchenko wrote:
> On Thu, Dec 21, 2023 at 06:13:41PM +0800, Shenghao Ding wrote:
>> Remove tas2563 from tas2562, it will be supported in tas2781 to better
>> support dsp mode.
> 
> DSP
> 
> Shouldn't this patch go after the actual change happen?

I would squash both, so device documentation does not disappear.

Best regards,
Krzysztof

RE: [EXTERNAL] Re: [PATCH v2 1/5] ASoC: dt-bindings: remove tas2563 from yaml

[Ding, Shenghao]

> -----Original Message-----
> From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Sent: Thursday, December 21, 2023 11:51 PM
> To: Ding, Shenghao <shenghao-ding@ti.com>
> Cc: broonie@kernel.org; conor+dt@kernel.org;
> krzysztof.kozlowski@linaro.org; robh+dt@kernel.org; Lu, Kevin <kevin-
> lu@ti.com>; Xu, Baojun <baojun.xu@ti.com>; devicetree@vger.kernel.org;
> lgirdwood@gmail.com; perex@perex.cz; pierre-louis.bossart@linux.intel.com;
> 13916275206@139.com; linux-sound@vger.kernel.org; linux-
> kernel@vger.kernel.org; liam.r.girdwood@intel.com; soyer@irl.hu;
> tiwai@suse.de; Gupta, Peeyush <peeyush@ti.com>; Navada Kanyana,
> Mukund <navada@ti.com>
> Subject: [EXTERNAL] Re: [PATCH v2 1/5] ASoC: dt-bindings: remove tas2563
> from yaml
> 
> On Thu, Dec 21, 2023 at 06:13:41PM +0800, Shenghao Ding wrote:
> > Remove tas2563 from tas2562, it will be supported in tas2781 to better
> > support dsp mode.
> 
> DSP
> 
> Shouldn't this patch go after the actual change happen?
> I don't know the answer myself, I would like to hear DT people on this.
> 
tas2781 driver can be reused as tas2563 driver, except for the DSP firmware file, 
and both DSP firmware files complied with TI SmartAMP DSP spec 3.0.
> 
> --
> With Best Regards,
> Andy Shevchenko
> 
> 

RE: [EXTERNAL] Re: [PATCH v2 1/5] ASoC: dt-bindings: remove tas2563 from yaml

[Ding, Shenghao]

> -----Original Message-----
> From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Sent: Friday, December 22, 2023 1:32 AM
> To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>; Ding, Shenghao
> <shenghao-ding@ti.com>
> Cc: broonie@kernel.org; conor+dt@kernel.org; robh+dt@kernel.org; Lu,
> Kevin <kevin-lu@ti.com>; Xu, Baojun <baojun.xu@ti.com>;
> devicetree@vger.kernel.org; lgirdwood@gmail.com; perex@perex.cz; pierre-
> louis.bossart@linux.intel.com; 13916275206@139.com; linux-
> sound@vger.kernel.org; linux-kernel@vger.kernel.org;
> liam.r.girdwood@intel.com; soyer@irl.hu; tiwai@suse.de; Gupta, Peeyush
> <peeyush@ti.com>; Navada Kanyana, Mukund <navada@ti.com>
> Subject: [EXTERNAL] Re: [PATCH v2 1/5] ASoC: dt-bindings: remove tas2563
> from yaml
> 
> On 21/12/2023 16:50, Andy Shevchenko wrote:
> > On Thu, Dec 21, 2023 at 06:13:41PM +0800, Shenghao Ding wrote:
> >> Remove tas2563 from tas2562, it will be supported in tas2781 to
> >> better support dsp mode.
> >
> > DSP
> >
> > Shouldn't this patch go after the actual change happen?
> 
> I would squash both, so device documentation does not disappear.
I do not fully understand "squash both", do you mean still to keep ti,tas2563 in tas2562.yaml?
> 
> Best regards,
> Krzysztof

RE: [EXTERNAL] Re: [PATCH v2 1/5] ASoC: dt-bindings: remove tas2563 from yaml

[Ding, Shenghao]

> -----Original Message-----
> From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Sent: Friday, December 22, 2023 1:31 AM
> To: Ding, Shenghao <shenghao-ding@ti.com>; broonie@kernel.org;
> conor+dt@kernel.org
> Cc: robh+dt@kernel.org; andriy.shevchenko@linux.intel.com; Lu, Kevin
> <kevin-lu@ti.com>; Xu, Baojun <baojun.xu@ti.com>;
> devicetree@vger.kernel.org; lgirdwood@gmail.com; perex@perex.cz; pierre-
> louis.bossart@linux.intel.com; 13916275206@139.com; linux-
> sound@vger.kernel.org; linux-kernel@vger.kernel.org;
> liam.r.girdwood@intel.com; soyer@irl.hu; tiwai@suse.de; Gupta, Peeyush
> <peeyush@ti.com>; Navada Kanyana, Mukund <navada@ti.com>
> Subject: [EXTERNAL] Re: [PATCH v2 1/5] ASoC: dt-bindings: remove tas2563
> from yaml
> 
> On 21/12/2023 11:13, Shenghao Ding wrote:
> > Remove tas2563 from tas2562, it will be supported in tas2781 to better
> > support dsp mode.
> 
> Please provide rationale in terms of bindings and hardware, not in terms of
> driver. Or at least not only. For example "supported in tas2781" does not fit
> hardware part, so you sure must be talking about drivers thus why driver
> change would affect bindings?
This patch mainly change the binding, not the driver code. Tas2563 is unbound 
to tas2562 driver, and bound to tas2781 driver.
> 
> 
> 
> Best regards,
> Krzysztof

Re: [EXTERNAL] Re: [PATCH v2 1/5] ASoC: dt-bindings: remove tas2563 from yaml

[Krzysztof Kozlowski]

On 27/12/2023 08:04, Ding, Shenghao wrote:
> 
> 
>> -----Original Message-----
>> From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>> Sent: Friday, December 22, 2023 1:32 AM
>> To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>; Ding, Shenghao
>> <shenghao-ding@ti.com>
>> Cc: broonie@kernel.org; conor+dt@kernel.org; robh+dt@kernel.org; Lu,
>> Kevin <kevin-lu@ti.com>; Xu, Baojun <baojun.xu@ti.com>;
>> devicetree@vger.kernel.org; lgirdwood@gmail.com; perex@perex.cz; pierre-
>> louis.bossart@linux.intel.com; 13916275206@139.com; linux-
>> sound@vger.kernel.org; linux-kernel@vger.kernel.org;
>> liam.r.girdwood@intel.com; soyer@irl.hu; tiwai@suse.de; Gupta, Peeyush
>> <peeyush@ti.com>; Navada Kanyana, Mukund <navada@ti.com>
>> Subject: [EXTERNAL] Re: [PATCH v2 1/5] ASoC: dt-bindings: remove tas2563
>> from yaml
>>
>> On 21/12/2023 16:50, Andy Shevchenko wrote:
>>> On Thu, Dec 21, 2023 at 06:13:41PM +0800, Shenghao Ding wrote:
>>>> Remove tas2563 from tas2562, it will be supported in tas2781 to
>>>> better support dsp mode.
>>>
>>> DSP
>>>
>>> Shouldn't this patch go after the actual change happen?
>>
>> I would squash both, so device documentation does not disappear.
> I do not fully understand "squash both", do you mean still to keep ti,tas2563 in tas2562.yaml?

I meant to squash both binding patches (git help rebase).

Best regards,
Krzysztof

Re: [EXTERNAL] Re: [PATCH v2 1/5] ASoC: dt-bindings: remove tas2563 from yaml

[Krzysztof Kozlowski]

On 27/12/2023 08:07, Ding, Shenghao wrote:
> 
> 
>> -----Original Message-----
>> From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>> Sent: Friday, December 22, 2023 1:31 AM
>> To: Ding, Shenghao <shenghao-ding@ti.com>; broonie@kernel.org;
>> conor+dt@kernel.org
>> Cc: robh+dt@kernel.org; andriy.shevchenko@linux.intel.com; Lu, Kevin
>> <kevin-lu@ti.com>; Xu, Baojun <baojun.xu@ti.com>;
>> devicetree@vger.kernel.org; lgirdwood@gmail.com; perex@perex.cz; pierre-
>> louis.bossart@linux.intel.com; 13916275206@139.com; linux-
>> sound@vger.kernel.org; linux-kernel@vger.kernel.org;
>> liam.r.girdwood@intel.com; soyer@irl.hu; tiwai@suse.de; Gupta, Peeyush
>> <peeyush@ti.com>; Navada Kanyana, Mukund <navada@ti.com>
>> Subject: [EXTERNAL] Re: [PATCH v2 1/5] ASoC: dt-bindings: remove tas2563
>> from yaml
>>
>> On 21/12/2023 11:13, Shenghao Ding wrote:
>>> Remove tas2563 from tas2562, it will be supported in tas2781 to better
>>> support dsp mode.
>>
>> Please provide rationale in terms of bindings and hardware, not in terms of
>> driver. Or at least not only. For example "supported in tas2781" does not fit
>> hardware part, so you sure must be talking about drivers thus why driver
>> change would affect bindings?
> This patch mainly change the binding, not the driver code. Tas2563 is unbound 
> to tas2562 driver, and bound to tas2781 driver.

Then why do you reference driver "tas2781" here?

Best regards,
Krzysztof

RE: [EXTERNAL] Re: [PATCH v2 1/5] ASoC: dt-bindings: remove tas2563 from yaml

[Ding, Shenghao]

> -----Original Message-----
> From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Sent: Wednesday, December 27, 2023 6:56 PM
> To: Ding, Shenghao <shenghao-ding@ti.com>
> Cc: robh+dt@kernel.org; andriy.shevchenko@linux.intel.com; Lu, Kevin
> <kevin-lu@ti.com>; Xu, Baojun <baojun.xu@ti.com>;
> devicetree@vger.kernel.org; lgirdwood@gmail.com; perex@perex.cz; pierre-
> louis.bossart@linux.intel.com; 13916275206@139.com; linux-
> sound@vger.kernel.org; linux-kernel@vger.kernel.org;
> liam.r.girdwood@intel.com; soyer@irl.hu; tiwai@suse.de; Gupta, Peeyush
> <peeyush@ti.com>; Navada Kanyana, Mukund <navada@ti.com>;
> broonie@kernel.org; conor+dt@kernel.org
> Subject: Re: [EXTERNAL] Re: [PATCH v2 1/5] ASoC: dt-bindings: remove
> tas2563 from yaml
> 
> On 27/12/2023 08:07, Ding, Shenghao wrote:
> >
> >
> >> -----Original Message-----
> >> From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> >> Sent: Friday, December 22, 2023 1:31 AM
> >> To: Ding, Shenghao <shenghao-ding@ti.com>; broonie@kernel.org;
> >> conor+dt@kernel.org
> >> Cc: robh+dt@kernel.org; andriy.shevchenko@linux.intel.com; Lu, Kevin
> >> <kevin-lu@ti.com>; Xu, Baojun <baojun.xu@ti.com>;
> >> devicetree@vger.kernel.org; lgirdwood@gmail.com; perex@perex.cz;
> >> pierre- louis.bossart@linux.intel.com; 13916275206@139.com; linux-
> >> sound@vger.kernel.org; linux-kernel@vger.kernel.org;
> >> liam.r.girdwood@intel.com; soyer@irl.hu; tiwai@suse.de; Gupta,
> >> Peeyush <peeyush@ti.com>; Navada Kanyana, Mukund <navada@ti.com>
> >> Subject: [EXTERNAL] Re: [PATCH v2 1/5] ASoC: dt-bindings: remove
> >> tas2563 from yaml
> >>
> >> On 21/12/2023 11:13, Shenghao Ding wrote:
> >>> Remove tas2563 from tas2562, it will be supported in tas2781 to
> >>> better support dsp mode.
> >>
> >> Please provide rationale in terms of bindings and hardware, not in
> >> terms of driver. Or at least not only. For example "supported in
> >> tas2781" does not fit hardware part, so you sure must be talking
> >> about drivers thus why driver change would affect bindings?
> > This patch mainly change the binding, not the driver code. Tas2563 is
> > unbound to tas2562 driver, and bound to tas2781 driver.
> 
> Then why do you reference driver "tas2781" here?
Both tas2563 and tas2781 are dsp-inside audio amplifier, 
tas2781 driver is designed for dsp-inside series chips, 
not only for tas2781.
> 
> Best regards,
> Krzysztof