* [PATCH] freevxfs: remove SLAB_MEM_SPREAD flag usage
@ 2024-02-24 13:48 chengming.zhou
2024-02-26 10:06 ` Christoph Hellwig
0 siblings, 1 reply; 5+ messages in thread
From: chengming.zhou @ 2024-02-24 13:48 UTC (permalink / raw)
To: hch
Cc: linux-kernel, linux-mm, vbabka, roman.gushchin, Xiongwei.Song,
chengming.zhou, Chengming Zhou
From: Chengming Zhou <zhouchengming@bytedance.com>
The SLAB_MEM_SPREAD flag is already a no-op as of 6.8-rc1, remove
its usage so we can delete it from slab. No functional change.
Signed-off-by: Chengming Zhou <zhouchengming@bytedance.com>
---
fs/freevxfs/vxfs_super.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/freevxfs/vxfs_super.c b/fs/freevxfs/vxfs_super.c
index e6e2a2185e7c..42e03b6b1cc7 100644
--- a/fs/freevxfs/vxfs_super.c
+++ b/fs/freevxfs/vxfs_super.c
@@ -307,7 +307,7 @@ vxfs_init(void)
vxfs_inode_cachep = kmem_cache_create_usercopy("vxfs_inode",
sizeof(struct vxfs_inode_info), 0,
- SLAB_RECLAIM_ACCOUNT|SLAB_MEM_SPREAD,
+ SLAB_RECLAIM_ACCOUNT,
offsetof(struct vxfs_inode_info, vii_immed.vi_immed),
sizeof_field(struct vxfs_inode_info,
vii_immed.vi_immed),
--
2.40.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] freevxfs: remove SLAB_MEM_SPREAD flag usage
2024-02-24 13:48 [PATCH] freevxfs: remove SLAB_MEM_SPREAD flag usage chengming.zhou
@ 2024-02-26 10:06 ` Christoph Hellwig
2024-02-26 10:24 ` Chengming Zhou
0 siblings, 1 reply; 5+ messages in thread
From: Christoph Hellwig @ 2024-02-26 10:06 UTC (permalink / raw)
To: chengming.zhou
Cc: hch, linux-kernel, linux-mm, vbabka, roman.gushchin,
Xiongwei.Song, Chengming Zhou
Please just do a scripted removal after next -rc1 instead of spamming
everyone..
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] freevxfs: remove SLAB_MEM_SPREAD flag usage
2024-02-26 10:06 ` Christoph Hellwig
@ 2024-02-26 10:24 ` Chengming Zhou
2024-02-26 10:35 ` Vlastimil Babka
2024-02-26 10:49 ` Christoph Hellwig
0 siblings, 2 replies; 5+ messages in thread
From: Chengming Zhou @ 2024-02-26 10:24 UTC (permalink / raw)
To: Christoph Hellwig
Cc: linux-kernel, vbabka, roman.gushchin, Xiongwei.Song, Chengming Zhou
On 2024/2/26 18:06, Christoph Hellwig wrote:
> Please just do a scripted removal after next -rc1 instead of spamming
> everyone..
>
Do you mean put all diffs into a single patch, send it to all people?
That is also a choice if it's preferable. Should it will go through
the slab tree then?
Thanks.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] freevxfs: remove SLAB_MEM_SPREAD flag usage
2024-02-26 10:24 ` Chengming Zhou
@ 2024-02-26 10:35 ` Vlastimil Babka
2024-02-26 10:49 ` Christoph Hellwig
1 sibling, 0 replies; 5+ messages in thread
From: Vlastimil Babka @ 2024-02-26 10:35 UTC (permalink / raw)
To: Chengming Zhou, Christoph Hellwig
Cc: linux-kernel, roman.gushchin, Xiongwei.Song, Chengming Zhou
On 2/26/24 11:24, Chengming Zhou wrote:
> On 2024/2/26 18:06, Christoph Hellwig wrote:
>> Please just do a scripted removal after next -rc1 instead of spamming
>> everyone..
>>
> Do you mean put all diffs into a single patch, send it to all people?
> That is also a choice if it's preferable. Should it will go through
> the slab tree then?
In case that's what Christoph means, we should exclude from that those
subsystems that already took your patches.
> Thanks.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] freevxfs: remove SLAB_MEM_SPREAD flag usage
2024-02-26 10:24 ` Chengming Zhou
2024-02-26 10:35 ` Vlastimil Babka
@ 2024-02-26 10:49 ` Christoph Hellwig
1 sibling, 0 replies; 5+ messages in thread
From: Christoph Hellwig @ 2024-02-26 10:49 UTC (permalink / raw)
To: Chengming Zhou
Cc: Christoph Hellwig, linux-kernel, vbabka, roman.gushchin,
Xiongwei.Song, Chengming Zhou
On Mon, Feb 26, 2024 at 06:24:32PM +0800, Chengming Zhou wrote:
> On 2024/2/26 18:06, Christoph Hellwig wrote:
> > Please just do a scripted removal after next -rc1 instead of spamming
> > everyone..
> >
> Do you mean put all diffs into a single patch, send it to all people?
> That is also a choice if it's preferable. Should it will go through
> the slab tree then?
Yes, send a scripted removal of what is left after6.9 -rc1 either to the
slab maintainers or directly to Linus with the slab maintainers ACK.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2024-02-26 10:49 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-02-24 13:48 [PATCH] freevxfs: remove SLAB_MEM_SPREAD flag usage chengming.zhou
2024-02-26 10:06 ` Christoph Hellwig
2024-02-26 10:24 ` Chengming Zhou
2024-02-26 10:35 ` Vlastimil Babka
2024-02-26 10:49 ` Christoph Hellwig
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).