* [PATCH] drivers/nvme: Add quirks for device 126f:2262
@ 2024-03-15 19:27 iBug
2024-03-17 7:34 ` Sagi Grimberg
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: iBug @ 2024-03-15 19:27 UTC (permalink / raw)
To: kbusch, axboe, hch, sagi, linux-nvme; +Cc: linux-kernel, Jiawei Fu (iBug)
From: "Jiawei Fu (iBug)" <i@ibugone.com>
This commit adds NVME_QUIRK_NO_DEEPEST_PS and NVME_QUIRK_BOGUS_NID for
device [126f:2262], which appears to be a generic VID:PID pair used for
many SSDs based on the Silicon Motion SM2262/SM2262EN controller.
Two of my SSDs with this VID:PID pair exhibit the same behavior:
* They frequently have trouble exiting the deepest power state (5),
resulting in the entire disk unresponsive.
Verified by setting nvme_core.default_ps_max_latency_us=10000 and
observing them behaving normally.
* They produce all-zero nguid and eui64 with `nvme id-ns` command.
The offending products are:
* HP SSD EX950 1TB
* HIKVISION C2000Pro 2TB
Signed-off-by: Jiawei Fu <i@ibugone.com>
---
drivers/nvme/host/pci.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
index e6267a6aa380..8e0bb9692685 100644
--- a/drivers/nvme/host/pci.c
+++ b/drivers/nvme/host/pci.c
@@ -3363,6 +3363,9 @@ static const struct pci_device_id nvme_id_table[] = {
NVME_QUIRK_BOGUS_NID, },
{ PCI_VDEVICE(REDHAT, 0x0010), /* Qemu emulated controller */
.driver_data = NVME_QUIRK_BOGUS_NID, },
+ { PCI_DEVICE(0x126f, 0x2262), /* Silicon Motion generic */
+ .driver_data = NVME_QUIRK_NO_DEEPEST_PS |
+ NVME_QUIRK_BOGUS_NID, },
{ PCI_DEVICE(0x126f, 0x2263), /* Silicon Motion unidentified */
.driver_data = NVME_QUIRK_NO_NS_DESC_LIST |
NVME_QUIRK_BOGUS_NID, },
--
2.43.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] drivers/nvme: Add quirks for device 126f:2262
2024-03-15 19:27 [PATCH] drivers/nvme: Add quirks for device 126f:2262 iBug
@ 2024-03-17 7:34 ` Sagi Grimberg
2024-03-17 20:23 ` Christoph Hellwig
2024-03-18 20:38 ` Keith Busch
2 siblings, 0 replies; 4+ messages in thread
From: Sagi Grimberg @ 2024-03-17 7:34 UTC (permalink / raw)
To: iBug, kbusch, axboe, hch, linux-nvme; +Cc: linux-kernel
Reviewed-by: Sagi Grimberg <sagi@grimberg.me>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] drivers/nvme: Add quirks for device 126f:2262
2024-03-15 19:27 [PATCH] drivers/nvme: Add quirks for device 126f:2262 iBug
2024-03-17 7:34 ` Sagi Grimberg
@ 2024-03-17 20:23 ` Christoph Hellwig
2024-03-18 20:38 ` Keith Busch
2 siblings, 0 replies; 4+ messages in thread
From: Christoph Hellwig @ 2024-03-17 20:23 UTC (permalink / raw)
To: iBug; +Cc: kbusch, axboe, hch, sagi, linux-nvme, linux-kernel
Looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] drivers/nvme: Add quirks for device 126f:2262
2024-03-15 19:27 [PATCH] drivers/nvme: Add quirks for device 126f:2262 iBug
2024-03-17 7:34 ` Sagi Grimberg
2024-03-17 20:23 ` Christoph Hellwig
@ 2024-03-18 20:38 ` Keith Busch
2 siblings, 0 replies; 4+ messages in thread
From: Keith Busch @ 2024-03-18 20:38 UTC (permalink / raw)
To: iBug; +Cc: axboe, hch, sagi, linux-nvme, linux-kernel
On Sat, Mar 16, 2024 at 03:27:49AM +0800, iBug wrote:
> From: "Jiawei Fu (iBug)" <i@ibugone.com>
>
> This commit adds NVME_QUIRK_NO_DEEPEST_PS and NVME_QUIRK_BOGUS_NID for
> device [126f:2262], which appears to be a generic VID:PID pair used for
> many SSDs based on the Silicon Motion SM2262/SM2262EN controller.
Thanks, applied to nvme-6.9.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-03-18 20:38 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-03-15 19:27 [PATCH] drivers/nvme: Add quirks for device 126f:2262 iBug
2024-03-17 7:34 ` Sagi Grimberg
2024-03-17 20:23 ` Christoph Hellwig
2024-03-18 20:38 ` Keith Busch
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).