linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2 0/3] ASoC: stm32: fix dtbs_check warnings
@ 2023-06-06 11:56 Olivier Moysan
  2023-06-06 11:56 ` [PATCH v2 1/3] ASoC: dt-bindings: stm32: document audio of graph port for i2s Olivier Moysan
                   ` (4 more replies)
  0 siblings, 5 replies; 8+ messages in thread
From: Olivier Moysan @ 2023-06-06 11:56 UTC (permalink / raw)
  To: James Schulman, David Rhodes, Lucas Tanure, Richard Fitzgerald,
	Liam Girdwood, Mark Brown, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, Olivier Moysan, Arnaud Pouliquen, Maxime Coquelin,
	Alexandre Torgue
  Cc: Alexandre Torgue, alsa-devel, patches, devicetree, linux-kernel,
	linux-stm32, linux-arm-kernel

Fix dtbs_check warnings in STM32MP15 DK boards Devices Trees for
STM32 I2S and Cirrus CS42L51 codec.

- Add OF graph port property in I2S and CS42L51 DT bindings.
  Fixes warnings:
  audio-controller@4000b000: Unevaluated properties are not allowed 
  ('port' was unexpected)
  cs42l51@4a: Unevaluated properties are not allowed
  ('port' was unexpected)
- Correct OF graph DAI audio format property for STM32MP15x Dkx I2S node

Changes in v2:
- Add port example in i2s and cs42l51 binding

Olivier Moysan (3):
  ASoC: dt-bindings: stm32: document audio of graph port for i2s
  ASoC: dt-bindings: document audio of graph port for cs42l51
  ARM: dts: stm32: fix i2s endpoint format property for stm32mp15xx-dkx

 .../devicetree/bindings/sound/cirrus,cs42l51.yaml     | 11 +++++++++++
 .../devicetree/bindings/sound/st,stm32-i2s.yaml       | 11 +++++++++++
 arch/arm/boot/dts/stm32mp15xx-dkx.dtsi                |  2 +-
 3 files changed, 23 insertions(+), 1 deletion(-)

-- 
2.25.1


^ permalink raw reply	[flat|nested] 8+ messages in thread

* [PATCH v2 1/3] ASoC: dt-bindings: stm32: document audio of graph port for i2s
  2023-06-06 11:56 [PATCH v2 0/3] ASoC: stm32: fix dtbs_check warnings Olivier Moysan
@ 2023-06-06 11:56 ` Olivier Moysan
  2023-06-06 12:29   ` Krzysztof Kozlowski
  2023-06-06 11:56 ` [PATCH v2 2/3] ASoC: dt-bindings: document audio of graph port for cs42l51 Olivier Moysan
                   ` (3 subsequent siblings)
  4 siblings, 1 reply; 8+ messages in thread
From: Olivier Moysan @ 2023-06-06 11:56 UTC (permalink / raw)
  To: Olivier Moysan, Arnaud Pouliquen, Liam Girdwood, Mark Brown,
	Rob Herring, Krzysztof Kozlowski, Conor Dooley, Maxime Coquelin,
	Alexandre Torgue
  Cc: alsa-devel, devicetree, linux-stm32, linux-arm-kernel, linux-kernel

When linking the STM32 I2S to another DAI component, according
to audio graph cards bindings, an OF graph port property is expected
in the node. Document the port property.

Signed-off-by: Olivier Moysan <olivier.moysan@foss.st.com>
---
 .../devicetree/bindings/sound/st,stm32-i2s.yaml       | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/Documentation/devicetree/bindings/sound/st,stm32-i2s.yaml b/Documentation/devicetree/bindings/sound/st,stm32-i2s.yaml
index a040d4d31412..b9111d375b93 100644
--- a/Documentation/devicetree/bindings/sound/st,stm32-i2s.yaml
+++ b/Documentation/devicetree/bindings/sound/st,stm32-i2s.yaml
@@ -61,6 +61,10 @@ properties:
     description: Configure the I2S device as MCLK clock provider.
     const: 0
 
+  port:
+    $ref: audio-graph-port.yaml#
+    unevaluatedProperties: false
+
 required:
   - compatible
   - "#sound-dai-cells"
@@ -89,6 +93,13 @@ examples:
         dma-names = "rx", "tx";
         pinctrl-names = "default";
         pinctrl-0 = <&i2s2_pins_a>;
+
+        /* assume audio-graph */
+        port {
+            codec_endpoint: endpoint {
+                remote-endpoint = <&codec_endpoint>;
+            };
+        };
     };
 
 ...
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 8+ messages in thread

* [PATCH v2 2/3] ASoC: dt-bindings: document audio of graph port for cs42l51
  2023-06-06 11:56 [PATCH v2 0/3] ASoC: stm32: fix dtbs_check warnings Olivier Moysan
  2023-06-06 11:56 ` [PATCH v2 1/3] ASoC: dt-bindings: stm32: document audio of graph port for i2s Olivier Moysan
@ 2023-06-06 11:56 ` Olivier Moysan
  2023-06-06 12:29   ` Krzysztof Kozlowski
  2023-06-06 11:56 ` [PATCH v2 3/3] ARM: dts: stm32: fix i2s endpoint format property for stm32mp15xx-dkx Olivier Moysan
                   ` (2 subsequent siblings)
  4 siblings, 1 reply; 8+ messages in thread
From: Olivier Moysan @ 2023-06-06 11:56 UTC (permalink / raw)
  To: James Schulman, David Rhodes, Lucas Tanure, Richard Fitzgerald,
	Liam Girdwood, Mark Brown, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, Olivier Moysan
  Cc: alsa-devel, patches, devicetree, linux-kernel

When linking the CS42L51 to another DAI component, according
to audio graph cards bindings, an OF graph port property is expected
in the node. Document the port property.

Signed-off-by: Olivier Moysan <olivier.moysan@foss.st.com>
---
 .../devicetree/bindings/sound/cirrus,cs42l51.yaml     | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/Documentation/devicetree/bindings/sound/cirrus,cs42l51.yaml b/Documentation/devicetree/bindings/sound/cirrus,cs42l51.yaml
index 670b67ec0b61..f7bafbd4f1c2 100644
--- a/Documentation/devicetree/bindings/sound/cirrus,cs42l51.yaml
+++ b/Documentation/devicetree/bindings/sound/cirrus,cs42l51.yaml
@@ -44,6 +44,10 @@ properties:
   VAHP-supply:
     description: phandle to voltage regulator of headphone
 
+  port:
+    $ref: audio-graph-port.yaml#
+    unevaluatedProperties: false
+
 required:
   - compatible
   - reg
@@ -69,6 +73,13 @@ examples:
         VA-supply = <&reg_audio>;
         VAHP-supply = <&reg_audio>;
         reset-gpios = <&gpiog 9 GPIO_ACTIVE_LOW>;
+
+        /* assume audio-graph */
+        port {
+          cpu_endpoint: endpoint {
+            remote-endpoint = <&cpu_endpoint>;
+          };
+        };
       };
     };
 ...
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 8+ messages in thread

* [PATCH v2 3/3] ARM: dts: stm32: fix i2s endpoint format property for stm32mp15xx-dkx
  2023-06-06 11:56 [PATCH v2 0/3] ASoC: stm32: fix dtbs_check warnings Olivier Moysan
  2023-06-06 11:56 ` [PATCH v2 1/3] ASoC: dt-bindings: stm32: document audio of graph port for i2s Olivier Moysan
  2023-06-06 11:56 ` [PATCH v2 2/3] ASoC: dt-bindings: document audio of graph port for cs42l51 Olivier Moysan
@ 2023-06-06 11:56 ` Olivier Moysan
  2023-06-07 20:17 ` (subset) [PATCH v2 0/3] ASoC: stm32: fix dtbs_check warnings Mark Brown
  2023-06-08 11:57 ` Alexandre TORGUE
  4 siblings, 0 replies; 8+ messages in thread
From: Olivier Moysan @ 2023-06-06 11:56 UTC (permalink / raw)
  To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Maxime Coquelin,
	Alexandre Torgue
  Cc: Olivier Moysan, Alexandre Torgue, devicetree, linux-stm32,
	linux-arm-kernel, linux-kernel

Use "dai-format" to configure DAI audio format as specified in
audio-graph-port.yaml bindings.

Fixes: 144d1ba70548 ("ARM: dts: stm32: Adapt STM32MP157 DK boards to stm32 DT diversity")
Signed-off-by: Olivier Moysan <olivier.moysan@foss.st.com>
---
 arch/arm/boot/dts/stm32mp15xx-dkx.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/stm32mp15xx-dkx.dtsi b/arch/arm/boot/dts/stm32mp15xx-dkx.dtsi
index e78ba956b9d0..511113f2e399 100644
--- a/arch/arm/boot/dts/stm32mp15xx-dkx.dtsi
+++ b/arch/arm/boot/dts/stm32mp15xx-dkx.dtsi
@@ -446,7 +446,7 @@ &i2s2 {
 	i2s2_port: port {
 		i2s2_endpoint: endpoint {
 			remote-endpoint = <&sii9022_tx_endpoint>;
-			format = "i2s";
+			dai-format = "i2s";
 			mclk-fs = <256>;
 		};
 	};
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 8+ messages in thread

* Re: [PATCH v2 1/3] ASoC: dt-bindings: stm32: document audio of graph port for i2s
  2023-06-06 11:56 ` [PATCH v2 1/3] ASoC: dt-bindings: stm32: document audio of graph port for i2s Olivier Moysan
@ 2023-06-06 12:29   ` Krzysztof Kozlowski
  0 siblings, 0 replies; 8+ messages in thread
From: Krzysztof Kozlowski @ 2023-06-06 12:29 UTC (permalink / raw)
  To: Olivier Moysan, Arnaud Pouliquen, Liam Girdwood, Mark Brown,
	Rob Herring, Krzysztof Kozlowski, Conor Dooley, Maxime Coquelin,
	Alexandre Torgue
  Cc: alsa-devel, devicetree, linux-stm32, linux-arm-kernel, linux-kernel

On 06/06/2023 13:56, Olivier Moysan wrote:
> When linking the STM32 I2S to another DAI component, according
> to audio graph cards bindings, an OF graph port property is expected
> in the node. Document the port property.
> 
> Signed-off-by: Olivier Moysan <olivier.moysan@foss.st.com>
> ---


Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof


^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH v2 2/3] ASoC: dt-bindings: document audio of graph port for cs42l51
  2023-06-06 11:56 ` [PATCH v2 2/3] ASoC: dt-bindings: document audio of graph port for cs42l51 Olivier Moysan
@ 2023-06-06 12:29   ` Krzysztof Kozlowski
  0 siblings, 0 replies; 8+ messages in thread
From: Krzysztof Kozlowski @ 2023-06-06 12:29 UTC (permalink / raw)
  To: Olivier Moysan, James Schulman, David Rhodes, Lucas Tanure,
	Richard Fitzgerald, Liam Girdwood, Mark Brown, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley
  Cc: alsa-devel, patches, devicetree, linux-kernel

On 06/06/2023 13:56, Olivier Moysan wrote:
> When linking the CS42L51 to another DAI component, according
> to audio graph cards bindings, an OF graph port property is expected
> in the node. Document the port property.
> 
> Signed-off-by: Olivier Moysan <olivier.moysan@foss.st.com>
> ---


Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof


^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: (subset) [PATCH v2 0/3] ASoC: stm32: fix dtbs_check warnings
  2023-06-06 11:56 [PATCH v2 0/3] ASoC: stm32: fix dtbs_check warnings Olivier Moysan
                   ` (2 preceding siblings ...)
  2023-06-06 11:56 ` [PATCH v2 3/3] ARM: dts: stm32: fix i2s endpoint format property for stm32mp15xx-dkx Olivier Moysan
@ 2023-06-07 20:17 ` Mark Brown
  2023-06-08 11:57 ` Alexandre TORGUE
  4 siblings, 0 replies; 8+ messages in thread
From: Mark Brown @ 2023-06-07 20:17 UTC (permalink / raw)
  To: James Schulman, David Rhodes, Lucas Tanure, Richard Fitzgerald,
	Liam Girdwood, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	Arnaud Pouliquen, Maxime Coquelin, Alexandre Torgue,
	Olivier Moysan
  Cc: Alexandre Torgue, alsa-devel, patches, devicetree, linux-kernel,
	linux-stm32, linux-arm-kernel

On Tue, 06 Jun 2023 13:56:01 +0200, Olivier Moysan wrote:
> Fix dtbs_check warnings in STM32MP15 DK boards Devices Trees for
> STM32 I2S and Cirrus CS42L51 codec.
> 
> - Add OF graph port property in I2S and CS42L51 DT bindings.
>   Fixes warnings:
>   audio-controller@4000b000: Unevaluated properties are not allowed
>   ('port' was unexpected)
>   cs42l51@4a: Unevaluated properties are not allowed
>   ('port' was unexpected)
> - Correct OF graph DAI audio format property for STM32MP15x Dkx I2S node
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/3] ASoC: dt-bindings: stm32: document audio of graph port for i2s
      commit: 401ec2b8878f34b6baf64fba3e29411c246b785c
[2/3] ASoC: dt-bindings: document audio of graph port for cs42l51
      commit: fe748da7c216528d46adb4c6f4a969346ec3a452

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark


^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH v2 0/3] ASoC: stm32: fix dtbs_check warnings
  2023-06-06 11:56 [PATCH v2 0/3] ASoC: stm32: fix dtbs_check warnings Olivier Moysan
                   ` (3 preceding siblings ...)
  2023-06-07 20:17 ` (subset) [PATCH v2 0/3] ASoC: stm32: fix dtbs_check warnings Mark Brown
@ 2023-06-08 11:57 ` Alexandre TORGUE
  4 siblings, 0 replies; 8+ messages in thread
From: Alexandre TORGUE @ 2023-06-08 11:57 UTC (permalink / raw)
  To: Olivier Moysan, James Schulman, David Rhodes, Lucas Tanure,
	Richard Fitzgerald, Liam Girdwood, Mark Brown, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, Arnaud Pouliquen,
	Maxime Coquelin
  Cc: Alexandre Torgue, alsa-devel, patches, devicetree, linux-kernel,
	linux-stm32, linux-arm-kernel

Hi

On 6/6/23 13:56, Olivier Moysan wrote:
> Fix dtbs_check warnings in STM32MP15 DK boards Devices Trees for
> STM32 I2S and Cirrus CS42L51 codec.
> 
> - Add OF graph port property in I2S and CS42L51 DT bindings.
>    Fixes warnings:
>    audio-controller@4000b000: Unevaluated properties are not allowed
>    ('port' was unexpected)
>    cs42l51@4a: Unevaluated properties are not allowed
>    ('port' was unexpected)
> - Correct OF graph DAI audio format property for STM32MP15x Dkx I2S node
> 
> Changes in v2:
> - Add port example in i2s and cs42l51 binding
> 
> Olivier Moysan (3):
>    ASoC: dt-bindings: stm32: document audio of graph port for i2s
>    ASoC: dt-bindings: document audio of graph port for cs42l51
>    ARM: dts: stm32: fix i2s endpoint format property for stm32mp15xx-dkx
> 
>   .../devicetree/bindings/sound/cirrus,cs42l51.yaml     | 11 +++++++++++
>   .../devicetree/bindings/sound/st,stm32-i2s.yaml       | 11 +++++++++++
>   arch/arm/boot/dts/stm32mp15xx-dkx.dtsi                |  2 +-
>   3 files changed, 23 insertions(+), 1 deletion(-)
> 

Patch[3] applied on stm32-next.

Thanks
Alex

^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2023-06-08 11:57 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-06-06 11:56 [PATCH v2 0/3] ASoC: stm32: fix dtbs_check warnings Olivier Moysan
2023-06-06 11:56 ` [PATCH v2 1/3] ASoC: dt-bindings: stm32: document audio of graph port for i2s Olivier Moysan
2023-06-06 12:29   ` Krzysztof Kozlowski
2023-06-06 11:56 ` [PATCH v2 2/3] ASoC: dt-bindings: document audio of graph port for cs42l51 Olivier Moysan
2023-06-06 12:29   ` Krzysztof Kozlowski
2023-06-06 11:56 ` [PATCH v2 3/3] ARM: dts: stm32: fix i2s endpoint format property for stm32mp15xx-dkx Olivier Moysan
2023-06-07 20:17 ` (subset) [PATCH v2 0/3] ASoC: stm32: fix dtbs_check warnings Mark Brown
2023-06-08 11:57 ` Alexandre TORGUE

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).