* [PATCH] blk: wbt: remove unused parameter from wbt_should_throttle
@ 2021-01-25 11:27 chenlei0x
2021-01-26 20:13 ` Jens Axboe
0 siblings, 1 reply; 2+ messages in thread
From: chenlei0x @ 2021-01-25 11:27 UTC (permalink / raw)
To: chenlei0x, axboe, linux-block, linux-kernel; +Cc: Lei Chen
From: Lei Chen <lennychen@tencent.com>
The first parameter rwb is not used for this function.
So just remove it.
Signed-off-by: Lei Chen <lennychen@tencent.com>
---
block/blk-wbt.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/block/blk-wbt.c b/block/blk-wbt.c
index 0321ca8..42aed01 100644
--- a/block/blk-wbt.c
+++ b/block/blk-wbt.c
@@ -518,7 +518,7 @@ static void __wbt_wait(struct rq_wb *rwb, enum wbt_flags wb_acct,
rq_qos_wait(rqw, &data, wbt_inflight_cb, wbt_cleanup_cb);
}
-static inline bool wbt_should_throttle(struct rq_wb *rwb, struct bio *bio)
+static inline bool wbt_should_throttle(struct bio *bio)
{
switch (bio_op(bio)) {
case REQ_OP_WRITE:
@@ -545,7 +545,7 @@ static enum wbt_flags bio_to_wbt_flags(struct rq_wb *rwb, struct bio *bio)
if (bio_op(bio) == REQ_OP_READ) {
flags = WBT_READ;
- } else if (wbt_should_throttle(rwb, bio)) {
+ } else if (wbt_should_throttle(bio)) {
if (current_is_kswapd())
flags |= WBT_KSWAPD;
if (bio_op(bio) == REQ_OP_DISCARD)
--
1.8.3.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] blk: wbt: remove unused parameter from wbt_should_throttle
2021-01-25 11:27 [PATCH] blk: wbt: remove unused parameter from wbt_should_throttle chenlei0x
@ 2021-01-26 20:13 ` Jens Axboe
0 siblings, 0 replies; 2+ messages in thread
From: Jens Axboe @ 2021-01-26 20:13 UTC (permalink / raw)
To: chenlei0x, linux-block, linux-kernel; +Cc: Lei Chen
On 1/25/21 4:27 AM, chenlei0x@gmail.com wrote:
> From: Lei Chen <lennychen@tencent.com>
>
> The first parameter rwb is not used for this function.
> So just remove it.
Applied, thanks.
--
Jens Axboe
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-01-27 5:51 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-25 11:27 [PATCH] blk: wbt: remove unused parameter from wbt_should_throttle chenlei0x
2021-01-26 20:13 ` Jens Axboe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).