* Re: [PATCH v5 1/6] dt-bindings: arm: mediatek: mmsys: change compatible for MT8195
[not found] ` <20220927152704.12018-2-jason-jh.lin@mediatek.com>
@ 2022-09-28 8:10 ` Krzysztof Kozlowski
2022-09-28 8:15 ` AngeloGioacchino Del Regno
1 sibling, 0 replies; 8+ messages in thread
From: Krzysztof Kozlowski @ 2022-09-28 8:10 UTC (permalink / raw)
To: Jason-JH.Lin, Matthias Brugger, Chun-Kuang Hu, Rob Herring,
Krzysztof Kozlowski, AngeloGioacchino Del Regno
Cc: CK Hu, Rex-BC Chen, Singo Chang, Nancy Lin, dri-devel,
linux-mediatek, devicetree, linux-kernel, linux-arm-kernel,
Project_Global_Chrome_Upstream_Group
On 27/09/2022 17:26, Jason-JH.Lin wrote:
> For previous MediaTek SoCs, such as MT8173, there are 2 display HW
> pipelines binding to 1 mmsys with the same power domain, the same
> clock driver and the same mediatek-drm driver.
>
> For MT8195, VDOSYS0 and VDOSYS1 are 2 display HW pipelines binding to
> 2 different power domains, different clock drivers and different
> mediatek-drm drivers.
>
> Moreover, Hardware pipeline of VDOSYS0 has these components: COLOR,
> CCORR, AAL, GAMMA, DITHER. They are related to the PQ (Picture Quality)
> and they makes VDOSYS0 supports PQ function while they are not
> including in VDOSYS1.
>
> Hardware pipeline of VDOSYS1 has the component ETHDR (HDR related
> component). It makes VDOSYS1 supports the HDR function while it's not
> including in VDOSYS0.
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v5 3/6] soc: mediatek: add mtk-mmsys support for mt8195 vdosys0
[not found] ` <20220927152704.12018-4-jason-jh.lin@mediatek.com>
@ 2022-09-28 8:14 ` AngeloGioacchino Del Regno
[not found] ` <ac0a8cadf18291575d5fc798f0d6b99f5c3a4258.camel@mediatek.com>
0 siblings, 1 reply; 8+ messages in thread
From: AngeloGioacchino Del Regno @ 2022-09-28 8:14 UTC (permalink / raw)
To: Jason-JH.Lin, Matthias Brugger, Chun-Kuang Hu, Rob Herring,
Krzysztof Kozlowski
Cc: CK Hu, Rex-BC Chen, Singo Chang, Nancy Lin, dri-devel,
linux-mediatek, devicetree, linux-kernel, linux-arm-kernel,
Project_Global_Chrome_Upstream_Group
Il 27/09/22 17:27, Jason-JH.Lin ha scritto:
> 1. Add mt8195 driver data with compatible "mediatek-mt8195-vdosys0".
> 2. Add mt8195 routing table settings of vdosys0.
>
> Signed-off-by: Jason-JH.Lin <jason-jh.lin@mediatek.com>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v5 5/6] drm/mediatek: add mediatek-drm of vdosys0 support for mt8195
[not found] ` <20220927152704.12018-6-jason-jh.lin@mediatek.com>
@ 2022-09-28 8:14 ` AngeloGioacchino Del Regno
2022-11-11 11:42 ` Matthias Brugger
1 sibling, 0 replies; 8+ messages in thread
From: AngeloGioacchino Del Regno @ 2022-09-28 8:14 UTC (permalink / raw)
To: Jason-JH.Lin, Matthias Brugger, Chun-Kuang Hu, Rob Herring,
Krzysztof Kozlowski
Cc: CK Hu, Rex-BC Chen, Singo Chang, Nancy Lin, dri-devel,
linux-mediatek, devicetree, linux-kernel, linux-arm-kernel,
Project_Global_Chrome_Upstream_Group
Il 27/09/22 17:27, Jason-JH.Lin ha scritto:
> Add driver data of mt8195 vdosys0 to mediatek-drm and the sub driver.
>
> Signed-off-by: Jason-JH.Lin <jason-jh.lin@mediatek.com>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v5 1/6] dt-bindings: arm: mediatek: mmsys: change compatible for MT8195
[not found] ` <20220927152704.12018-2-jason-jh.lin@mediatek.com>
2022-09-28 8:10 ` [PATCH v5 1/6] dt-bindings: arm: mediatek: mmsys: change compatible for MT8195 Krzysztof Kozlowski
@ 2022-09-28 8:15 ` AngeloGioacchino Del Regno
1 sibling, 0 replies; 8+ messages in thread
From: AngeloGioacchino Del Regno @ 2022-09-28 8:15 UTC (permalink / raw)
To: Jason-JH.Lin, Matthias Brugger, Chun-Kuang Hu, Rob Herring,
Krzysztof Kozlowski
Cc: CK Hu, Rex-BC Chen, Singo Chang, Nancy Lin, dri-devel,
linux-mediatek, devicetree, linux-kernel, linux-arm-kernel,
Project_Global_Chrome_Upstream_Group
Il 27/09/22 17:26, Jason-JH.Lin ha scritto:
> For previous MediaTek SoCs, such as MT8173, there are 2 display HW
> pipelines binding to 1 mmsys with the same power domain, the same
> clock driver and the same mediatek-drm driver.
>
> For MT8195, VDOSYS0 and VDOSYS1 are 2 display HW pipelines binding to
> 2 different power domains, different clock drivers and different
> mediatek-drm drivers.
>
> Moreover, Hardware pipeline of VDOSYS0 has these components: COLOR,
> CCORR, AAL, GAMMA, DITHER. They are related to the PQ (Picture Quality)
> and they makes VDOSYS0 supports PQ function while they are not
> including in VDOSYS1.
>
> Hardware pipeline of VDOSYS1 has the component ETHDR (HDR related
> component). It makes VDOSYS1 supports the HDR function while it's not
> including in VDOSYS0.
>
> To summarize0:
> Only VDOSYS0 can support PQ adjustment.
> Only VDOSYS1 can support HDR adjustment.
>
> Therefore, we need to separate these two different mmsys hardwares to
> 2 different compatibles for MT8195.
>
> Fixes: 81c5a41d10b9 ("dt-bindings: arm: mediatek: mmsys: add mt8195 SoC binding")
> Signed-off-by: Jason-JH.Lin <jason-jh.lin@mediatek.com>
> Signed-off-by: Bo-Chen Chen <rex-bc.chen@mediatek.com>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v5 6/6] soc: mediatek: remove DDP_DOMPONENT_DITHER from enum
[not found] ` <20220927152704.12018-7-jason-jh.lin@mediatek.com>
@ 2022-11-09 11:25 ` Matthias Brugger
2022-11-10 13:42 ` Chun-Kuang Hu
0 siblings, 1 reply; 8+ messages in thread
From: Matthias Brugger @ 2022-11-09 11:25 UTC (permalink / raw)
To: Jason-JH.Lin, Chun-Kuang Hu, Rob Herring, Krzysztof Kozlowski,
AngeloGioacchino Del Regno
Cc: CK Hu, Rex-BC Chen, Singo Chang, Nancy Lin, dri-devel,
linux-mediatek, devicetree, linux-kernel, linux-arm-kernel,
Project_Global_Chrome_Upstream_Group
On 27/09/2022 17:27, Jason-JH.Lin wrote:
> After mmsys and drm change DITHER enum to DDP_COMPONENT_DITHER0,
> mmsys header can remove the useless DDP_COMPONENT_DITHER enum.
>
> Signed-off-by: Jason-JH.Lin <jason-jh.lin@mediatek.com>
> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> Reviewed-by: Rex-BC Chen <rex-bc.chen@mediatek.com>
> Acked-by: Matthias Brugger <matthias.bgg@gmail.com>
Chun-Kuan, I understand you will take this patch through your tree as it depends
on DRM changes. We can also sync so that I take it once you merged the rest of
the series. Having vdosys1 series around maybe that's better to avoid merge
problems.
Regards,
Matthias
> ---
> include/linux/soc/mediatek/mtk-mmsys.h | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/include/linux/soc/mediatek/mtk-mmsys.h b/include/linux/soc/mediatek/mtk-mmsys.h
> index d2b02bb43768..16ac0e5847f0 100644
> --- a/include/linux/soc/mediatek/mtk-mmsys.h
> +++ b/include/linux/soc/mediatek/mtk-mmsys.h
> @@ -16,8 +16,7 @@ enum mtk_ddp_comp_id {
> DDP_COMPONENT_CCORR,
> DDP_COMPONENT_COLOR0,
> DDP_COMPONENT_COLOR1,
> - DDP_COMPONENT_DITHER,
> - DDP_COMPONENT_DITHER0 = DDP_COMPONENT_DITHER,
> + DDP_COMPONENT_DITHER0,
> DDP_COMPONENT_DITHER1,
> DDP_COMPONENT_DP_INTF0,
> DDP_COMPONENT_DP_INTF1,
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v5 3/6] soc: mediatek: add mtk-mmsys support for mt8195 vdosys0
[not found] ` <ac0a8cadf18291575d5fc798f0d6b99f5c3a4258.camel@mediatek.com>
@ 2022-11-09 11:25 ` Matthias Brugger
0 siblings, 0 replies; 8+ messages in thread
From: Matthias Brugger @ 2022-11-09 11:25 UTC (permalink / raw)
To: Jason-JH.Lin, Chun-Kuang Hu, Rob Herring, Krzysztof Kozlowski,
AngeloGioacchino Del Regno
Cc: CK Hu, Rex-BC Chen, Singo Chang, Nancy Lin, dri-devel,
linux-mediatek, devicetree, linux-kernel, linux-arm-kernel,
Project_Global_Chrome_Upstream_Group
On 05/10/2022 09:08, Jason-JH.Lin wrote:
> Hi Matthias,
>
> Do you have any comment for this binding?
>
> Can you help us review the soc/mediatek related patches?
>
Patches 1-3 applied now. Sorry for the late answer.
Matthias
> Regards,
> Jason-JH.Lin
>
> On Wed, 2022-09-28 at 10:14 +0200, AngeloGioacchino Del Regno wrote:
>> Il 27/09/22 17:27, Jason-JH.Lin ha scritto:
>>> 1. Add mt8195 driver data with compatible "mediatek-mt8195-
>>> vdosys0".
>>> 2. Add mt8195 routing table settings of vdosys0.
>>>
>>> Signed-off-by: Jason-JH.Lin <jason-jh.lin@mediatek.com>
>>
>> Reviewed-by: AngeloGioacchino Del Regno <
>> angelogioacchino.delregno@collabora.com>
>>
>>
>>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v5 6/6] soc: mediatek: remove DDP_DOMPONENT_DITHER from enum
2022-11-09 11:25 ` [PATCH v5 6/6] soc: mediatek: remove DDP_DOMPONENT_DITHER from enum Matthias Brugger
@ 2022-11-10 13:42 ` Chun-Kuang Hu
0 siblings, 0 replies; 8+ messages in thread
From: Chun-Kuang Hu @ 2022-11-10 13:42 UTC (permalink / raw)
To: Matthias Brugger
Cc: Jason-JH.Lin, Chun-Kuang Hu, Rob Herring, Krzysztof Kozlowski,
AngeloGioacchino Del Regno, CK Hu, Rex-BC Chen, Singo Chang,
Nancy Lin, dri-devel, linux-mediatek, devicetree, linux-kernel,
linux-arm-kernel, Project_Global_Chrome_Upstream_Group
Matthias Brugger <matthias.bgg@gmail.com> 於 2022年11月9日 週三 晚上7:25寫道:
>
>
>
> On 27/09/2022 17:27, Jason-JH.Lin wrote:
> > After mmsys and drm change DITHER enum to DDP_COMPONENT_DITHER0,
> > mmsys header can remove the useless DDP_COMPONENT_DITHER enum.
> >
> > Signed-off-by: Jason-JH.Lin <jason-jh.lin@mediatek.com>
> > Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> > Reviewed-by: Rex-BC Chen <rex-bc.chen@mediatek.com>
> > Acked-by: Matthias Brugger <matthias.bgg@gmail.com>
>
> Chun-Kuan, I understand you will take this patch through your tree as it depends
> on DRM changes. We can also sync so that I take it once you merged the rest of
> the series. Having vdosys1 series around maybe that's better to avoid merge
> problems.
Hi, Matthias:
I do not hurry to merge patches. To prevent merge conflict, let's
merge step by step.
The drm patches depend on binding document patch, so I would wait for
binding document merged.
After drm patch merged, you could merge this patch.
vdosys1 patches depend on vdosys0 patches, so just let it around.
Regards,
Chun-Kuang.
>
> Regards,
> Matthias
>
> > ---
> > include/linux/soc/mediatek/mtk-mmsys.h | 3 +--
> > 1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > diff --git a/include/linux/soc/mediatek/mtk-mmsys.h b/include/linux/soc/mediatek/mtk-mmsys.h
> > index d2b02bb43768..16ac0e5847f0 100644
> > --- a/include/linux/soc/mediatek/mtk-mmsys.h
> > +++ b/include/linux/soc/mediatek/mtk-mmsys.h
> > @@ -16,8 +16,7 @@ enum mtk_ddp_comp_id {
> > DDP_COMPONENT_CCORR,
> > DDP_COMPONENT_COLOR0,
> > DDP_COMPONENT_COLOR1,
> > - DDP_COMPONENT_DITHER,
> > - DDP_COMPONENT_DITHER0 = DDP_COMPONENT_DITHER,
> > + DDP_COMPONENT_DITHER0,
> > DDP_COMPONENT_DITHER1,
> > DDP_COMPONENT_DP_INTF0,
> > DDP_COMPONENT_DP_INTF1,
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v5 5/6] drm/mediatek: add mediatek-drm of vdosys0 support for mt8195
[not found] ` <20220927152704.12018-6-jason-jh.lin@mediatek.com>
2022-09-28 8:14 ` [PATCH v5 5/6] drm/mediatek: add mediatek-drm of vdosys0 support for mt8195 AngeloGioacchino Del Regno
@ 2022-11-11 11:42 ` Matthias Brugger
1 sibling, 0 replies; 8+ messages in thread
From: Matthias Brugger @ 2022-11-11 11:42 UTC (permalink / raw)
To: Jason-JH.Lin, Chun-Kuang Hu, Rob Herring, Krzysztof Kozlowski,
AngeloGioacchino Del Regno
Cc: CK Hu, Rex-BC Chen, Singo Chang, Nancy Lin, dri-devel,
linux-mediatek, devicetree, linux-kernel, linux-arm-kernel,
Project_Global_Chrome_Upstream_Group
On 27/09/2022 17:27, Jason-JH.Lin wrote:
> Add driver data of mt8195 vdosys0 to mediatek-drm and the sub driver.
>
> Signed-off-by: Jason-JH.Lin <jason-jh.lin@mediatek.com>
> ---
> drivers/gpu/drm/mediatek/mtk_disp_rdma.c | 6 +++++
> drivers/gpu/drm/mediatek/mtk_drm_drv.c | 28 ++++++++++++++++++++++++
> 2 files changed, 34 insertions(+)
>
> diff --git a/drivers/gpu/drm/mediatek/mtk_disp_rdma.c b/drivers/gpu/drm/mediatek/mtk_disp_rdma.c
> index 2cb90466798c..66cdd0bc1311 100644
> --- a/drivers/gpu/drm/mediatek/mtk_disp_rdma.c
> +++ b/drivers/gpu/drm/mediatek/mtk_disp_rdma.c
> @@ -374,6 +374,10 @@ static const struct mtk_disp_rdma_data mt8192_rdma_driver_data = {
> .fifo_size = 5 * SZ_1K,
> };
>
> +static const struct mtk_disp_rdma_data mt8195_rdma_driver_data = {
> + .fifo_size = 1920,
> +};
> +
> static const struct of_device_id mtk_disp_rdma_driver_dt_match[] = {
> { .compatible = "mediatek,mt2701-disp-rdma",
> .data = &mt2701_rdma_driver_data},
> @@ -383,6 +387,8 @@ static const struct of_device_id mtk_disp_rdma_driver_dt_match[] = {
> .data = &mt8183_rdma_driver_data},
> { .compatible = "mediatek,mt8192-disp-rdma",
> .data = &mt8192_rdma_driver_data},
> + { .compatible = "mediatek,mt8195-disp-rdma",
> + .data = &mt8195_rdma_driver_data},
> {},
> };
> MODULE_DEVICE_TABLE(of, mtk_disp_rdma_driver_dt_match);
> diff --git a/drivers/gpu/drm/mediatek/mtk_drm_drv.c b/drivers/gpu/drm/mediatek/mtk_drm_drv.c
> index adc9a4f4085b..9b5a7a7ddde0 100644
> --- a/drivers/gpu/drm/mediatek/mtk_drm_drv.c
> +++ b/drivers/gpu/drm/mediatek/mtk_drm_drv.c
> @@ -195,6 +195,19 @@ static const enum mtk_ddp_comp_id mt8192_mtk_ddp_ext[] = {
> DDP_COMPONENT_DPI0,
> };
>
> +static const enum mtk_ddp_comp_id mt8195_mtk_ddp_main[] = {
> + DDP_COMPONENT_OVL0,
> + DDP_COMPONENT_RDMA0,
> + DDP_COMPONENT_COLOR0,
> + DDP_COMPONENT_CCORR,
> + DDP_COMPONENT_AAL0,
> + DDP_COMPONENT_GAMMA,
> + DDP_COMPONENT_DITHER0,
> + DDP_COMPONENT_DSC0,
> + DDP_COMPONENT_MERGE0,
> + DDP_COMPONENT_DP_INTF0,
> +};
> +
> static const struct mtk_mmsys_driver_data mt2701_mmsys_driver_data = {
> .main_path = mt2701_mtk_ddp_main,
> .main_len = ARRAY_SIZE(mt2701_mtk_ddp_main),
> @@ -253,6 +266,11 @@ static const struct mtk_mmsys_driver_data mt8192_mmsys_driver_data = {
> .ext_len = ARRAY_SIZE(mt8192_mtk_ddp_ext),
> };
>
> +static const struct mtk_mmsys_driver_data mt8195_vdosys0_driver_data = {
> + .main_path = mt8195_mtk_ddp_main,
> + .main_len = ARRAY_SIZE(mt8195_mtk_ddp_main),
> +};
> +
> static int mtk_drm_kms_init(struct drm_device *drm)
> {
> struct mtk_drm_private *private = drm->dev_private;
> @@ -470,12 +488,16 @@ static const struct of_device_id mtk_ddp_comp_dt_ids[] = {
> .data = (void *)MTK_DISP_DITHER },
> { .compatible = "mediatek,mt8183-disp-dither",
> .data = (void *)MTK_DISP_DITHER },
> + { .compatible = "mediatek,mt8195-disp-dsc",
> + .data = (void *)MTK_DISP_DSC },
> { .compatible = "mediatek,mt8167-disp-gamma",
> .data = (void *)MTK_DISP_GAMMA, },
> { .compatible = "mediatek,mt8173-disp-gamma",
> .data = (void *)MTK_DISP_GAMMA, },
> { .compatible = "mediatek,mt8183-disp-gamma",
> .data = (void *)MTK_DISP_GAMMA, },
> + { .compatible = "mediatek,mt8195-disp-merge",
> + .data = (void *)MTK_DISP_MERGE },
> { .compatible = "mediatek,mt2701-disp-mutex",
> .data = (void *)MTK_DISP_MUTEX },
> { .compatible = "mediatek,mt2712-disp-mutex",
> @@ -490,6 +512,8 @@ static const struct of_device_id mtk_ddp_comp_dt_ids[] = {
> .data = (void *)MTK_DISP_MUTEX },
> { .compatible = "mediatek,mt8192-disp-mutex",
> .data = (void *)MTK_DISP_MUTEX },
> + { .compatible = "mediatek,mt8195-disp-mutex",
> + .data = (void *)MTK_DISP_MUTEX },
> { .compatible = "mediatek,mt8173-disp-od",
> .data = (void *)MTK_DISP_OD },
> { .compatible = "mediatek,mt2701-disp-ovl",
> @@ -524,6 +548,8 @@ static const struct of_device_id mtk_ddp_comp_dt_ids[] = {
> .data = (void *)MTK_DISP_RDMA },
> { .compatible = "mediatek,mt8192-disp-rdma",
> .data = (void *)MTK_DISP_RDMA },
> + { .compatible = "mediatek,mt8195-disp-rdma",
> + .data = (void *)MTK_DISP_RDMA },
> { .compatible = "mediatek,mt8173-disp-ufoe",
> .data = (void *)MTK_DISP_UFOE },
> { .compatible = "mediatek,mt8173-disp-wdma",
> @@ -568,6 +594,8 @@ static const struct of_device_id mtk_drm_of_ids[] = {
> .data = &mt8186_mmsys_driver_data},
> { .compatible = "mediatek,mt8192-mmsys",
> .data = &mt8192_mmsys_driver_data},
> + { .compatible = "mediatek,mt8195-vdosys0",
> + .data = &mt8195_vdosys0_driver_data},
To make this work with older device tree, we will need to provide the same
driver data to the old compatible:
+ { .compatible = "mediatek,,mt8195-mmsys",
+ .data = &mt8195_vdosys0_driver_data},
+ }
Regards,
Matthias
> { }
> };
> MODULE_DEVICE_TABLE(of, mtk_drm_of_ids);
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2022-11-11 11:42 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20220927152704.12018-1-jason-jh.lin@mediatek.com>
[not found] ` <20220927152704.12018-2-jason-jh.lin@mediatek.com>
2022-09-28 8:10 ` [PATCH v5 1/6] dt-bindings: arm: mediatek: mmsys: change compatible for MT8195 Krzysztof Kozlowski
2022-09-28 8:15 ` AngeloGioacchino Del Regno
[not found] ` <20220927152704.12018-4-jason-jh.lin@mediatek.com>
2022-09-28 8:14 ` [PATCH v5 3/6] soc: mediatek: add mtk-mmsys support for mt8195 vdosys0 AngeloGioacchino Del Regno
[not found] ` <ac0a8cadf18291575d5fc798f0d6b99f5c3a4258.camel@mediatek.com>
2022-11-09 11:25 ` Matthias Brugger
[not found] ` <20220927152704.12018-6-jason-jh.lin@mediatek.com>
2022-09-28 8:14 ` [PATCH v5 5/6] drm/mediatek: add mediatek-drm of vdosys0 support for mt8195 AngeloGioacchino Del Regno
2022-11-11 11:42 ` Matthias Brugger
[not found] ` <20220927152704.12018-7-jason-jh.lin@mediatek.com>
2022-11-09 11:25 ` [PATCH v5 6/6] soc: mediatek: remove DDP_DOMPONENT_DITHER from enum Matthias Brugger
2022-11-10 13:42 ` Chun-Kuang Hu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).