From: Pkshih <pkshih@realtek.com>
To: "s.hauer@pengutronix.de" <s.hauer@pengutronix.de>
Cc: "johannes@sipsolutions.net" <johannes@sipsolutions.net>,
"kernel@pengutronix.de" <kernel@pengutronix.de>,
"neojou@gmail.com" <neojou@gmail.com>,
"kvalo@kernel.org" <kvalo@kernel.org>,
"tony0620emma@gmail.com" <tony0620emma@gmail.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"martin.blumenstingl@googlemail.com"
<martin.blumenstingl@googlemail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux@ulli-kroll.de" <linux@ulli-kroll.de>,
"neo_jou@realtek.com" <neo_jou@realtek.com>
Subject: Re: [PATCH 06/10] rtw88: Add common USB chip support
Date: Fri, 20 May 2022 09:23:11 +0000 [thread overview]
Message-ID: <a0c7fb57d0e9c1a36f328f4e523643ba6009630f.camel@realtek.com> (raw)
In-Reply-To: <20220520085156.GE25578@pengutronix.de>
On Fri, 2022-05-20 at 10:51 +0200, s.hauer@pengutronix.de wrote:
> On Fri, May 20, 2022 at 07:39:03AM +0000, Pkshih wrote:
> > On Wed, 2022-05-18 at 10:23 +0200, Sascha Hauer wrote:
> > > Add the common bits and pieces to add USB support to the RTW88 driver.
> > > This is based on https://github.com/ulli-kroll/rtw88-usb.git which
> > > itself is first written by Neo Jou.
> > >
> > > Signed-off-by: neo_jou <neo_jou@realtek.com>
> > > Signed-off-by: Hans Ulli Kroll <linux@ulli-kroll.de>
> > > Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
> > > ---
> > > drivers/net/wireless/realtek/rtw88/Kconfig | 3 +
> > > drivers/net/wireless/realtek/rtw88/Makefile | 2 +
> > > drivers/net/wireless/realtek/rtw88/mac.c | 3 +
> > > drivers/net/wireless/realtek/rtw88/main.c | 5 +
> > > drivers/net/wireless/realtek/rtw88/main.h | 4 +
> > > drivers/net/wireless/realtek/rtw88/reg.h | 1 +
> > > drivers/net/wireless/realtek/rtw88/tx.h | 31 +
> > > drivers/net/wireless/realtek/rtw88/usb.c | 1051 +++++++++++++++++++
> > > drivers/net/wireless/realtek/rtw88/usb.h | 109 ++
> > > 9 files changed, 1209 insertions(+)
> > > create mode 100644 drivers/net/wireless/realtek/rtw88/usb.c
> > > create mode 100644 drivers/net/wireless/realtek/rtw88/usb.h
> > >
> >
> > > +}
> > > +
> > > +static void rtw_usb_cancel_rx_bufs(struct rtw_usb *rtwusb)
> > > +{
> > > + struct rx_usb_ctrl_block *rxcb;
> > > + unsigned long flags;
> > > +
> > > + spin_lock_irqsave(&rtwusb->rx_data_list_lock, flags);
> > > +
> > > + while (true) {
> > > + rxcb = list_first_entry_or_null(&rtwusb->rx_data_used,
> > > + struct rx_usb_ctrl_block, list);
> > > +
> > > + spin_unlock_irqrestore(&rtwusb->rx_data_list_lock, flags);
> > > +
> > > + if (!rxcb)
> > > + break;
> > > +
> > > + usb_kill_urb(rxcb->rx_urb);
> > > +
> > > + spin_lock_irqsave(&rtwusb->rx_data_list_lock, flags);
> > > + list_move(&rxcb->list, &rtwusb->rx_data_free);
> > > + }
> > > +}
> >
> > The spin_lock pairs are not intuitive.
> > Can we change this chunk to
> >
> > while (true) {
> > spin_lock();
> > rxcb = list_first_entry_or_null();
> > spin_unlock()
> >
> > if (!rxcb)
> > return;
> >
> > usb_free_urb();
> >
> > spin_lock();
> > list_del();
> > spin_unlock();
> > }
> >
> > The drawback is lock/unlock twice in single loop.
>
> Yes, that's why I did it the way I did ;)
>
> How about:
>
> while (true) {
> unsigned long flags;
>
> spin_lock_irqsave(&rtwusb->rx_data_list_lock, flags);
>
> rxcb = list_first_entry_or_null(&rtwusb->rx_data_free,
> struct rx_usb_ctrl_block, list);
> if (rxcb)
> list_del(&rxcb->list);
>
> spin_unlock_irqrestore(&rtwusb->rx_data_list_lock, flags);
>
> if (!rxcb)
> break;
>
> usb_free_urb(rxcb->rx_urb);
> }
>
With the new one, I can easily check spin_lock/_unlock is paired, so
I vote it.
--
Ping-Ke
next prev parent reply other threads:[~2022-05-20 9:23 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-18 8:23 [PATCH 00/10] RTW88: Add support for USB variants Sascha Hauer
2022-05-18 8:23 ` [PATCH 01/10] rtw88: Call rtw_fw_beacon_filter_config() with rtwdev->mutex held Sascha Hauer
2022-05-18 8:23 ` [PATCH 02/10] rtw88: Drop rf_lock Sascha Hauer
2022-05-20 3:49 ` Pkshih
2022-05-20 6:54 ` s.hauer
2022-05-18 8:23 ` [PATCH 03/10] rtw88: Drop h2c.lock Sascha Hauer
2022-05-18 8:23 ` [PATCH 04/10] rtw88: Drop coex mutex Sascha Hauer
2022-05-18 8:23 ` [PATCH 05/10] rtw88: Do not access registers while atomic Sascha Hauer
2022-05-20 6:06 ` Pkshih
2022-05-20 7:07 ` s.hauer
2022-05-20 17:32 ` Larry Finger
2022-05-18 8:23 ` [PATCH 06/10] rtw88: Add common USB chip support Sascha Hauer
2022-05-18 8:32 ` Sascha Hauer
2022-05-18 8:34 ` Johannes Berg
2022-05-19 13:58 ` Sascha Hauer
2022-05-20 7:39 ` Pkshih
2022-05-20 8:51 ` s.hauer
2022-05-20 9:23 ` Pkshih [this message]
2022-05-20 18:33 ` Larry Finger
2022-05-23 4:07 ` Hans Ulli Kroll
2022-05-18 8:23 ` [PATCH 07/10] rtw88: Add rtw8723du chipset support Sascha Hauer
2022-05-18 16:55 ` kernel test robot
2022-05-20 7:47 ` Pkshih
2022-05-20 8:16 ` s.hauer
2022-05-30 6:34 ` Icenowy Zheng
2022-05-18 8:23 ` [PATCH 08/10] rtw88: Add rtw8821cu " Sascha Hauer
2022-05-20 7:56 ` Pkshih
2022-05-18 8:23 ` [PATCH 09/10] rtw88: Add rtw8822bu " Sascha Hauer
2022-05-20 7:58 ` Pkshih
2022-05-23 11:56 ` Rin Cat (鈴猫)
2022-05-23 12:34 ` Sascha Hauer
2022-05-18 8:23 ` [PATCH 10/10] rtw88: Add rtw8822cu " Sascha Hauer
2022-05-20 8:03 ` Pkshih
2022-05-20 8:56 ` s.hauer
2022-05-23 4:07 ` [PATCH 00/10] RTW88: Add support for USB variants Hans Ulli Kroll
2022-05-23 6:53 ` Sascha Hauer
2022-05-23 11:39 ` Ping-Ke Shih
2022-05-24 6:54 ` s.hauer
2022-05-23 10:13 ` Sascha Hauer
2022-05-30 9:25 ` Kalle Valo
2022-05-30 9:52 ` Sascha Hauer
2022-05-30 10:07 ` Kalle Valo
2022-05-30 10:16 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a0c7fb57d0e9c1a36f328f4e523643ba6009630f.camel@realtek.com \
--to=pkshih@realtek.com \
--cc=johannes@sipsolutions.net \
--cc=kernel@pengutronix.de \
--cc=kvalo@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linux@ulli-kroll.de \
--cc=martin.blumenstingl@googlemail.com \
--cc=neo_jou@realtek.com \
--cc=neojou@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=tony0620emma@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).