* [PATCH] comedi: remove unused dma_chain_flag_bits function
@ 2023-03-21 12:14 Tom Rix
2023-03-21 14:18 ` Ian Abbott
0 siblings, 1 reply; 2+ messages in thread
From: Tom Rix @ 2023-03-21 12:14 UTC (permalink / raw)
To: abbotti, hsweeten, nathan, ndesaulniers; +Cc: linux-kernel, llvm, Tom Rix
clang with W=1 reports
drivers/comedi/drivers/cb_pcidas64.c:377:28: error: unused function
'dma_chain_flag_bits' [-Werror,-Wunused-function]
static inline unsigned int dma_chain_flag_bits(u16 prepost_bits)
^
This function is not used, so remove it.
Signed-off-by: Tom Rix <trix@redhat.com>
---
drivers/comedi/drivers/cb_pcidas64.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/drivers/comedi/drivers/cb_pcidas64.c b/drivers/comedi/drivers/cb_pcidas64.c
index ca6038a25f26..59390b23fa81 100644
--- a/drivers/comedi/drivers/cb_pcidas64.c
+++ b/drivers/comedi/drivers/cb_pcidas64.c
@@ -374,11 +374,6 @@ static inline u16 pipe_full_bits(u16 hw_status_bits)
return (hw_status_bits >> 10) & 0x3;
};
-static inline unsigned int dma_chain_flag_bits(u16 prepost_bits)
-{
- return (prepost_bits >> 6) & 0x3;
-}
-
static inline unsigned int adc_upper_read_ptr_code(u16 prepost_bits)
{
return (prepost_bits >> 12) & 0x3;
--
2.27.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] comedi: remove unused dma_chain_flag_bits function
2023-03-21 12:14 [PATCH] comedi: remove unused dma_chain_flag_bits function Tom Rix
@ 2023-03-21 14:18 ` Ian Abbott
0 siblings, 0 replies; 2+ messages in thread
From: Ian Abbott @ 2023-03-21 14:18 UTC (permalink / raw)
To: Tom Rix, hsweeten, nathan, ndesaulniers; +Cc: linux-kernel, llvm
On 21/03/2023 12:14, Tom Rix wrote:
> clang with W=1 reports
> drivers/comedi/drivers/cb_pcidas64.c:377:28: error: unused function
> 'dma_chain_flag_bits' [-Werror,-Wunused-function]
> static inline unsigned int dma_chain_flag_bits(u16 prepost_bits)
> ^
> This function is not used, so remove it.
>
> Signed-off-by: Tom Rix <trix@redhat.com>
> ---
> drivers/comedi/drivers/cb_pcidas64.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/drivers/comedi/drivers/cb_pcidas64.c b/drivers/comedi/drivers/cb_pcidas64.c
> index ca6038a25f26..59390b23fa81 100644
> --- a/drivers/comedi/drivers/cb_pcidas64.c
> +++ b/drivers/comedi/drivers/cb_pcidas64.c
> @@ -374,11 +374,6 @@ static inline u16 pipe_full_bits(u16 hw_status_bits)
> return (hw_status_bits >> 10) & 0x3;
> };
>
> -static inline unsigned int dma_chain_flag_bits(u16 prepost_bits)
> -{
> - return (prepost_bits >> 6) & 0x3;
> -}
> -
> static inline unsigned int adc_upper_read_ptr_code(u16 prepost_bits)
> {
> return (prepost_bits >> 12) & 0x3;
Looks OK, thanks!
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
--
-=( Ian Abbott <abbotti@mev.co.uk> || MEV Ltd. is a company )=-
-=( registered in England & Wales. Regd. number: 02862268. )=-
-=( Regd. addr.: S11 & 12 Building 67, Europa Business Park, )=-
-=( Bird Hall Lane, STOCKPORT, SK3 0XA, UK. || www.mev.co.uk )=-
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-03-21 14:28 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-21 12:14 [PATCH] comedi: remove unused dma_chain_flag_bits function Tom Rix
2023-03-21 14:18 ` Ian Abbott
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).