From: Philipp Zabel <p.zabel@pengutronix.de>
To: "Lad, Prabhakar" <prabhakar.csengg@gmail.com>,
Geert Uytterhoeven <geert+renesas@glider.be>
Cc: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>,
Rob Herring <robh+dt@kernel.org>,
Fabrizio Castro <fabrizio.castro.jz@renesas.com>,
Wolfgang Grandegger <wg@grandegger.com>,
Marc Kleine-Budde <mkl@pengutronix.de>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
linux-can@vger.kernel.org, netdev <netdev@vger.kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
linux-clk <linux-clk@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
Biju Das <biju.das.jz@bp.renesas.com>
Subject: Re: [PATCH v2 1/5] dt-bindings: net: can: renesas,rcar-canfd: Document RZ/G2L SoC
Date: Tue, 20 Jul 2021 18:33:31 +0200 [thread overview]
Message-ID: <a129d6ea0b2706d290418db5bfe4a5f3f274dce1.camel@pengutronix.de> (raw)
In-Reply-To: <CA+V-a8v-54QXtcT-gPy5vj9drqZ6Ntr0-3j=42Dedi-kojNtXQ@mail.gmail.com>
Hi Prabhakar,
On Tue, 2021-07-20 at 15:31 +0100, Lad, Prabhakar wrote:
> Hi Philipp,
>
> Thank you for the review.
>
> On Tue, Jul 20, 2021 at 11:22 AM Philipp Zabel <p.zabel@pengutronix.de> wrote:
> > Hi Lad,
Sorry I mixed up your name.
> > On Mon, 2021-07-19 at 15:38 +0100, Lad Prabhakar wrote:
> > > Add CANFD binding documentation for Renesas RZ/G2L SoC.
> > >
> > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> > > Reviewed-by: Biju Das <biju.das.jz@bp.renesas.com>
> > > ---
> > > .../bindings/net/can/renesas,rcar-canfd.yaml | 66 +++++++++++++++++--
> > > 1 file changed, 60 insertions(+), 6 deletions(-)
> > >
> > > diff --git a/Documentation/devicetree/bindings/net/can/renesas,rcar-canfd.yaml b/Documentation/devicetree/bindings/net/can/renesas,rcar-canfd.yaml
> > > index 0b33ba9ccb47..4fb6dd370904 100644
> > > --- a/Documentation/devicetree/bindings/net/can/renesas,rcar-canfd.yaml
> > > +++ b/Documentation/devicetree/bindings/net/can/renesas,rcar-canfd.yaml
> > > @@ -30,13 +30,15 @@ properties:
> > > - renesas,r8a77995-canfd # R-Car D3
> > > - const: renesas,rcar-gen3-canfd # R-Car Gen3 and RZ/G2
> > >
> > > + - items:
> > > + - enum:
> > > + - renesas,r9a07g044-canfd # RZ/G2{L,LC}
> > > + - const: renesas,rzg2l-canfd # RZ/G2L family
> > > +
> > > reg:
> > > maxItems: 1
> > >
> > > - interrupts:
> > > - items:
> > > - - description: Channel interrupt
> > > - - description: Global interrupt
> > > + interrupts: true
> > >
> > > clocks:
> > > maxItems: 3
> > > @@ -50,8 +52,7 @@ properties:
> > > power-domains:
> > > maxItems: 1
> > >
> > > - resets:
> > > - maxItems: 1
> > > + resets: true
> > >
> > > renesas,no-can-fd:
> > > $ref: /schemas/types.yaml#/definitions/flag
> > > @@ -91,6 +92,59 @@ required:
> > > - channel0
> > > - channel1
> > >
> > > +if:
> > > + properties:
> > > + compatible:
> > > + contains:
> > > + enum:
> > > + - renesas,rzg2l-canfd
> > > +then:
> > > + properties:
> > > + interrupts:
> > > + items:
> > > + - description: CAN global error interrupt
> > > + - description: CAN receive FIFO interrupt
> > > + - description: CAN0 error interrupt
> > > + - description: CAN0 transmit interrupt
> > > + - description: CAN0 transmit/receive FIFO receive completion interrupt
> > > + - description: CAN1 error interrupt
> > > + - description: CAN1 transmit interrupt
> > > + - description: CAN1 transmit/receive FIFO receive completion interrupt
> > > +
> > > + interrupt-names:
> > > + items:
> > > + - const: g_error
> > > + - const: g_rx_fifo
> > > + - const: can0_error
> > > + - const: can0_tx
> > > + - const: can0_tx_rx_fifo_receive_completion
> > > + - const: can1_error
> > > + - const: can1_tx
> > > + - const: can1_tx_rx_fifo_receive_completion
> > > +
> > > + resets:
> > > + items:
> > > + - description: CANFD_RSTP_N
> > > + - description: CANFD_RSTC_N
> >
> > Do you know what the "P" and "C" stands for? It would be nice if the
> > description could tell us what the reset lines are used for.
> >
> unfortunately the HW manual does not mention anything about "P" and "C" :(
Yes, unfortunately this is all too common.
> > I would prefer if you used these names (or shortened versions, for
> > example "rstp_n", "rstc_n") as "reset-names" and let the driver
> > reference the resets by name instead of by index.
> >
> OK will do that and maxItems:2 for resets.
>
> @Geert, for R-Car Gen3 does "canfd_rst" (as it's a module reset)
> sounds good for reset-names? Or do you have any other suggestions?
I agree with Geert here. Assuming no second reset will be discovered for
R-Car Gen3 later, there is no need to invent a name.
regards
Philipp
next prev parent reply other threads:[~2021-07-20 16:36 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-19 14:38 [PATCH v2 0/5] Renesas RZ/G2L CANFD support Lad Prabhakar
2021-07-19 14:38 ` [PATCH v2 1/5] dt-bindings: net: can: renesas,rcar-canfd: Document RZ/G2L SoC Lad Prabhakar
2021-07-20 10:20 ` Geert Uytterhoeven
2021-07-20 14:37 ` Lad, Prabhakar
2021-07-20 10:22 ` Philipp Zabel
2021-07-20 14:31 ` Lad, Prabhakar
2021-07-20 15:11 ` Geert Uytterhoeven
2021-07-20 15:56 ` Lad, Prabhakar
2021-07-20 16:33 ` Philipp Zabel
2021-07-20 16:33 ` Philipp Zabel [this message]
2021-07-19 14:38 ` [PATCH v2 2/5] can: rcar_canfd: Add support for RZ/G2L family Lad Prabhakar
2021-07-20 10:23 ` Philipp Zabel
2021-07-20 14:57 ` Lad, Prabhakar
2021-07-20 10:30 ` Geert Uytterhoeven
2021-07-20 15:15 ` Lad, Prabhakar
2021-07-19 14:38 ` [PATCH v2 3/5] dt-bindings: clk: r9a07g044-cpg: Add entry for P0_DIV2 core clock Lad Prabhakar
2021-07-20 10:39 ` Geert Uytterhoeven
2021-07-19 14:38 ` [PATCH v2 4/5] clk: renesas: r9a07g044-cpg: Add entry for fixed clock P0_DIV2 Lad Prabhakar
2021-07-20 10:39 ` Geert Uytterhoeven
2021-07-19 14:38 ` [PATCH v2 5/5] arm64: dts: renesas: r9a07g044: Add CANFD node Lad Prabhakar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a129d6ea0b2706d290418db5bfe4a5f3f274dce1.camel@pengutronix.de \
--to=p.zabel@pengutronix.de \
--cc=biju.das.jz@bp.renesas.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=fabrizio.castro.jz@renesas.com \
--cc=geert+renesas@glider.be \
--cc=kuba@kernel.org \
--cc=linux-can@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=mkl@pengutronix.de \
--cc=mturquette@baylibre.com \
--cc=netdev@vger.kernel.org \
--cc=prabhakar.csengg@gmail.com \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).