* [PATCH] rsxx: remove extraneous 'const' qualifier
@ 2021-03-23 21:57 Arnd Bergmann
2021-03-24 12:56 ` Jens Axboe
0 siblings, 1 reply; 2+ messages in thread
From: Arnd Bergmann @ 2021-03-23 21:57 UTC (permalink / raw)
To: Joshua Morris, Philip Kelleher, Jens Axboe
Cc: Arnd Bergmann, Nick Desaulniers, Nathan Chancellor,
Gustavo A. R. Silva, Philip J Kelleher, linux-block,
linux-kernel, clang-built-linux
From: Arnd Bergmann <arnd@arndb.de>
The returned string from rsxx_card_state_to_str is 'const',
but the other qualifier doesn't change anything here except
causing a warning with 'clang -Wextra':
drivers/block/rsxx/core.c:393:21: warning: 'const' type qualifier on return type has no effect [-Wignored-qualifiers]
static const char * const rsxx_card_state_to_str(unsigned int state)
Fixes: f37912039eb0 ("block: IBM RamSan 70/80 trivial changes.")
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/block/rsxx/core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/block/rsxx/core.c b/drivers/block/rsxx/core.c
index 5ac1881396af..813b0a554d4a 100644
--- a/drivers/block/rsxx/core.c
+++ b/drivers/block/rsxx/core.c
@@ -392,7 +392,7 @@ static irqreturn_t rsxx_isr(int irq, void *pdata)
}
/*----------------- Card Event Handler -------------------*/
-static const char * const rsxx_card_state_to_str(unsigned int state)
+static const char *rsxx_card_state_to_str(unsigned int state)
{
static const char * const state_strings[] = {
"Unknown", "Shutdown", "Starting", "Formatting",
--
2.29.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] rsxx: remove extraneous 'const' qualifier
2021-03-23 21:57 [PATCH] rsxx: remove extraneous 'const' qualifier Arnd Bergmann
@ 2021-03-24 12:56 ` Jens Axboe
0 siblings, 0 replies; 2+ messages in thread
From: Jens Axboe @ 2021-03-24 12:56 UTC (permalink / raw)
To: Arnd Bergmann, Joshua Morris, Philip Kelleher
Cc: Arnd Bergmann, Nick Desaulniers, Nathan Chancellor,
Gustavo A. R. Silva, Philip J Kelleher, linux-block,
linux-kernel, clang-built-linux
On 3/23/21 3:57 PM, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> The returned string from rsxx_card_state_to_str is 'const',
> but the other qualifier doesn't change anything here except
> causing a warning with 'clang -Wextra':
>
> drivers/block/rsxx/core.c:393:21: warning: 'const' type qualifier on return type has no effect [-Wignored-qualifiers]
> static const char * const rsxx_card_state_to_str(unsigned int state)
Applied, thanks Arnd.
--
Jens Axboe
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-03-24 12:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-23 21:57 [PATCH] rsxx: remove extraneous 'const' qualifier Arnd Bergmann
2021-03-24 12:56 ` Jens Axboe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).