* [PATCH v2] drm/fb-helper: improve DRM fbdev emulation device names
@ 2021-05-25 15:13 Javier Martinez Canillas
2021-05-26 7:20 ` Thomas Zimmermann
2021-05-26 19:24 ` Thomas Zimmermann
0 siblings, 2 replies; 3+ messages in thread
From: Javier Martinez Canillas @ 2021-05-25 15:13 UTC (permalink / raw)
To: linux-kernel
Cc: Thomas Zimmermann, Javier Martinez Canillas, Daniel Vetter,
David Airlie, Maarten Lankhorst, Maxime Ripard, dri-devel
Framebuffer devices that are registered by DRM drivers for fbdev emulation
have a "drmfb" suffix in their name. But makes them to be quite confusing
for drivers that already have "drm" in their name:
$ cat /proc/fb
0 rockchipdrmdrmfb
$ cat /proc/fb
0 simpledrmdrmfb
Also, there isn't a lot of value in adding these "drmfb" suffices to their
names, since users shouldn't really care if the FB devices were registered
by a real fbdev driver or a DRM driver using the fbdev emulation.
What programs should be interested about is if there's a DRM device, and
there are better ways to query that info than reading this procfs entry.
So let's just remove the suffix, which leads to much better device names:
$ cat /proc/fb
0 rockchipdrm
$ cat /proc/fb
0 simpledrm
Suggested-by: Thomas Zimmermann <tzimmermann@suse.de>
Signed-off-by: Javier Martinez Canillas <javierm@redhat.com>
---
Changes in v2:
- Just remove the "drmfb" suffix instead of using a different one (tzimmermann).
drivers/gpu/drm/drm_fb_helper.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/drm_fb_helper.c b/drivers/gpu/drm/drm_fb_helper.c
index f6baa204612..d77a24507d3 100644
--- a/drivers/gpu/drm/drm_fb_helper.c
+++ b/drivers/gpu/drm/drm_fb_helper.c
@@ -1737,7 +1737,7 @@ void drm_fb_helper_fill_info(struct fb_info *info,
sizes->fb_width, sizes->fb_height);
info->par = fb_helper;
- snprintf(info->fix.id, sizeof(info->fix.id), "%sdrmfb",
+ snprintf(info->fix.id, sizeof(info->fix.id), "%s",
fb_helper->dev->driver->name);
}
--
2.31.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] drm/fb-helper: improve DRM fbdev emulation device names
2021-05-25 15:13 [PATCH v2] drm/fb-helper: improve DRM fbdev emulation device names Javier Martinez Canillas
@ 2021-05-26 7:20 ` Thomas Zimmermann
2021-05-26 19:24 ` Thomas Zimmermann
1 sibling, 0 replies; 3+ messages in thread
From: Thomas Zimmermann @ 2021-05-26 7:20 UTC (permalink / raw)
To: Javier Martinez Canillas, linux-kernel
Cc: Daniel Vetter, David Airlie, Maarten Lankhorst, Maxime Ripard, dri-devel
[-- Attachment #1.1: Type: text/plain, Size: 2033 bytes --]
Am 25.05.21 um 17:13 schrieb Javier Martinez Canillas:
> Framebuffer devices that are registered by DRM drivers for fbdev emulation
> have a "drmfb" suffix in their name. But makes them to be quite confusing
> for drivers that already have "drm" in their name:
>
> $ cat /proc/fb
> 0 rockchipdrmdrmfb
>
> $ cat /proc/fb
> 0 simpledrmdrmfb
>
> Also, there isn't a lot of value in adding these "drmfb" suffices to their
> names, since users shouldn't really care if the FB devices were registered
> by a real fbdev driver or a DRM driver using the fbdev emulation.
>
> What programs should be interested about is if there's a DRM device, and
> there are better ways to query that info than reading this procfs entry.
>
> So let's just remove the suffix, which leads to much better device names:
>
> $ cat /proc/fb
> 0 rockchipdrm
>
> $ cat /proc/fb
> 0 simpledrm
>
> Suggested-by: Thomas Zimmermann <tzimmermann@suse.de>
> Signed-off-by: Javier Martinez Canillas <javierm@redhat.com>
Acked-by: Thomas Zimmermann <tzimmermann@suse.de>
> ---
>
> Changes in v2:
> - Just remove the "drmfb" suffix instead of using a different one (tzimmermann).
>
> drivers/gpu/drm/drm_fb_helper.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/drm_fb_helper.c b/drivers/gpu/drm/drm_fb_helper.c
> index f6baa204612..d77a24507d3 100644
> --- a/drivers/gpu/drm/drm_fb_helper.c
> +++ b/drivers/gpu/drm/drm_fb_helper.c
> @@ -1737,7 +1737,7 @@ void drm_fb_helper_fill_info(struct fb_info *info,
> sizes->fb_width, sizes->fb_height);
>
> info->par = fb_helper;
> - snprintf(info->fix.id, sizeof(info->fix.id), "%sdrmfb",
> + snprintf(info->fix.id, sizeof(info->fix.id), "%s",
> fb_helper->dev->driver->name);
>
> }
>
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] drm/fb-helper: improve DRM fbdev emulation device names
2021-05-25 15:13 [PATCH v2] drm/fb-helper: improve DRM fbdev emulation device names Javier Martinez Canillas
2021-05-26 7:20 ` Thomas Zimmermann
@ 2021-05-26 19:24 ` Thomas Zimmermann
1 sibling, 0 replies; 3+ messages in thread
From: Thomas Zimmermann @ 2021-05-26 19:24 UTC (permalink / raw)
To: Javier Martinez Canillas, linux-kernel; +Cc: David Airlie, dri-devel
[-- Attachment #1.1: Type: text/plain, Size: 2042 bytes --]
Am 25.05.21 um 17:13 schrieb Javier Martinez Canillas:
> Framebuffer devices that are registered by DRM drivers for fbdev emulation
> have a "drmfb" suffix in their name. But makes them to be quite confusing
> for drivers that already have "drm" in their name:
>
> $ cat /proc/fb
> 0 rockchipdrmdrmfb
>
> $ cat /proc/fb
> 0 simpledrmdrmfb
>
> Also, there isn't a lot of value in adding these "drmfb" suffices to their
> names, since users shouldn't really care if the FB devices were registered
> by a real fbdev driver or a DRM driver using the fbdev emulation.
>
> What programs should be interested about is if there's a DRM device, and
> there are better ways to query that info than reading this procfs entry.
>
> So let's just remove the suffix, which leads to much better device names:
>
> $ cat /proc/fb
> 0 rockchipdrm
>
> $ cat /proc/fb
> 0 simpledrm
>
> Suggested-by: Thomas Zimmermann <tzimmermann@suse.de>
> Signed-off-by: Javier Martinez Canillas <javierm@redhat.com>
Added to drm-misc-next. Thank you.
Best regards
Thomas
> ---
>
> Changes in v2:
> - Just remove the "drmfb" suffix instead of using a different one (tzimmermann).
>
> drivers/gpu/drm/drm_fb_helper.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/drm_fb_helper.c b/drivers/gpu/drm/drm_fb_helper.c
> index f6baa204612..d77a24507d3 100644
> --- a/drivers/gpu/drm/drm_fb_helper.c
> +++ b/drivers/gpu/drm/drm_fb_helper.c
> @@ -1737,7 +1737,7 @@ void drm_fb_helper_fill_info(struct fb_info *info,
> sizes->fb_width, sizes->fb_height);
>
> info->par = fb_helper;
> - snprintf(info->fix.id, sizeof(info->fix.id), "%sdrmfb",
> + snprintf(info->fix.id, sizeof(info->fix.id), "%s",
> fb_helper->dev->driver->name);
>
> }
>
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-05-26 19:24 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-25 15:13 [PATCH v2] drm/fb-helper: improve DRM fbdev emulation device names Javier Martinez Canillas
2021-05-26 7:20 ` Thomas Zimmermann
2021-05-26 19:24 ` Thomas Zimmermann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).