* [PATCH] OPP: Fix an un-initialized variable usage
@ 2022-08-15 12:44 Christophe JAILLET
2022-08-16 5:20 ` Viresh Kumar
0 siblings, 1 reply; 2+ messages in thread
From: Christophe JAILLET @ 2022-08-15 12:44 UTC (permalink / raw)
To: Viresh Kumar, Nishanth Menon, Stephen Boyd
Cc: linux-kernel, kernel-janitors, Christophe JAILLET, Viresh Kumar,
linux-pm
smatch complains that 'ret' may be returned un-initialized.
Explicitly return 0 if we reach the end of the function (should
'opp_table->clk_count' be 0).
Fixes: 8174a3a613af ("OPP: Provide a simple implementation to configure multiple clocks")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
drivers/opp/core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/opp/core.c b/drivers/opp/core.c
index 77d1ba3a4154..e87567dbe99f 100644
--- a/drivers/opp/core.c
+++ b/drivers/opp/core.c
@@ -873,7 +873,7 @@ int dev_pm_opp_config_clks_simple(struct device *dev,
}
}
- return ret;
+ return 0;
}
EXPORT_SYMBOL_GPL(dev_pm_opp_config_clks_simple);
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] OPP: Fix an un-initialized variable usage
2022-08-15 12:44 [PATCH] OPP: Fix an un-initialized variable usage Christophe JAILLET
@ 2022-08-16 5:20 ` Viresh Kumar
0 siblings, 0 replies; 2+ messages in thread
From: Viresh Kumar @ 2022-08-16 5:20 UTC (permalink / raw)
To: Christophe JAILLET
Cc: Viresh Kumar, Nishanth Menon, Stephen Boyd, linux-kernel,
kernel-janitors, linux-pm
On 15-08-22, 14:44, Christophe JAILLET wrote:
> smatch complains that 'ret' may be returned un-initialized.
>
> Explicitly return 0 if we reach the end of the function (should
> 'opp_table->clk_count' be 0).
>
> Fixes: 8174a3a613af ("OPP: Provide a simple implementation to configure multiple clocks")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
> drivers/opp/core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/opp/core.c b/drivers/opp/core.c
> index 77d1ba3a4154..e87567dbe99f 100644
> --- a/drivers/opp/core.c
> +++ b/drivers/opp/core.c
> @@ -873,7 +873,7 @@ int dev_pm_opp_config_clks_simple(struct device *dev,
> }
> }
>
> - return ret;
> + return 0;
> }
> EXPORT_SYMBOL_GPL(dev_pm_opp_config_clks_simple);
Applied. Thanks.
--
viresh
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-08-16 8:02 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-15 12:44 [PATCH] OPP: Fix an un-initialized variable usage Christophe JAILLET
2022-08-16 5:20 ` Viresh Kumar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).