* [PATCH] mm: use pgprot_val to get value of pgprot
@ 2022-04-25 8:17 liusongtang
2022-04-25 10:29 ` Anshuman Khandual
0 siblings, 1 reply; 5+ messages in thread
From: liusongtang @ 2022-04-25 8:17 UTC (permalink / raw)
To: akpm
Cc: liusongtang, linux-mm, linux-kernel, nixiaoming, young.liuyang, trivial
pgprot.pgprot is a non-portable code, it should be replaced by
portable macro pgprot_val.
Signed-off-by: liusongtang <liusongtang@huawei.com>
---
mm/memory_hotplug.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c
index 416b38c..bf7d181 100644
--- a/mm/memory_hotplug.c
+++ b/mm/memory_hotplug.c
@@ -303,7 +303,7 @@ int __ref __add_pages(int nid, unsigned long pfn, unsigned long nr_pages,
int err;
struct vmem_altmap *altmap = params->altmap;
- if (WARN_ON_ONCE(!params->pgprot.pgprot))
+ if (WARN_ON_ONCE(!pgprot_val(params->pgprot)))
return -EINVAL;
VM_BUG_ON(!mhp_range_allowed(PFN_PHYS(pfn), nr_pages * PAGE_SIZE, false));
--
2.12.3
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] mm: use pgprot_val to get value of pgprot
2022-04-25 8:17 [PATCH] mm: use pgprot_val to get value of pgprot liusongtang
@ 2022-04-25 10:29 ` Anshuman Khandual
2022-04-25 10:40 ` Kefeng Wang
0 siblings, 1 reply; 5+ messages in thread
From: Anshuman Khandual @ 2022-04-25 10:29 UTC (permalink / raw)
To: liusongtang, akpm
Cc: linux-mm, linux-kernel, nixiaoming, young.liuyang, trivial
Should have added 'memory_hotplug' in the subject line. Otherwise
this does not specify where the change is (neither does the commit
message below).
mm/memory_hotplug: use pgprot_val to get value of pgprot
On 4/25/22 13:47, liusongtang wrote:
> pgprot.pgprot is a non-portable code, it should be replaced by
> portable macro pgprot_val.
>
> Signed-off-by: liusongtang <liusongtang@huawei.com>
> ---
> mm/memory_hotplug.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c
> index 416b38c..bf7d181 100644
> --- a/mm/memory_hotplug.c
> +++ b/mm/memory_hotplug.c
> @@ -303,7 +303,7 @@ int __ref __add_pages(int nid, unsigned long pfn, unsigned long nr_pages,
> int err;
> struct vmem_altmap *altmap = params->altmap;
>
> - if (WARN_ON_ONCE(!params->pgprot.pgprot))
> + if (WARN_ON_ONCE(!pgprot_val(params->pgprot)))
> return -EINVAL;
>
> VM_BUG_ON(!mhp_range_allowed(PFN_PHYS(pfn), nr_pages * PAGE_SIZE, false));
Otherwise LGTM.
Reviewed-by: Anshuman Khandual <anshuman.khandual@arm.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] mm: use pgprot_val to get value of pgprot
2022-04-25 10:29 ` Anshuman Khandual
@ 2022-04-25 10:40 ` Kefeng Wang
2022-04-25 13:48 ` liusongtang
0 siblings, 1 reply; 5+ messages in thread
From: Kefeng Wang @ 2022-04-25 10:40 UTC (permalink / raw)
To: Anshuman Khandual, liusongtang, akpm
Cc: linux-mm, linux-kernel, nixiaoming, young.liuyang, trivial
On 2022/4/25 18:29, Anshuman Khandual wrote:
> Should have added 'memory_hotplug' in the subject line. Otherwise
> this does not specify where the change is (neither does the commit
> message below).
>
> mm/memory_hotplug: use pgprot_val to get value of pgprot
$ git grep "pgprot\.pgprot"
arch/ia64/mm/init.c: if (WARN_ON_ONCE(params->pgprot.pgprot !=
PAGE_KERNEL.pgprot))
arch/s390/mm/init.c: if (WARN_ON_ONCE(params->pgprot.pgprot !=
PAGE_KERNEL.pgprot))
arch/sh/mm/init.c: if (WARN_ON_ONCE(params->pgprot.pgprot !=
PAGE_KERNEL.pgprot))
mm/memory_hotplug.c: if (WARN_ON_ONCE(!params->pgprot.pgprot))
You can change other's codes too.
>
> On 4/25/22 13:47, liusongtang wrote:
>> pgprot.pgprot is a non-portable code, it should be replaced by
>> portable macro pgprot_val.
>>
>> Signed-off-by: liusongtang <liusongtang@huawei.com>
>> ---
>> mm/memory_hotplug.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c
>> index 416b38c..bf7d181 100644
>> --- a/mm/memory_hotplug.c
>> +++ b/mm/memory_hotplug.c
>> @@ -303,7 +303,7 @@ int __ref __add_pages(int nid, unsigned long pfn, unsigned long nr_pages,
>> int err;
>> struct vmem_altmap *altmap = params->altmap;
>>
>> - if (WARN_ON_ONCE(!params->pgprot.pgprot))
>> + if (WARN_ON_ONCE(!pgprot_val(params->pgprot)))
>> return -EINVAL;
>>
>> VM_BUG_ON(!mhp_range_allowed(PFN_PHYS(pfn), nr_pages * PAGE_SIZE, false));
> Otherwise LGTM.
>
> Reviewed-by: Anshuman Khandual <anshuman.khandual@arm.com>
>
> .
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] mm: use pgprot_val to get value of pgprot
2022-04-25 10:40 ` Kefeng Wang
@ 2022-04-25 13:48 ` liusongtang
2022-04-26 5:38 ` Kefeng Wang
0 siblings, 1 reply; 5+ messages in thread
From: liusongtang @ 2022-04-25 13:48 UTC (permalink / raw)
To: Kefeng Wang, Anshuman Khandual, akpm
Cc: linux-mm, linux-kernel, nixiaoming, young.liuyang, trivial
OK, Shall I add "Suggested-by: Kefeng Wang <wangkefeng.wang@huawei.com>"
to these patches?
On 2022/4/25 18:40, Kefeng Wang wrote:
>
> On 2022/4/25 18:29, Anshuman Khandual wrote:
>> Should have added 'memory_hotplug' in the subject line. Otherwise
>> this does not specify where the change is (neither does the commit
>> message below).
>>
>> mm/memory_hotplug: use pgprot_val to get value of pgprot
>
>
> $ git grep "pgprot\.pgprot"
> arch/ia64/mm/init.c: if (WARN_ON_ONCE(params->pgprot.pgprot !=
> PAGE_KERNEL.pgprot))
> arch/s390/mm/init.c: if (WARN_ON_ONCE(params->pgprot.pgprot !=
> PAGE_KERNEL.pgprot))
> arch/sh/mm/init.c: if (WARN_ON_ONCE(params->pgprot.pgprot !=
> PAGE_KERNEL.pgprot))
> mm/memory_hotplug.c: if (WARN_ON_ONCE(!params->pgprot.pgprot))
>
> You can change other's codes too.
>
>>
>> On 4/25/22 13:47, liusongtang wrote:
>>> pgprot.pgprot is a non-portable code, it should be replaced by
>>> portable macro pgprot_val.
>>>
>>> Signed-off-by: liusongtang <liusongtang@huawei.com>
>>> ---
>>> mm/memory_hotplug.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c
>>> index 416b38c..bf7d181 100644
>>> --- a/mm/memory_hotplug.c
>>> +++ b/mm/memory_hotplug.c
>>> @@ -303,7 +303,7 @@ int __ref __add_pages(int nid, unsigned long
>>> pfn, unsigned long nr_pages,
>>> int err;
>>> struct vmem_altmap *altmap = params->altmap;
>>> - if (WARN_ON_ONCE(!params->pgprot.pgprot))
>>> + if (WARN_ON_ONCE(!pgprot_val(params->pgprot)))
>>> return -EINVAL;
>>> VM_BUG_ON(!mhp_range_allowed(PFN_PHYS(pfn), nr_pages *
>>> PAGE_SIZE, false));
>> Otherwise LGTM.
>>
>> Reviewed-by: Anshuman Khandual <anshuman.khandual@arm.com>
>>
>> .
> .
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] mm: use pgprot_val to get value of pgprot
2022-04-25 13:48 ` liusongtang
@ 2022-04-26 5:38 ` Kefeng Wang
0 siblings, 0 replies; 5+ messages in thread
From: Kefeng Wang @ 2022-04-26 5:38 UTC (permalink / raw)
To: liusongtang, Anshuman Khandual, akpm
Cc: linux-mm, linux-kernel, nixiaoming, young.liuyang, trivial
On 2022/4/25 21:48, liusongtang wrote:
> OK, Shall I add "Suggested-by: Kefeng Wang
> <wangkefeng.wang@huawei.com>" to these patches?
>
It is unnecessary ；）
> On 2022/4/25 18:40, Kefeng Wang wrote:
>>
>> On 2022/4/25 18:29, Anshuman Khandual wrote:
>>> Should have added 'memory_hotplug' in the subject line. Otherwise
>>> this does not specify where the change is (neither does the commit
>>> message below).
>>>
>>> mm/memory_hotplug: use pgprot_val to get value of pgprot
>>
>>
>> $ git grep "pgprot\.pgprot"
>> arch/ia64/mm/init.c: if (WARN_ON_ONCE(params->pgprot.pgprot !=
>> PAGE_KERNEL.pgprot))
>> arch/s390/mm/init.c: if (WARN_ON_ONCE(params->pgprot.pgprot !=
>> PAGE_KERNEL.pgprot))
>> arch/sh/mm/init.c: if (WARN_ON_ONCE(params->pgprot.pgprot !=
>> PAGE_KERNEL.pgprot))
>> mm/memory_hotplug.c: if (WARN_ON_ONCE(!params->pgprot.pgprot))
>>
>> You can change other's codes too.
>>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-04-26 5:39 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-25 8:17 [PATCH] mm: use pgprot_val to get value of pgprot liusongtang
2022-04-25 10:29 ` Anshuman Khandual
2022-04-25 10:40 ` Kefeng Wang
2022-04-25 13:48 ` liusongtang
2022-04-26 5:38 ` Kefeng Wang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).