From: Peter Ujfalusi <peter.ujfalusi@ti.com>
To: Johan Hovold <johan@kernel.org>, Stephen Boyd <sboyd@codeaurora.org>
Cc: Andy Gross <andy.gross@linaro.org>,
David Brown <david.brown@linaro.org>,
Michael Turquette <mturquette@baylibre.com>,
Tero Kristo <t-kristo@ti.com>, <linux-arm-msm@vger.kernel.org>,
<linux-clk@vger.kernel.org>, <linux-omap@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, stable <stable@vger.kernel.org>
Subject: Re: [PATCH 2/2] clk: ti: dra7-atl-clock: fix child-node lookups
Date: Mon, 13 Nov 2017 22:15:13 +0200 [thread overview]
Message-ID: <a35e8131-a726-0897-5f85-84ddd10d0b7e@ti.com> (raw)
In-Reply-To: <20171111162929.11722-2-johan@kernel.org>
On 11/11/2017 06:29 PM, Johan Hovold wrote:
> Fix child node-lookup during probe, which ended up searching the whole
> device tree depth-first starting at parent rather than just matching on
> its children.
>
> Note that the original premature free of the parent node has already
> been fixed separately, but that fix was apparently never backported to
> stable.
Acked-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
>
> Fixes: 9ac33b0ce81f ("CLK: TI: Driver for DRA7 ATL (Audio Tracking Logic)")
> Fixes: 660e15519399 ("clk: ti: dra7-atl-clock: Fix of_node reference counting")
> Cc: stable <stable@vger.kernel.org> # 3.16: 660e15519399
> Cc: Peter Ujfalusi <peter.ujfalusi@ti.com>
> Signed-off-by: Johan Hovold <johan@kernel.org>
> ---
> drivers/clk/ti/clk-dra7-atl.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/clk/ti/clk-dra7-atl.c b/drivers/clk/ti/clk-dra7-atl.c
> index 13eb04f72389..148815470431 100644
> --- a/drivers/clk/ti/clk-dra7-atl.c
> +++ b/drivers/clk/ti/clk-dra7-atl.c
> @@ -274,8 +274,7 @@ static int of_dra7_atl_clk_probe(struct platform_device *pdev)
>
> /* Get configuration for the ATL instances */
> snprintf(prop, sizeof(prop), "atl%u", i);
> - of_node_get(node);
> - cfg_node = of_find_node_by_name(node, prop);
> + cfg_node = of_get_child_by_name(node, prop);
> if (cfg_node) {
> ret = of_property_read_u32(cfg_node, "bws",
> &cdesc->bws);
>
--
Péter
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
next prev parent reply other threads:[~2017-11-13 20:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-11 16:29 [PATCH 1/2] clk: qcom: common: fix legacy board-clock registration Johan Hovold
2017-11-11 16:29 ` [PATCH 2/2] clk: ti: dra7-atl-clock: fix child-node lookups Johan Hovold
2017-11-13 20:15 ` Peter Ujfalusi [this message]
2017-11-14 23:53 ` Stephen Boyd
2017-11-14 23:49 ` [PATCH 1/2] clk: qcom: common: fix legacy board-clock registration Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a35e8131-a726-0897-5f85-84ddd10d0b7e@ti.com \
--to=peter.ujfalusi@ti.com \
--cc=andy.gross@linaro.org \
--cc=david.brown@linaro.org \
--cc=johan@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=sboyd@codeaurora.org \
--cc=stable@vger.kernel.org \
--cc=t-kristo@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).