From: Dan Murphy <dmurphy@ti.com>
To: Sven Van Asbroeck <thesven73@gmail.com>,
Lee Jones <lee.jones@linaro.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
Jacek Anaszewski <jacek.anaszewski@gmail.com>,
Pavel Machek <pavel@ucw.cz>, Rob Herring <robh+dt@kernel.org>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Grigoryev Denis <grigoryev@fastwel.ru>,
Axel Lin <axel.lin@ingics.com>,
Mark Rutland <mark.rutland@arm.com>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <linux-leds@vger.kernel.org>
Subject: Re: [PATCH v2 4/4] dt-bindings: mfd: update TI tps6105x chip bindings
Date: Tue, 19 Nov 2019 12:36:21 -0600 [thread overview]
Message-ID: <a37d098e-12ea-af2e-22cd-cb5ec2856b6d@ti.com> (raw)
In-Reply-To: <20191119154611.29625-5-TheSven73@gmail.com>
Sven
On 11/19/19 9:46 AM, Sven Van Asbroeck wrote:
> The driver has been extended to optionally get its operational
> mode, regulator init data and led label from the devicetree.
>
> Tree: next-20191118
> Signed-off-by: Sven Van Asbroeck <TheSven73@gmail.com>
> ---
> .../devicetree/bindings/mfd/tps6105x.txt | 42 ++++++++++++++++++-
> 1 file changed, 41 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/mfd/tps6105x.txt b/Documentation/devicetree/bindings/mfd/tps6105x.txt
> index 93602c7a19c8..ab5d4c52074f 100644
> --- a/Documentation/devicetree/bindings/mfd/tps6105x.txt
> +++ b/Documentation/devicetree/bindings/mfd/tps6105x.txt
> @@ -7,11 +7,51 @@ Required properties:
> - compatible: "ti,tps61050" or "ti,tps61052"
> - reg: Specifies the I2C slave address
>
> -Example:
> +Optional sub-node:
> +
> +This subnode selects the chip's operational mode.
> +There can be at most one single available subnode.
> +
> +- regulator: presence of this sub-node puts the chip in regulator mode.
> + see Documentation/devicetree/bindings/regulator/regulator.txt
> +
> +- led: presence of this sub-node puts the chip in led mode.
> + Optional properties:
> + - label: see Documentation/devicetree/bindings/leds/common.txt
> +
> +Example (GPIO operation only):
> +
> +i2c0 {
> + tps61052@33 {
> + compatible = "ti,tps61052";
> + reg = <0x33>;
> + };
> +};
> +
> +Example (GPIO + regulator operation):
>
> i2c0 {
> tps61052@33 {
> compatible = "ti,tps61052";
> reg = <0x33>;
> +
> + regulator {
> + regulator-min-microvolt = <5000000>;
> + regulator-max-microvolt = <5000000>;
> + regulator-always-on;
> + };
> + };
> +};
> +
> +Example (GPIO + led operation):
What part of the example is GPIO? Is that the default function?
> +
> +i2c0 {
> + tps61052@33 {
> + compatible = "ti,tps61052";
> + reg = <0x33>;
> +
> + led {
> + label = "tps-torch";
function and color examples?
> + };
> };
> };
next prev parent reply other threads:[~2019-11-19 18:38 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-19 15:46 [PATCH v2 0/4] tps6105x add devicetree and leds support Sven Van Asbroeck
2019-11-19 15:46 ` [PATCH v2 1/4] tps6105x: add optional devicetree support Sven Van Asbroeck
2019-11-20 17:18 ` Applied "tps6105x: add optional devicetree support" to the regulator tree Mark Brown
2019-11-22 7:31 ` Lee Jones
2019-11-22 13:32 ` Mark Brown
2019-11-22 13:39 ` Sven Van Asbroeck
2019-11-22 14:42 ` Lee Jones
2019-11-19 15:46 ` [PATCH v2 2/4] regulator: tps6105x: add optional devicetree support Sven Van Asbroeck
2019-11-19 18:14 ` Mark Brown
2019-11-19 18:21 ` Sven Van Asbroeck
2019-11-20 14:15 ` Sven Van Asbroeck
2019-11-20 17:18 ` Applied "regulator: tps6105x: add optional devicetree support" to the regulator tree Mark Brown
2019-11-19 15:46 ` [PATCH v2 3/4] leds: tps6105x: add driver for mfd chip led mode Sven Van Asbroeck
2019-11-19 18:32 ` Dan Murphy
2019-11-19 18:59 ` Sven Van Asbroeck
2019-11-19 21:52 ` Sven Van Asbroeck
2019-11-19 15:46 ` [PATCH v2 4/4] dt-bindings: mfd: update TI tps6105x chip bindings Sven Van Asbroeck
2019-11-19 18:36 ` Dan Murphy [this message]
2019-11-19 19:03 ` Sven Van Asbroeck
2019-11-19 19:38 ` Jacek Anaszewski
2019-11-19 20:22 ` Sven Van Asbroeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a37d098e-12ea-af2e-22cd-cb5ec2856b6d@ti.com \
--to=dmurphy@ti.com \
--cc=axel.lin@ingics.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=grigoryev@fastwel.ru \
--cc=jacek.anaszewski@gmail.com \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pavel@ucw.cz \
--cc=robh+dt@kernel.org \
--cc=thesven73@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).