From: Sven Van Asbroeck <thesven73@gmail.com>
To: Jacek Anaszewski <jacek.anaszewski@gmail.com>
Cc: Dan Murphy <dmurphy@ti.com>, Lee Jones <lee.jones@linaro.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Pavel Machek <pavel@ucw.cz>,
Rob Herring <robh+dt@kernel.org>,
Linus Walleij <linus.walleij@linaro.org>,
Grigoryev Denis <grigoryev@fastwel.ru>,
Axel Lin <axel.lin@ingics.com>,
Mark Rutland <mark.rutland@arm.com>,
devicetree <devicetree@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-leds@vger.kernel.org
Subject: Re: [PATCH v2 4/4] dt-bindings: mfd: update TI tps6105x chip bindings
Date: Tue, 19 Nov 2019 15:22:25 -0500 [thread overview]
Message-ID: <CAGngYiUDPc+xMO6zzr+bN=i7-QFTUaNE0P5iP+QELjRHnfqUsw@mail.gmail.com> (raw)
In-Reply-To: <b2ea6130-cfce-4d41-0b35-ba076f599402@gmail.com>
On Tue, Nov 19, 2019 at 2:38 PM Jacek Anaszewski
<jacek.anaszewski@gmail.com> wrote:
>
> label DT property was recently deprecated. We now encourage using
> 'function' and/or 'color'. Please refer to
> Documentation/devicetree/bindings/leds/common.txt.
Ah, I see.
I'm actually back-porting this from a 4.19 vendor kernel, which I believe
does not have function/color support. If I introduce it here, I wouldn't
be able to test it easily, and I'd have to forward/back-port.
All I need is a single led in the system. So I'll just remove the 'label'
code/description, and hard-code the led name to 'tps6105x'. If
anyone wants to use this driver and wants named leds, they can
always add it themselves.
Jacek and Dan, does that satisfy your concerns?
prev parent reply other threads:[~2019-11-19 20:22 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-19 15:46 [PATCH v2 0/4] tps6105x add devicetree and leds support Sven Van Asbroeck
2019-11-19 15:46 ` [PATCH v2 1/4] tps6105x: add optional devicetree support Sven Van Asbroeck
2019-11-20 17:18 ` Applied "tps6105x: add optional devicetree support" to the regulator tree Mark Brown
2019-11-22 7:31 ` Lee Jones
2019-11-22 13:32 ` Mark Brown
2019-11-22 13:39 ` Sven Van Asbroeck
2019-11-22 14:42 ` Lee Jones
2019-11-19 15:46 ` [PATCH v2 2/4] regulator: tps6105x: add optional devicetree support Sven Van Asbroeck
2019-11-19 18:14 ` Mark Brown
2019-11-19 18:21 ` Sven Van Asbroeck
2019-11-20 14:15 ` Sven Van Asbroeck
2019-11-20 17:18 ` Applied "regulator: tps6105x: add optional devicetree support" to the regulator tree Mark Brown
2019-11-19 15:46 ` [PATCH v2 3/4] leds: tps6105x: add driver for mfd chip led mode Sven Van Asbroeck
2019-11-19 18:32 ` Dan Murphy
2019-11-19 18:59 ` Sven Van Asbroeck
2019-11-19 21:52 ` Sven Van Asbroeck
2019-11-19 15:46 ` [PATCH v2 4/4] dt-bindings: mfd: update TI tps6105x chip bindings Sven Van Asbroeck
2019-11-19 18:36 ` Dan Murphy
2019-11-19 19:03 ` Sven Van Asbroeck
2019-11-19 19:38 ` Jacek Anaszewski
2019-11-19 20:22 ` Sven Van Asbroeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAGngYiUDPc+xMO6zzr+bN=i7-QFTUaNE0P5iP+QELjRHnfqUsw@mail.gmail.com' \
--to=thesven73@gmail.com \
--cc=axel.lin@ingics.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmurphy@ti.com \
--cc=grigoryev@fastwel.ru \
--cc=jacek.anaszewski@gmail.com \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pavel@ucw.cz \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).