From: Jon Hunter <jonathanh@nvidia.com>
To: Mirza Krak <mirza.krak@gmail.com>, Rob Herring <robh@kernel.org>
Cc: Stephen Warren <swarren@wwwdotorg.org>,
Thierry Reding <thierry.reding@gmail.com>,
Alexandre Courbot <gnurou@gmail.com>, <linux@armlinux.org.uk>,
<pdeschrijver@nvidia.com>, Prashant Gaikwad <pgaikwad@nvidia.com>,
Michael Turquette <mturquette@baylibre.com>,
<sboyd@codeaurora.org>, <mark.rutland@arm.com>,
<devicetree@vger.kernel.org>, <linux-tegra@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-clk@vger.kernel.org>
Subject: Re: [PATCH v2 3/6] dt/bindings: Add bindings for Tegra GMI controller
Date: Tue, 6 Sep 2016 11:32:14 +0100 [thread overview]
Message-ID: <a3a2371b-5d98-db2d-b7e4-be6d08cb7271@nvidia.com> (raw)
In-Reply-To: <CALw8SCUYQGWXn7=Jpn=uvFvvPRVFQGrtSNot+-tVgP73yAEEOQ@mail.gmail.com>
On 31/08/16 12:22, Mirza Krak wrote:
> 2016-08-30 19:06 GMT+02:00 Rob Herring <robh@kernel.org>:
...
>>> nvidia,snor-cs = <4>;
>>
>> NAK, no custom CS properties.
Ok, so ...
> gmi@70090000 {
> compatible = "nvidia,tegra20-gmi";
> reg = <0x70009000 0x1000>;
> #address-cells = <2>;
> #size-cells = <1>;
> clocks = <&tegra_car TEGRA20_CLK_NOR>;
> clock-names = "gmi";
> resets = <&tegra_car 42>;
> reset-names = "gmi";
> ranges = <4 0 0xd0000000 0xfffffff>;
>
> status = "okay";
>
> bus@4,0 {
> compatible = "simple-bus";
> #address-cells = <1>;
> #size-cells = <1>;
> ranges = <0 4 0 0x40000>;
>
> nvidia,snor-mux-mode;
> nvidia,snor-adv-inv;
>
> can@0 {
> reg = <0 0x100>;
> ...
> };
>
> can@40000 {
> reg = <0x40000 0x100>;
> ...
> };
> };
> };
>
> Have I understood you correct?
>
> Also wanted to verify the example case where you only have on device
> connected to one CS#, from what I see in other implementations it
> seems OK to put the CS# in the reg property in that case. Is this
> correct?
>
> Example with one SJA1000 CAN controller connected to the GMI bus
> on CS4:
>
> gmi@70090000 {
> compatible = "nvidia,tegra20-gmi";
> reg = <0x70009000 0x1000>;
> #address-cells = <2>;
> #size-cells = <1>;
> clocks = <&tegra_car TEGRA20_CLK_NOR>;
> clock-names = "gmi";
> resets = <&tegra_car 42>;
> reset-names = "gmi";
> ranges = <4 0 0xd0000000 0xfffffff>;
>
> status = "okay";
>
> can@4,0 {
> reg = <4 0 0x100>;
> nvidia,snor-mux-mode;
> nvidia,snor-adv-inv;
> ...
> };
> };
>
> Jon, to be able to handle both cases in the driver we would first
> attempt to decode the CS# from the ranges property, and fallback to
> reg property if no ranges are defined. Does that sound reasonable?
Given the above examples that may be supported, is there a
better/simpler way to extract the CS# than what Mirza is proposing? For
example, from the node-name unit-address?
Cheers
Jon
--
nvpublic
next prev parent reply other threads:[~2016-09-06 10:32 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-24 13:37 [PATCH v2 0/6] Add support for Tegra GMI bus controller Mirza Krak
2016-08-24 13:37 ` [PATCH v2 1/6] clk: tegra: add TEGRA20_CLK_NOR to init table Mirza Krak
2016-08-24 13:37 ` [PATCH v2 2/6] clk: tegra: add TEGRA30_CLK_NOR " Mirza Krak
2016-08-24 13:37 ` [PATCH v2 3/6] dt/bindings: Add bindings for Tegra GMI controller Mirza Krak
2016-08-24 15:56 ` Jon Hunter
2016-08-24 19:54 ` Mirza Krak
2016-08-26 4:53 ` Mirza Krak
2016-08-26 7:25 ` Jon Hunter
2016-08-29 7:38 ` Mirza Krak
2016-08-30 17:06 ` Rob Herring
2016-08-31 11:22 ` Mirza Krak
2016-09-06 10:32 ` Jon Hunter [this message]
2016-09-19 7:21 ` Mirza Krak
2016-09-30 8:02 ` Jon Hunter
2016-09-06 10:35 ` Jon Hunter
2016-08-30 15:02 ` Marcel Ziswiler
2016-08-31 9:24 ` Mirza Krak
2016-08-24 13:37 ` [PATCH v2 4/6] ARM: tegra: Add Tegra30 GMI support Mirza Krak
2016-08-24 13:37 ` [PATCH v2 5/6] ARM: tegra: Add Tegra20 " Mirza Krak
2016-08-24 13:37 ` [PATCH v2 6/6] bus: Add support for Tegra Generic Memory Interface Mirza Krak
2016-08-26 8:21 ` Jon Hunter
2016-08-30 15:01 ` [PATCH v2 0/6] Add support for Tegra GMI bus controller Marcel Ziswiler
2016-08-31 9:23 ` Mirza Krak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a3a2371b-5d98-db2d-b7e4-be6d08cb7271@nvidia.com \
--to=jonathanh@nvidia.com \
--cc=devicetree@vger.kernel.org \
--cc=gnurou@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mark.rutland@arm.com \
--cc=mirza.krak@gmail.com \
--cc=mturquette@baylibre.com \
--cc=pdeschrijver@nvidia.com \
--cc=pgaikwad@nvidia.com \
--cc=robh@kernel.org \
--cc=sboyd@codeaurora.org \
--cc=swarren@wwwdotorg.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).