From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Jiucheng Xu <jiucheng.xu@amlogic.com>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-amlogic@lists.infradead.org, devicetree@vger.kernel.org
Cc: Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Will Deacon <will@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Neil Armstrong <narmstrong@baylibre.com>,
Kevin Hilman <khilman@baylibre.com>,
Jerome Brunet <jbrunet@baylibre.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
Chris Healy <cphealy@gmail.com>
Subject: Re: [PATCH v4 4/4] dt-binding: perf: Add Amlogic DDR PMU
Date: Fri, 5 Aug 2022 10:21:37 +0200 [thread overview]
Message-ID: <a3cd55ad-cec2-9570-2078-6724ab1d7300@linaro.org> (raw)
In-Reply-To: <20220805071426.2598818-4-jiucheng.xu@amlogic.com>
On 05/08/2022 09:14, Jiucheng Xu wrote:
> Add binding documentation for the Amlogic G12 series DDR
> performance monitor unit.
>
Bindings go first in the series, before their implementation.
> Signed-off-by: Jiucheng Xu <jiucheng.xu@amlogic.com>
> ---
> Changes v3 -> v4:
> - Fix "$id: relative path/filename doesn't match actual path or
> filename" warning
>
> Changes v2 -> v3:
> - Remove oneOf
> - Add descriptions
> - Fix compiling warning
>
> Changes v1 -> v2:
> - Rename file, from aml_ddr_pmu.yaml to amlogic,g12_ddr_pmu.yaml
> - Delete "model", "dmc_nr", "chann_nr" new properties
> - Fix compiling error
> ---
> .../bindings/perf/amlogic,g12-ddr-pmu.yaml | 52 +++++++++++++++++++
> MAINTAINERS | 1 +
> 2 files changed, 53 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/perf/amlogic,g12-ddr-pmu.yaml
>
> diff --git a/Documentation/devicetree/bindings/perf/amlogic,g12-ddr-pmu.yaml b/Documentation/devicetree/bindings/perf/amlogic,g12-ddr-pmu.yaml
> new file mode 100644
> index 000000000000..4d018574ffd1
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/perf/amlogic,g12-ddr-pmu.yaml
> @@ -0,0 +1,52 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/perf/amlogic,g12-ddr-pmu.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Amlogic G12 DDR performance monitor
> +
> +maintainers:
> + - Jiucheng Xu <jiucheng.xu@amlogic.com>
> +
> +description: |
> + Amlogic G12 series SoC integrate DDR bandwidth monitor.
> + A timer is inside and can generate interrupt when timeout.
> + The bandwidth is counted in the timer ISR. Different platform
> + has different subset of event format attribute.
> +
> +properties:
> + compatible:
> + items:
You have only one item, so remove "items".
> + - enum:
> + - amlogic,g12b-ddr-pmu
> + - amlogic,g12a-ddr-pmu
> + - amlogic,sm1-ddr-pmu
> +
> + reg:
> + items:
> + - description: Physical address of DMC bandwidth register
> + and size of the configuration address space.
Skip obvious pieces, so only:
description: DMC bandwidth register space
> + - description: Physical address of DMC PLL register and
> + size of the configuration address space.
description: DMC PLL bandwidth register space
> +
> + interrupts:
> + items:
> + - description: The IRQ of the inside timer timeout.
> +
> +required:
> + - compatible
> + - reg
> + - interrupts
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/interrupt-controller/arm-gic.h>
> + ddr_pmu@ff638000 {
No underscores in node names, generic node names, so just "pmu".
https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation
> + compatible = "amlogic,g12a-ddr-pmu";
> + reg = <0xff638000 0x100
> + 0xff638c00 0x100>;
This is still not fixed. Binding says you have two items, but you
declared here only one item.
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-08-05 8:21 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-05 7:14 [PATCH v4 1/4] perf/amlogic: Add support for Amlogic meson G12 SoC DDR PMU driver Jiucheng Xu
2022-08-05 7:14 ` [PATCH v4 2/4] docs/perf: Add documentation for the Amlogic G12 DDR PMU Jiucheng Xu
2022-08-08 12:58 ` kernel test robot
2022-08-13 0:27 ` kernel test robot
2022-08-05 7:14 ` [PATCH v4 3/4] arm64: dts: meson: Add DDR PMU node Jiucheng Xu
2022-08-05 8:22 ` Krzysztof Kozlowski
2022-08-05 9:57 ` Jiucheng Xu
2022-08-08 6:14 ` Krzysztof Kozlowski
2022-08-05 7:14 ` [PATCH v4 4/4] dt-binding: perf: Add Amlogic DDR PMU Jiucheng Xu
2022-08-05 8:21 ` Krzysztof Kozlowski [this message]
2022-08-05 10:00 ` Jiucheng Xu
2022-08-15 9:04 ` Jiucheng Xu
2022-08-16 5:57 ` Krzysztof Kozlowski
2022-08-05 8:38 ` [PATCH v4 1/4] perf/amlogic: Add support for Amlogic meson G12 SoC DDR PMU driver Krzysztof Kozlowski
2022-08-05 9:55 ` Jiucheng Xu
2022-08-08 5:42 ` Krzysztof Kozlowski
2022-08-08 7:36 ` Jiucheng Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a3cd55ad-cec2-9570-2078-6724ab1d7300@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=cphealy@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=jbrunet@baylibre.com \
--cc=jiucheng.xu@amlogic.com \
--cc=khilman@baylibre.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=martin.blumenstingl@googlemail.com \
--cc=narmstrong@baylibre.com \
--cc=robh+dt@kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).