* [PATCH] ethernet:broadcom:bcm63xx_enet:remove redundant variable definitions
@ 2020-03-05 12:22 tangbin
2020-03-05 17:27 ` Florian Fainelli
2020-03-05 22:59 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: tangbin @ 2020-03-05 12:22 UTC (permalink / raw)
To: davem
Cc: f.fainelli, bcm-kernel-feedback-list, netdev, linux-arm-kernel,
linux-kernel, tangbin
in this function,‘ret’ is always assigned,so this's definition
'ret = 0' make no sense.
Signed-off-by: tangbin <tangbin@cmss.chinamobile.com>
---
drivers/net/ethernet/broadcom/bcm63xx_enet.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/ethernet/broadcom/bcm63xx_enet.c b/drivers/net/ethernet/broadcom/bcm63xx_enet.c
index 620cd3fc1..ea5087a8e 100644
--- a/drivers/net/ethernet/broadcom/bcm63xx_enet.c
+++ b/drivers/net/ethernet/broadcom/bcm63xx_enet.c
@@ -1706,7 +1706,6 @@ static int bcm_enet_probe(struct platform_device *pdev)
if (!res_irq || !res_irq_rx || !res_irq_tx)
return -ENODEV;
- ret = 0;
dev = alloc_etherdev(sizeof(*priv));
if (!dev)
return -ENOMEM;
--
2.20.1.windows.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ethernet:broadcom:bcm63xx_enet:remove redundant variable definitions
2020-03-05 12:22 [PATCH] ethernet:broadcom:bcm63xx_enet:remove redundant variable definitions tangbin
@ 2020-03-05 17:27 ` Florian Fainelli
2020-03-05 22:59 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Florian Fainelli @ 2020-03-05 17:27 UTC (permalink / raw)
To: tangbin, davem
Cc: netdev, linux-kernel, bcm-kernel-feedback-list, linux-arm-kernel
On 3/5/20 4:22 AM, tangbin wrote:
> in this function,‘ret’ is always assigned,so this's definition
> 'ret = 0' make no sense.
>
> Signed-off-by: tangbin <tangbin@cmss.chinamobile.com>
This looks fine, but your subject should be:
bcm63xx_enet: Remove redundant variable definitions
to matchthe majority of commit subjects done to that file. With that:
Acked-by: Florian Fainelli <f.fainelli@gmail.com>
--
Florian
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ethernet:broadcom:bcm63xx_enet:remove redundant variable definitions
2020-03-05 12:22 [PATCH] ethernet:broadcom:bcm63xx_enet:remove redundant variable definitions tangbin
2020-03-05 17:27 ` Florian Fainelli
@ 2020-03-05 22:59 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2020-03-05 22:59 UTC (permalink / raw)
To: tangbin
Cc: f.fainelli, bcm-kernel-feedback-list, netdev, linux-arm-kernel,
linux-kernel
From: tangbin <tangbin@cmss.chinamobile.com>
Date: Thu, 5 Mar 2020 20:22:59 +0800
> in this function,‘ret’ is always assigned,so this's definition
> 'ret = 0' make no sense.
>
> Signed-off-by: tangbin <tangbin@cmss.chinamobile.com>
Applied with Subject line fixed.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-03-05 22:59 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-05 12:22 [PATCH] ethernet:broadcom:bcm63xx_enet:remove redundant variable definitions tangbin
2020-03-05 17:27 ` Florian Fainelli
2020-03-05 22:59 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).