linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* Oops while modprobing phy fixed module
@ 2007-07-14 12:18 Gabriel C
  2007-07-14 12:44 ` Gabriel C
  2007-07-15  5:39 ` Satyam Sharma
  0 siblings, 2 replies; 40+ messages in thread
From: Gabriel C @ 2007-07-14 12:18 UTC (permalink / raw)
  To: Linux Kernel Mailing List

[-- Attachment #1: Type: text/plain, Size: 11854 bytes --]

Hi,

doing a modprobe fixed the driver segfaults and I get this Oops:


Jul 14 13:43:30 lara [  157.952915] Fixed PHY: Registered new driver
Jul 14 13:43:30 lara [  157.953010] Device 'fixed@100:1' does not have a
release() function, it is broken and must be fixed.
Jul 14 13:43:30 lara [  157.953019] WARNING: at drivers/base/core.c:107
device_release()
Jul 14 13:43:30 lara [  157.953032]  [<c01cf949>] kobject_cleanup+0x3d/0x54
Jul 14 13:43:30 lara [  157.953050]  [<c01cf960>] kobject_release+0x0/0x8
Jul 14 13:43:30 lara [  157.953060]  [<c01d0530>] kref_put+0x60/0x6d
Jul 14 13:43:30 lara [  157.953068]  [<c022f31c>] device_del+0x1f3/0x215
Jul 14 13:43:30 lara [  157.953083]  [<e8c8f2d5>]
fixed_mdio_register_device+0x1e2/0x20d [fixed]
Jul 14 13:43:30 lara [  157.953108]  [<e8c8701b>] fixed_init+0x1b/0x2f
[fixed]
Jul 14 13:43:30 lara [  157.953119]  [<c01376ab>]
sys_init_module+0x1686/0x175a
Jul 14 13:43:30 lara [  157.953133]  [<c01601e3>] do_sync_read+0x0/0x10a
Jul 14 13:43:30 lara [  157.953180]  [<c0103dee>]
sysenter_past_esp+0x5f/0x85
Jul 14 13:43:30 lara [  157.953195]  [<c0300000>]
packet_setsockopt+0x1c9/0x2f3
Jul 14 13:43:30 lara [  157.953232]  =======================
Jul 14 13:43:30 lara [  157.953261] BUG: unable to handle kernel paging
request at virtual address 43b7a800
Jul 14 13:43:30 lara [  157.953273]  printing eip:
Jul 14 13:43:30 lara [  157.953278] c015d269
Jul 14 13:43:30 lara [  157.953283] *pde = 00000000
Jul 14 13:43:30 lara [  157.953293] Oops: 0000 [#1]
Jul 14 13:43:30 lara [  157.953293] Oops: 0000 [#1]
Jul 14 13:43:30 lara [  157.953301] PREEMPT SMP
Jul 14 13:43:30 lara [  157.953301] PREEMPT SMP
Jul 14 13:43:30 lara [  157.953309] Modules linked in: fixed pc87360
hwmon_vid i2c_isa eeprom adm1021 uhci_hcd sr_mod shpchp pci_hotplug
ohci_hcd iTCO_wdt iTCO_vendor_support intel_agp i82860_edac i2c_i801
ehci_hcd usbcore edac_mc cdrom agpgart 3c59x mii ext4dev jbd2 capability
commoncap loop lp parport_pc parport
Jul 14 13:43:30 lara [  157.953386] CPU:    3
Jul 14 13:43:30 lara [  157.953386] CPU:    3
Jul 14 13:43:30 lara [  157.953387] EIP:    0060:[<c015d269>]    Not
tainted VLI
Jul 14 13:43:30 lara [  157.953387] EIP:    0060:[<c015d269>]    Not
tainted VLI
Jul 14 13:43:30 lara [  157.953391] EFLAGS: 00210006   (2.6.22-g8d9107e8 #7)
Jul 14 13:43:30 lara [  157.953391] EFLAGS: 00210006   (2.6.22-g8d9107e8 #7)
Jul 14 13:43:30 lara [  157.953404] EIP is at kmem_cache_zalloc+0x75/0x89
Jul 14 13:43:30 lara [  157.953404] EIP is at kmem_cache_zalloc+0x75/0x89
Jul 14 13:43:30 lara [  157.953412] eax: 00000000   ebx: 00200282   ecx:
c14c8760   edx: 43b7a800
Jul 14 13:43:30 lara [  157.953412] eax: 00000000   ebx: 00200282   ecx:
c14c8760   edx: 43b7a800
Jul 14 13:43:30 lara [  157.953423] esi: e7f75840   edi: c17937b8   ebp:
000000d0   esp: db1ced98
Jul 14 13:43:30 lara [  157.953423] esi: e7f75840   edi: c17937b8   ebp:
000000d0   esp: db1ced98
Jul 14 13:43:30 lara [  157.953434] ds: 007b   es: 007b   fs: 00d8  gs:
0033  ss: 0068
Jul 14 13:43:30 lara [  157.953434] ds: 007b   es: 007b   fs: 00d8  gs:
0033  ss: 0068
Jul 14 13:43:30 lara [  157.953444] Process modprobe (pid: 2164,
ti=db1ce000 task=de78ac20 task.ti=db1ce000)
Jul 14 13:43:30 lara [  157.953444] Process modprobe (pid: 2164,
ti=db1ce000 task=de78ac20 task.ti=db1ce000)
Jul 14 13:43:30 lara [  157.953450] Stack: c014cfd4 c01cf2f7 43b7a800
c03ae384 c036d990 db150690 c17937b8 c17937b8
Jul 14 13:43:30 lara [  157.953450] Stack: c014cfd4 c01cf2f7 43b7a800
c03ae384 c036d990 db150690 c17937b8 c17937b8
Jul 14 13:43:30 lara [  157.953470]        c019752a 00000002 41ed0000
e643bb60 c036d990 db150690 c036d990 e643bb60
Jul 14 13:43:30 lara [  157.953470]        c019752a 00000002 41ed0000
e643bb60 c036d990 db150690 c036d990 e643bb60
Jul 14 13:43:30 lara [  157.953489]        c01979b1 c0197712 db1cede4
00000000 e643bb60 c036d990 00000000 c03b8e98
Jul 14 13:43:30 lara [  157.953489]        c01979b1 c0197712 db1cede4
00000000 e643bb60 c036d990 00000000 c03b8e98
Jul 14 13:43:30 lara [  157.953513] Call Trace:
Jul 14 13:43:30 lara [  157.953513] Call Trace:
Jul 14 13:43:30 lara [  157.953518]  [<c014cfd4>] kstrdup+0x27/0x47
Jul 14 13:43:30 lara [  157.953518]  [<c014cfd4>] kstrdup+0x27/0x47
Jul 14 13:43:30 lara [  157.953530]  [<c01cf2f7>]
ida_get_new_above+0xe6/0x166
Jul 14 13:43:30 lara [  157.953530]  [<c01cf2f7>]
ida_get_new_above+0xe6/0x166
Jul 14 13:43:30 lara [  157.953551]  [<c019752a>] sysfs_new_dirent+0x3d/0xdc
Jul 14 13:43:30 lara [  157.953551]  [<c019752a>] sysfs_new_dirent+0x3d/0xdc
Jul 14 13:43:30 lara [  157.953574]  [<c01979b1>] create_dir+0x1e/0x8c
Jul 14 13:43:30 lara [  157.953574]  [<c01979b1>] create_dir+0x1e/0x8c
Jul 14 13:43:30 lara [  157.953588]  [<c0197712>]
sysfs_addrm_finish+0x13/0x1d8
Jul 14 13:43:30 lara [  157.953588]  [<c0197712>]
sysfs_addrm_finish+0x13/0x1d8
Jul 14 13:43:30 lara [  157.953609]  [<c0197a90>]
sysfs_create_subdir+0x13/0x16
Jul 14 13:43:30 lara [  157.953609]  [<c0197a90>]
sysfs_create_subdir+0x13/0x16
Jul 14 13:43:30 lara [  157.953622]  [<c0198dba>]
sysfs_create_group+0x25/0xe7
Jul 14 13:43:30 lara [  157.953622]  [<c0198dba>]
sysfs_create_group+0x25/0xe7
Jul 14 13:43:30 lara [  157.953642]  [<c0233616>] device_pm_add+0x38/0x72
Jul 14 13:43:30 lara [  157.953642]  [<c0233616>] device_pm_add+0x38/0x72
Jul 14 13:43:30 lara [  157.953655]  [<c022f61d>] device_add+0x230/0x3d8
Jul 14 13:43:30 lara [  157.953655]  [<c022f61d>] device_add+0x230/0x3d8
Jul 14 13:43:30 lara [  157.953678]  [<e8c8f26d>]
fixed_mdio_register_device+0x17a/0x20d [fixed]
Jul 14 13:43:30 lara [  157.953678]  [<e8c8f26d>]
fixed_mdio_register_device+0x17a/0x20d [fixed]
Jul 14 13:43:30 lara [  157.953706]  [<e8c8702c>] fixed_init+0x2c/0x2f
[fixed]
Jul 14 13:43:30 lara [  157.953706]  [<e8c8702c>] fixed_init+0x2c/0x2f
[fixed]
Jul 14 13:43:30 lara [  157.953718]  [<c01376ab>]
sys_init_module+0x1686/0x175a
Jul 14 13:43:30 lara [  157.953718]  [<c01376ab>]
sys_init_module+0x1686/0x175a
Jul 14 13:43:30 lara [  157.953734]  [<c01601e3>] do_sync_read+0x0/0x10a
Jul 14 13:43:30 lara [  157.953734]  [<c01601e3>] do_sync_read+0x0/0x10a
Jul 14 13:43:30 lara [  157.953797]  [<c0103dee>]
sysenter_past_esp+0x5f/0x85
Jul 14 13:43:30 lara [  157.953797]  [<c0103dee>]
sysenter_past_esp+0x5f/0x85
Jul 14 13:43:30 lara [  157.953816]  [<c0300000>]
packet_setsockopt+0x1c9/0x2f3
Jul 14 13:43:30 lara [  157.953816]  [<c0300000>]
packet_setsockopt+0x1c9/0x2f3
Jul 14 13:43:30 lara [  157.953835]  =======================
Jul 14 13:43:30 lara [  157.953835]  =======================
Jul 14 13:43:30 lara [  157.953841] Code: 08 00 74 2f 8b 56 08 31 c0 89
d1 c1 e9 02 8b 7c 24 08 f3 ab f6 c2 02 74 02 66 ab f6 c2 01 74 01 aa eb
10 0f b7 41 0a 8b 54 24 08 <8b> 04 82 89 41 0c eb c8 8b 44 24 08 83 c4
10 5b 5e 5f 5d c3 57
Jul 14 13:43:30 lara [  157.953841] Code: 08 00 74 2f 8b 56 08 31 c0 89
d1 c1 e9 02 8b 7c 24 08 f3 ab f6 c2 02 74 02 66 ab f6 c2 01 74 01 aa eb
10 0f b7 41 0a 8b 54 24 08 <8b> 04 82 89 41 0c eb c8 8b 44 24 08 83 c4
10 5b 5e 5f 5d c3 57
Jul 14 13:43:30 lara [  157.953943] EIP: [<c015d269>]
kmem_cache_zalloc+0x75/0x89 SS:ESP 0068:db1ced98
Jul 14 13:43:30 lara [  157.953943] EIP: [<c015d269>]
kmem_cache_zalloc+0x75/0x89 SS:ESP 0068:db1ced98
Jul 14 13:43:30 lara [  157.954836] BUG: unable to handle kernel paging
request at virtual address 43b7a800
Jul 14 13:43:30 lara [  157.954847]  printing eip:
Jul 14 13:43:30 lara [  157.954852] c015d269
Jul 14 13:43:30 lara [  157.954856] *pde = 00000000
Jul 14 13:43:30 lara [  157.954863] Oops: 0000 [#2]
Jul 14 13:43:30 lara [  157.954863] Oops: 0000 [#2]
Jul 14 13:43:30 lara [  157.954865] PREEMPT SMP
Jul 14 13:43:30 lara [  157.954865] PREEMPT SMP
Jul 14 13:43:30 lara [  157.954870] Modules linked in: fixed pc87360
hwmon_vid i2c_isa eeprom adm1021 uhci_hcd sr_mod shpchp pci_hotplug
ohci_hcd iTCO_wdt iTCO_vendor_support intel_agp i82860_edac i2c_i801
ehci_hcd usbcore edac_mc cdrom agpgart 3c59x mii ext4dev jbd2 capability
commoncap loop lp parport_pc parport
Jul 14 13:43:30 lara [  157.954913] CPU:    3
Jul 14 13:43:30 lara [  157.954913] CPU:    3
Jul 14 13:43:30 lara [  157.954914] EIP:    0060:[<c015d269>]    Not
tainted VLI
Jul 14 13:43:30 lara [  157.954914] EIP:    0060:[<c015d269>]    Not
tainted VLI
Jul 14 13:43:30 lara [  157.954916] EFLAGS: 00010006   (2.6.22-g8d9107e8 #7)
Jul 14 13:43:30 lara [  157.954916] EFLAGS: 00010006   (2.6.22-g8d9107e8 #7)
Jul 14 13:43:30 lara [  157.954929] EIP is at kmem_cache_zalloc+0x75/0x89
Jul 14 13:43:30 lara [  157.954929] EIP is at kmem_cache_zalloc+0x75/0x89
Jul 14 13:43:30 lara [  157.954934] eax: 00000000   ebx: 00000282   ecx:
c14c8760   edx: 43b7a800
Jul 14 13:43:30 lara [  157.954934] eax: 00000000   ebx: 00000282   ecx:
c14c8760   edx: 43b7a800
Jul 14 13:43:30 lara [  157.954941] esi: e7f75840   edi: fffffff4   ebp:
000000d0   esp: e6c05eec
Jul 14 13:43:30 lara [  157.954941] esi: e7f75840   edi: fffffff4   ebp:
000000d0   esp: e6c05eec
Jul 14 13:43:30 lara [  157.954949] ds: 007b   es: 007b   fs: 00d8  gs:
0033  ss: 0068
Jul 14 13:43:30 lara [  157.954949] ds: 007b   es: 007b   fs: 00d8  gs:
0033  ss: 0068
Jul 14 13:43:30 lara [  157.954956] Process udevd (pid: 611, ti=e6c05000
task=c1791840 task.ti=e6c05000)
Jul 14 13:43:30 lara [  157.954956] Process udevd (pid: 611, ti=e6c05000
task=c1791840 task.ti=e6c05000)
Jul 14 13:43:30 lara [  157.954961] Stack: 000200d0 00000010 43b7a800
00000296 db448000 c1791840 fffffff4 db448000
Jul 14 13:43:30 lara [  157.954961] Stack: 000200d0 00000010 43b7a800
00000296 db448000 c1791840 fffffff4 db448000
Jul 14 13:43:30 lara [  157.954979]        c014373a db4c4000 c011973d
c1525154 db7b36e0 e6c05fb8 e6c05fb8 bff81c98
Jul 14 13:43:30 lara [  157.954979]        c014373a db4c4000 c011973d
c1525154 db7b36e0 e6c05fb8 e6c05fb8 bff81c98
Jul 14 13:43:30 lara [  157.954995]        01200011 c0128c84 db448000
c03ab4b4 e7e147d0 c03ab4b0 00000879 00000001
Jul 14 13:43:30 lara [  157.954995]        01200011 c0128c84 db448000
c03ab4b4 e7e147d0 c03ab4b0 00000879 00000001
Jul 14 13:43:30 lara [  157.955013] Call Trace:
Jul 14 13:43:30 lara [  157.955013] Call Trace:
Jul 14 13:43:30 lara [  157.955025]  [<c014373a>]
__delayacct_tsk_init+0x12/0x2b
Jul 14 13:43:30 lara [  157.955025]  [<c014373a>]
__delayacct_tsk_init+0x12/0x2b
Jul 14 13:43:30 lara [  157.955039]  [<c011973d>] copy_process+0x289/0x1150
Jul 14 13:43:30 lara [  157.955039]  [<c011973d>] copy_process+0x289/0x1150
Jul 14 13:43:30 lara [  157.955058]  [<c0128c84>] alloc_pid+0x212/0x236
Jul 14 13:43:30 lara [  157.955058]  [<c0128c84>] alloc_pid+0x212/0x236
Jul 14 13:43:30 lara [  157.955079]  [<c011a860>] do_fork+0x9a/0x1c2
Jul 14 13:43:30 lara [  157.955079]  [<c011a860>] do_fork+0x9a/0x1c2
Jul 14 13:43:30 lara [  157.955098]  [<c010221f>] sys_clone+0x36/0x3b
Jul 14 13:43:30 lara [  157.955098]  [<c010221f>] sys_clone+0x36/0x3b
Jul 14 13:43:30 lara [  157.955106]  [<c0103dee>]
sysenter_past_esp+0x5f/0x85
Jul 14 13:43:30 lara [  157.955106]  [<c0103dee>]
sysenter_past_esp+0x5f/0x85
Jul 14 13:43:30 lara [  157.955121]  =======================
Jul 14 13:43:30 lara [  157.955121]  =======================
Jul 14 13:43:30 lara [  157.955123] Code: 08 00 74 2f 8b 56 08 31 c0 89
d1 c1 e9 02 8b 7c 24 08 f3 ab f6 c2 02 74 02 66 ab f6 c2 01 74 01 aa eb
10 0f b7 41 0a 8b 54 24 08 <8b> 04 82 89 41 0c eb c8 8b 44 24 08 83 c4
10 5b 5e 5f 5d c3 57
Jul 14 13:43:30 lara [  157.955123] Code: 08 00 74 2f 8b 56 08 31 c0 89
d1 c1 e9 02 8b 7c 24 08 f3 ab f6 c2 02 74 02 66 ab f6 c2 01 74 01 aa eb
10 0f b7 41 0a 8b 54 24 08 <8b> 04 82 89 41 0c eb c8 8b 44 24 08 83 c4
10 5b 5e 5f 5d c3 57
Jul 14 13:43:30 lara [  157.955204] EIP: [<c015d269>]
kmem_cache_zalloc+0x75/0x89 SS:ESP 0068:e6c05eec
Jul 14 13:43:30 lara [  157.955204] EIP: [<c015d269>]
kmem_cache_zalloc+0x75/0x89 SS:ESP 0068:e6c05eec


Config is attached.

Regards,

Gabriel C

[-- Attachment #2: config-2.6.22-g8d9107e8 --]
[-- Type: text/plain, Size: 54259 bytes --]

#
# Automatically generated make config: don't edit
# Linux kernel version: 2.6.22
# Sat Jul 14 02:23:34 2007
#
CONFIG_X86_32=y
CONFIG_GENERIC_TIME=y
CONFIG_CLOCKSOURCE_WATCHDOG=y
CONFIG_GENERIC_CLOCKEVENTS=y
CONFIG_GENERIC_CLOCKEVENTS_BROADCAST=y
CONFIG_LOCKDEP_SUPPORT=y
CONFIG_STACKTRACE_SUPPORT=y
CONFIG_SEMAPHORE_SLEEPERS=y
CONFIG_X86=y
CONFIG_MMU=y
CONFIG_ZONE_DMA=y
CONFIG_QUICKLIST=y
CONFIG_GENERIC_ISA_DMA=y
CONFIG_GENERIC_IOMAP=y
CONFIG_GENERIC_BUG=y
CONFIG_GENERIC_HWEIGHT=y
CONFIG_ARCH_MAY_HAVE_PC_FDC=y
CONFIG_DMI=y
CONFIG_DEFCONFIG_LIST="/lib/modules/$UNAME_RELEASE/.config"

#
# Code maturity level options
#
CONFIG_EXPERIMENTAL=y
CONFIG_LOCK_KERNEL=y
CONFIG_INIT_ENV_ARG_LIMIT=32

#
# General setup
#
CONFIG_LOCALVERSION=""
CONFIG_LOCALVERSION_AUTO=y
CONFIG_SWAP=y
CONFIG_SYSVIPC=y
CONFIG_IPC_NS=y
CONFIG_SYSVIPC_SYSCTL=y
CONFIG_POSIX_MQUEUE=y
CONFIG_BSD_PROCESS_ACCT=y
# CONFIG_BSD_PROCESS_ACCT_V3 is not set
CONFIG_TASKSTATS=y
CONFIG_TASK_DELAY_ACCT=y
CONFIG_TASK_XACCT=y
CONFIG_TASK_IO_ACCOUNTING=y
CONFIG_UTS_NS=y
CONFIG_AUDIT=y
CONFIG_AUDITSYSCALL=y
CONFIG_IKCONFIG=y
CONFIG_IKCONFIG_PROC=y
CONFIG_LOG_BUF_SHIFT=17
# CONFIG_CPUSETS is not set
# CONFIG_SYSFS_DEPRECATED is not set
CONFIG_RELAY=y
CONFIG_BLK_DEV_INITRD=y
CONFIG_INITRAMFS_SOURCE=""
CONFIG_CC_OPTIMIZE_FOR_SIZE=y
CONFIG_SYSCTL=y
# CONFIG_EMBEDDED is not set
CONFIG_UID16=y
CONFIG_SYSCTL_SYSCALL=y
CONFIG_KALLSYMS=y
# CONFIG_KALLSYMS_ALL is not set
CONFIG_KALLSYMS_EXTRA_PASS=y
CONFIG_HOTPLUG=y
CONFIG_PRINTK=y
CONFIG_BUG=y
CONFIG_ELF_CORE=y
CONFIG_BASE_FULL=y
CONFIG_FUTEX=y
CONFIG_ANON_INODES=y
CONFIG_EPOLL=y
CONFIG_SIGNALFD=y
CONFIG_TIMERFD=y
CONFIG_EVENTFD=y
CONFIG_SHMEM=y
CONFIG_VM_EVENT_COUNTERS=y
CONFIG_SLUB_DEBUG=y
# CONFIG_SLAB is not set
CONFIG_SLUB=y
# CONFIG_SLOB is not set
CONFIG_RT_MUTEXES=y
# CONFIG_TINY_SHMEM is not set
CONFIG_BASE_SMALL=0

#
# Loadable module support
#
CONFIG_MODULES=y
CONFIG_MODULE_UNLOAD=y
CONFIG_MODULE_FORCE_UNLOAD=y
CONFIG_MODVERSIONS=y
# CONFIG_MODULE_SRCVERSION_ALL is not set
CONFIG_KMOD=y
CONFIG_STOP_MACHINE=y
CONFIG_BLOCK=y
CONFIG_LBD=y
CONFIG_BLK_DEV_IO_TRACE=y
CONFIG_LSF=y

#
# IO Schedulers
#
CONFIG_IOSCHED_NOOP=y
CONFIG_IOSCHED_AS=y
CONFIG_IOSCHED_DEADLINE=y
CONFIG_IOSCHED_CFQ=y
# CONFIG_DEFAULT_AS is not set
# CONFIG_DEFAULT_DEADLINE is not set
CONFIG_DEFAULT_CFQ=y
# CONFIG_DEFAULT_NOOP is not set
CONFIG_DEFAULT_IOSCHED="cfq"

#
# Processor type and features
#
CONFIG_TICK_ONESHOT=y
CONFIG_NO_HZ=y
CONFIG_HIGH_RES_TIMERS=y
CONFIG_SMP=y
CONFIG_X86_PC=y
# CONFIG_X86_ELAN is not set
# CONFIG_X86_VOYAGER is not set
# CONFIG_X86_NUMAQ is not set
# CONFIG_X86_SUMMIT is not set
# CONFIG_X86_BIGSMP is not set
# CONFIG_X86_VISWS is not set
# CONFIG_X86_GENERICARCH is not set
# CONFIG_X86_ES7000 is not set
# CONFIG_PARAVIRT is not set
# CONFIG_M386 is not set
# CONFIG_M486 is not set
# CONFIG_M586 is not set
# CONFIG_M586TSC is not set
# CONFIG_M586MMX is not set
# CONFIG_M686 is not set
# CONFIG_MPENTIUMII is not set
# CONFIG_MPENTIUMIII is not set
# CONFIG_MPENTIUMM is not set
# CONFIG_MCORE2 is not set
CONFIG_MPENTIUM4=y
# CONFIG_MK6 is not set
# CONFIG_MK7 is not set
# CONFIG_MK8 is not set
# CONFIG_MCRUSOE is not set
# CONFIG_MEFFICEON is not set
# CONFIG_MWINCHIPC6 is not set
# CONFIG_MWINCHIP2 is not set
# CONFIG_MWINCHIP3D is not set
# CONFIG_MGEODEGX1 is not set
# CONFIG_MGEODE_LX is not set
# CONFIG_MCYRIXIII is not set
# CONFIG_MVIAC3_2 is not set
# CONFIG_MVIAC7 is not set
# CONFIG_X86_GENERIC is not set
CONFIG_X86_CMPXCHG=y
CONFIG_X86_L1_CACHE_SHIFT=7
CONFIG_X86_XADD=y
CONFIG_RWSEM_XCHGADD_ALGORITHM=y
# CONFIG_ARCH_HAS_ILOG2_U32 is not set
# CONFIG_ARCH_HAS_ILOG2_U64 is not set
CONFIG_GENERIC_CALIBRATE_DELAY=y
CONFIG_X86_WP_WORKS_OK=y
CONFIG_X86_INVLPG=y
CONFIG_X86_BSWAP=y
CONFIG_X86_POPAD_OK=y
CONFIG_X86_GOOD_APIC=y
CONFIG_X86_INTEL_USERCOPY=y
CONFIG_X86_USE_PPRO_CHECKSUM=y
CONFIG_X86_TSC=y
CONFIG_X86_CMOV=y
CONFIG_X86_MINIMUM_CPU_FAMILY=4
# CONFIG_HPET_TIMER is not set
CONFIG_NR_CPUS=8
CONFIG_SCHED_SMT=y
CONFIG_SCHED_MC=y
# CONFIG_PREEMPT_NONE is not set
# CONFIG_PREEMPT_VOLUNTARY is not set
CONFIG_PREEMPT=y
CONFIG_PREEMPT_BKL=y
CONFIG_X86_LOCAL_APIC=y
CONFIG_X86_IO_APIC=y
CONFIG_X86_MCE=y
CONFIG_X86_MCE_NONFATAL=y
CONFIG_X86_MCE_P4THERMAL=y
CONFIG_VM86=y
# CONFIG_TOSHIBA is not set
# CONFIG_I8K is not set
CONFIG_X86_REBOOTFIXUPS=y
CONFIG_MICROCODE=m
CONFIG_MICROCODE_OLD_INTERFACE=y
CONFIG_X86_MSR=y
CONFIG_X86_CPUID=y

#
# Firmware Drivers
#
CONFIG_EDD=y
CONFIG_DELL_RBU=y
CONFIG_DCDBAS=y
CONFIG_DMIID=y
CONFIG_NOHIGHMEM=y
# CONFIG_HIGHMEM4G is not set
# CONFIG_HIGHMEM64G is not set
CONFIG_PAGE_OFFSET=0xC0000000
CONFIG_ARCH_FLATMEM_ENABLE=y
CONFIG_ARCH_SPARSEMEM_ENABLE=y
CONFIG_ARCH_SELECT_MEMORY_MODEL=y
CONFIG_ARCH_POPULATES_NODE_MAP=y
CONFIG_SELECT_MEMORY_MODEL=y
CONFIG_FLATMEM_MANUAL=y
# CONFIG_DISCONTIGMEM_MANUAL is not set
# CONFIG_SPARSEMEM_MANUAL is not set
CONFIG_FLATMEM=y
CONFIG_FLAT_NODE_MEM_MAP=y
CONFIG_SPARSEMEM_STATIC=y
CONFIG_SPLIT_PTLOCK_CPUS=4
# CONFIG_RESOURCES_64BIT is not set
CONFIG_ZONE_DMA_FLAG=1
CONFIG_NR_QUICK=1
# CONFIG_MATH_EMULATION is not set
CONFIG_MTRR=y
# CONFIG_EFI is not set
CONFIG_IRQBALANCE=y
CONFIG_SECCOMP=y
# CONFIG_HZ_100 is not set
# CONFIG_HZ_250 is not set
# CONFIG_HZ_300 is not set
CONFIG_HZ_1000=y
CONFIG_HZ=1000
CONFIG_KEXEC=y
CONFIG_PHYSICAL_START=0x100000
# CONFIG_RELOCATABLE is not set
CONFIG_PHYSICAL_ALIGN=0x100000
# CONFIG_HOTPLUG_CPU is not set
# CONFIG_COMPAT_VDSO is not set

#
# Power management options (ACPI, APM)
#
CONFIG_PM=y
# CONFIG_PM_LEGACY is not set
# CONFIG_PM_DEBUG is not set
# CONFIG_PM_SYSFS_DEPRECATED is not set

#
# ACPI (Advanced Configuration and Power Interface) Support
#
CONFIG_ACPI=y
CONFIG_ACPI_PROCFS=y
# CONFIG_ACPI_AC is not set
# CONFIG_ACPI_BATTERY is not set
CONFIG_ACPI_BUTTON=m
CONFIG_ACPI_VIDEO=m
CONFIG_ACPI_FAN=m
# CONFIG_ACPI_DOCK is not set
CONFIG_ACPI_PROCESSOR=y
CONFIG_ACPI_THERMAL=y
# CONFIG_ACPI_ASUS is not set
# CONFIG_ACPI_TOSHIBA is not set
CONFIG_ACPI_BLACKLIST_YEAR=0
# CONFIG_ACPI_DEBUG is not set
CONFIG_ACPI_EC=y
CONFIG_ACPI_POWER=y
CONFIG_ACPI_SYSTEM=y
CONFIG_X86_PM_TIMER=y
CONFIG_ACPI_CONTAINER=m
# CONFIG_ACPI_SBS is not set
# CONFIG_APM is not set

#
# CPU Frequency scaling
#
CONFIG_CPU_FREQ=y
CONFIG_CPU_FREQ_TABLE=m
# CONFIG_CPU_FREQ_DEBUG is not set
CONFIG_CPU_FREQ_STAT=m
CONFIG_CPU_FREQ_STAT_DETAILS=y
CONFIG_CPU_FREQ_DEFAULT_GOV_PERFORMANCE=y
# CONFIG_CPU_FREQ_DEFAULT_GOV_USERSPACE is not set
CONFIG_CPU_FREQ_GOV_PERFORMANCE=y
CONFIG_CPU_FREQ_GOV_POWERSAVE=m
CONFIG_CPU_FREQ_GOV_USERSPACE=m
CONFIG_CPU_FREQ_GOV_ONDEMAND=m
CONFIG_CPU_FREQ_GOV_CONSERVATIVE=m

#
# CPUFreq processor drivers
#
CONFIG_X86_ACPI_CPUFREQ=m
# CONFIG_X86_POWERNOW_K6 is not set
# CONFIG_X86_POWERNOW_K7 is not set
# CONFIG_X86_POWERNOW_K8 is not set
# CONFIG_X86_GX_SUSPMOD is not set
# CONFIG_X86_SPEEDSTEP_CENTRINO is not set
# CONFIG_X86_SPEEDSTEP_ICH is not set
# CONFIG_X86_SPEEDSTEP_SMI is not set
CONFIG_X86_P4_CLOCKMOD=m
# CONFIG_X86_CPUFREQ_NFORCE2 is not set
# CONFIG_X86_LONGRUN is not set
# CONFIG_X86_LONGHAUL is not set
# CONFIG_X86_E_POWERSAVER is not set

#
# shared options
#
# CONFIG_X86_ACPI_CPUFREQ_PROC_INTF is not set
CONFIG_X86_SPEEDSTEP_LIB=m

#
# Bus options (PCI, PCMCIA, EISA, MCA, ISA)
#
CONFIG_PCI=y
# CONFIG_PCI_GOBIOS is not set
# CONFIG_PCI_GOMMCONFIG is not set
CONFIG_PCI_GODIRECT=y
# CONFIG_PCI_GOANY is not set
CONFIG_PCI_DIRECT=y
# CONFIG_PCIEPORTBUS is not set
CONFIG_ARCH_SUPPORTS_MSI=y
# CONFIG_PCI_MSI is not set
# CONFIG_PCI_DEBUG is not set
CONFIG_HT_IRQ=y
CONFIG_ISA_DMA_API=y
CONFIG_ISA=y
# CONFIG_EISA is not set
# CONFIG_MCA is not set
# CONFIG_SCx200 is not set

#
# PCCARD (PCMCIA/CardBus) support
#
# CONFIG_PCCARD is not set
CONFIG_HOTPLUG_PCI=m
CONFIG_HOTPLUG_PCI_FAKE=m
CONFIG_HOTPLUG_PCI_ACPI=m
# CONFIG_HOTPLUG_PCI_ACPI_IBM is not set
# CONFIG_HOTPLUG_PCI_CPCI is not set
CONFIG_HOTPLUG_PCI_SHPC=m

#
# Executable file formats
#
CONFIG_BINFMT_ELF=y
CONFIG_BINFMT_AOUT=y
CONFIG_BINFMT_MISC=y

#
# Networking
#
CONFIG_NET=y

#
# Networking options
#
CONFIG_PACKET=y
CONFIG_PACKET_MMAP=y
CONFIG_UNIX=y
CONFIG_XFRM=y
CONFIG_XFRM_USER=m
# CONFIG_XFRM_SUB_POLICY is not set
# CONFIG_XFRM_MIGRATE is not set
CONFIG_NET_KEY=m
# CONFIG_NET_KEY_MIGRATE is not set
CONFIG_INET=y
CONFIG_IP_MULTICAST=y
CONFIG_IP_ADVANCED_ROUTER=y
CONFIG_ASK_IP_FIB_HASH=y
# CONFIG_IP_FIB_TRIE is not set
CONFIG_IP_FIB_HASH=y
CONFIG_IP_MULTIPLE_TABLES=y
CONFIG_IP_ROUTE_MULTIPATH=y
# CONFIG_IP_ROUTE_VERBOSE is not set
CONFIG_IP_PNP=y
CONFIG_IP_PNP_DHCP=y
CONFIG_IP_PNP_BOOTP=y
CONFIG_IP_PNP_RARP=y
CONFIG_NET_IPIP=m
CONFIG_NET_IPGRE=m
# CONFIG_NET_IPGRE_BROADCAST is not set
CONFIG_IP_MROUTE=y
CONFIG_IP_PIMSM_V1=y
CONFIG_IP_PIMSM_V2=y
# CONFIG_ARPD is not set
CONFIG_SYN_COOKIES=y
CONFIG_INET_AH=m
CONFIG_INET_ESP=m
CONFIG_INET_IPCOMP=m
CONFIG_INET_XFRM_TUNNEL=m
CONFIG_INET_TUNNEL=m
CONFIG_INET_XFRM_MODE_TRANSPORT=m
CONFIG_INET_XFRM_MODE_TUNNEL=m
CONFIG_INET_XFRM_MODE_BEET=m
CONFIG_INET_DIAG=y
CONFIG_INET_TCP_DIAG=y
CONFIG_TCP_CONG_ADVANCED=y
CONFIG_TCP_CONG_BIC=m
CONFIG_TCP_CONG_CUBIC=y
CONFIG_TCP_CONG_WESTWOOD=m
CONFIG_TCP_CONG_HTCP=m
CONFIG_TCP_CONG_HSTCP=m
CONFIG_TCP_CONG_HYBLA=y
CONFIG_TCP_CONG_VEGAS=m
CONFIG_TCP_CONG_SCALABLE=m
CONFIG_TCP_CONG_LP=m
CONFIG_TCP_CONG_VENO=m
CONFIG_TCP_CONG_YEAH=m
CONFIG_TCP_CONG_ILLINOIS=m
# CONFIG_DEFAULT_BIC is not set
CONFIG_DEFAULT_CUBIC=y
# CONFIG_DEFAULT_HTCP is not set
# CONFIG_DEFAULT_VEGAS is not set
# CONFIG_DEFAULT_WESTWOOD is not set
# CONFIG_DEFAULT_RENO is not set
CONFIG_DEFAULT_TCP_CONG="cubic"
CONFIG_TCP_MD5SIG=y
# CONFIG_IP_VS is not set
# CONFIG_IPV6 is not set
# CONFIG_INET6_XFRM_TUNNEL is not set
# CONFIG_INET6_TUNNEL is not set
# CONFIG_NETLABEL is not set
CONFIG_NETWORK_SECMARK=y
CONFIG_NETFILTER=y
# CONFIG_NETFILTER_DEBUG is not set
CONFIG_BRIDGE_NETFILTER=y

#
# Core Netfilter Configuration
#
CONFIG_NETFILTER_NETLINK=m
CONFIG_NETFILTER_NETLINK_QUEUE=m
CONFIG_NETFILTER_NETLINK_LOG=m
CONFIG_NF_CONNTRACK_ENABLED=m
CONFIG_NF_CONNTRACK=m
CONFIG_NF_CT_ACCT=y
CONFIG_NF_CONNTRACK_MARK=y
CONFIG_NF_CONNTRACK_SECMARK=y
CONFIG_NF_CONNTRACK_EVENTS=y
CONFIG_NF_CT_PROTO_GRE=m
CONFIG_NF_CT_PROTO_SCTP=m
CONFIG_NF_CONNTRACK_AMANDA=m
CONFIG_NF_CONNTRACK_FTP=m
CONFIG_NF_CONNTRACK_H323=m
CONFIG_NF_CONNTRACK_IRC=m
CONFIG_NF_CONNTRACK_NETBIOS_NS=m
CONFIG_NF_CONNTRACK_PPTP=m
CONFIG_NF_CONNTRACK_SANE=m
CONFIG_NF_CONNTRACK_SIP=m
CONFIG_NF_CONNTRACK_TFTP=m
CONFIG_NF_CT_NETLINK=m
CONFIG_NETFILTER_XTABLES=m
CONFIG_NETFILTER_XT_TARGET_CLASSIFY=m
CONFIG_NETFILTER_XT_TARGET_CONNMARK=m
CONFIG_NETFILTER_XT_TARGET_DSCP=m
CONFIG_NETFILTER_XT_TARGET_MARK=m
CONFIG_NETFILTER_XT_TARGET_NFQUEUE=m
CONFIG_NETFILTER_XT_TARGET_NFLOG=m
CONFIG_NETFILTER_XT_TARGET_NOTRACK=m
CONFIG_NETFILTER_XT_TARGET_TRACE=m
CONFIG_NETFILTER_XT_TARGET_SECMARK=m
CONFIG_NETFILTER_XT_TARGET_CONNSECMARK=m
CONFIG_NETFILTER_XT_TARGET_TCPMSS=m
CONFIG_NETFILTER_XT_MATCH_COMMENT=m
CONFIG_NETFILTER_XT_MATCH_CONNBYTES=m
CONFIG_NETFILTER_XT_MATCH_CONNMARK=m
CONFIG_NETFILTER_XT_MATCH_CONNTRACK=m
CONFIG_NETFILTER_XT_MATCH_DCCP=m
CONFIG_NETFILTER_XT_MATCH_DSCP=m
CONFIG_NETFILTER_XT_MATCH_ESP=m
CONFIG_NETFILTER_XT_MATCH_HELPER=m
CONFIG_NETFILTER_XT_MATCH_LENGTH=m
CONFIG_NETFILTER_XT_MATCH_LIMIT=m
CONFIG_NETFILTER_XT_MATCH_MAC=m
CONFIG_NETFILTER_XT_MATCH_MARK=m
CONFIG_NETFILTER_XT_MATCH_POLICY=m
CONFIG_NETFILTER_XT_MATCH_MULTIPORT=m
CONFIG_NETFILTER_XT_MATCH_PHYSDEV=m
CONFIG_NETFILTER_XT_MATCH_PKTTYPE=m
CONFIG_NETFILTER_XT_MATCH_QUOTA=m
CONFIG_NETFILTER_XT_MATCH_REALM=m
CONFIG_NETFILTER_XT_MATCH_SCTP=m
CONFIG_NETFILTER_XT_MATCH_STATE=m
CONFIG_NETFILTER_XT_MATCH_STATISTIC=m
CONFIG_NETFILTER_XT_MATCH_STRING=m
CONFIG_NETFILTER_XT_MATCH_TCPMSS=m
CONFIG_NETFILTER_XT_MATCH_U32=m
CONFIG_NETFILTER_XT_MATCH_HASHLIMIT=m

#
# IP: Netfilter Configuration
#
CONFIG_NF_CONNTRACK_IPV4=m
CONFIG_NF_CONNTRACK_PROC_COMPAT=y
CONFIG_IP_NF_QUEUE=m
CONFIG_IP_NF_IPTABLES=m
CONFIG_IP_NF_MATCH_IPRANGE=m
CONFIG_IP_NF_MATCH_TOS=m
CONFIG_IP_NF_MATCH_RECENT=m
CONFIG_IP_NF_MATCH_ECN=m
CONFIG_IP_NF_MATCH_AH=m
CONFIG_IP_NF_MATCH_TTL=m
CONFIG_IP_NF_MATCH_OWNER=m
CONFIG_IP_NF_MATCH_ADDRTYPE=m
CONFIG_IP_NF_FILTER=m
CONFIG_IP_NF_TARGET_REJECT=m
CONFIG_IP_NF_TARGET_LOG=m
CONFIG_IP_NF_TARGET_ULOG=m
CONFIG_NF_NAT=m
CONFIG_NF_NAT_NEEDED=y
CONFIG_IP_NF_TARGET_MASQUERADE=m
CONFIG_IP_NF_TARGET_REDIRECT=m
CONFIG_IP_NF_TARGET_NETMAP=m
CONFIG_IP_NF_TARGET_SAME=m
CONFIG_NF_NAT_SNMP_BASIC=m
CONFIG_NF_NAT_PROTO_GRE=m
CONFIG_NF_NAT_FTP=m
CONFIG_NF_NAT_IRC=m
CONFIG_NF_NAT_TFTP=m
CONFIG_NF_NAT_AMANDA=m
CONFIG_NF_NAT_PPTP=m
CONFIG_NF_NAT_H323=m
CONFIG_NF_NAT_SIP=m
CONFIG_IP_NF_MANGLE=m
CONFIG_IP_NF_TARGET_TOS=m
CONFIG_IP_NF_TARGET_ECN=m
CONFIG_IP_NF_TARGET_TTL=m
CONFIG_IP_NF_TARGET_CLUSTERIP=m
CONFIG_IP_NF_RAW=m
CONFIG_IP_NF_ARPTABLES=m
CONFIG_IP_NF_ARPFILTER=m
CONFIG_IP_NF_ARP_MANGLE=m

#
# DECnet: Netfilter Configuration
#
CONFIG_DECNET_NF_GRABULATOR=m

#
# Bridge: Netfilter Configuration
#
CONFIG_BRIDGE_NF_EBTABLES=m
CONFIG_BRIDGE_EBT_BROUTE=m
CONFIG_BRIDGE_EBT_T_FILTER=m
CONFIG_BRIDGE_EBT_T_NAT=m
CONFIG_BRIDGE_EBT_802_3=m
CONFIG_BRIDGE_EBT_AMONG=m
CONFIG_BRIDGE_EBT_ARP=m
CONFIG_BRIDGE_EBT_IP=m
CONFIG_BRIDGE_EBT_LIMIT=m
CONFIG_BRIDGE_EBT_MARK=m
CONFIG_BRIDGE_EBT_PKTTYPE=m
CONFIG_BRIDGE_EBT_STP=m
CONFIG_BRIDGE_EBT_VLAN=m
CONFIG_BRIDGE_EBT_ARPREPLY=m
CONFIG_BRIDGE_EBT_DNAT=m
CONFIG_BRIDGE_EBT_MARK_T=m
CONFIG_BRIDGE_EBT_REDIRECT=m
CONFIG_BRIDGE_EBT_SNAT=m
CONFIG_BRIDGE_EBT_LOG=m
CONFIG_BRIDGE_EBT_ULOG=m
CONFIG_IP_DCCP=m
CONFIG_INET_DCCP_DIAG=m
CONFIG_IP_DCCP_ACKVEC=y

#
# DCCP CCIDs Configuration (EXPERIMENTAL)
#
CONFIG_IP_DCCP_CCID2=m
# CONFIG_IP_DCCP_CCID2_DEBUG is not set
CONFIG_IP_DCCP_CCID3=m
CONFIG_IP_DCCP_TFRC_LIB=m
# CONFIG_IP_DCCP_CCID3_DEBUG is not set
CONFIG_IP_DCCP_CCID3_RTO=100

#
# DCCP Kernel Hacking
#
# CONFIG_IP_DCCP_DEBUG is not set
CONFIG_IP_SCTP=m
# CONFIG_SCTP_DBG_MSG is not set
# CONFIG_SCTP_DBG_OBJCNT is not set
# CONFIG_SCTP_HMAC_NONE is not set
# CONFIG_SCTP_HMAC_SHA1 is not set
CONFIG_SCTP_HMAC_MD5=y
CONFIG_TIPC=m
CONFIG_TIPC_ADVANCED=y
CONFIG_TIPC_ZONES=3
CONFIG_TIPC_CLUSTERS=1
CONFIG_TIPC_NODES=255
CONFIG_TIPC_SLAVE_NODES=0
CONFIG_TIPC_PORTS=8191
CONFIG_TIPC_LOG=0
# CONFIG_TIPC_DEBUG is not set
CONFIG_ATM=m
CONFIG_ATM_CLIP=m
# CONFIG_ATM_CLIP_NO_ICMP is not set
# CONFIG_ATM_LANE is not set
CONFIG_ATM_BR2684=m
CONFIG_ATM_BR2684_IPFILTER=y
CONFIG_BRIDGE=m
CONFIG_VLAN_8021Q=m
CONFIG_DECNET=m
# CONFIG_DECNET_ROUTER is not set
CONFIG_LLC=m
CONFIG_LLC2=m
CONFIG_IPX=m
# CONFIG_IPX_INTERN is not set
CONFIG_ATALK=m
CONFIG_DEV_APPLETALK=m
CONFIG_LTPC=m
CONFIG_COPS=m
# CONFIG_COPS_DAYNA is not set
# CONFIG_COPS_TANGENT is not set
CONFIG_IPDDP=m
CONFIG_IPDDP_ENCAP=y
CONFIG_IPDDP_DECAP=y
# CONFIG_X25 is not set
# CONFIG_LAPB is not set
# CONFIG_ECONET is not set
CONFIG_WAN_ROUTER=m

#
# QoS and/or fair queueing
#
CONFIG_NET_SCHED=y
CONFIG_NET_SCH_FIFO=y

#
# Queueing/Scheduling
#
CONFIG_NET_SCH_CBQ=m
CONFIG_NET_SCH_HTB=m
CONFIG_NET_SCH_HFSC=m
CONFIG_NET_SCH_ATM=m
CONFIG_NET_SCH_PRIO=m
CONFIG_NET_SCH_RR=m
CONFIG_NET_SCH_RED=m
CONFIG_NET_SCH_SFQ=m
CONFIG_NET_SCH_TEQL=m
CONFIG_NET_SCH_TBF=m
CONFIG_NET_SCH_GRED=m
CONFIG_NET_SCH_DSMARK=m
CONFIG_NET_SCH_NETEM=m
CONFIG_NET_SCH_INGRESS=m

#
# Classification
#
CONFIG_NET_CLS=y
CONFIG_NET_CLS_BASIC=m
CONFIG_NET_CLS_TCINDEX=m
CONFIG_NET_CLS_ROUTE4=m
CONFIG_NET_CLS_ROUTE=y
CONFIG_NET_CLS_FW=m
CONFIG_NET_CLS_U32=m
CONFIG_CLS_U32_PERF=y
CONFIG_CLS_U32_MARK=y
CONFIG_NET_CLS_RSVP=m
CONFIG_NET_CLS_RSVP6=m
CONFIG_NET_EMATCH=y
CONFIG_NET_EMATCH_STACK=32
CONFIG_NET_EMATCH_CMP=m
CONFIG_NET_EMATCH_NBYTE=m
CONFIG_NET_EMATCH_U32=m
CONFIG_NET_EMATCH_META=m
CONFIG_NET_EMATCH_TEXT=m
CONFIG_NET_CLS_ACT=y
CONFIG_NET_ACT_POLICE=m
CONFIG_NET_ACT_GACT=m
CONFIG_GACT_PROB=y
CONFIG_NET_ACT_MIRRED=m
CONFIG_NET_ACT_IPT=m
CONFIG_NET_ACT_PEDIT=m
# CONFIG_NET_ACT_SIMP is not set
CONFIG_NET_CLS_IND=y

#
# Network testing
#
# CONFIG_NET_PKTGEN is not set
# CONFIG_HAMRADIO is not set
# CONFIG_IRDA is not set
# CONFIG_BT is not set
# CONFIG_AF_RXRPC is not set
CONFIG_FIB_RULES=y

#
# Wireless
#
CONFIG_CFG80211=m
# CONFIG_WIRELESS_EXT is not set
# CONFIG_MAC80211 is not set
# CONFIG_IEEE80211 is not set
# CONFIG_RFKILL is not set

#
# Device Drivers
#

#
# Generic Driver Options
#
CONFIG_STANDALONE=y
CONFIG_PREVENT_FIRMWARE_BUILD=y
CONFIG_FW_LOADER=y
# CONFIG_DEBUG_DRIVER is not set
# CONFIG_DEBUG_DEVRES is not set
# CONFIG_SYS_HYPERVISOR is not set

#
# Connector - unified userspace <-> kernelspace linker
#
CONFIG_CONNECTOR=y
CONFIG_PROC_EVENTS=y
# CONFIG_MTD is not set

#
# Parallel port support
#
CONFIG_PARPORT=m
CONFIG_PARPORT_PC=m
CONFIG_PARPORT_SERIAL=m
CONFIG_PARPORT_PC_FIFO=y
CONFIG_PARPORT_PC_SUPERIO=y
# CONFIG_PARPORT_GSC is not set
CONFIG_PARPORT_AX88796=m
CONFIG_PARPORT_1284=y
CONFIG_PARPORT_NOT_PC=y

#
# Plug and Play support
#
CONFIG_PNP=y
# CONFIG_PNP_DEBUG is not set

#
# Protocols
#
CONFIG_ISAPNP=y
CONFIG_PNPBIOS=y
CONFIG_PNPBIOS_PROC_FS=y
CONFIG_PNPACPI=y
CONFIG_BLK_DEV=y
# CONFIG_BLK_DEV_FD is not set
# CONFIG_BLK_DEV_XD is not set
CONFIG_PARIDE=m

#
# Parallel IDE high-level drivers
#
CONFIG_PARIDE_PD=m
CONFIG_PARIDE_PCD=m
CONFIG_PARIDE_PF=m
# CONFIG_PARIDE_PT is not set
CONFIG_PARIDE_PG=m

#
# Parallel IDE protocol modules
#
# CONFIG_PARIDE_ATEN is not set
# CONFIG_PARIDE_BPCK is not set
# CONFIG_PARIDE_BPCK6 is not set
# CONFIG_PARIDE_COMM is not set
# CONFIG_PARIDE_DSTR is not set
# CONFIG_PARIDE_FIT2 is not set
# CONFIG_PARIDE_FIT3 is not set
# CONFIG_PARIDE_EPAT is not set
# CONFIG_PARIDE_EPIA is not set
# CONFIG_PARIDE_FRIQ is not set
# CONFIG_PARIDE_FRPW is not set
# CONFIG_PARIDE_KBIC is not set
# CONFIG_PARIDE_KTTI is not set
# CONFIG_PARIDE_ON20 is not set
# CONFIG_PARIDE_ON26 is not set
# CONFIG_BLK_CPQ_DA is not set
# CONFIG_BLK_CPQ_CISS_DA is not set
# CONFIG_BLK_DEV_DAC960 is not set
# CONFIG_BLK_DEV_UMEM is not set
# CONFIG_BLK_DEV_COW_COMMON is not set
CONFIG_BLK_DEV_LOOP=m
CONFIG_BLK_DEV_CRYPTOLOOP=m
CONFIG_BLK_DEV_NBD=m
# CONFIG_BLK_DEV_SX8 is not set
# CONFIG_BLK_DEV_UB is not set
CONFIG_BLK_DEV_RAM=y
CONFIG_BLK_DEV_RAM_COUNT=16
CONFIG_BLK_DEV_RAM_SIZE=16384
CONFIG_BLK_DEV_RAM_BLOCKSIZE=1024
CONFIG_CDROM_PKTCDVD=m
CONFIG_CDROM_PKTCDVD_BUFFERS=8
CONFIG_CDROM_PKTCDVD_WCACHE=y
# CONFIG_ATA_OVER_ETH is not set

#
# Misc devices
#
# CONFIG_IBM_ASM is not set
# CONFIG_PHANTOM is not set
CONFIG_EEPROM_93CX6=m
# CONFIG_SGI_IOC4 is not set
# CONFIG_TIFM_CORE is not set
# CONFIG_ASUS_LAPTOP is not set
# CONFIG_MSI_LAPTOP is not set
# CONFIG_SONY_LAPTOP is not set
# CONFIG_THINKPAD_ACPI is not set
# CONFIG_IDE is not set

#
# SCSI device support
#
CONFIG_RAID_ATTRS=m
CONFIG_SCSI=y
CONFIG_SCSI_TGT=y
CONFIG_SCSI_NETLINK=y
CONFIG_SCSI_PROC_FS=y

#
# SCSI support type (disk, tape, CD-ROM)
#
CONFIG_BLK_DEV_SD=y
# CONFIG_CHR_DEV_ST is not set
# CONFIG_CHR_DEV_OSST is not set
CONFIG_BLK_DEV_SR=m
CONFIG_BLK_DEV_SR_VENDOR=y
CONFIG_CHR_DEV_SG=y
CONFIG_CHR_DEV_SCH=m

#
# Some SCSI devices (e.g. CD jukebox) support multiple LUNs
#
CONFIG_SCSI_MULTI_LUN=y
# CONFIG_SCSI_CONSTANTS is not set
CONFIG_SCSI_LOGGING=y
CONFIG_SCSI_SCAN_ASYNC=y
CONFIG_SCSI_WAIT_SCAN=m

#
# SCSI Transports
#
CONFIG_SCSI_SPI_ATTRS=y
CONFIG_SCSI_FC_ATTRS=m
CONFIG_SCSI_ISCSI_ATTRS=m
CONFIG_SCSI_SAS_ATTRS=m
CONFIG_SCSI_SAS_LIBSAS=m
# CONFIG_SCSI_SAS_LIBSAS_DEBUG is not set

#
# SCSI low-level drivers
#
CONFIG_ISCSI_TCP=m
# CONFIG_BLK_DEV_3W_XXXX_RAID is not set
# CONFIG_SCSI_3W_9XXX is not set
# CONFIG_SCSI_7000FASST is not set
# CONFIG_SCSI_ACARD is not set
# CONFIG_SCSI_AHA152X is not set
# CONFIG_SCSI_AHA1542 is not set
# CONFIG_SCSI_AACRAID is not set
CONFIG_SCSI_AIC7XXX=y
CONFIG_AIC7XXX_CMDS_PER_DEVICE=32
CONFIG_AIC7XXX_RESET_DELAY_MS=15000
# CONFIG_AIC7XXX_DEBUG_ENABLE is not set
CONFIG_AIC7XXX_DEBUG_MASK=0
# CONFIG_AIC7XXX_REG_PRETTY_PRINT is not set
# CONFIG_SCSI_AIC7XXX_OLD is not set
# CONFIG_SCSI_AIC79XX is not set
# CONFIG_SCSI_AIC94XX is not set
# CONFIG_SCSI_DPT_I2O is not set
# CONFIG_SCSI_ADVANSYS is not set
# CONFIG_SCSI_IN2000 is not set
# CONFIG_SCSI_ARCMSR is not set
# CONFIG_MEGARAID_NEWGEN is not set
# CONFIG_MEGARAID_LEGACY is not set
# CONFIG_MEGARAID_SAS is not set
# CONFIG_SCSI_HPTIOP is not set
CONFIG_SCSI_BUSLOGIC=y
CONFIG_SCSI_OMIT_FLASHPOINT=y
# CONFIG_SCSI_DMX3191D is not set
# CONFIG_SCSI_DTC3280 is not set
# CONFIG_SCSI_EATA is not set
# CONFIG_SCSI_FUTURE_DOMAIN is not set
# CONFIG_SCSI_GDTH is not set
# CONFIG_SCSI_GENERIC_NCR5380 is not set
# CONFIG_SCSI_GENERIC_NCR5380_MMIO is not set
# CONFIG_SCSI_IPS is not set
# CONFIG_SCSI_INITIO is not set
# CONFIG_SCSI_INIA100 is not set
# CONFIG_SCSI_PPA is not set
# CONFIG_SCSI_IMM is not set
# CONFIG_SCSI_NCR53C406A is not set
# CONFIG_SCSI_STEX is not set
# CONFIG_SCSI_SYM53C8XX_2 is not set
# CONFIG_SCSI_IPR is not set
# CONFIG_SCSI_PAS16 is not set
# CONFIG_SCSI_PSI240I is not set
# CONFIG_SCSI_QLOGIC_FAS is not set
# CONFIG_SCSI_QLOGIC_1280 is not set
# CONFIG_SCSI_QLA_FC is not set
# CONFIG_SCSI_QLA_ISCSI is not set
# CONFIG_SCSI_LPFC is not set
# CONFIG_SCSI_SEAGATE is not set
# CONFIG_SCSI_SYM53C416 is not set
# CONFIG_SCSI_DC395x is not set
# CONFIG_SCSI_DC390T is not set
# CONFIG_SCSI_T128 is not set
# CONFIG_SCSI_U14_34F is not set
# CONFIG_SCSI_ULTRASTOR is not set
# CONFIG_SCSI_NSP32 is not set
# CONFIG_SCSI_DEBUG is not set
# CONFIG_SCSI_SRP is not set
CONFIG_ATA=y
# CONFIG_ATA_NONSTANDARD is not set
CONFIG_ATA_ACPI=y
# CONFIG_SATA_AHCI is not set
# CONFIG_SATA_SVW is not set
CONFIG_ATA_PIIX=y
# CONFIG_SATA_MV is not set
# CONFIG_SATA_NV is not set
# CONFIG_PDC_ADMA is not set
# CONFIG_SATA_QSTOR is not set
# CONFIG_SATA_PROMISE is not set
# CONFIG_SATA_SX4 is not set
# CONFIG_SATA_SIL is not set
# CONFIG_SATA_SIL24 is not set
# CONFIG_SATA_SIS is not set
# CONFIG_SATA_ULI is not set
# CONFIG_SATA_VIA is not set
# CONFIG_SATA_VITESSE is not set
# CONFIG_SATA_INIC162X is not set
# CONFIG_PATA_ALI is not set
# CONFIG_PATA_AMD is not set
# CONFIG_PATA_ARTOP is not set
# CONFIG_PATA_ATIIXP is not set
# CONFIG_PATA_CMD640_PCI is not set
# CONFIG_PATA_CMD64X is not set
# CONFIG_PATA_CS5520 is not set
# CONFIG_PATA_CS5530 is not set
# CONFIG_PATA_CS5535 is not set
# CONFIG_PATA_CYPRESS is not set
# CONFIG_PATA_EFAR is not set
CONFIG_ATA_GENERIC=y
# CONFIG_PATA_HPT366 is not set
# CONFIG_PATA_HPT37X is not set
# CONFIG_PATA_HPT3X2N is not set
# CONFIG_PATA_HPT3X3 is not set
# CONFIG_PATA_ISAPNP is not set
# CONFIG_PATA_IT821X is not set
# CONFIG_PATA_IT8213 is not set
# CONFIG_PATA_JMICRON is not set
# CONFIG_PATA_LEGACY is not set
# CONFIG_PATA_TRIFLEX is not set
# CONFIG_PATA_MARVELL is not set
# CONFIG_PATA_MPIIX is not set
# CONFIG_PATA_OLDPIIX is not set
# CONFIG_PATA_NETCELL is not set
# CONFIG_PATA_NS87410 is not set
# CONFIG_PATA_OPTI is not set
# CONFIG_PATA_OPTIDMA is not set
# CONFIG_PATA_PDC_OLD is not set
# CONFIG_PATA_QDI is not set
# CONFIG_PATA_RADISYS is not set
# CONFIG_PATA_RZ1000 is not set
# CONFIG_PATA_SC1200 is not set
# CONFIG_PATA_SERVERWORKS is not set
# CONFIG_PATA_PDC2027X is not set
# CONFIG_PATA_SIL680 is not set
# CONFIG_PATA_SIS is not set
# CONFIG_PATA_VIA is not set
# CONFIG_PATA_WINBOND is not set
# CONFIG_PATA_WINBOND_VLB is not set

#
# Multi-device support (RAID and LVM)
#
# CONFIG_MD is not set

#
# Fusion MPT device support
#
# CONFIG_FUSION is not set
# CONFIG_FUSION_SPI is not set
# CONFIG_FUSION_FC is not set
# CONFIG_FUSION_SAS is not set

#
# IEEE 1394 (FireWire) support
#
# CONFIG_FIREWIRE is not set
# CONFIG_IEEE1394 is not set

#
# I2O device support
#
CONFIG_I2O=m
CONFIG_I2O_LCT_NOTIFY_ON_CHANGES=y
CONFIG_I2O_EXT_ADAPTEC=y
CONFIG_I2O_CONFIG=m
# CONFIG_I2O_CONFIG_OLD_IOCTL is not set
CONFIG_I2O_BUS=m
CONFIG_I2O_BLOCK=m
CONFIG_I2O_SCSI=m
CONFIG_I2O_PROC=m
# CONFIG_MACINTOSH_DRIVERS is not set
CONFIG_NETDEVICES=y
# CONFIG_NETDEVICES_MULTIQUEUE is not set
CONFIG_IFB=m
CONFIG_DUMMY=m
CONFIG_BONDING=m
CONFIG_EQUALIZER=m
CONFIG_TUN=m
CONFIG_NET_SB1000=m
# CONFIG_ARCNET is not set
CONFIG_PHYLIB=y

#
# MII PHY device drivers
#
CONFIG_MARVELL_PHY=m
CONFIG_DAVICOM_PHY=m
CONFIG_QSEMI_PHY=m
CONFIG_LXT_PHY=m
CONFIG_CICADA_PHY=m
CONFIG_VITESSE_PHY=m
CONFIG_SMSC_PHY=m
CONFIG_BROADCOM_PHY=m
CONFIG_ICPLUS_PHY=m
CONFIG_FIXED_PHY=m
CONFIG_FIXED_MII_10_FDX=y
CONFIG_FIXED_MII_100_FDX=y
CONFIG_NET_ETHERNET=y
CONFIG_MII=m
# CONFIG_HAPPYMEAL is not set
# CONFIG_SUNGEM is not set
# CONFIG_CASSINI is not set
CONFIG_NET_VENDOR_3COM=y
CONFIG_EL1=m
CONFIG_EL2=m
CONFIG_ELPLUS=m
CONFIG_EL16=m
CONFIG_EL3=m
CONFIG_3C515=m
CONFIG_VORTEX=m
CONFIG_TYPHOON=m
# CONFIG_LANCE is not set
# CONFIG_NET_VENDOR_SMC is not set
# CONFIG_NET_VENDOR_RACAL is not set
# CONFIG_NET_TULIP is not set
# CONFIG_AT1700 is not set
# CONFIG_DEPCA is not set
# CONFIG_HP100 is not set
# CONFIG_NET_ISA is not set
CONFIG_NET_PCI=y
CONFIG_PCNET32=m
# CONFIG_PCNET32_NAPI is not set
# CONFIG_AMD8111_ETH is not set
# CONFIG_ADAPTEC_STARFIRE is not set
# CONFIG_AC3200 is not set
# CONFIG_APRICOT is not set
# CONFIG_B44 is not set
# CONFIG_FORCEDETH is not set
# CONFIG_CS89x0 is not set
# CONFIG_DGRS is not set
# CONFIG_EEPRO100 is not set
# CONFIG_E100 is not set
# CONFIG_FEALNX is not set
# CONFIG_NATSEMI is not set
# CONFIG_NE2K_PCI is not set
# CONFIG_8139CP is not set
CONFIG_8139TOO=m
# CONFIG_8139TOO_PIO is not set
# CONFIG_8139TOO_TUNE_TWISTER is not set
# CONFIG_8139TOO_8129 is not set
# CONFIG_8139_OLD_RX_RESET is not set
# CONFIG_SIS900 is not set
# CONFIG_EPIC100 is not set
# CONFIG_SUNDANCE is not set
# CONFIG_TLAN is not set
# CONFIG_VIA_RHINE is not set
# CONFIG_SC92031 is not set
# CONFIG_NET_POCKET is not set
# CONFIG_NETDEV_1000 is not set
# CONFIG_NETDEV_10000 is not set
# CONFIG_TR is not set

#
# Wireless LAN
#
# CONFIG_WLAN_PRE80211 is not set
# CONFIG_WLAN_80211 is not set

#
# USB Network Adapters
#
# CONFIG_USB_CATC is not set
# CONFIG_USB_KAWETH is not set
# CONFIG_USB_PEGASUS is not set
# CONFIG_USB_RTL8150 is not set
# CONFIG_USB_USBNET_MII is not set
# CONFIG_USB_USBNET is not set
# CONFIG_WAN is not set
# CONFIG_ATM_DRIVERS is not set
# CONFIG_FDDI is not set
# CONFIG_HIPPI is not set
CONFIG_PLIP=m
CONFIG_PPP=m
CONFIG_PPP_MULTILINK=y
CONFIG_PPP_FILTER=y
CONFIG_PPP_ASYNC=m
CONFIG_PPP_SYNC_TTY=m
CONFIG_PPP_DEFLATE=m
CONFIG_PPP_BSDCOMP=m
CONFIG_PPP_MPPE=m
CONFIG_PPPOE=m
CONFIG_PPPOATM=m
# CONFIG_PPPOL2TP is not set
CONFIG_SLIP=m
CONFIG_SLIP_COMPRESSED=y
CONFIG_SLHC=m
CONFIG_SLIP_SMART=y
CONFIG_SLIP_MODE_SLIP6=y
# CONFIG_NET_FC is not set
# CONFIG_SHAPER is not set
# CONFIG_NETCONSOLE is not set
# CONFIG_NETPOLL is not set
# CONFIG_NET_POLL_CONTROLLER is not set

#
# ISDN subsystem
#
# CONFIG_ISDN is not set

#
# Telephony Support
#
# CONFIG_PHONE is not set

#
# Input device support
#
CONFIG_INPUT=y
CONFIG_INPUT_FF_MEMLESS=m
CONFIG_INPUT_POLLDEV=m

#
# Userland interfaces
#
CONFIG_INPUT_MOUSEDEV=y
CONFIG_INPUT_MOUSEDEV_PSAUX=y
CONFIG_INPUT_MOUSEDEV_SCREEN_X=1024
CONFIG_INPUT_MOUSEDEV_SCREEN_Y=768
# CONFIG_INPUT_JOYDEV is not set
# CONFIG_INPUT_TSDEV is not set
CONFIG_INPUT_EVDEV=m
# CONFIG_INPUT_EVBUG is not set

#
# Input Device Drivers
#
CONFIG_INPUT_KEYBOARD=y
CONFIG_KEYBOARD_ATKBD=y
CONFIG_KEYBOARD_SUNKBD=m
CONFIG_KEYBOARD_LKKBD=m
CONFIG_KEYBOARD_XTKBD=m
CONFIG_KEYBOARD_NEWTON=m
CONFIG_KEYBOARD_STOWAWAY=m
CONFIG_INPUT_MOUSE=y
CONFIG_MOUSE_PS2=y
CONFIG_MOUSE_PS2_ALPS=y
CONFIG_MOUSE_PS2_LOGIPS2PP=y
CONFIG_MOUSE_PS2_SYNAPTICS=y
CONFIG_MOUSE_PS2_LIFEBOOK=y
CONFIG_MOUSE_PS2_TRACKPOINT=y
# CONFIG_MOUSE_PS2_TOUCHKIT is not set
CONFIG_MOUSE_SERIAL=y
# CONFIG_MOUSE_APPLETOUCH is not set
CONFIG_MOUSE_INPORT=m
# CONFIG_MOUSE_ATIXL is not set
CONFIG_MOUSE_LOGIBM=m
CONFIG_MOUSE_PC110PAD=m
CONFIG_MOUSE_VSXXXAA=m
# CONFIG_INPUT_JOYSTICK is not set
# CONFIG_INPUT_TABLET is not set
# CONFIG_INPUT_TOUCHSCREEN is not set
CONFIG_INPUT_MISC=y
CONFIG_INPUT_PCSPKR=m
# CONFIG_INPUT_WISTRON_BTNS is not set
# CONFIG_INPUT_ATLAS_BTNS is not set
# CONFIG_INPUT_ATI_REMOTE is not set
# CONFIG_INPUT_ATI_REMOTE2 is not set
# CONFIG_INPUT_KEYSPAN_REMOTE is not set
# CONFIG_INPUT_POWERMATE is not set
# CONFIG_INPUT_YEALINK is not set
CONFIG_INPUT_UINPUT=m

#
# Hardware I/O ports
#
CONFIG_SERIO=y
CONFIG_SERIO_I8042=y
CONFIG_SERIO_SERPORT=m
CONFIG_SERIO_CT82C710=m
CONFIG_SERIO_PARKBD=m
CONFIG_SERIO_PCIPS2=m
CONFIG_SERIO_LIBPS2=y
CONFIG_SERIO_RAW=m
# CONFIG_GAMEPORT is not set

#
# Character devices
#
CONFIG_VT=y
CONFIG_VT_CONSOLE=y
CONFIG_HW_CONSOLE=y
CONFIG_VT_HW_CONSOLE_BINDING=y
CONFIG_SERIAL_NONSTANDARD=y
# CONFIG_COMPUTONE is not set
# CONFIG_ROCKETPORT is not set
# CONFIG_CYCLADES is not set
# CONFIG_DIGIEPCA is not set
# CONFIG_ESPSERIAL is not set
# CONFIG_MOXA_INTELLIO is not set
# CONFIG_MOXA_SMARTIO is not set
# CONFIG_MOXA_SMARTIO_NEW is not set
# CONFIG_ISI is not set
# CONFIG_SYNCLINK is not set
# CONFIG_SYNCLINKMP is not set
# CONFIG_SYNCLINK_GT is not set
# CONFIG_N_HDLC is not set
# CONFIG_SPECIALIX is not set
# CONFIG_SX is not set
# CONFIG_RIO is not set
# CONFIG_STALDRV is not set

#
# Serial drivers
#
CONFIG_SERIAL_8250=y
CONFIG_SERIAL_8250_CONSOLE=y
CONFIG_SERIAL_8250_PCI=y
CONFIG_SERIAL_8250_PNP=y
CONFIG_SERIAL_8250_NR_UARTS=4
CONFIG_SERIAL_8250_RUNTIME_UARTS=4
CONFIG_SERIAL_8250_EXTENDED=y
CONFIG_SERIAL_8250_MANY_PORTS=y
CONFIG_SERIAL_8250_FOURPORT=m
CONFIG_SERIAL_8250_ACCENT=m
CONFIG_SERIAL_8250_BOCA=m
CONFIG_SERIAL_8250_EXAR_ST16C554=m
CONFIG_SERIAL_8250_HUB6=m
CONFIG_SERIAL_8250_SHARE_IRQ=y
# CONFIG_SERIAL_8250_DETECT_IRQ is not set
CONFIG_SERIAL_8250_RSA=y

#
# Non-8250 serial port support
#
CONFIG_SERIAL_CORE=y
CONFIG_SERIAL_CORE_CONSOLE=y
CONFIG_SERIAL_JSM=m
CONFIG_UNIX98_PTYS=y
# CONFIG_LEGACY_PTYS is not set
CONFIG_PRINTER=m
CONFIG_LP_CONSOLE=y
CONFIG_PPDEV=m
# CONFIG_TIPAR is not set

#
# IPMI
#
CONFIG_IPMI_HANDLER=m
# CONFIG_IPMI_PANIC_EVENT is not set
CONFIG_IPMI_DEVICE_INTERFACE=m
CONFIG_IPMI_SI=m
CONFIG_IPMI_WATCHDOG=m
CONFIG_IPMI_POWEROFF=m
CONFIG_WATCHDOG=y
# CONFIG_WATCHDOG_NOWAYOUT is not set

#
# Watchdog Device Drivers
#
CONFIG_SOFT_WATCHDOG=m
# CONFIG_ACQUIRE_WDT is not set
# CONFIG_ADVANTECH_WDT is not set
# CONFIG_ALIM1535_WDT is not set
# CONFIG_ALIM7101_WDT is not set
# CONFIG_SC520_WDT is not set
# CONFIG_EUROTECH_WDT is not set
# CONFIG_IB700_WDT is not set
# CONFIG_IBMASR is not set
# CONFIG_WAFER_WDT is not set
# CONFIG_I6300ESB_WDT is not set
CONFIG_ITCO_WDT=m
CONFIG_ITCO_VENDOR_SUPPORT=y
# CONFIG_SC1200_WDT is not set
# CONFIG_PC87413_WDT is not set
# CONFIG_60XX_WDT is not set
# CONFIG_SBC8360_WDT is not set
# CONFIG_CPU5_WDT is not set
# CONFIG_SMSC37B787_WDT is not set
# CONFIG_W83627HF_WDT is not set
# CONFIG_W83697HF_WDT is not set
# CONFIG_W83877F_WDT is not set
# CONFIG_W83977F_WDT is not set
# CONFIG_MACHZ_WDT is not set
# CONFIG_SBC_EPX_C3_WATCHDOG is not set

#
# ISA-based Watchdog Cards
#
# CONFIG_PCWATCHDOG is not set
# CONFIG_MIXCOMWD is not set
# CONFIG_WDT is not set

#
# PCI-based Watchdog Cards
#
# CONFIG_PCIPCWATCHDOG is not set
# CONFIG_WDTPCI is not set

#
# USB-based Watchdog Cards
#
# CONFIG_USBPCWATCHDOG is not set
CONFIG_HW_RANDOM=y
CONFIG_HW_RANDOM_INTEL=y
# CONFIG_HW_RANDOM_AMD is not set
# CONFIG_HW_RANDOM_GEODE is not set
# CONFIG_HW_RANDOM_VIA is not set
# CONFIG_NVRAM is not set
CONFIG_RTC=m
CONFIG_GEN_RTC=m
CONFIG_GEN_RTC_X=y
CONFIG_DTLK=m
# CONFIG_R3964 is not set
# CONFIG_APPLICOM is not set
# CONFIG_SONYPI is not set
CONFIG_AGP=m
# CONFIG_AGP_ALI is not set
# CONFIG_AGP_ATI is not set
# CONFIG_AGP_AMD is not set
# CONFIG_AGP_AMD64 is not set
CONFIG_AGP_INTEL=m
# CONFIG_AGP_NVIDIA is not set
# CONFIG_AGP_SIS is not set
# CONFIG_AGP_SWORKS is not set
# CONFIG_AGP_VIA is not set
# CONFIG_AGP_EFFICEON is not set
# CONFIG_DRM is not set
# CONFIG_MWAVE is not set
# CONFIG_PC8736x_GPIO is not set
# CONFIG_NSC_GPIO is not set
# CONFIG_CS5535_GPIO is not set
# CONFIG_RAW_DRIVER is not set
# CONFIG_HPET is not set
CONFIG_HANGCHECK_TIMER=m

#
# TPM devices
#
# CONFIG_TCG_TPM is not set
# CONFIG_TELCLOCK is not set
CONFIG_DEVPORT=y
CONFIG_I2C=y
CONFIG_I2C_BOARDINFO=y
CONFIG_I2C_CHARDEV=y

#
# I2C Algorithms
#
CONFIG_I2C_ALGOBIT=m
CONFIG_I2C_ALGOPCF=m
CONFIG_I2C_ALGOPCA=m

#
# I2C Hardware Bus support
#
CONFIG_I2C_ALI1535=m
# CONFIG_I2C_ALI1563 is not set
# CONFIG_I2C_ALI15X3 is not set
# CONFIG_I2C_AMD756 is not set
# CONFIG_I2C_AMD8111 is not set
CONFIG_I2C_I801=m
CONFIG_I2C_I810=m
CONFIG_I2C_PIIX4=m
CONFIG_I2C_ISA=m
# CONFIG_I2C_NFORCE2 is not set
# CONFIG_I2C_OCORES is not set
# CONFIG_I2C_PARPORT is not set
# CONFIG_I2C_PARPORT_LIGHT is not set
# CONFIG_I2C_PROSAVAGE is not set
# CONFIG_I2C_SAVAGE4 is not set
# CONFIG_I2C_SIMTEC is not set
# CONFIG_SCx200_ACB is not set
# CONFIG_I2C_SIS5595 is not set
# CONFIG_I2C_SIS630 is not set
# CONFIG_I2C_SIS96X is not set
# CONFIG_I2C_TAOS_EVM is not set
# CONFIG_I2C_STUB is not set
# CONFIG_I2C_TINY_USB is not set
# CONFIG_I2C_VIA is not set
# CONFIG_I2C_VIAPRO is not set
# CONFIG_I2C_VOODOO3 is not set
CONFIG_I2C_PCA_ISA=m

#
# Miscellaneous I2C Chip support
#
CONFIG_SENSORS_DS1337=m
# CONFIG_SENSORS_DS1374 is not set
# CONFIG_DS1682 is not set
CONFIG_SENSORS_EEPROM=m
# CONFIG_SENSORS_PCF8574 is not set
# CONFIG_SENSORS_PCA9539 is not set
# CONFIG_SENSORS_PCF8591 is not set
# CONFIG_SENSORS_MAX6875 is not set
CONFIG_SENSORS_TSL2550=m
# CONFIG_I2C_DEBUG_CORE is not set
# CONFIG_I2C_DEBUG_ALGO is not set
# CONFIG_I2C_DEBUG_BUS is not set
# CONFIG_I2C_DEBUG_CHIP is not set

#
# SPI support
#
# CONFIG_SPI is not set
# CONFIG_SPI_MASTER is not set

#
# Dallas's 1-wire bus
#
# CONFIG_W1 is not set
# CONFIG_POWER_SUPPLY is not set
CONFIG_HWMON=y
CONFIG_HWMON_VID=m
CONFIG_SENSORS_ABITUGURU=m
CONFIG_SENSORS_AD7418=m
CONFIG_SENSORS_ADM1021=m
CONFIG_SENSORS_ADM1025=m
CONFIG_SENSORS_ADM1026=m
CONFIG_SENSORS_ADM1029=m
CONFIG_SENSORS_ADM1031=m
CONFIG_SENSORS_ADM9240=m
CONFIG_SENSORS_K8TEMP=m
CONFIG_SENSORS_ASB100=m
CONFIG_SENSORS_ATXP1=m
CONFIG_SENSORS_DS1621=m
CONFIG_SENSORS_F71805F=m
CONFIG_SENSORS_FSCHER=m
CONFIG_SENSORS_FSCPOS=m
CONFIG_SENSORS_GL518SM=m
CONFIG_SENSORS_GL520SM=m
CONFIG_SENSORS_CORETEMP=m
CONFIG_SENSORS_IT87=m
CONFIG_SENSORS_LM63=m
CONFIG_SENSORS_LM75=m
CONFIG_SENSORS_LM77=m
CONFIG_SENSORS_LM78=m
CONFIG_SENSORS_LM80=m
CONFIG_SENSORS_LM83=m
CONFIG_SENSORS_LM85=m
CONFIG_SENSORS_LM87=m
CONFIG_SENSORS_LM90=m
CONFIG_SENSORS_LM92=m
CONFIG_SENSORS_MAX1619=m
CONFIG_SENSORS_MAX6650=m
CONFIG_SENSORS_PC87360=m
CONFIG_SENSORS_PC87427=m
CONFIG_SENSORS_SIS5595=m
CONFIG_SENSORS_SMSC47M1=m
CONFIG_SENSORS_SMSC47M192=m
CONFIG_SENSORS_SMSC47B397=m
CONFIG_SENSORS_VIA686A=m
CONFIG_SENSORS_VT1211=m
CONFIG_SENSORS_VT8231=m
CONFIG_SENSORS_W83781D=m
CONFIG_SENSORS_W83791D=m
CONFIG_SENSORS_W83792D=m
CONFIG_SENSORS_W83793=m
CONFIG_SENSORS_W83L785TS=m
CONFIG_SENSORS_W83627HF=m
CONFIG_SENSORS_W83627EHF=m
CONFIG_SENSORS_HDAPS=m
CONFIG_SENSORS_APPLESMC=m
CONFIG_HWMON_DEBUG_CHIP=y

#
# Multifunction device drivers
#
# CONFIG_MFD_SM501 is not set

#
# Multimedia devices
#
CONFIG_VIDEO_DEV=m
CONFIG_VIDEO_V4L1=y
CONFIG_VIDEO_V4L1_COMPAT=y
CONFIG_VIDEO_V4L2=y
CONFIG_VIDEO_CAPTURE_DRIVERS=y
# CONFIG_VIDEO_ADV_DEBUG is not set
CONFIG_VIDEO_HELPER_CHIPS_AUTO=y
CONFIG_VIDEO_VIVI=m
# CONFIG_VIDEO_BT848 is not set
# CONFIG_VIDEO_PMS is not set
# CONFIG_VIDEO_BWQCAM is not set
# CONFIG_VIDEO_CQCAM is not set
# CONFIG_VIDEO_W9966 is not set
# CONFIG_VIDEO_CPIA is not set
# CONFIG_VIDEO_CPIA2 is not set
# CONFIG_VIDEO_SAA5246A is not set
# CONFIG_VIDEO_SAA5249 is not set
# CONFIG_TUNER_3036 is not set
# CONFIG_VIDEO_STRADIS is not set
# CONFIG_VIDEO_ZORAN is not set
# CONFIG_VIDEO_SAA7134 is not set
# CONFIG_VIDEO_MXB is not set
# CONFIG_VIDEO_DPC is not set
# CONFIG_VIDEO_HEXIUM_ORION is not set
# CONFIG_VIDEO_HEXIUM_GEMINI is not set
# CONFIG_VIDEO_CX88 is not set
# CONFIG_VIDEO_IVTV is not set
# CONFIG_VIDEO_CAFE_CCIC is not set
CONFIG_V4L_USB_DRIVERS=y
# CONFIG_VIDEO_PVRUSB2 is not set
# CONFIG_VIDEO_EM28XX is not set
# CONFIG_VIDEO_USBVISION is not set
# CONFIG_USB_VICAM is not set
# CONFIG_USB_IBMCAM is not set
# CONFIG_USB_KONICAWC is not set
# CONFIG_USB_QUICKCAM_MESSENGER is not set
# CONFIG_USB_ET61X251 is not set
# CONFIG_VIDEO_OVCAMCHIP is not set
# CONFIG_USB_W9968CF is not set
# CONFIG_USB_OV511 is not set
# CONFIG_USB_SE401 is not set
# CONFIG_USB_SN9C102 is not set
# CONFIG_USB_STV680 is not set
# CONFIG_USB_ZC0301 is not set
# CONFIG_USB_PWC is not set
# CONFIG_USB_ZR364XX is not set
# CONFIG_RADIO_ADAPTERS is not set
# CONFIG_DVB_CORE is not set
CONFIG_VIDEO_BUF=m
# CONFIG_DAB is not set

#
# Graphics support
#
CONFIG_BACKLIGHT_LCD_SUPPORT=y
CONFIG_BACKLIGHT_CLASS_DEVICE=y
CONFIG_LCD_CLASS_DEVICE=y
# CONFIG_BACKLIGHT_PROGEAR is not set

#
# Display device support
#
CONFIG_DISPLAY_SUPPORT=y

#
# Display hardware drivers
#
CONFIG_VGASTATE=y
CONFIG_FB=y
CONFIG_FIRMWARE_EDID=y
# CONFIG_FB_DDC is not set
CONFIG_FB_CFB_FILLRECT=y
CONFIG_FB_CFB_COPYAREA=y
CONFIG_FB_CFB_IMAGEBLIT=y
# CONFIG_FB_SYS_FILLRECT is not set
# CONFIG_FB_SYS_COPYAREA is not set
# CONFIG_FB_SYS_IMAGEBLIT is not set
# CONFIG_FB_SYS_FOPS is not set
CONFIG_FB_DEFERRED_IO=y
# CONFIG_FB_SVGALIB is not set
# CONFIG_FB_MACMODES is not set
# CONFIG_FB_BACKLIGHT is not set
CONFIG_FB_MODE_HELPERS=y
CONFIG_FB_TILEBLITTING=y

#
# Frame buffer hardware drivers
#
# CONFIG_FB_CIRRUS is not set
# CONFIG_FB_PM2 is not set
# CONFIG_FB_CYBER2000 is not set
# CONFIG_FB_ARC is not set
# CONFIG_FB_ASILIANT is not set
# CONFIG_FB_IMSTT is not set
CONFIG_FB_VGA16=y
CONFIG_FB_VESA=y
# CONFIG_FB_HECUBA is not set
# CONFIG_FB_HGA is not set
# CONFIG_FB_S1D13XXX is not set
# CONFIG_FB_NVIDIA is not set
# CONFIG_FB_RIVA is not set
# CONFIG_FB_I810 is not set
# CONFIG_FB_LE80578 is not set
# CONFIG_FB_INTEL is not set
# CONFIG_FB_MATROX is not set
# CONFIG_FB_RADEON is not set
# CONFIG_FB_ATY128 is not set
# CONFIG_FB_ATY is not set
# CONFIG_FB_S3 is not set
# CONFIG_FB_SAVAGE is not set
# CONFIG_FB_SIS is not set
# CONFIG_FB_NEOMAGIC is not set
# CONFIG_FB_KYRO is not set
# CONFIG_FB_3DFX is not set
# CONFIG_FB_VOODOO1 is not set
# CONFIG_FB_VT8623 is not set
# CONFIG_FB_CYBLA is not set
# CONFIG_FB_TRIDENT is not set
# CONFIG_FB_ARK is not set
# CONFIG_FB_PM3 is not set
# CONFIG_FB_GEODE is not set
# CONFIG_FB_VIRTUAL is not set

#
# Console display driver support
#
CONFIG_VGA_CONSOLE=y
CONFIG_VGACON_SOFT_SCROLLBACK=y
CONFIG_VGACON_SOFT_SCROLLBACK_SIZE=64
CONFIG_VIDEO_SELECT=y
CONFIG_MDA_CONSOLE=m
CONFIG_DUMMY_CONSOLE=y
CONFIG_FRAMEBUFFER_CONSOLE=y
CONFIG_FRAMEBUFFER_CONSOLE_ROTATION=y
CONFIG_FONTS=y
CONFIG_FONT_8x8=y
CONFIG_FONT_8x16=y
# CONFIG_FONT_6x11 is not set
# CONFIG_FONT_7x14 is not set
# CONFIG_FONT_PEARL_8x8 is not set
# CONFIG_FONT_ACORN_8x8 is not set
# CONFIG_FONT_MINI_4x6 is not set
# CONFIG_FONT_SUN8x16 is not set
# CONFIG_FONT_SUN12x22 is not set
# CONFIG_FONT_10x18 is not set
# CONFIG_LOGO is not set

#
# Sound
#
CONFIG_SOUND=y

#
# Advanced Linux Sound Architecture
#
CONFIG_SND=y
CONFIG_SND_TIMER=y
CONFIG_SND_PCM=y
CONFIG_SND_HWDEP=m
CONFIG_SND_RAWMIDI=m
CONFIG_SND_SEQUENCER=m
CONFIG_SND_SEQ_DUMMY=m
CONFIG_SND_OSSEMUL=y
CONFIG_SND_MIXER_OSS=m
CONFIG_SND_PCM_OSS=m
CONFIG_SND_PCM_OSS_PLUGINS=y
CONFIG_SND_SEQUENCER_OSS=y
CONFIG_SND_RTCTIMER=m
CONFIG_SND_SEQ_RTCTIMER_DEFAULT=y
# CONFIG_SND_DYNAMIC_MINORS is not set
# CONFIG_SND_SUPPORT_OLD_API is not set
# CONFIG_SND_VERBOSE_PROCFS is not set
# CONFIG_SND_VERBOSE_PRINTK is not set
# CONFIG_SND_DEBUG is not set

#
# Generic devices
#
CONFIG_SND_MPU401_UART=m
CONFIG_SND_AC97_CODEC=y
CONFIG_SND_DUMMY=m
CONFIG_SND_VIRMIDI=m
CONFIG_SND_MTPAV=m
CONFIG_SND_MTS64=m
CONFIG_SND_SERIAL_U16550=m
CONFIG_SND_MPU401=m
CONFIG_SND_PORTMAN2X4=m

#
# ISA devices
#
# CONFIG_SND_ADLIB is not set
# CONFIG_SND_AD1816A is not set
# CONFIG_SND_AD1848 is not set
# CONFIG_SND_ALS100 is not set
# CONFIG_SND_AZT2320 is not set
# CONFIG_SND_CMI8330 is not set
# CONFIG_SND_CS4231 is not set
# CONFIG_SND_CS4232 is not set
# CONFIG_SND_CS4236 is not set
# CONFIG_SND_DT019X is not set
# CONFIG_SND_ES968 is not set
# CONFIG_SND_ES1688 is not set
# CONFIG_SND_ES18XX is not set
# CONFIG_SND_GUSCLASSIC is not set
# CONFIG_SND_GUSEXTREME is not set
# CONFIG_SND_GUSMAX is not set
# CONFIG_SND_INTERWAVE is not set
# CONFIG_SND_INTERWAVE_STB is not set
# CONFIG_SND_OPL3SA2 is not set
# CONFIG_SND_OPTI92X_AD1848 is not set
# CONFIG_SND_OPTI92X_CS4231 is not set
# CONFIG_SND_OPTI93X is not set
# CONFIG_SND_MIRO is not set
# CONFIG_SND_SB8 is not set
# CONFIG_SND_SB16 is not set
# CONFIG_SND_SBAWE is not set
# CONFIG_SND_SGALAXY is not set
# CONFIG_SND_SSCAPE is not set
# CONFIG_SND_WAVEFRONT is not set

#
# PCI devices
#
# CONFIG_SND_AD1889 is not set
# CONFIG_SND_ALS300 is not set
# CONFIG_SND_ALS4000 is not set
# CONFIG_SND_ALI5451 is not set
# CONFIG_SND_ATIIXP is not set
# CONFIG_SND_ATIIXP_MODEM is not set
# CONFIG_SND_AU8810 is not set
# CONFIG_SND_AU8820 is not set
# CONFIG_SND_AU8830 is not set
# CONFIG_SND_AZT3328 is not set
# CONFIG_SND_BT87X is not set
# CONFIG_SND_CA0106 is not set
# CONFIG_SND_CMIPCI is not set
# CONFIG_SND_CS4281 is not set
# CONFIG_SND_CS46XX is not set
# CONFIG_SND_CS5535AUDIO is not set
# CONFIG_SND_DARLA20 is not set
# CONFIG_SND_GINA20 is not set
# CONFIG_SND_LAYLA20 is not set
# CONFIG_SND_DARLA24 is not set
# CONFIG_SND_GINA24 is not set
# CONFIG_SND_LAYLA24 is not set
# CONFIG_SND_MONA is not set
# CONFIG_SND_MIA is not set
# CONFIG_SND_ECHO3G is not set
# CONFIG_SND_INDIGO is not set
# CONFIG_SND_INDIGOIO is not set
# CONFIG_SND_INDIGODJ is not set
# CONFIG_SND_EMU10K1 is not set
# CONFIG_SND_EMU10K1X is not set
# CONFIG_SND_ENS1370 is not set
# CONFIG_SND_ENS1371 is not set
# CONFIG_SND_ES1938 is not set
# CONFIG_SND_ES1968 is not set
# CONFIG_SND_FM801 is not set
# CONFIG_SND_HDA_INTEL is not set
# CONFIG_SND_HDSP is not set
# CONFIG_SND_HDSPM is not set
# CONFIG_SND_ICE1712 is not set
# CONFIG_SND_ICE1724 is not set
CONFIG_SND_INTEL8X0=y
CONFIG_SND_INTEL8X0M=m
# CONFIG_SND_KORG1212 is not set
# CONFIG_SND_MAESTRO3 is not set
# CONFIG_SND_MIXART is not set
# CONFIG_SND_NM256 is not set
# CONFIG_SND_PCXHR is not set
# CONFIG_SND_RIPTIDE is not set
# CONFIG_SND_RME32 is not set
# CONFIG_SND_RME96 is not set
# CONFIG_SND_RME9652 is not set
# CONFIG_SND_SONICVIBES is not set
# CONFIG_SND_TRIDENT is not set
# CONFIG_SND_VIA82XX is not set
# CONFIG_SND_VIA82XX_MODEM is not set
# CONFIG_SND_VX222 is not set
# CONFIG_SND_YMFPCI is not set
CONFIG_SND_AC97_POWER_SAVE=y

#
# USB devices
#
CONFIG_SND_USB_AUDIO=m
CONFIG_SND_USB_USX2Y=m
CONFIG_SND_USB_CAIAQ=m
# CONFIG_SND_USB_CAIAQ_INPUT is not set

#
# System on Chip audio support
#
# CONFIG_SND_SOC is not set

#
# Open Sound System
#
# CONFIG_SOUND_PRIME is not set
CONFIG_AC97_BUS=y
CONFIG_HID_SUPPORT=y
CONFIG_HID=y
CONFIG_HID_DEBUG=y

#
# USB Input Devices
#
CONFIG_USB_HID=m
# CONFIG_USB_HIDINPUT_POWERBOOK is not set
# CONFIG_HID_FF is not set
CONFIG_USB_HIDDEV=y

#
# USB HID Boot Protocol drivers
#
# CONFIG_USB_KBD is not set
# CONFIG_USB_MOUSE is not set
CONFIG_USB_SUPPORT=y
CONFIG_USB_ARCH_HAS_HCD=y
CONFIG_USB_ARCH_HAS_OHCI=y
CONFIG_USB_ARCH_HAS_EHCI=y
CONFIG_USB=m
# CONFIG_USB_DEBUG is not set

#
# Miscellaneous USB options
#
CONFIG_USB_DEVICEFS=y
CONFIG_USB_DEVICE_CLASS=y
CONFIG_USB_DYNAMIC_MINORS=y
# CONFIG_USB_SUSPEND is not set
# CONFIG_USB_PERSIST is not set
# CONFIG_USB_OTG is not set

#
# USB Host Controller Drivers
#
CONFIG_USB_EHCI_HCD=m
CONFIG_USB_EHCI_SPLIT_ISO=y
CONFIG_USB_EHCI_ROOT_HUB_TT=y
CONFIG_USB_EHCI_TT_NEWSCHED=y
CONFIG_USB_ISP116X_HCD=m
CONFIG_USB_OHCI_HCD=m
# CONFIG_USB_OHCI_BIG_ENDIAN_DESC is not set
# CONFIG_USB_OHCI_BIG_ENDIAN_MMIO is not set
CONFIG_USB_OHCI_LITTLE_ENDIAN=y
CONFIG_USB_UHCI_HCD=m
# CONFIG_USB_SL811_HCD is not set
# CONFIG_USB_R8A66597_HCD is not set

#
# USB Device Class drivers
#
# CONFIG_USB_ACM is not set
# CONFIG_USB_PRINTER is not set

#
# NOTE: USB_STORAGE enables SCSI, and 'SCSI disk support'
#

#
# may also be needed; see USB_STORAGE Help for more information
#
CONFIG_USB_STORAGE=m
# CONFIG_USB_STORAGE_DEBUG is not set
# CONFIG_USB_STORAGE_DATAFAB is not set
# CONFIG_USB_STORAGE_FREECOM is not set
# CONFIG_USB_STORAGE_DPCM is not set
# CONFIG_USB_STORAGE_USBAT is not set
# CONFIG_USB_STORAGE_SDDR09 is not set
# CONFIG_USB_STORAGE_SDDR55 is not set
# CONFIG_USB_STORAGE_JUMPSHOT is not set
# CONFIG_USB_STORAGE_ALAUDA is not set
# CONFIG_USB_STORAGE_KARMA is not set
# CONFIG_USB_LIBUSUAL is not set

#
# USB Imaging devices
#
# CONFIG_USB_MDC800 is not set
# CONFIG_USB_MICROTEK is not set
# CONFIG_USB_MON is not set

#
# USB port drivers
#
# CONFIG_USB_USS720 is not set

#
# USB Serial Converter support
#
# CONFIG_USB_SERIAL is not set

#
# USB Miscellaneous drivers
#
# CONFIG_USB_EMI62 is not set
# CONFIG_USB_EMI26 is not set
# CONFIG_USB_ADUTUX is not set
# CONFIG_USB_AUERSWALD is not set
# CONFIG_USB_RIO500 is not set
# CONFIG_USB_LEGOTOWER is not set
# CONFIG_USB_LCD is not set
# CONFIG_USB_BERRY_CHARGE is not set
CONFIG_USB_LED=m
# CONFIG_USB_CYPRESS_CY7C63 is not set
# CONFIG_USB_CYTHERM is not set
# CONFIG_USB_PHIDGET is not set
# CONFIG_USB_IDMOUSE is not set
# CONFIG_USB_FTDI_ELAN is not set
# CONFIG_USB_APPLEDISPLAY is not set
# CONFIG_USB_SISUSBVGA is not set
# CONFIG_USB_LD is not set
# CONFIG_USB_TRANCEVIBRATOR is not set
# CONFIG_USB_IOWARRIOR is not set
# CONFIG_USB_TEST is not set

#
# USB DSL modem support
#
# CONFIG_USB_ATM is not set

#
# USB Gadget Support
#
# CONFIG_USB_GADGET is not set
# CONFIG_MMC is not set

#
# LED devices
#
CONFIG_NEW_LEDS=y
CONFIG_LEDS_CLASS=m

#
# LED drivers
#

#
# LED Triggers
#
CONFIG_LEDS_TRIGGERS=y
CONFIG_LEDS_TRIGGER_TIMER=m
CONFIG_LEDS_TRIGGER_HEARTBEAT=m
# CONFIG_INFINIBAND is not set

#
# EDAC - error detection and reporting (RAS) (EXPERIMENTAL)
#
CONFIG_EDAC=m

#
# Reporting subsystems
#
# CONFIG_EDAC_DEBUG is not set
CONFIG_EDAC_MM_EDAC=m
# CONFIG_EDAC_AMD76X is not set
CONFIG_EDAC_E7XXX=m
CONFIG_EDAC_E752X=m
CONFIG_EDAC_I82875P=m
CONFIG_EDAC_I82860=m
# CONFIG_EDAC_R82600 is not set
CONFIG_EDAC_POLL=y

#
# Real Time Clock
#
CONFIG_RTC_LIB=y
CONFIG_RTC_CLASS=y
CONFIG_RTC_HCTOSYS=y
CONFIG_RTC_HCTOSYS_DEVICE="rtc0"
# CONFIG_RTC_DEBUG is not set

#
# RTC interfaces
#
CONFIG_RTC_INTF_SYSFS=y
CONFIG_RTC_INTF_PROC=y
CONFIG_RTC_INTF_DEV=y
CONFIG_RTC_INTF_DEV_UIE_EMUL=y
# CONFIG_RTC_DRV_TEST is not set

#
# I2C RTC drivers
#
CONFIG_RTC_DRV_DS1307=m
CONFIG_RTC_DRV_DS1672=m
CONFIG_RTC_DRV_MAX6900=m
CONFIG_RTC_DRV_RS5C372=m
CONFIG_RTC_DRV_ISL1208=m
CONFIG_RTC_DRV_X1205=m
CONFIG_RTC_DRV_PCF8563=m
CONFIG_RTC_DRV_PCF8583=m

#
# SPI RTC drivers
#

#
# Platform RTC drivers
#
CONFIG_RTC_DRV_CMOS=y
CONFIG_RTC_DRV_DS1553=m
CONFIG_RTC_DRV_DS1742=m
CONFIG_RTC_DRV_M48T86=m
CONFIG_RTC_DRV_V3020=m

#
# on-CPU RTC drivers
#

#
# DMA Engine support
#
# CONFIG_DMA_ENGINE is not set

#
# DMA Clients
#

#
# DMA Devices
#

#
# Auxiliary Display support
#
# CONFIG_KS0108 is not set

#
# Virtualization
#
# CONFIG_KVM is not set

#
# File systems
#
CONFIG_EXT2_FS=m
CONFIG_EXT2_FS_XATTR=y
CONFIG_EXT2_FS_POSIX_ACL=y
CONFIG_EXT2_FS_SECURITY=y
# CONFIG_EXT2_FS_XIP is not set
CONFIG_EXT3_FS=y
CONFIG_EXT3_FS_XATTR=y
CONFIG_EXT3_FS_POSIX_ACL=y
CONFIG_EXT3_FS_SECURITY=y
CONFIG_EXT4DEV_FS=m
CONFIG_EXT4DEV_FS_XATTR=y
CONFIG_EXT4DEV_FS_POSIX_ACL=y
CONFIG_EXT4DEV_FS_SECURITY=y
CONFIG_JBD=y
# CONFIG_JBD_DEBUG is not set
CONFIG_JBD2=m
# CONFIG_JBD2_DEBUG is not set
CONFIG_FS_MBCACHE=y
# CONFIG_REISERFS_FS is not set
# CONFIG_JFS_FS is not set
CONFIG_FS_POSIX_ACL=y
# CONFIG_XFS_FS is not set
# CONFIG_GFS2_FS is not set
# CONFIG_OCFS2_FS is not set
# CONFIG_MINIX_FS is not set
CONFIG_ROMFS_FS=y
CONFIG_INOTIFY=y
CONFIG_INOTIFY_USER=y
CONFIG_QUOTA=y
CONFIG_QFMT_V1=m
CONFIG_QFMT_V2=m
CONFIG_QUOTACTL=y
CONFIG_DNOTIFY=y
CONFIG_AUTOFS_FS=m
CONFIG_AUTOFS4_FS=m
CONFIG_FUSE_FS=m
CONFIG_GENERIC_ACL=y

#
# CD-ROM/DVD Filesystems
#
CONFIG_ISO9660_FS=m
CONFIG_JOLIET=y
CONFIG_ZISOFS=y
CONFIG_UDF_FS=m
CONFIG_UDF_NLS=y

#
# DOS/FAT/NT Filesystems
#
CONFIG_FAT_FS=m
CONFIG_MSDOS_FS=m
CONFIG_VFAT_FS=m
CONFIG_FAT_DEFAULT_CODEPAGE=437
CONFIG_FAT_DEFAULT_IOCHARSET="iso8859-1"
CONFIG_NTFS_FS=m
# CONFIG_NTFS_DEBUG is not set
CONFIG_NTFS_RW=y

#
# Pseudo filesystems
#
CONFIG_PROC_FS=y
CONFIG_PROC_KCORE=y
CONFIG_PROC_SYSCTL=y
CONFIG_SYSFS=y
CONFIG_TMPFS=y
CONFIG_TMPFS_POSIX_ACL=y
# CONFIG_HUGETLBFS is not set
# CONFIG_HUGETLB_PAGE is not set
CONFIG_RAMFS=y
CONFIG_CONFIGFS_FS=m

#
# Miscellaneous filesystems
#
# CONFIG_ADFS_FS is not set
# CONFIG_AFFS_FS is not set
CONFIG_ECRYPT_FS=m
# CONFIG_HFS_FS is not set
# CONFIG_HFSPLUS_FS is not set
# CONFIG_BEFS_FS is not set
# CONFIG_BFS_FS is not set
# CONFIG_EFS_FS is not set
CONFIG_CRAMFS=m
# CONFIG_VXFS_FS is not set
# CONFIG_HPFS_FS is not set
# CONFIG_QNX4FS_FS is not set
# CONFIG_SYSV_FS is not set
# CONFIG_UFS_FS is not set

#
# Network File Systems
#
CONFIG_NFS_FS=m
CONFIG_NFS_V3=y
CONFIG_NFS_V3_ACL=y
CONFIG_NFS_V4=y
CONFIG_NFS_DIRECTIO=y
CONFIG_NFSD=m
CONFIG_NFSD_V2_ACL=y
CONFIG_NFSD_V3=y
CONFIG_NFSD_V3_ACL=y
CONFIG_NFSD_V4=y
CONFIG_NFSD_TCP=y
CONFIG_LOCKD=m
CONFIG_LOCKD_V4=y
CONFIG_EXPORTFS=m
CONFIG_NFS_ACL_SUPPORT=m
CONFIG_NFS_COMMON=y
CONFIG_SUNRPC=m
CONFIG_SUNRPC_GSS=m
CONFIG_SUNRPC_BIND34=y
CONFIG_RPCSEC_GSS_KRB5=m
# CONFIG_RPCSEC_GSS_SPKM3 is not set
# CONFIG_SMB_FS is not set
# CONFIG_CIFS is not set
# CONFIG_NCP_FS is not set
# CONFIG_CODA_FS is not set
# CONFIG_AFS_FS is not set
# CONFIG_9P_FS is not set

#
# Partition Types
#
CONFIG_PARTITION_ADVANCED=y
# CONFIG_ACORN_PARTITION is not set
# CONFIG_OSF_PARTITION is not set
# CONFIG_AMIGA_PARTITION is not set
# CONFIG_ATARI_PARTITION is not set
# CONFIG_MAC_PARTITION is not set
CONFIG_MSDOS_PARTITION=y
# CONFIG_BSD_DISKLABEL is not set
# CONFIG_MINIX_SUBPARTITION is not set
# CONFIG_SOLARIS_X86_PARTITION is not set
# CONFIG_UNIXWARE_DISKLABEL is not set
# CONFIG_LDM_PARTITION is not set
# CONFIG_SGI_PARTITION is not set
# CONFIG_ULTRIX_PARTITION is not set
# CONFIG_SUN_PARTITION is not set
# CONFIG_KARMA_PARTITION is not set
# CONFIG_EFI_PARTITION is not set
# CONFIG_SYSV68_PARTITION is not set

#
# Native Language Support
#
CONFIG_NLS=y
CONFIG_NLS_DEFAULT="iso8859-15"
CONFIG_NLS_CODEPAGE_437=m
# CONFIG_NLS_CODEPAGE_737 is not set
# CONFIG_NLS_CODEPAGE_775 is not set
CONFIG_NLS_CODEPAGE_850=m
CONFIG_NLS_CODEPAGE_852=m
# CONFIG_NLS_CODEPAGE_855 is not set
# CONFIG_NLS_CODEPAGE_857 is not set
# CONFIG_NLS_CODEPAGE_860 is not set
# CONFIG_NLS_CODEPAGE_861 is not set
# CONFIG_NLS_CODEPAGE_862 is not set
# CONFIG_NLS_CODEPAGE_863 is not set
# CONFIG_NLS_CODEPAGE_864 is not set
# CONFIG_NLS_CODEPAGE_865 is not set
# CONFIG_NLS_CODEPAGE_866 is not set
# CONFIG_NLS_CODEPAGE_869 is not set
# CONFIG_NLS_CODEPAGE_936 is not set
# CONFIG_NLS_CODEPAGE_950 is not set
# CONFIG_NLS_CODEPAGE_932 is not set
# CONFIG_NLS_CODEPAGE_949 is not set
# CONFIG_NLS_CODEPAGE_874 is not set
# CONFIG_NLS_ISO8859_8 is not set
CONFIG_NLS_CODEPAGE_1250=m
CONFIG_NLS_CODEPAGE_1251=m
CONFIG_NLS_ASCII=m
CONFIG_NLS_ISO8859_1=m
CONFIG_NLS_ISO8859_2=m
# CONFIG_NLS_ISO8859_3 is not set
# CONFIG_NLS_ISO8859_4 is not set
# CONFIG_NLS_ISO8859_5 is not set
# CONFIG_NLS_ISO8859_6 is not set
# CONFIG_NLS_ISO8859_7 is not set
# CONFIG_NLS_ISO8859_9 is not set
# CONFIG_NLS_ISO8859_13 is not set
# CONFIG_NLS_ISO8859_14 is not set
CONFIG_NLS_ISO8859_15=y
# CONFIG_NLS_KOI8_R is not set
# CONFIG_NLS_KOI8_U is not set
CONFIG_NLS_UTF8=m

#
# Distributed Lock Manager
#
CONFIG_DLM=m
# CONFIG_DLM_DEBUG is not set

#
# Instrumentation Support
#
# CONFIG_PROFILING is not set
# CONFIG_KPROBES is not set

#
# Kernel hacking
#
CONFIG_TRACE_IRQFLAGS_SUPPORT=y
CONFIG_PRINTK_TIME=y
# CONFIG_ENABLE_MUST_CHECK is not set
CONFIG_MAGIC_SYSRQ=y
# CONFIG_UNUSED_SYMBOLS is not set
CONFIG_DEBUG_FS=y
CONFIG_HEADERS_CHECK=y
CONFIG_DEBUG_KERNEL=y
# CONFIG_DEBUG_SHIRQ is not set
CONFIG_DETECT_SOFTLOCKUP=y
# CONFIG_SCHED_DEBUG is not set
# CONFIG_SCHEDSTATS is not set
# CONFIG_TIMER_STATS is not set
# CONFIG_DEBUG_PREEMPT is not set
# CONFIG_DEBUG_RT_MUTEXES is not set
# CONFIG_RT_MUTEX_TESTER is not set
# CONFIG_DEBUG_SPINLOCK is not set
# CONFIG_DEBUG_MUTEXES is not set
# CONFIG_DEBUG_LOCK_ALLOC is not set
# CONFIG_PROVE_LOCKING is not set
# CONFIG_DEBUG_SPINLOCK_SLEEP is not set
# CONFIG_DEBUG_LOCKING_API_SELFTESTS is not set
# CONFIG_DEBUG_KOBJECT is not set
CONFIG_DEBUG_BUGVERBOSE=y
# CONFIG_DEBUG_INFO is not set
# CONFIG_DEBUG_VM is not set
# CONFIG_DEBUG_LIST is not set
# CONFIG_FRAME_POINTER is not set
# CONFIG_FORCED_INLINING is not set
# CONFIG_RCU_TORTURE_TEST is not set
# CONFIG_FAULT_INJECTION is not set
CONFIG_EARLY_PRINTK=y
# CONFIG_DEBUG_STACKOVERFLOW is not set
# CONFIG_DEBUG_STACK_USAGE is not set
# CONFIG_DEBUG_PAGEALLOC is not set
# CONFIG_DEBUG_RODATA is not set
CONFIG_4KSTACKS=y
CONFIG_X86_FIND_SMP_CONFIG=y
CONFIG_X86_MPPARSE=y
CONFIG_DOUBLEFAULT=y

#
# Security options
#
CONFIG_KEYS=y
CONFIG_KEYS_DEBUG_PROC_KEYS=y
CONFIG_SECURITY=y
CONFIG_SECURITY_NETWORK=y
CONFIG_SECURITY_NETWORK_XFRM=y
CONFIG_SECURITY_CAPABILITIES=m
CONFIG_SECURITY_ROOTPLUG=m
# CONFIG_SECURITY_SELINUX is not set

#
# Cryptographic options
#
CONFIG_CRYPTO=y
CONFIG_CRYPTO_ALGAPI=y
CONFIG_CRYPTO_ABLKCIPHER=m
CONFIG_CRYPTO_BLKCIPHER=y
CONFIG_CRYPTO_HASH=y
CONFIG_CRYPTO_MANAGER=y
CONFIG_CRYPTO_HMAC=y
CONFIG_CRYPTO_XCBC=m
CONFIG_CRYPTO_NULL=m
CONFIG_CRYPTO_MD4=m
CONFIG_CRYPTO_MD5=y
CONFIG_CRYPTO_SHA1=m
CONFIG_CRYPTO_SHA256=m
CONFIG_CRYPTO_SHA512=m
CONFIG_CRYPTO_WP512=m
CONFIG_CRYPTO_TGR192=m
CONFIG_CRYPTO_GF128MUL=m
CONFIG_CRYPTO_ECB=m
CONFIG_CRYPTO_CBC=y
CONFIG_CRYPTO_PCBC=m
CONFIG_CRYPTO_LRW=m
CONFIG_CRYPTO_CRYPTD=m
CONFIG_CRYPTO_DES=y
CONFIG_CRYPTO_FCRYPT=m
CONFIG_CRYPTO_BLOWFISH=m
CONFIG_CRYPTO_TWOFISH=m
CONFIG_CRYPTO_TWOFISH_COMMON=m
CONFIG_CRYPTO_TWOFISH_586=m
CONFIG_CRYPTO_SERPENT=m
CONFIG_CRYPTO_AES=m
CONFIG_CRYPTO_AES_586=m
CONFIG_CRYPTO_CAST5=m
CONFIG_CRYPTO_CAST6=m
CONFIG_CRYPTO_TEA=m
CONFIG_CRYPTO_ARC4=m
CONFIG_CRYPTO_KHAZAD=m
CONFIG_CRYPTO_ANUBIS=m
CONFIG_CRYPTO_DEFLATE=m
CONFIG_CRYPTO_MICHAEL_MIC=m
CONFIG_CRYPTO_CRC32C=m
CONFIG_CRYPTO_CAMELLIA=m
# CONFIG_CRYPTO_TEST is not set

#
# Hardware crypto devices
#
CONFIG_CRYPTO_DEV_PADLOCK=y
CONFIG_CRYPTO_DEV_PADLOCK_AES=m
CONFIG_CRYPTO_DEV_PADLOCK_SHA=m
CONFIG_CRYPTO_DEV_GEODE=m

#
# Library routines
#
CONFIG_BITREVERSE=y
CONFIG_CRC_CCITT=m
CONFIG_CRC16=m
CONFIG_CRC_ITU_T=m
CONFIG_CRC32=y
CONFIG_LIBCRC32C=m
CONFIG_AUDIT_GENERIC=y
CONFIG_ZLIB_INFLATE=m
CONFIG_ZLIB_DEFLATE=m
CONFIG_TEXTSEARCH=y
CONFIG_TEXTSEARCH_KMP=m
CONFIG_TEXTSEARCH_BM=m
CONFIG_TEXTSEARCH_FSM=m
CONFIG_PLIST=y
CONFIG_HAS_IOMEM=y
CONFIG_HAS_IOPORT=y
CONFIG_HAS_DMA=y
CONFIG_GENERIC_HARDIRQS=y
CONFIG_GENERIC_IRQ_PROBE=y
CONFIG_GENERIC_PENDING_IRQ=y
CONFIG_X86_SMP=y
CONFIG_X86_HT=y
CONFIG_X86_BIOS_REBOOT=y
CONFIG_X86_TRAMPOLINE=y
CONFIG_KTIME_SCALAR=y

^ permalink raw reply	[flat|nested] 40+ messages in thread

* Re: Oops while modprobing phy fixed module
  2007-07-14 12:18 Oops while modprobing phy fixed module Gabriel C
@ 2007-07-14 12:44 ` Gabriel C
  2007-07-15  5:39 ` Satyam Sharma
  1 sibling, 0 replies; 40+ messages in thread
From: Gabriel C @ 2007-07-14 12:44 UTC (permalink / raw)
  To: Linux Kernel Mailing List

Gabriel C wrote:
> Hi,
>
> doing a modprobe fixed the driver segfaults and I get this Oops:
>
>
> Jul 14 13:43:30 lara [  157.952915] Fixed PHY: Registered new driver
[...]

God , tbird sucks ..

There the dmesg with the Oops :

http://194.231.229.228/kern.log

Should be better to read.

Regards,

Gabriel


^ permalink raw reply	[flat|nested] 40+ messages in thread

* Re: Oops while modprobing phy fixed module
  2007-07-14 12:18 Oops while modprobing phy fixed module Gabriel C
  2007-07-14 12:44 ` Gabriel C
@ 2007-07-15  5:39 ` Satyam Sharma
  2007-07-15 17:42   ` Gabriel C
  1 sibling, 1 reply; 40+ messages in thread
From: Satyam Sharma @ 2007-07-15  5:39 UTC (permalink / raw)
  To: Gabriel C
  Cc: Linux Kernel Mailing List, Vitaly Bordug, Jeff Garzik, Christoph Lameter

Hi Gabriel,

On 7/14/07, Gabriel C <nix.or.die@googlemail.com> wrote:
> Hi,
>
> doing a modprobe fixed the driver segfaults and I get this Oops:
>
>
> Jul 14 13:43:30 lara [  157.952915] Fixed PHY: Registered new driver
> Jul 14 13:43:30 lara [  157.953010] Device 'fixed@100:1' does not have a
> release() function, it is broken and must be fixed.
> Jul 14 13:43:30 lara [  157.953019] WARNING: at drivers/base/core.c:107
> device_release()
> Jul 14 13:43:30 lara [  157.953032]  [<c01cf949>] kobject_cleanup+0x3d/0x54
> Jul 14 13:43:30 lara [  157.953050]  [<c01cf960>] kobject_release+0x0/0x8
> Jul 14 13:43:30 lara [  157.953060]  [<c01d0530>] kref_put+0x60/0x6d
> Jul 14 13:43:30 lara [  157.953068]  [<c022f31c>] device_del+0x1f3/0x215
> Jul 14 13:43:30 lara [  157.953083]  [<e8c8f2d5>]
> fixed_mdio_register_device+0x1e2/0x20d [fixed]
> Jul 14 13:43:30 lara [  157.953108]  [<e8c8701b>] fixed_init+0x1b/0x2f
> [fixed]
> Jul 14 13:43:30 lara [  157.953119]  [<c01376ab>]
> sys_init_module+0x1686/0x175a
> Jul 14 13:43:30 lara [  157.953133]  [<c01601e3>] do_sync_read+0x0/0x10a
> Jul 14 13:43:30 lara [  157.953180]  [<c0103dee>]
> sysenter_past_esp+0x5f/0x85
> Jul 14 13:43:30 lara [  157.953195]  [<c0300000>]
> packet_setsockopt+0x1c9/0x2f3
> Jul 14 13:43:30 lara [  157.953232]  =======================

This looks unrelated to the oops itself, but still something that
needs to be fixed, of course. [ Maintainers added to Cc: ]

> Jul 14 13:43:30 lara [  157.953261] BUG: unable to handle kernel paging
> request at virtual address 43b7a800

43b7a800 looks suspicious, it could have been a valid kernel
address, if only for what looks like a single-bit flip.

> Jul 14 13:43:30 lara [  157.953273]  printing eip:
> Jul 14 13:43:30 lara [  157.953278] c015d269
> Jul 14 13:43:30 lara [  157.953283] *pde = 00000000
> Jul 14 13:43:30 lara [  157.953293] Oops: 0000 [#1]
> Jul 14 13:43:30 lara [  157.953301] PREEMPT SMP
> Jul 14 13:43:30 lara [  157.953309] Modules linked in: fixed pc87360
> hwmon_vid i2c_isa eeprom adm1021 uhci_hcd sr_mod shpchp pci_hotplug
> ohci_hcd iTCO_wdt iTCO_vendor_support intel_agp i82860_edac i2c_i801
> ehci_hcd usbcore edac_mc cdrom agpgart 3c59x mii ext4dev jbd2 capability
> commoncap loop lp parport_pc parport
> Jul 14 13:43:30 lara [  157.953386] CPU:    3
> Jul 14 13:43:30 lara [  157.953387] EIP:    0060:[<c015d269>]    Not
> tainted VLI
> Jul 14 13:43:30 lara [  157.953391] EFLAGS: 00210006   (2.6.22-g8d9107e8 #7)
> Jul 14 13:43:30 lara [  157.953404] EIP is at kmem_cache_zalloc+0x75/0x89
> Jul 14 13:43:30 lara [  157.953412] eax: 00000000   ebx: 00200282   ecx:
> c14c8760   edx: 43b7a800
> Jul 14 13:43:30 lara [  157.953423] esi: e7f75840   edi: c17937b8   ebp:
> 000000d0   esp: db1ced98
> Jul 14 13:43:30 lara [  157.953434] ds: 007b   es: 007b   fs: 00d8  gs:
> 0033  ss: 0068
> Jul 14 13:43:30 lara [  157.953444] Process modprobe (pid: 2164,
> ti=db1ce000 task=de78ac20 task.ti=db1ce000)
> Jul 14 13:43:30 lara [  157.953450] Stack: c014cfd4 c01cf2f7 43b7a800
> c03ae384 c036d990 db150690 c17937b8 c17937b8
> Jul 14 13:43:30 lara [  157.953470]        c019752a 00000002 41ed0000
> e643bb60 c036d990 db150690 c036d990 e643bb60
> Jul 14 13:43:30 lara [  157.953489]        c01979b1 c0197712 db1cede4
> 00000000 e643bb60 c036d990 00000000 c03b8e98
> Jul 14 13:43:30 lara [  157.953513] Call Trace:
> Jul 14 13:43:30 lara [  157.953518]  [<c014cfd4>] kstrdup+0x27/0x47
> Jul 14 13:43:30 lara [  157.953530]  [<c01cf2f7>]
> ida_get_new_above+0xe6/0x166
> Jul 14 13:43:30 lara [  157.953551]  [<c019752a>] sysfs_new_dirent+0x3d/0xdc
> Jul 14 13:43:30 lara [  157.953574]  [<c01979b1>] create_dir+0x1e/0x8c
> Jul 14 13:43:30 lara [  157.953588]  [<c0197712>]
> sysfs_addrm_finish+0x13/0x1d8
> Jul 14 13:43:30 lara [  157.953609]  [<c0197a90>]
> sysfs_create_subdir+0x13/0x16
> Jul 14 13:43:30 lara [  157.953622]  [<c0198dba>]
> sysfs_create_group+0x25/0xe7
> Jul 14 13:43:30 lara [  157.953642]  [<c0233616>] device_pm_add+0x38/0x72
> Jul 14 13:43:30 lara [  157.953655]  [<c022f61d>] device_add+0x230/0x3d8
> Jul 14 13:43:30 lara [  157.953678]  [<e8c8f26d>]
> fixed_mdio_register_device+0x17a/0x20d [fixed]
> Jul 14 13:43:30 lara [  157.953706]  [<e8c8702c>] fixed_init+0x2c/0x2f
> [fixed]
> Jul 14 13:43:30 lara [  157.953718]  [<c01376ab>]
> sys_init_module+0x1686/0x175a
> Jul 14 13:43:30 lara [  157.953734]  [<c01601e3>] do_sync_read+0x0/0x10a
> Jul 14 13:43:30 lara [  157.953797]  [<c0103dee>]
> sysenter_past_esp+0x5f/0x85
> Jul 14 13:43:30 lara [  157.953816]  [<c0300000>]
> packet_setsockopt+0x1c9/0x2f3
> Jul 14 13:43:30 lara [  157.953835]  =======================
> Jul 14 13:43:30 lara [  157.953841] Code: 08 00 74 2f 8b 56 08 31 c0 89
> d1 c1 e9 02 8b 7c 24 08 f3 ab f6 c2 02 74 02 66 ab f6 c2 01 74 01 aa eb
> 10 0f b7 41 0a 8b 54 24 08 <8b> 04 82 89 41 0c eb c8 8b 44 24 08 83 c4
> 10 5b 5e 5f 5d c3 57

Thanks to Randy's wonderful decodecode script, we know this is
mov    (%edx,%eax,4),%eax

> Jul 14 13:43:30 lara [  157.953943] EIP: [<c015d269>]
> kmem_cache_zalloc+0x75/0x89 SS:ESP 0068:db1ced98

I think this is slab_alloc() inlined from SLUB's kmem_cache_zalloc():

	page = s->cpu_slab[smp_processor_id()];
	if (unlikely(!page || !page->lockless_freelist ||
			(node != -1 && page_to_nid(page) != node)))

		object = __slab_alloc(s, gfpflags, node, addr, page);

	else {
		object = page->lockless_freelist;
		page->lockless_freelist = object[page->offset];	<=== Oops
	}

which shouldn't happen unless you have memory errors. I'd suggest
to check with memtest86+.

Satyam

^ permalink raw reply	[flat|nested] 40+ messages in thread

* Re: Oops while modprobing phy fixed module
  2007-07-15  5:39 ` Satyam Sharma
@ 2007-07-15 17:42   ` Gabriel C
  2007-07-15 20:32     ` Gabriel C
                       ` (2 more replies)
  0 siblings, 3 replies; 40+ messages in thread
From: Gabriel C @ 2007-07-15 17:42 UTC (permalink / raw)
  To: Satyam Sharma
  Cc: Linux Kernel Mailing List, Vitaly Bordug, Jeff Garzik, Christoph Lameter

Satyam Sharma wrote:
> Hi Gabriel,
>   

Hi Satyam ,

> On 7/14/07, Gabriel C <nix.or.die@googlemail.com> wrote:
>   
>> Hi,
>>
>> doing a modprobe fixed the driver segfaults and I get this Oops:
>>
>>
>> Jul 14 13:43:30 lara [  157.952915] Fixed PHY: Registered new driver
>> Jul 14 13:43:30 lara [  157.953010] Device 'fixed@100:1' does not have a
>> release() function, it is broken and must be fixed.
>> Jul 14 13:43:30 lara [  157.953019] WARNING: at drivers/base/core.c:107
>> device_release()
>> Jul 14 13:43:30 lara [  157.953032]  [<c01cf949>] kobject_cleanup+0x3d/0x54
>> Jul 14 13:43:30 lara [  157.953050]  [<c01cf960>] kobject_release+0x0/0x8
>> Jul 14 13:43:30 lara [  157.953060]  [<c01d0530>] kref_put+0x60/0x6d
>> Jul 14 13:43:30 lara [  157.953068]  [<c022f31c>] device_del+0x1f3/0x215
>> Jul 14 13:43:30 lara [  157.953083]  [<e8c8f2d5>]
>> fixed_mdio_register_device+0x1e2/0x20d [fixed]
>> Jul 14 13:43:30 lara [  157.953108]  [<e8c8701b>] fixed_init+0x1b/0x2f
>> [fixed]
>> Jul 14 13:43:30 lara [  157.953119]  [<c01376ab>]
>> sys_init_module+0x1686/0x175a
>> Jul 14 13:43:30 lara [  157.953133]  [<c01601e3>] do_sync_read+0x0/0x10a
>> Jul 14 13:43:30 lara [  157.953180]  [<c0103dee>]
>> sysenter_past_esp+0x5f/0x85
>> Jul 14 13:43:30 lara [  157.953195]  [<c0300000>]
>> packet_setsockopt+0x1c9/0x2f3
>> Jul 14 13:43:30 lara [  157.953232]  =======================
>>     
>
> This looks unrelated to the oops itself, but still something that
> needs to be fixed, of course. [ Maintainers added to Cc: ]
>
>   
>> Jul 14 13:43:30 lara [  157.953261] BUG: unable to handle kernel paging
>> request at virtual address 43b7a800
>>     
>
> 43b7a800 looks suspicious, it could have been a valid kernel
> address, if only for what looks like a single-bit flip.
>
>   
>> Jul 14 13:43:30 lara [  157.953273]  printing eip:
>> Jul 14 13:43:30 lara [  157.953278] c015d269
>> Jul 14 13:43:30 lara [  157.953283] *pde = 00000000
>> Jul 14 13:43:30 lara [  157.953293] Oops: 0000 [#1]
>> Jul 14 13:43:30 lara [  157.953301] PREEMPT SMP
>> Jul 14 13:43:30 lara [  157.953309] Modules linked in: fixed pc87360
>> hwmon_vid i2c_isa eeprom adm1021 uhci_hcd sr_mod shpchp pci_hotplug
>> ohci_hcd iTCO_wdt iTCO_vendor_support intel_agp i82860_edac i2c_i801
>> ehci_hcd usbcore edac_mc cdrom agpgart 3c59x mii ext4dev jbd2 capability
>> commoncap loop lp parport_pc parport
>> Jul 14 13:43:30 lara [  157.953386] CPU:    3
>> Jul 14 13:43:30 lara [  157.953387] EIP:    0060:[<c015d269>]    Not
>> tainted VLI
>> Jul 14 13:43:30 lara [  157.953391] EFLAGS: 00210006   (2.6.22-g8d9107e8 #7)
>> Jul 14 13:43:30 lara [  157.953404] EIP is at kmem_cache_zalloc+0x75/0x89
>> Jul 14 13:43:30 lara [  157.953412] eax: 00000000   ebx: 00200282   ecx:
>> c14c8760   edx: 43b7a800
>> Jul 14 13:43:30 lara [  157.953423] esi: e7f75840   edi: c17937b8   ebp:
>> 000000d0   esp: db1ced98
>> Jul 14 13:43:30 lara [  157.953434] ds: 007b   es: 007b   fs: 00d8  gs:
>> 0033  ss: 0068
>> Jul 14 13:43:30 lara [  157.953444] Process modprobe (pid: 2164,
>> ti=db1ce000 task=de78ac20 task.ti=db1ce000)
>> Jul 14 13:43:30 lara [  157.953450] Stack: c014cfd4 c01cf2f7 43b7a800
>> c03ae384 c036d990 db150690 c17937b8 c17937b8
>> Jul 14 13:43:30 lara [  157.953470]        c019752a 00000002 41ed0000
>> e643bb60 c036d990 db150690 c036d990 e643bb60
>> Jul 14 13:43:30 lara [  157.953489]        c01979b1 c0197712 db1cede4
>> 00000000 e643bb60 c036d990 00000000 c03b8e98
>> Jul 14 13:43:30 lara [  157.953513] Call Trace:
>> Jul 14 13:43:30 lara [  157.953518]  [<c014cfd4>] kstrdup+0x27/0x47
>> Jul 14 13:43:30 lara [  157.953530]  [<c01cf2f7>]
>> ida_get_new_above+0xe6/0x166
>> Jul 14 13:43:30 lara [  157.953551]  [<c019752a>] sysfs_new_dirent+0x3d/0xdc
>> Jul 14 13:43:30 lara [  157.953574]  [<c01979b1>] create_dir+0x1e/0x8c
>> Jul 14 13:43:30 lara [  157.953588]  [<c0197712>]
>> sysfs_addrm_finish+0x13/0x1d8
>> Jul 14 13:43:30 lara [  157.953609]  [<c0197a90>]
>> sysfs_create_subdir+0x13/0x16
>> Jul 14 13:43:30 lara [  157.953622]  [<c0198dba>]
>> sysfs_create_group+0x25/0xe7
>> Jul 14 13:43:30 lara [  157.953642]  [<c0233616>] device_pm_add+0x38/0x72
>> Jul 14 13:43:30 lara [  157.953655]  [<c022f61d>] device_add+0x230/0x3d8
>> Jul 14 13:43:30 lara [  157.953678]  [<e8c8f26d>]
>> fixed_mdio_register_device+0x17a/0x20d [fixed]
>> Jul 14 13:43:30 lara [  157.953706]  [<e8c8702c>] fixed_init+0x2c/0x2f
>> [fixed]
>> Jul 14 13:43:30 lara [  157.953718]  [<c01376ab>]
>> sys_init_module+0x1686/0x175a
>> Jul 14 13:43:30 lara [  157.953734]  [<c01601e3>] do_sync_read+0x0/0x10a
>> Jul 14 13:43:30 lara [  157.953797]  [<c0103dee>]
>> sysenter_past_esp+0x5f/0x85
>> Jul 14 13:43:30 lara [  157.953816]  [<c0300000>]
>> packet_setsockopt+0x1c9/0x2f3
>> Jul 14 13:43:30 lara [  157.953835]  =======================
>> Jul 14 13:43:30 lara [  157.953841] Code: 08 00 74 2f 8b 56 08 31 c0 89
>> d1 c1 e9 02 8b 7c 24 08 f3 ab f6 c2 02 74 02 66 ab f6 c2 01 74 01 aa eb
>> 10 0f b7 41 0a 8b 54 24 08 <8b> 04 82 89 41 0c eb c8 8b 44 24 08 83 c4
>> 10 5b 5e 5f 5d c3 57
>>     
>
> Thanks to Randy's wonderful decodecode script, we know this is
> mov    (%edx,%eax,4),%eax
>
>   
>> Jul 14 13:43:30 lara [  157.953943] EIP: [<c015d269>]
>> kmem_cache_zalloc+0x75/0x89 SS:ESP 0068:db1ced98
>>     
>
> I think this is slab_alloc() inlined from SLUB's kmem_cache_zalloc():
>
> 	page = s->cpu_slab[smp_processor_id()];
> 	if (unlikely(!page || !page->lockless_freelist ||
> 			(node != -1 && page_to_nid(page) != node)))
>
> 		object = __slab_alloc(s, gfpflags, node, addr, page);
>
> 	else {
> 		object = page->lockless_freelist;
> 		page->lockless_freelist = object[page->offset];	<=== Oops
> 	}
>
> which shouldn't happen unless you have memory errors. I'd suggest
> to check with memtest86+.
>   

I did so again ( did a 24h memtest run like 2 weeks ago with no errors )
for 12 hours now an no errors / no ECC errors , so I think my RAM is ok.

That box is using RDRAM PC800 ECC Rambus.

Do you want me to try reproduce this Oops with a full debug enabled kernel ?

> Satyam
>
>   

Gabriel

^ permalink raw reply	[flat|nested] 40+ messages in thread

* Re: Oops while modprobing phy fixed module
  2007-07-15 17:42   ` Gabriel C
@ 2007-07-15 20:32     ` Gabriel C
  2007-07-15 21:14     ` Satyam Sharma
  2007-07-16 17:43     ` Vitaly Bordug
  2 siblings, 0 replies; 40+ messages in thread
From: Gabriel C @ 2007-07-15 20:32 UTC (permalink / raw)
  To: Satyam Sharma
  Cc: Linux Kernel Mailing List, Vitaly Bordug, Jeff Garzik, Christoph Lameter

Gabriel C wrote:
> Satyam Sharma wrote:
>   
>> Hi Gabriel,
>>   
>>     
>
> Hi Satyam ,
>
>   
>> On 7/14/07, Gabriel C <nix.or.die@googlemail.com> wrote:
>>   
>>     
>>> Hi,
>>>
>>> doing a modprobe fixed the driver segfaults and I get this Oops:
>>>
>>>
>>> Jul 14 13:43:30 lara [  157.952915] Fixed PHY: Registered new driver
>>> Jul 14 13:43:30 lara [  157.953010] Device 'fixed@100:1' does not have a
>>> release() function, it is broken and must be fixed.
>>> Jul 14 13:43:30 lara [  157.953019] WARNING: at drivers/base/core.c:107
>>> device_release()
>>> Jul 14 13:43:30 lara [  157.953032]  [<c01cf949>] kobject_cleanup+0x3d/0x54
>>> Jul 14 13:43:30 lara [  157.953050]  [<c01cf960>] kobject_release+0x0/0x8
>>> Jul 14 13:43:30 lara [  157.953060]  [<c01d0530>] kref_put+0x60/0x6d
>>> Jul 14 13:43:30 lara [  157.953068]  [<c022f31c>] device_del+0x1f3/0x215
>>> Jul 14 13:43:30 lara [  157.953083]  [<e8c8f2d5>]
>>> fixed_mdio_register_device+0x1e2/0x20d [fixed]
>>> Jul 14 13:43:30 lara [  157.953108]  [<e8c8701b>] fixed_init+0x1b/0x2f
>>> [fixed]
>>> Jul 14 13:43:30 lara [  157.953119]  [<c01376ab>]
>>> sys_init_module+0x1686/0x175a
>>> Jul 14 13:43:30 lara [  157.953133]  [<c01601e3>] do_sync_read+0x0/0x10a
>>> Jul 14 13:43:30 lara [  157.953180]  [<c0103dee>]
>>> sysenter_past_esp+0x5f/0x85
>>> Jul 14 13:43:30 lara [  157.953195]  [<c0300000>]
>>> packet_setsockopt+0x1c9/0x2f3
>>> Jul 14 13:43:30 lara [  157.953232]  =======================
>>>     
>>>       
>> This looks unrelated to the oops itself, but still something that
>> needs to be fixed, of course. [ Maintainers added to Cc: ]
>>
>>   
>>     
>>> Jul 14 13:43:30 lara [  157.953261] BUG: unable to handle kernel paging
>>> request at virtual address 43b7a800
>>>     
>>>       
>> 43b7a800 looks suspicious, it could have been a valid kernel
>> address, if only for what looks like a single-bit flip.
>>
>>   
>>     
>>> Jul 14 13:43:30 lara [  157.953273]  printing eip:
>>> Jul 14 13:43:30 lara [  157.953278] c015d269
>>> Jul 14 13:43:30 lara [  157.953283] *pde = 00000000
>>> Jul 14 13:43:30 lara [  157.953293] Oops: 0000 [#1]
>>> Jul 14 13:43:30 lara [  157.953301] PREEMPT SMP
>>> Jul 14 13:43:30 lara [  157.953309] Modules linked in: fixed pc87360
>>> hwmon_vid i2c_isa eeprom adm1021 uhci_hcd sr_mod shpchp pci_hotplug
>>> ohci_hcd iTCO_wdt iTCO_vendor_support intel_agp i82860_edac i2c_i801
>>> ehci_hcd usbcore edac_mc cdrom agpgart 3c59x mii ext4dev jbd2 capability
>>> commoncap loop lp parport_pc parport
>>> Jul 14 13:43:30 lara [  157.953386] CPU:    3
>>> Jul 14 13:43:30 lara [  157.953387] EIP:    0060:[<c015d269>]    Not
>>> tainted VLI
>>> Jul 14 13:43:30 lara [  157.953391] EFLAGS: 00210006   (2.6.22-g8d9107e8 #7)
>>> Jul 14 13:43:30 lara [  157.953404] EIP is at kmem_cache_zalloc+0x75/0x89
>>> Jul 14 13:43:30 lara [  157.953412] eax: 00000000   ebx: 00200282   ecx:
>>> c14c8760   edx: 43b7a800
>>> Jul 14 13:43:30 lara [  157.953423] esi: e7f75840   edi: c17937b8   ebp:
>>> 000000d0   esp: db1ced98
>>> Jul 14 13:43:30 lara [  157.953434] ds: 007b   es: 007b   fs: 00d8  gs:
>>> 0033  ss: 0068
>>> Jul 14 13:43:30 lara [  157.953444] Process modprobe (pid: 2164,
>>> ti=db1ce000 task=de78ac20 task.ti=db1ce000)
>>> Jul 14 13:43:30 lara [  157.953450] Stack: c014cfd4 c01cf2f7 43b7a800
>>> c03ae384 c036d990 db150690 c17937b8 c17937b8
>>> Jul 14 13:43:30 lara [  157.953470]        c019752a 00000002 41ed0000
>>> e643bb60 c036d990 db150690 c036d990 e643bb60
>>> Jul 14 13:43:30 lara [  157.953489]        c01979b1 c0197712 db1cede4
>>> 00000000 e643bb60 c036d990 00000000 c03b8e98
>>> Jul 14 13:43:30 lara [  157.953513] Call Trace:
>>> Jul 14 13:43:30 lara [  157.953518]  [<c014cfd4>] kstrdup+0x27/0x47
>>> Jul 14 13:43:30 lara [  157.953530]  [<c01cf2f7>]
>>> ida_get_new_above+0xe6/0x166
>>> Jul 14 13:43:30 lara [  157.953551]  [<c019752a>] sysfs_new_dirent+0x3d/0xdc
>>> Jul 14 13:43:30 lara [  157.953574]  [<c01979b1>] create_dir+0x1e/0x8c
>>> Jul 14 13:43:30 lara [  157.953588]  [<c0197712>]
>>> sysfs_addrm_finish+0x13/0x1d8
>>> Jul 14 13:43:30 lara [  157.953609]  [<c0197a90>]
>>> sysfs_create_subdir+0x13/0x16
>>> Jul 14 13:43:30 lara [  157.953622]  [<c0198dba>]
>>> sysfs_create_group+0x25/0xe7
>>> Jul 14 13:43:30 lara [  157.953642]  [<c0233616>] device_pm_add+0x38/0x72
>>> Jul 14 13:43:30 lara [  157.953655]  [<c022f61d>] device_add+0x230/0x3d8
>>> Jul 14 13:43:30 lara [  157.953678]  [<e8c8f26d>]
>>> fixed_mdio_register_device+0x17a/0x20d [fixed]
>>> Jul 14 13:43:30 lara [  157.953706]  [<e8c8702c>] fixed_init+0x2c/0x2f
>>> [fixed]
>>> Jul 14 13:43:30 lara [  157.953718]  [<c01376ab>]
>>> sys_init_module+0x1686/0x175a
>>> Jul 14 13:43:30 lara [  157.953734]  [<c01601e3>] do_sync_read+0x0/0x10a
>>> Jul 14 13:43:30 lara [  157.953797]  [<c0103dee>]
>>> sysenter_past_esp+0x5f/0x85
>>> Jul 14 13:43:30 lara [  157.953816]  [<c0300000>]
>>> packet_setsockopt+0x1c9/0x2f3
>>> Jul 14 13:43:30 lara [  157.953835]  =======================
>>> Jul 14 13:43:30 lara [  157.953841] Code: 08 00 74 2f 8b 56 08 31 c0 89
>>> d1 c1 e9 02 8b 7c 24 08 f3 ab f6 c2 02 74 02 66 ab f6 c2 01 74 01 aa eb
>>> 10 0f b7 41 0a 8b 54 24 08 <8b> 04 82 89 41 0c eb c8 8b 44 24 08 83 c4
>>> 10 5b 5e 5f 5d c3 57
>>>     
>>>       
>> Thanks to Randy's wonderful decodecode script, we know this is
>> mov    (%edx,%eax,4),%eax
>>
>>   
>>     
>>> Jul 14 13:43:30 lara [  157.953943] EIP: [<c015d269>]
>>> kmem_cache_zalloc+0x75/0x89 SS:ESP 0068:db1ced98
>>>     
>>>       
>> I think this is slab_alloc() inlined from SLUB's kmem_cache_zalloc():
>>
>> 	page = s->cpu_slab[smp_processor_id()];
>> 	if (unlikely(!page || !page->lockless_freelist ||
>> 			(node != -1 && page_to_nid(page) != node)))
>>
>> 		object = __slab_alloc(s, gfpflags, node, addr, page);
>>
>> 	else {
>> 		object = page->lockless_freelist;
>> 		page->lockless_freelist = object[page->offset];	<=== Oops
>> 	}
>>
>> which shouldn't happen unless you have memory errors. I'd suggest
>> to check with memtest86+.
>>   
>>     
>
> I did so again ( did a 24h memtest run like 2 weeks ago with no errors )
> for 12 hours now an no errors / no ECC errors , so I think my RAM is ok.
>
> That box is using RDRAM PC800 ECC Rambus.
>
> Do you want me to try reproduce this Oops with a full debug enabled kernel ?
>   

Also I switched to SLAB ( with the same config ) and no Oops anymore
just the driver warning left.


Gabriel


^ permalink raw reply	[flat|nested] 40+ messages in thread

* Re: Oops while modprobing phy fixed module
  2007-07-15 17:42   ` Gabriel C
  2007-07-15 20:32     ` Gabriel C
@ 2007-07-15 21:14     ` Satyam Sharma
  2007-07-15 22:19       ` Gabriel C
  2007-07-16 17:43     ` Vitaly Bordug
  2 siblings, 1 reply; 40+ messages in thread
From: Satyam Sharma @ 2007-07-15 21:14 UTC (permalink / raw)
  To: Gabriel C; +Cc: Linux Kernel Mailing List, Christoph Lameter

On 7/15/07, Gabriel C <nix.or.die@googlemail.com> wrote:
> >> [...]
> >> doing a modprobe fixed the driver segfaults and I get this Oops:
> >>
> >> Jul 14 13:43:30 lara [  157.953261] BUG: unable to handle kernel paging
> >> request at virtual address 43b7a800
> >>
> >
> > 43b7a800 looks suspicious, it could have been a valid kernel
> > address, if only for what looks like a single-bit flip.
> >
> >
> >> Jul 14 13:43:30 lara [  157.953273]  printing eip:
> >> Jul 14 13:43:30 lara [  157.953278] c015d269
> >> Jul 14 13:43:30 lara [  157.953283] *pde = 00000000
> >> Jul 14 13:43:30 lara [  157.953293] Oops: 0000 [#1]
> >> Jul 14 13:43:30 lara [  157.953301] PREEMPT SMP
> >> Jul 14 13:43:30 lara [  157.953309] Modules linked in: fixed pc87360
> >> hwmon_vid i2c_isa eeprom adm1021 uhci_hcd sr_mod shpchp pci_hotplug
> >> ohci_hcd iTCO_wdt iTCO_vendor_support intel_agp i82860_edac i2c_i801
> >> ehci_hcd usbcore edac_mc cdrom agpgart 3c59x mii ext4dev jbd2 capability
> >> commoncap loop lp parport_pc parport
> >> Jul 14 13:43:30 lara [  157.953386] CPU:    3
> >> Jul 14 13:43:30 lara [  157.953387] EIP:    0060:[<c015d269>]    Not
> >> tainted VLI
> >> Jul 14 13:43:30 lara [  157.953391] EFLAGS: 00210006   (2.6.22-g8d9107e8 #7)
> >> Jul 14 13:43:30 lara [  157.953404] EIP is at kmem_cache_zalloc+0x75/0x89
> >> Jul 14 13:43:30 lara [  157.953412] eax: 00000000   ebx: 00200282   ecx:
> >> c14c8760   edx: 43b7a800
> >> Jul 14 13:43:30 lara [  157.953423] esi: e7f75840   edi: c17937b8   ebp:
> >> 000000d0   esp: db1ced98
> >> Jul 14 13:43:30 lara [  157.953434] ds: 007b   es: 007b   fs: 00d8  gs:
> >> 0033  ss: 0068
> >> Jul 14 13:43:30 lara [  157.953444] Process modprobe (pid: 2164,
> >> ti=db1ce000 task=de78ac20 task.ti=db1ce000)
> >> Jul 14 13:43:30 lara [  157.953450] Stack: c014cfd4 c01cf2f7 43b7a800
> >> c03ae384 c036d990 db150690 c17937b8 c17937b8
> >> Jul 14 13:43:30 lara [  157.953470]        c019752a 00000002 41ed0000
> >> e643bb60 c036d990 db150690 c036d990 e643bb60
> >> Jul 14 13:43:30 lara [  157.953489]        c01979b1 c0197712 db1cede4
> >> 00000000 e643bb60 c036d990 00000000 c03b8e98
> >> Jul 14 13:43:30 lara [  157.953513] Call Trace:
> >> Jul 14 13:43:30 lara [  157.953518]  [<c014cfd4>] kstrdup+0x27/0x47
> >> Jul 14 13:43:30 lara [  157.953530]  [<c01cf2f7>]
> >> ida_get_new_above+0xe6/0x166
> >> Jul 14 13:43:30 lara [  157.953551]  [<c019752a>] sysfs_new_dirent+0x3d/0xdc
> >> Jul 14 13:43:30 lara [  157.953574]  [<c01979b1>] create_dir+0x1e/0x8c
> >> Jul 14 13:43:30 lara [  157.953588]  [<c0197712>]
> >> sysfs_addrm_finish+0x13/0x1d8
> >> Jul 14 13:43:30 lara [  157.953609]  [<c0197a90>]
> >> sysfs_create_subdir+0x13/0x16
> >> Jul 14 13:43:30 lara [  157.953622]  [<c0198dba>]
> >> sysfs_create_group+0x25/0xe7
> >> Jul 14 13:43:30 lara [  157.953642]  [<c0233616>] device_pm_add+0x38/0x72
> >> Jul 14 13:43:30 lara [  157.953655]  [<c022f61d>] device_add+0x230/0x3d8
> >> Jul 14 13:43:30 lara [  157.953678]  [<e8c8f26d>]
> >> fixed_mdio_register_device+0x17a/0x20d [fixed]
> >> Jul 14 13:43:30 lara [  157.953706]  [<e8c8702c>] fixed_init+0x2c/0x2f
> >> [fixed]
> >> Jul 14 13:43:30 lara [  157.953718]  [<c01376ab>]
> >> sys_init_module+0x1686/0x175a
> >> Jul 14 13:43:30 lara [  157.953734]  [<c01601e3>] do_sync_read+0x0/0x10a
> >> Jul 14 13:43:30 lara [  157.953797]  [<c0103dee>]
> >> sysenter_past_esp+0x5f/0x85
> >> Jul 14 13:43:30 lara [  157.953816]  [<c0300000>]
> >> packet_setsockopt+0x1c9/0x2f3
> >> Jul 14 13:43:30 lara [  157.953835]  =======================
> >> Jul 14 13:43:30 lara [  157.953841] Code: 08 00 74 2f 8b 56 08 31 c0 89
> >> d1 c1 e9 02 8b 7c 24 08 f3 ab f6 c2 02 74 02 66 ab f6 c2 01 74 01 aa eb
> >> 10 0f b7 41 0a 8b 54 24 08 <8b> 04 82 89 41 0c eb c8 8b 44 24 08 83 c4
> >> 10 5b 5e 5f 5d c3 57
> >>
> >
> > Thanks to Randy's wonderful decodecode script, we know this is
> > mov    (%edx,%eax,4),%eax
> >
> >
> >> Jul 14 13:43:30 lara [  157.953943] EIP: [<c015d269>]
> >> kmem_cache_zalloc+0x75/0x89 SS:ESP 0068:db1ced98
> >>
> >
> > I think this is slab_alloc() inlined from SLUB's kmem_cache_zalloc():
> >
> >       page = s->cpu_slab[smp_processor_id()];
> >       if (unlikely(!page || !page->lockless_freelist ||
> >                       (node != -1 && page_to_nid(page) != node)))
> >
> >               object = __slab_alloc(s, gfpflags, node, addr, page);
> >
> >       else {
> >               object = page->lockless_freelist;
> >               page->lockless_freelist = object[page->offset]; <=== Oops
> >       }
> >
> > which shouldn't happen unless you have memory errors. I'd suggest
> > to check with memtest86+.
> >
>
> I did so again ( did a 24h memtest run like 2 weeks ago with no errors )
> for 12 hours now an no errors / no ECC errors , so I think my RAM is ok.
>
> That box is using RDRAM PC800 ECC Rambus.
>
> Do you want me to try reproduce this Oops with a full debug enabled kernel ?

Yup, it'll be good if you can reproduce the oops -- whether with a debug
enabled kernel or not (race conditions could get hidden with debug stuff
enabled, so getting oops frequently even without the debug stuff would
still be helpful).

Thanks,
Satyam

^ permalink raw reply	[flat|nested] 40+ messages in thread

* Re: Oops while modprobing phy fixed module
  2007-07-15 21:14     ` Satyam Sharma
@ 2007-07-15 22:19       ` Gabriel C
  2007-07-16 12:17         ` Gabriel C
  0 siblings, 1 reply; 40+ messages in thread
From: Gabriel C @ 2007-07-15 22:19 UTC (permalink / raw)
  To: Satyam Sharma; +Cc: Linux Kernel Mailing List, Christoph Lameter

Satyam Sharma wrote:
> On 7/15/07, Gabriel C <nix.or.die@googlemail.com> wrote:
>   
>>>> [...]
>>>> doing a modprobe fixed the driver segfaults and I get this Oops:
>>>>
>>>> Jul 14 13:43:30 lara [  157.953261] BUG: unable to handle kernel paging
>>>> request at virtual address 43b7a800
>>>>
>>>>         
>>> 43b7a800 looks suspicious, it could have been a valid kernel
>>> address, if only for what looks like a single-bit flip.
>>>
>>>
>>>       
>>>> Jul 14 13:43:30 lara [  157.953273]  printing eip:
>>>> Jul 14 13:43:30 lara [  157.953278] c015d269
>>>> Jul 14 13:43:30 lara [  157.953283] *pde = 00000000
>>>> Jul 14 13:43:30 lara [  157.953293] Oops: 0000 [#1]
>>>> Jul 14 13:43:30 lara [  157.953301] PREEMPT SMP
>>>> Jul 14 13:43:30 lara [  157.953309] Modules linked in: fixed pc87360
>>>> hwmon_vid i2c_isa eeprom adm1021 uhci_hcd sr_mod shpchp pci_hotplug
>>>> ohci_hcd iTCO_wdt iTCO_vendor_support intel_agp i82860_edac i2c_i801
>>>> ehci_hcd usbcore edac_mc cdrom agpgart 3c59x mii ext4dev jbd2 capability
>>>> commoncap loop lp parport_pc parport
>>>> Jul 14 13:43:30 lara [  157.953386] CPU:    3
>>>> Jul 14 13:43:30 lara [  157.953387] EIP:    0060:[<c015d269>]    Not
>>>> tainted VLI
>>>> Jul 14 13:43:30 lara [  157.953391] EFLAGS: 00210006   (2.6.22-g8d9107e8 #7)
>>>> Jul 14 13:43:30 lara [  157.953404] EIP is at kmem_cache_zalloc+0x75/0x89
>>>> Jul 14 13:43:30 lara [  157.953412] eax: 00000000   ebx: 00200282   ecx:
>>>> c14c8760   edx: 43b7a800
>>>> Jul 14 13:43:30 lara [  157.953423] esi: e7f75840   edi: c17937b8   ebp:
>>>> 000000d0   esp: db1ced98
>>>> Jul 14 13:43:30 lara [  157.953434] ds: 007b   es: 007b   fs: 00d8  gs:
>>>> 0033  ss: 0068
>>>> Jul 14 13:43:30 lara [  157.953444] Process modprobe (pid: 2164,
>>>> ti=db1ce000 task=de78ac20 task.ti=db1ce000)
>>>> Jul 14 13:43:30 lara [  157.953450] Stack: c014cfd4 c01cf2f7 43b7a800
>>>> c03ae384 c036d990 db150690 c17937b8 c17937b8
>>>> Jul 14 13:43:30 lara [  157.953470]        c019752a 00000002 41ed0000
>>>> e643bb60 c036d990 db150690 c036d990 e643bb60
>>>> Jul 14 13:43:30 lara [  157.953489]        c01979b1 c0197712 db1cede4
>>>> 00000000 e643bb60 c036d990 00000000 c03b8e98
>>>> Jul 14 13:43:30 lara [  157.953513] Call Trace:
>>>> Jul 14 13:43:30 lara [  157.953518]  [<c014cfd4>] kstrdup+0x27/0x47
>>>> Jul 14 13:43:30 lara [  157.953530]  [<c01cf2f7>]
>>>> ida_get_new_above+0xe6/0x166
>>>> Jul 14 13:43:30 lara [  157.953551]  [<c019752a>] sysfs_new_dirent+0x3d/0xdc
>>>> Jul 14 13:43:30 lara [  157.953574]  [<c01979b1>] create_dir+0x1e/0x8c
>>>> Jul 14 13:43:30 lara [  157.953588]  [<c0197712>]
>>>> sysfs_addrm_finish+0x13/0x1d8
>>>> Jul 14 13:43:30 lara [  157.953609]  [<c0197a90>]
>>>> sysfs_create_subdir+0x13/0x16
>>>> Jul 14 13:43:30 lara [  157.953622]  [<c0198dba>]
>>>> sysfs_create_group+0x25/0xe7
>>>> Jul 14 13:43:30 lara [  157.953642]  [<c0233616>] device_pm_add+0x38/0x72
>>>> Jul 14 13:43:30 lara [  157.953655]  [<c022f61d>] device_add+0x230/0x3d8
>>>> Jul 14 13:43:30 lara [  157.953678]  [<e8c8f26d>]
>>>> fixed_mdio_register_device+0x17a/0x20d [fixed]
>>>> Jul 14 13:43:30 lara [  157.953706]  [<e8c8702c>] fixed_init+0x2c/0x2f
>>>> [fixed]
>>>> Jul 14 13:43:30 lara [  157.953718]  [<c01376ab>]
>>>> sys_init_module+0x1686/0x175a
>>>> Jul 14 13:43:30 lara [  157.953734]  [<c01601e3>] do_sync_read+0x0/0x10a
>>>> Jul 14 13:43:30 lara [  157.953797]  [<c0103dee>]
>>>> sysenter_past_esp+0x5f/0x85
>>>> Jul 14 13:43:30 lara [  157.953816]  [<c0300000>]
>>>> packet_setsockopt+0x1c9/0x2f3
>>>> Jul 14 13:43:30 lara [  157.953835]  =======================
>>>> Jul 14 13:43:30 lara [  157.953841] Code: 08 00 74 2f 8b 56 08 31 c0 89
>>>> d1 c1 e9 02 8b 7c 24 08 f3 ab f6 c2 02 74 02 66 ab f6 c2 01 74 01 aa eb
>>>> 10 0f b7 41 0a 8b 54 24 08 <8b> 04 82 89 41 0c eb c8 8b 44 24 08 83 c4
>>>> 10 5b 5e 5f 5d c3 57
>>>>
>>>>         
>>> Thanks to Randy's wonderful decodecode script, we know this is
>>> mov    (%edx,%eax,4),%eax
>>>
>>>
>>>       
>>>> Jul 14 13:43:30 lara [  157.953943] EIP: [<c015d269>]
>>>> kmem_cache_zalloc+0x75/0x89 SS:ESP 0068:db1ced98
>>>>
>>>>         
>>> I think this is slab_alloc() inlined from SLUB's kmem_cache_zalloc():
>>>
>>>       page = s->cpu_slab[smp_processor_id()];
>>>       if (unlikely(!page || !page->lockless_freelist ||
>>>                       (node != -1 && page_to_nid(page) != node)))
>>>
>>>               object = __slab_alloc(s, gfpflags, node, addr, page);
>>>
>>>       else {
>>>               object = page->lockless_freelist;
>>>               page->lockless_freelist = object[page->offset]; <=== Oops
>>>       }
>>>
>>> which shouldn't happen unless you have memory errors. I'd suggest
>>> to check with memtest86+.
>>>
>>>       
>> I did so again ( did a 24h memtest run like 2 weeks ago with no errors )
>> for 12 hours now an no errors / no ECC errors , so I think my RAM is ok.
>>
>> That box is using RDRAM PC800 ECC Rambus.
>>
>> Do you want me to try reproduce this Oops with a full debug enabled kernel ?
>>     
>
> Yup, it'll be good if you can reproduce the oops -- whether with a debug
> enabled kernel or not (race conditions could get hidden with debug stuff
> enabled, so getting oops frequently even without the debug stuff would
> still be helpful).
>
>   
Ok here it is again same config but with DEBUG_KERNEL=n


...

Jul 15 23:51:01 lara [  220.800701] Fixed PHY: Registered new driver
Jul 15 23:51:01 lara [  220.800815] Device 'fixed@100:1' does not have a
release() function, it is broken and must be fixed.
Jul 15 23:51:01 lara [  220.800823] WARNING: at drivers/base/core.c:107
device_release()
Jul 15 23:51:01 lara [  220.800837]  [<c01cf7c9>] kobject_cleanup+0x3d/0x54
Jul 15 23:51:01 lara [  220.800853]  [<c01cf7e0>] kobject_release+0x0/0x8
Jul 15 23:51:01 lara [  220.800863]  [<c01d03b0>] kref_put+0x60/0x6d
Jul 15 23:51:01 lara [  220.800870]  [<c022f198>] device_del+0x1f3/0x215
Jul 15 23:51:01 lara [  220.800888]  [<e8c8f2d5>]
fixed_mdio_register_device+0x1e2/0x20d [fixed]
Jul 15 23:51:01 lara [  220.800910]  [<e8c8701b>] fixed_init+0x1b/0x2f
[fixed]
Jul 15 23:51:01 lara [  220.800920]  [<c01376c3>]
sys_init_module+0x1686/0x175a
Jul 15 23:51:01 lara [  220.800934]  [<c0160070>] do_sync_read+0x0/0x10a
Jul 15 23:51:01 lara [  220.800984]  [<c0103dee>]
sysenter_past_esp+0x5f/0x85
Jul 15 23:51:01 lara [  220.801000]  [<c0300000>]
packet_getsockopt+0x5a/0x103
Jul 15 23:51:01 lara [  220.801016]  =======================
Jul 15 23:51:01 lara [  220.801045] BUG: unable to handle kernel paging
request at virtual address 0f096800
Jul 15 23:51:01 lara [  220.801053]  printing eip:
Jul 15 23:51:01 lara [  220.801056] c015d0f1
Jul 15 23:51:01 lara [  220.801060] *pde = 00000000
Jul 15 23:51:01 lara [  220.801068] Oops: 0000 [#1]
Jul 15 23:51:01 lara [  220.801068] Oops: 0000 [#1]
Jul 15 23:51:01 lara [  220.801071] PREEMPT SMP
Jul 15 23:51:01 lara [  220.801071] PREEMPT SMP
Jul 15 23:51:01 lara [  220.801076] Modules linked in: fixed pc87360
hwmon_vid i2c_isa eeprom adm1021 uhci_hcd sr_mod shpchp pci_hotplug
ohci_hcd iTCO_wdt iTCO_vendor_support intel_agp i82860_edac i2c_i801
ehci_hcd usbcore edac_mc cdrom agpgart 3c59x mii ext4dev jbd2 capability
commoncap loop lp parport_pc parport
Jul 15 23:51:01 lara [  220.801130] CPU:    1
Jul 15 23:51:01 lara [  220.801130] CPU:    1
Jul 15 23:51:01 lara [  220.801133] EIP:    0060:[<c015d0f1>]    Not
tainted VLI
Jul 15 23:51:01 lara [  220.801133] EIP:    0060:[<c015d0f1>]    Not
tainted VLI
Jul 15 23:51:01 lara [  220.801135] EFLAGS: 00210006   (2.6.22-g8d9107e8
#11)
Jul 15 23:51:01 lara [  220.801135] EFLAGS: 00210006   (2.6.22-g8d9107e8
#11)
Jul 15 23:51:01 lara [  220.801145] EIP is at kmem_cache_zalloc+0x75/0x89
Jul 15 23:51:01 lara [  220.801145] EIP is at kmem_cache_zalloc+0x75/0x89
Jul 15 23:51:01 lara [  220.801151] eax: 00000000   ebx: 00200282   ecx:
c1381e00   edx: 0f096800
Jul 15 23:51:01 lara [  220.801151] eax: 00000000   ebx: 00200282   ecx:
c1381e00   edx: 0f096800
Jul 15 23:51:01 lara [  220.801159] esi: e7f75840   edi: e7f0f6a8   ebp:
000000d0   esp: dbe97d98
Jul 15 23:51:01 lara [  220.801159] esi: e7f75840   edi: e7f0f6a8   ebp:
000000d0   esp: dbe97d98
Jul 15 23:51:01 lara [  220.801168] ds: 007b   es: 007b   fs: 00d8  gs:
0033  ss: 0068
Jul 15 23:51:01 lara [  220.801168] ds: 007b   es: 007b   fs: 00d8  gs:
0033  ss: 0068
Jul 15 23:51:01 lara [  220.801176] Process modprobe (pid: 2240,
ti=dbe96000 task=db72ec20 task.ti=dbe96000)
Jul 15 23:51:01 lara [  220.801176] Process modprobe (pid: 2240,
ti=dbe96000 task=db72ec20 task.ti=dbe96000)
Jul 15 23:51:01 lara [  220.801181] Stack: c014ce5c c01cf177 0f096800
c03ae384 c036d768 db0ae690 e7f0f6a8 e7f0f6a8
Jul 15 23:51:01 lara [  220.801181] Stack: c014ce5c c01cf177 0f096800
c03ae384 c036d768 db0ae690 e7f0f6a8 e7f0f6a8
Jul 15 23:51:01 lara [  220.801201]        c01973aa 00000002 41ed0000
dc0f08c0 c036d768 db0ae690 c036d768 dc0f08c0
Jul 15 23:51:01 lara [  220.801201]        c01973aa 00000002 41ed0000
dc0f08c0 c036d768 db0ae690 c036d768 dc0f08c0
Jul 15 23:51:01 lara [  220.801233]        c0197831 c0197592 dbe97de4
00000000 dc0f08c0 c036d768 00000000 c03b8e98
Jul 15 23:51:01 lara [  220.801233]        c0197831 c0197592 dbe97de4
00000000 dc0f08c0 c036d768 00000000 c03b8e98
Jul 15 23:51:01 lara [  220.801257] Call Trace:
Jul 15 23:51:01 lara [  220.801257] Call Trace:
Jul 15 23:51:01 lara [  220.801261]  [<c014ce5c>] kstrdup+0x27/0x47
Jul 15 23:51:01 lara [  220.801261]  [<c014ce5c>] kstrdup+0x27/0x47
Jul 15 23:51:01 lara [  220.801272]  [<c01cf177>]
ida_get_new_above+0xe6/0x166
Jul 15 23:51:01 lara [  220.801272]  [<c01cf177>]
ida_get_new_above+0xe6/0x166
Jul 15 23:51:01 lara [  220.801288]  [<c01973aa>] sysfs_new_dirent+0x3d/0xdc
Jul 15 23:51:01 lara [  220.801288]  [<c01973aa>] sysfs_new_dirent+0x3d/0xdc
Jul 15 23:51:01 lara [  220.801306]  [<c0197831>] create_dir+0x1e/0x8c
Jul 15 23:51:01 lara [  220.801306]  [<c0197831>] create_dir+0x1e/0x8c
Jul 15 23:51:01 lara [  220.801316]  [<c0197592>]
sysfs_addrm_finish+0x13/0x1d8
Jul 15 23:51:01 lara [  220.801316]  [<c0197592>]
sysfs_addrm_finish+0x13/0x1d8
Jul 15 23:51:01 lara [  220.801332]  [<c0197910>]
sysfs_create_subdir+0x13/0x16
Jul 15 23:51:01 lara [  220.801332]  [<c0197910>]
sysfs_create_subdir+0x13/0x16
Jul 15 23:51:01 lara [  220.801343]  [<c0198c3a>]
sysfs_create_group+0x25/0xe7
Jul 15 23:51:01 lara [  220.801343]  [<c0198c3a>]
sysfs_create_group+0x25/0xe7
Jul 15 23:51:01 lara [  220.801359]  [<c0233492>] device_pm_add+0x38/0x72
Jul 15 23:51:01 lara [  220.801359]  [<c0233492>] device_pm_add+0x38/0x72
Jul 15 23:51:01 lara [  220.801371]  [<c022f499>] device_add+0x230/0x3d8
Jul 15 23:51:01 lara [  220.801371]  [<c022f499>] device_add+0x230/0x3d8
Jul 15 23:51:01 lara [  220.801389]  [<e8c8f26d>]
fixed_mdio_register_device+0x17a/0x20d [fixed]
Jul 15 23:51:01 lara [  220.801389]  [<e8c8f26d>]
fixed_mdio_register_device+0x17a/0x20d [fixed]
Jul 15 23:51:01 lara [  220.801411]  [<e8c8702c>] fixed_init+0x2c/0x2f
[fixed]
Jul 15 23:51:01 lara [  220.801411]  [<e8c8702c>] fixed_init+0x2c/0x2f
[fixed]
Jul 15 23:51:01 lara [  220.801422]  [<c01376c3>]
sys_init_module+0x1686/0x175a
Jul 15 23:51:01 lara [  220.801422]  [<c01376c3>]
sys_init_module+0x1686/0x175a
Jul 15 23:51:01 lara [  220.801435]  [<c0160070>] do_sync_read+0x0/0x10a
Jul 15 23:51:01 lara [  220.801435]  [<c0160070>] do_sync_read+0x0/0x10a
Jul 15 23:51:01 lara [  220.801478]  [<c0103dee>]
sysenter_past_esp+0x5f/0x85
Jul 15 23:51:01 lara [  220.801478]  [<c0103dee>]
sysenter_past_esp+0x5f/0x85
Jul 15 23:51:01 lara [  220.801495]  [<c0300000>]
packet_getsockopt+0x5a/0x103
Jul 15 23:51:01 lara [  220.801495]  [<c0300000>]
packet_getsockopt+0x5a/0x103
Jul 15 23:51:01 lara [  220.801510]  =======================
Jul 15 23:51:01 lara [  220.801510]  =======================
Jul 15 23:51:01 lara [  220.801515] Code: 08 00 74 2f 8b 56 08 31 c0 89
d1 c1 e9 02 8b 7c 24 08 f3 ab f6 c2 02 74 02 66 ab f6 c2 01 74 01 aa eb
10 0f b7 41 0a 8b 54 24 08 <8b> 04 82 89 41 0c eb c8 8b 44 24 08 83 c4
10 5b 5e 5f 5d c3 57
Jul 15 23:51:01 lara [  220.801515] Code: 08 00 74 2f 8b 56 08 31 c0 89
d1 c1 e9 02 8b 7c 24 08 f3 ab f6 c2 02 74 02 66 ab f6 c2 01 74 01 aa eb
10 0f b7 41 0a 8b 54 24 08 <8b> 04 82 89 41 0c eb c8 8b 44 24 08 83 c4
10 5b 5e 5f 5d c3 57
Jul 15 23:51:01 lara [  220.801670] EIP: [<c015d0f1>]
kmem_cache_zalloc+0x75/0x89 SS:ESP 0068:dbe97d98
Jul 15 23:51:01 lara [  220.801670] EIP: [<c015d0f1>]
kmem_cache_zalloc+0x75/0x89 SS:ESP 0068:dbe97d98
Jul 15 23:51:06 lara [  225.774876] BUG: unable to handle kernel paging
request at virtual address 0f096800
Jul 15 23:51:06 lara [  225.774884]  printing eip:
Jul 15 23:51:06 lara [  225.774888] c015d3b8
Jul 15 23:51:06 lara [  225.774890] *pde = 00000000
Jul 15 23:51:06 lara [  225.774895] Oops: 0000 [#2]
Jul 15 23:51:06 lara [  225.774895] Oops: 0000 [#2]
Jul 15 23:51:06 lara [  225.774898] PREEMPT SMP
Jul 15 23:51:06 lara [  225.774898] PREEMPT SMP
Jul 15 23:51:06 lara [  225.774902] Modules linked in: fixed pc87360
hwmon_vid i2c_isa eeprom adm1021 uhci_hcd sr_mod shpchp pci_hotplug
ohci_hcd iTCO_wdt iTCO_vendor_support intel_agp i82860_edac i2c_i801
ehci_hcd usbcore edac_mc cdrom agpgart 3c59x mii ext4dev jbd2 capability
commoncap loop lp parport_pc parport
Jul 15 23:51:06 lara [  225.774944] CPU:    1
Jul 15 23:51:06 lara [  225.774944] CPU:    1
Jul 15 23:51:06 lara [  225.774945] EIP:    0060:[<c015d3b8>]    Not
tainted VLI
Jul 15 23:51:06 lara [  225.774945] EIP:    0060:[<c015d3b8>]    Not
tainted VLI
Jul 15 23:51:06 lara [  225.774947] EFLAGS: 00010006   (2.6.22-g8d9107e8
#11)
Jul 15 23:51:06 lara [  225.774947] EFLAGS: 00010006   (2.6.22-g8d9107e8
#11)
Jul 15 23:51:06 lara [  225.774958] EIP is at kmem_cache_alloc+0x4e/0x56
Jul 15 23:51:06 lara [  225.774958] EIP is at kmem_cache_alloc+0x4e/0x56
Jul 15 23:51:06 lara [  225.774962] eax: 00000000   ebx: 00000286   ecx:
c1381e00   edx: 0f096800
Jul 15 23:51:06 lara [  225.774962] eax: 00000000   ebx: 00000286   ecx:
c1381e00   edx: 0f096800
Jul 15 23:51:06 lara [  225.774967] esi: e7f75840   edi: e88556c4   ebp:
00000050   esp: e69e3ec0
Jul 15 23:51:06 lara [  225.774967] esi: e7f75840   edi: e88556c4   ebp:
00000050   esp: e69e3ec0
Jul 15 23:51:06 lara [  225.774972] ds: 007b   es: 007b   fs: 00d8  gs:
0000  ss: 0068
Jul 15 23:51:06 lara [  225.774972] ds: 007b   es: 007b   fs: 00d8  gs:
0000  ss: 0068
Jul 15 23:51:06 lara [  225.774977] Process kjournald2 (pid: 887,
ti=e69e2000 task=e7edf840 task.ti=e69e2000)
Jul 15 23:51:06 lara [  225.774977] Process kjournald2 (pid: 887,
ti=e69e2000 task=e7edf840 task.ti=e69e2000)
Jul 15 23:51:06 lara [  225.774981] Stack: 00000000 e7f6ac00 e6d92d20
e69e2000 e68fa000 00000000 e88556c4 e737e248
Jul 15 23:51:06 lara [  225.774981] Stack: 00000000 e7f6ac00 e6d92d20
e69e2000 e68fa000 00000000 e88556c4 e737e248
Jul 15 23:51:06 lara [  225.774993]        00000003 e4c0a578 e737e240
00000000 e6d92d20 00000000 e68fa000 e69e2000
Jul 15 23:51:06 lara [  225.774993]        00000003 e4c0a578 e737e240
00000000 e6d92d20 00000000 e68fa000 e69e2000
Jul 15 23:51:06 lara [  225.775004]        e88570cc 00001000 0000061b
00000000 de20e780 e4c0a578 e69e2000 e8852c68
Jul 15 23:51:06 lara [  225.775004]        e88570cc 00001000 0000061b
00000000 de20e780 e4c0a578 e69e2000 e8852c68
Jul 15 23:51:06 lara [  225.775016] Call Trace:
Jul 15 23:51:06 lara [  225.775016] Call Trace:
Jul 15 23:51:06 lara [  225.775023]  [<e88556c4>]
jbd2_journal_add_journal_head+0x29/0x189 [jbd2]
Jul 15 23:51:06 lara [  225.775023]  [<e88556c4>]
jbd2_journal_add_journal_head+0x29/0x189 [jbd2]
Jul 15 23:51:06 lara [  225.775046]  [<e88570cc>]
jbd2_journal_get_descriptor_buffer+0x7b/0x83 [jbd2]
Jul 15 23:51:06 lara [  225.775046]  [<e88570cc>]
jbd2_journal_get_descriptor_buffer+0x7b/0x83 [jbd2]
Jul 15 23:51:06 lara [  225.775063]  [<e8852c68>]
jbd2_journal_commit_transaction+0x7eb/0x1163 [jbd2]
Jul 15 23:51:06 lara [  225.775063]  [<e8852c68>]
jbd2_journal_commit_transaction+0x7eb/0x1163 [jbd2]
Jul 15 23:51:06 lara [  225.775077]  [<c0301644>]
__sched_text_start+0x654/0x6cc
Jul 15 23:51:06 lara [  225.775077]  [<c0301644>]
__sched_text_start+0x654/0x6cc
Jul 15 23:51:06 lara [  225.775095]  [<c0122602>] lock_timer_base+0x19/0x35
Jul 15 23:51:06 lara [  225.775095]  [<c0122602>] lock_timer_base+0x19/0x35
Jul 15 23:51:06 lara [  225.775106]  [<c0122662>]
try_to_del_timer_sync+0x44/0x4a
Jul 15 23:51:06 lara [  225.775106]  [<c0122662>]
try_to_del_timer_sync+0x44/0x4a
Jul 15 23:51:06 lara [  225.775115]  [<e88569bc>] kjournald2+0xb0/0x1ef
[jbd2]
Jul 15 23:51:06 lara [  225.775115]  [<e88569bc>] kjournald2+0xb0/0x1ef
[jbd2]
Jul 15 23:51:06 lara [  225.775129]  [<c012ad54>]
autoremove_wake_function+0x0/0x33
Jul 15 23:51:06 lara [  225.775129]  [<c012ad54>]
autoremove_wake_function+0x0/0x33
Jul 15 23:51:06 lara [  225.775139]  [<e885690c>] kjournald2+0x0/0x1ef
[jbd2]
Jul 15 23:51:06 lara [  225.775139]  [<e885690c>] kjournald2+0x0/0x1ef
[jbd2]
Jul 15 23:51:06 lara [  225.775151]  [<c012ac87>] kthread+0x38/0x5d
Jul 15 23:51:06 lara [  225.775151]  [<c012ac87>] kthread+0x38/0x5d
Jul 15 23:51:06 lara [  225.775157]  [<c012ac4f>] kthread+0x0/0x5d
Jul 15 23:51:06 lara [  225.775157]  [<c012ac4f>] kthread+0x0/0x5d
Jul 15 23:51:06 lara [  225.775162]  [<c0104a3f>]
kernel_thread_helper+0x7/0x10
Jul 15 23:51:06 lara [  225.775162]  [<c0104a3f>]
kernel_thread_helper+0x7/0x10
Jul 15 23:51:06 lara [  225.775172]  =======================
Jul 15 23:51:06 lara [  225.775172]  =======================
Jul 15 23:51:06 lara [  225.775175] Code: 8b 51 0c 85 d2 75 20 89 4c 24
04 89 3c 24 83 c9 ff 89 ea 89 f0 e8 a7 f7 ff ff 89 c2 53 9d 89 d0 5f 5d
5b 5e 5f 5d c3 0f b7 41 0a <8b> 04 82 89 41 0c eb e9 55 57 56 53 83 ec
10 89 c1 89 54 24 0c
Jul 15 23:51:06 lara [  225.775175] Code: 8b 51 0c 85 d2 75 20 89 4c 24
04 89 3c 24 83 c9 ff 89 ea 89 f0 e8 a7 f7 ff ff 89 c2 53 9d 89 d0 5f 5d
5b 5e 5f 5d c3 0f b7 41 0a <8b> 04 82 89 41 0c eb e9 55 57 56 53 83 ec
10 89 c1 89 54 24 0c
Jul 15 23:51:06 lara [  225.775235] EIP: [<c015d3b8>]
kmem_cache_alloc+0x4e/0x56 SS:ESP 0068:e69e3ec0
Jul 15 23:51:06 lara [  225.775235] EIP: [<c015d3b8>]
kmem_cache_alloc+0x4e/0x56 SS:ESP 0068:e69e3ec0

.....

Second Oops occurred while doing 'ls'.

( http://194.231.229.228/Oops.txt )
> Thanks,
> Satyam
>
>   

Gabriel


^ permalink raw reply	[flat|nested] 40+ messages in thread

* Re: Oops while modprobing phy fixed module
  2007-07-15 22:19       ` Gabriel C
@ 2007-07-16 12:17         ` Gabriel C
  2007-07-16 15:19           ` Satyam Sharma
  0 siblings, 1 reply; 40+ messages in thread
From: Gabriel C @ 2007-07-16 12:17 UTC (permalink / raw)
  To: Satyam Sharma
  Cc: Linux Kernel Mailing List, Christoph Lameter, htejun, gregkh

Gabriel C wrote:
> Satyam Sharma wrote:
>   
>> On 7/15/07, Gabriel C <nix.or.die@googlemail.com> wrote:
>>   
>>     
>>>>> [...]
>>>>> doing a modprobe fixed the driver segfaults and I get this Oops:
>>>>>
>>>>> Jul 14 13:43:30 lara [  157.953261] BUG: unable to handle kernel paging
>>>>> request at virtual address 43b7a800
>>>>>
>>>>>         
>>>>>           
>>>> 43b7a800 looks suspicious, it could have been a valid kernel
>>>> address, if only for what looks like a single-bit flip.
>>>>
>>>>
>>>>       
>>>>         
>>>>> Jul 14 13:43:30 lara [  157.953273]  printing eip:
>>>>> Jul 14 13:43:30 lara [  157.953278] c015d269
>>>>> Jul 14 13:43:30 lara [  157.953283] *pde = 00000000
>>>>> Jul 14 13:43:30 lara [  157.953293] Oops: 0000 [#1]
>>>>> Jul 14 13:43:30 lara [  157.953301] PREEMPT SMP
>>>>> Jul 14 13:43:30 lara [  157.953309] Modules linked in: fixed pc87360
>>>>> hwmon_vid i2c_isa eeprom adm1021 uhci_hcd sr_mod shpchp pci_hotplug
>>>>> ohci_hcd iTCO_wdt iTCO_vendor_support intel_agp i82860_edac i2c_i801
>>>>> ehci_hcd usbcore edac_mc cdrom agpgart 3c59x mii ext4dev jbd2 capability
>>>>> commoncap loop lp parport_pc parport
>>>>> Jul 14 13:43:30 lara [  157.953386] CPU:    3
>>>>> Jul 14 13:43:30 lara [  157.953387] EIP:    0060:[<c015d269>]    Not
>>>>> tainted VLI
>>>>> Jul 14 13:43:30 lara [  157.953391] EFLAGS: 00210006   (2.6.22-g8d9107e8 #7)
>>>>> Jul 14 13:43:30 lara [  157.953404] EIP is at kmem_cache_zalloc+0x75/0x89
>>>>> Jul 14 13:43:30 lara [  157.953412] eax: 00000000   ebx: 00200282   ecx:
>>>>> c14c8760   edx: 43b7a800
>>>>> Jul 14 13:43:30 lara [  157.953423] esi: e7f75840   edi: c17937b8   ebp:
>>>>> 000000d0   esp: db1ced98
>>>>> Jul 14 13:43:30 lara [  157.953434] ds: 007b   es: 007b   fs: 00d8  gs:
>>>>> 0033  ss: 0068
>>>>> Jul 14 13:43:30 lara [  157.953444] Process modprobe (pid: 2164,
>>>>> ti=db1ce000 task=de78ac20 task.ti=db1ce000)
>>>>> Jul 14 13:43:30 lara [  157.953450] Stack: c014cfd4 c01cf2f7 43b7a800
>>>>> c03ae384 c036d990 db150690 c17937b8 c17937b8
>>>>> Jul 14 13:43:30 lara [  157.953470]        c019752a 00000002 41ed0000
>>>>> e643bb60 c036d990 db150690 c036d990 e643bb60
>>>>> Jul 14 13:43:30 lara [  157.953489]        c01979b1 c0197712 db1cede4
>>>>> 00000000 e643bb60 c036d990 00000000 c03b8e98
>>>>> Jul 14 13:43:30 lara [  157.953513] Call Trace:
>>>>> Jul 14 13:43:30 lara [  157.953518]  [<c014cfd4>] kstrdup+0x27/0x47
>>>>> Jul 14 13:43:30 lara [  157.953530]  [<c01cf2f7>]
>>>>> ida_get_new_above+0xe6/0x166
>>>>> Jul 14 13:43:30 lara [  157.953551]  [<c019752a>] sysfs_new_dirent+0x3d/0xdc
>>>>> Jul 14 13:43:30 lara [  157.953574]  [<c01979b1>] create_dir+0x1e/0x8c
>>>>> Jul 14 13:43:30 lara [  157.953588]  [<c0197712>]
>>>>> sysfs_addrm_finish+0x13/0x1d8
>>>>> Jul 14 13:43:30 lara [  157.953609]  [<c0197a90>]
>>>>> sysfs_create_subdir+0x13/0x16
>>>>> Jul 14 13:43:30 lara [  157.953622]  [<c0198dba>]
>>>>> sysfs_create_group+0x25/0xe7
>>>>> Jul 14 13:43:30 lara [  157.953642]  [<c0233616>] device_pm_add+0x38/0x72
>>>>> Jul 14 13:43:30 lara [  157.953655]  [<c022f61d>] device_add+0x230/0x3d8
>>>>> Jul 14 13:43:30 lara [  157.953678]  [<e8c8f26d>]
>>>>> fixed_mdio_register_device+0x17a/0x20d [fixed]
>>>>> Jul 14 13:43:30 lara [  157.953706]  [<e8c8702c>] fixed_init+0x2c/0x2f
>>>>> [fixed]
>>>>> Jul 14 13:43:30 lara [  157.953718]  [<c01376ab>]
>>>>> sys_init_module+0x1686/0x175a
>>>>> Jul 14 13:43:30 lara [  157.953734]  [<c01601e3>] do_sync_read+0x0/0x10a
>>>>> Jul 14 13:43:30 lara [  157.953797]  [<c0103dee>]
>>>>> sysenter_past_esp+0x5f/0x85
>>>>> Jul 14 13:43:30 lara [  157.953816]  [<c0300000>]
>>>>> packet_setsockopt+0x1c9/0x2f3
>>>>> Jul 14 13:43:30 lara [  157.953835]  =======================
>>>>> Jul 14 13:43:30 lara [  157.953841] Code: 08 00 74 2f 8b 56 08 31 c0 89
>>>>> d1 c1 e9 02 8b 7c 24 08 f3 ab f6 c2 02 74 02 66 ab f6 c2 01 74 01 aa eb
>>>>> 10 0f b7 41 0a 8b 54 24 08 <8b> 04 82 89 41 0c eb c8 8b 44 24 08 83 c4
>>>>> 10 5b 5e 5f 5d c3 57
>>>>>
>>>>>         
>>>>>           
>>>> Thanks to Randy's wonderful decodecode script, we know this is
>>>> mov    (%edx,%eax,4),%eax
>>>>
>>>>
>>>>       
>>>>         
>>>>> Jul 14 13:43:30 lara [  157.953943] EIP: [<c015d269>]
>>>>> kmem_cache_zalloc+0x75/0x89 SS:ESP 0068:db1ced98
>>>>>
>>>>>         
>>>>>           
>>>> I think this is slab_alloc() inlined from SLUB's kmem_cache_zalloc():
>>>>
>>>>       page = s->cpu_slab[smp_processor_id()];
>>>>       if (unlikely(!page || !page->lockless_freelist ||
>>>>                       (node != -1 && page_to_nid(page) != node)))
>>>>
>>>>               object = __slab_alloc(s, gfpflags, node, addr, page);
>>>>
>>>>       else {
>>>>               object = page->lockless_freelist;
>>>>               page->lockless_freelist = object[page->offset]; <=== Oops
>>>>       }
>>>>
>>>> which shouldn't happen unless you have memory errors. I'd suggest
>>>> to check with memtest86+.
>>>>
>>>>       
>>>>         
>>> I did so again ( did a 24h memtest run like 2 weeks ago with no errors )
>>> for 12 hours now an no errors / no ECC errors , so I think my RAM is ok.
>>>
>>> That box is using RDRAM PC800 ECC Rambus.
>>>
>>> Do you want me to try reproduce this Oops with a full debug enabled kernel ?
>>>     
>>>       
>> Yup, it'll be good if you can reproduce the oops -- whether with a debug
>> enabled kernel or not (race conditions could get hidden with debug stuff
>> enabled, so getting oops frequently even without the debug stuff would
>> still be helpful).
>>
>>   
>>     
> Ok here it is again same config but with DEBUG_KERNEL=n
>
>
> ...
>
> Jul 15 23:51:01 lara [  220.800701] Fixed PHY: Registered new driver
> Jul 15 23:51:01 lara [  220.800815] Device 'fixed@100:1' does not have a
> release() function, it is broken and must be fixed.
> Jul 15 23:51:01 lara [  220.800823] WARNING: at drivers/base/core.c:107
> device_release()
> Jul 15 23:51:01 lara [  220.800837]  [<c01cf7c9>] kobject_cleanup+0x3d/0x54
> Jul 15 23:51:01 lara [  220.800853]  [<c01cf7e0>] kobject_release+0x0/0x8
> Jul 15 23:51:01 lara [  220.800863]  [<c01d03b0>] kref_put+0x60/0x6d
> Jul 15 23:51:01 lara [  220.800870]  [<c022f198>] device_del+0x1f3/0x215
> Jul 15 23:51:01 lara [  220.800888]  [<e8c8f2d5>]
> fixed_mdio_register_device+0x1e2/0x20d [fixed]
> Jul 15 23:51:01 lara [  220.800910]  [<e8c8701b>] fixed_init+0x1b/0x2f
> [fixed]
> Jul 15 23:51:01 lara [  220.800920]  [<c01376c3>]
> sys_init_module+0x1686/0x175a
> Jul 15 23:51:01 lara [  220.800934]  [<c0160070>] do_sync_read+0x0/0x10a
> Jul 15 23:51:01 lara [  220.800984]  [<c0103dee>]
> sysenter_past_esp+0x5f/0x85
> Jul 15 23:51:01 lara [  220.801000]  [<c0300000>]
> packet_getsockopt+0x5a/0x103
> Jul 15 23:51:01 lara [  220.801016]  =======================
> Jul 15 23:51:01 lara [  220.801045] BUG: unable to handle kernel paging
> request at virtual address 0f096800
> Jul 15 23:51:01 lara [  220.801053]  printing eip:
> Jul 15 23:51:01 lara [  220.801056] c015d0f1
> Jul 15 23:51:01 lara [  220.801060] *pde = 00000000
> Jul 15 23:51:01 lara [  220.801068] Oops: 0000 [#1]
> Jul 15 23:51:01 lara [  220.801068] Oops: 0000 [#1]
> Jul 15 23:51:01 lara [  220.801071] PREEMPT SMP
> Jul 15 23:51:01 lara [  220.801071] PREEMPT SMP
> Jul 15 23:51:01 lara [  220.801076] Modules linked in: fixed pc87360
> hwmon_vid i2c_isa eeprom adm1021 uhci_hcd sr_mod shpchp pci_hotplug
> ohci_hcd iTCO_wdt iTCO_vendor_support intel_agp i82860_edac i2c_i801
> ehci_hcd usbcore edac_mc cdrom agpgart 3c59x mii ext4dev jbd2 capability
> commoncap loop lp parport_pc parport
> Jul 15 23:51:01 lara [  220.801130] CPU:    1
> Jul 15 23:51:01 lara [  220.801130] CPU:    1
> Jul 15 23:51:01 lara [  220.801133] EIP:    0060:[<c015d0f1>]    Not
> tainted VLI
> Jul 15 23:51:01 lara [  220.801133] EIP:    0060:[<c015d0f1>]    Not
> tainted VLI
> Jul 15 23:51:01 lara [  220.801135] EFLAGS: 00210006   (2.6.22-g8d9107e8
> #11)
> Jul 15 23:51:01 lara [  220.801135] EFLAGS: 00210006   (2.6.22-g8d9107e8
> #11)
> Jul 15 23:51:01 lara [  220.801145] EIP is at kmem_cache_zalloc+0x75/0x89
> Jul 15 23:51:01 lara [  220.801145] EIP is at kmem_cache_zalloc+0x75/0x89
> Jul 15 23:51:01 lara [  220.801151] eax: 00000000   ebx: 00200282   ecx:
> c1381e00   edx: 0f096800
> Jul 15 23:51:01 lara [  220.801151] eax: 00000000   ebx: 00200282   ecx:
> c1381e00   edx: 0f096800
> Jul 15 23:51:01 lara [  220.801159] esi: e7f75840   edi: e7f0f6a8   ebp:
> 000000d0   esp: dbe97d98
> Jul 15 23:51:01 lara [  220.801159] esi: e7f75840   edi: e7f0f6a8   ebp:
> 000000d0   esp: dbe97d98
> Jul 15 23:51:01 lara [  220.801168] ds: 007b   es: 007b   fs: 00d8  gs:
> 0033  ss: 0068
> Jul 15 23:51:01 lara [  220.801168] ds: 007b   es: 007b   fs: 00d8  gs:
> 0033  ss: 0068
> Jul 15 23:51:01 lara [  220.801176] Process modprobe (pid: 2240,
> ti=dbe96000 task=db72ec20 task.ti=dbe96000)
> Jul 15 23:51:01 lara [  220.801176] Process modprobe (pid: 2240,
> ti=dbe96000 task=db72ec20 task.ti=dbe96000)
> Jul 15 23:51:01 lara [  220.801181] Stack: c014ce5c c01cf177 0f096800
> c03ae384 c036d768 db0ae690 e7f0f6a8 e7f0f6a8
> Jul 15 23:51:01 lara [  220.801181] Stack: c014ce5c c01cf177 0f096800
> c03ae384 c036d768 db0ae690 e7f0f6a8 e7f0f6a8
> Jul 15 23:51:01 lara [  220.801201]        c01973aa 00000002 41ed0000
> dc0f08c0 c036d768 db0ae690 c036d768 dc0f08c0
> Jul 15 23:51:01 lara [  220.801201]        c01973aa 00000002 41ed0000
> dc0f08c0 c036d768 db0ae690 c036d768 dc0f08c0
> Jul 15 23:51:01 lara [  220.801233]        c0197831 c0197592 dbe97de4
> 00000000 dc0f08c0 c036d768 00000000 c03b8e98
> Jul 15 23:51:01 lara [  220.801233]        c0197831 c0197592 dbe97de4
> 00000000 dc0f08c0 c036d768 00000000 c03b8e98
> Jul 15 23:51:01 lara [  220.801257] Call Trace:
> Jul 15 23:51:01 lara [  220.801257] Call Trace:
> Jul 15 23:51:01 lara [  220.801261]  [<c014ce5c>] kstrdup+0x27/0x47
> Jul 15 23:51:01 lara [  220.801261]  [<c014ce5c>] kstrdup+0x27/0x47
> Jul 15 23:51:01 lara [  220.801272]  [<c01cf177>]
> ida_get_new_above+0xe6/0x166
> Jul 15 23:51:01 lara [  220.801272]  [<c01cf177>]
> ida_get_new_above+0xe6/0x166
> Jul 15 23:51:01 lara [  220.801288]  [<c01973aa>] sysfs_new_dirent+0x3d/0xdc
> Jul 15 23:51:01 lara [  220.801288]  [<c01973aa>] sysfs_new_dirent+0x3d/0xdc
> Jul 15 23:51:01 lara [  220.801306]  [<c0197831>] create_dir+0x1e/0x8c
> Jul 15 23:51:01 lara [  220.801306]  [<c0197831>] create_dir+0x1e/0x8c
> Jul 15 23:51:01 lara [  220.801316]  [<c0197592>]
> sysfs_addrm_finish+0x13/0x1d8
> Jul 15 23:51:01 lara [  220.801316]  [<c0197592>]
> sysfs_addrm_finish+0x13/0x1d8
> Jul 15 23:51:01 lara [  220.801332]  [<c0197910>]
> sysfs_create_subdir+0x13/0x16
> Jul 15 23:51:01 lara [  220.801332]  [<c0197910>]
> sysfs_create_subdir+0x13/0x16
> Jul 15 23:51:01 lara [  220.801343]  [<c0198c3a>]
> sysfs_create_group+0x25/0xe7
> Jul 15 23:51:01 lara [  220.801343]  [<c0198c3a>]
> sysfs_create_group+0x25/0xe7
> Jul 15 23:51:01 lara [  220.801359]  [<c0233492>] device_pm_add+0x38/0x72
> Jul 15 23:51:01 lara [  220.801359]  [<c0233492>] device_pm_add+0x38/0x72
> Jul 15 23:51:01 lara [  220.801371]  [<c022f499>] device_add+0x230/0x3d8
> Jul 15 23:51:01 lara [  220.801371]  [<c022f499>] device_add+0x230/0x3d8
> Jul 15 23:51:01 lara [  220.801389]  [<e8c8f26d>]
> fixed_mdio_register_device+0x17a/0x20d [fixed]
> Jul 15 23:51:01 lara [  220.801389]  [<e8c8f26d>]
> fixed_mdio_register_device+0x17a/0x20d [fixed]
> Jul 15 23:51:01 lara [  220.801411]  [<e8c8702c>] fixed_init+0x2c/0x2f
> [fixed]
> Jul 15 23:51:01 lara [  220.801411]  [<e8c8702c>] fixed_init+0x2c/0x2f
> [fixed]
> Jul 15 23:51:01 lara [  220.801422]  [<c01376c3>]
> sys_init_module+0x1686/0x175a
> Jul 15 23:51:01 lara [  220.801422]  [<c01376c3>]
> sys_init_module+0x1686/0x175a
> Jul 15 23:51:01 lara [  220.801435]  [<c0160070>] do_sync_read+0x0/0x10a
> Jul 15 23:51:01 lara [  220.801435]  [<c0160070>] do_sync_read+0x0/0x10a
> Jul 15 23:51:01 lara [  220.801478]  [<c0103dee>]
> sysenter_past_esp+0x5f/0x85
> Jul 15 23:51:01 lara [  220.801478]  [<c0103dee>]
> sysenter_past_esp+0x5f/0x85
> Jul 15 23:51:01 lara [  220.801495]  [<c0300000>]
> packet_getsockopt+0x5a/0x103
> Jul 15 23:51:01 lara [  220.801495]  [<c0300000>]
> packet_getsockopt+0x5a/0x103
> Jul 15 23:51:01 lara [  220.801510]  =======================
> Jul 15 23:51:01 lara [  220.801510]  =======================
> Jul 15 23:51:01 lara [  220.801515] Code: 08 00 74 2f 8b 56 08 31 c0 89
> d1 c1 e9 02 8b 7c 24 08 f3 ab f6 c2 02 74 02 66 ab f6 c2 01 74 01 aa eb
> 10 0f b7 41 0a 8b 54 24 08 <8b> 04 82 89 41 0c eb c8 8b 44 24 08 83 c4
> 10 5b 5e 5f 5d c3 57
> Jul 15 23:51:01 lara [  220.801515] Code: 08 00 74 2f 8b 56 08 31 c0 89
> d1 c1 e9 02 8b 7c 24 08 f3 ab f6 c2 02 74 02 66 ab f6 c2 01 74 01 aa eb
> 10 0f b7 41 0a 8b 54 24 08 <8b> 04 82 89 41 0c eb c8 8b 44 24 08 83 c4
> 10 5b 5e 5f 5d c3 57
> Jul 15 23:51:01 lara [  220.801670] EIP: [<c015d0f1>]
> kmem_cache_zalloc+0x75/0x89 SS:ESP 0068:dbe97d98
> Jul 15 23:51:01 lara [  220.801670] EIP: [<c015d0f1>]
> kmem_cache_zalloc+0x75/0x89 SS:ESP 0068:dbe97d98
> Jul 15 23:51:06 lara [  225.774876] BUG: unable to handle kernel paging
> request at virtual address 0f096800
> Jul 15 23:51:06 lara [  225.774884]  printing eip:
> Jul 15 23:51:06 lara [  225.774888] c015d3b8
> Jul 15 23:51:06 lara [  225.774890] *pde = 00000000
> Jul 15 23:51:06 lara [  225.774895] Oops: 0000 [#2]
> Jul 15 23:51:06 lara [  225.774895] Oops: 0000 [#2]
> Jul 15 23:51:06 lara [  225.774898] PREEMPT SMP
> Jul 15 23:51:06 lara [  225.774898] PREEMPT SMP
> Jul 15 23:51:06 lara [  225.774902] Modules linked in: fixed pc87360
> hwmon_vid i2c_isa eeprom adm1021 uhci_hcd sr_mod shpchp pci_hotplug
> ohci_hcd iTCO_wdt iTCO_vendor_support intel_agp i82860_edac i2c_i801
> ehci_hcd usbcore edac_mc cdrom agpgart 3c59x mii ext4dev jbd2 capability
> commoncap loop lp parport_pc parport
> Jul 15 23:51:06 lara [  225.774944] CPU:    1
> Jul 15 23:51:06 lara [  225.774944] CPU:    1
> Jul 15 23:51:06 lara [  225.774945] EIP:    0060:[<c015d3b8>]    Not
> tainted VLI
> Jul 15 23:51:06 lara [  225.774945] EIP:    0060:[<c015d3b8>]    Not
> tainted VLI
> Jul 15 23:51:06 lara [  225.774947] EFLAGS: 00010006   (2.6.22-g8d9107e8
> #11)
> Jul 15 23:51:06 lara [  225.774947] EFLAGS: 00010006   (2.6.22-g8d9107e8
> #11)
> Jul 15 23:51:06 lara [  225.774958] EIP is at kmem_cache_alloc+0x4e/0x56
> Jul 15 23:51:06 lara [  225.774958] EIP is at kmem_cache_alloc+0x4e/0x56
> Jul 15 23:51:06 lara [  225.774962] eax: 00000000   ebx: 00000286   ecx:
> c1381e00   edx: 0f096800
> Jul 15 23:51:06 lara [  225.774962] eax: 00000000   ebx: 00000286   ecx:
> c1381e00   edx: 0f096800
> Jul 15 23:51:06 lara [  225.774967] esi: e7f75840   edi: e88556c4   ebp:
> 00000050   esp: e69e3ec0
> Jul 15 23:51:06 lara [  225.774967] esi: e7f75840   edi: e88556c4   ebp:
> 00000050   esp: e69e3ec0
> Jul 15 23:51:06 lara [  225.774972] ds: 007b   es: 007b   fs: 00d8  gs:
> 0000  ss: 0068
> Jul 15 23:51:06 lara [  225.774972] ds: 007b   es: 007b   fs: 00d8  gs:
> 0000  ss: 0068
> Jul 15 23:51:06 lara [  225.774977] Process kjournald2 (pid: 887,
> ti=e69e2000 task=e7edf840 task.ti=e69e2000)
> Jul 15 23:51:06 lara [  225.774977] Process kjournald2 (pid: 887,
> ti=e69e2000 task=e7edf840 task.ti=e69e2000)
> Jul 15 23:51:06 lara [  225.774981] Stack: 00000000 e7f6ac00 e6d92d20
> e69e2000 e68fa000 00000000 e88556c4 e737e248
> Jul 15 23:51:06 lara [  225.774981] Stack: 00000000 e7f6ac00 e6d92d20
> e69e2000 e68fa000 00000000 e88556c4 e737e248
> Jul 15 23:51:06 lara [  225.774993]        00000003 e4c0a578 e737e240
> 00000000 e6d92d20 00000000 e68fa000 e69e2000
> Jul 15 23:51:06 lara [  225.774993]        00000003 e4c0a578 e737e240
> 00000000 e6d92d20 00000000 e68fa000 e69e2000
> Jul 15 23:51:06 lara [  225.775004]        e88570cc 00001000 0000061b
> 00000000 de20e780 e4c0a578 e69e2000 e8852c68
> Jul 15 23:51:06 lara [  225.775004]        e88570cc 00001000 0000061b
> 00000000 de20e780 e4c0a578 e69e2000 e8852c68
> Jul 15 23:51:06 lara [  225.775016] Call Trace:
> Jul 15 23:51:06 lara [  225.775016] Call Trace:
> Jul 15 23:51:06 lara [  225.775023]  [<e88556c4>]
> jbd2_journal_add_journal_head+0x29/0x189 [jbd2]
> Jul 15 23:51:06 lara [  225.775023]  [<e88556c4>]
> jbd2_journal_add_journal_head+0x29/0x189 [jbd2]
> Jul 15 23:51:06 lara [  225.775046]  [<e88570cc>]
> jbd2_journal_get_descriptor_buffer+0x7b/0x83 [jbd2]
> Jul 15 23:51:06 lara [  225.775046]  [<e88570cc>]
> jbd2_journal_get_descriptor_buffer+0x7b/0x83 [jbd2]
> Jul 15 23:51:06 lara [  225.775063]  [<e8852c68>]
> jbd2_journal_commit_transaction+0x7eb/0x1163 [jbd2]
> Jul 15 23:51:06 lara [  225.775063]  [<e8852c68>]
> jbd2_journal_commit_transaction+0x7eb/0x1163 [jbd2]
> Jul 15 23:51:06 lara [  225.775077]  [<c0301644>]
> __sched_text_start+0x654/0x6cc
> Jul 15 23:51:06 lara [  225.775077]  [<c0301644>]
> __sched_text_start+0x654/0x6cc
> Jul 15 23:51:06 lara [  225.775095]  [<c0122602>] lock_timer_base+0x19/0x35
> Jul 15 23:51:06 lara [  225.775095]  [<c0122602>] lock_timer_base+0x19/0x35
> Jul 15 23:51:06 lara [  225.775106]  [<c0122662>]
> try_to_del_timer_sync+0x44/0x4a
> Jul 15 23:51:06 lara [  225.775106]  [<c0122662>]
> try_to_del_timer_sync+0x44/0x4a
> Jul 15 23:51:06 lara [  225.775115]  [<e88569bc>] kjournald2+0xb0/0x1ef
> [jbd2]
> Jul 15 23:51:06 lara [  225.775115]  [<e88569bc>] kjournald2+0xb0/0x1ef
> [jbd2]
> Jul 15 23:51:06 lara [  225.775129]  [<c012ad54>]
> autoremove_wake_function+0x0/0x33
> Jul 15 23:51:06 lara [  225.775129]  [<c012ad54>]
> autoremove_wake_function+0x0/0x33
> Jul 15 23:51:06 lara [  225.775139]  [<e885690c>] kjournald2+0x0/0x1ef
> [jbd2]
> Jul 15 23:51:06 lara [  225.775139]  [<e885690c>] kjournald2+0x0/0x1ef
> [jbd2]
> Jul 15 23:51:06 lara [  225.775151]  [<c012ac87>] kthread+0x38/0x5d
> Jul 15 23:51:06 lara [  225.775151]  [<c012ac87>] kthread+0x38/0x5d
> Jul 15 23:51:06 lara [  225.775157]  [<c012ac4f>] kthread+0x0/0x5d
> Jul 15 23:51:06 lara [  225.775157]  [<c012ac4f>] kthread+0x0/0x5d
> Jul 15 23:51:06 lara [  225.775162]  [<c0104a3f>]
> kernel_thread_helper+0x7/0x10
> Jul 15 23:51:06 lara [  225.775162]  [<c0104a3f>]
> kernel_thread_helper+0x7/0x10
> Jul 15 23:51:06 lara [  225.775172]  =======================
> Jul 15 23:51:06 lara [  225.775172]  =======================
> Jul 15 23:51:06 lara [  225.775175] Code: 8b 51 0c 85 d2 75 20 89 4c 24
> 04 89 3c 24 83 c9 ff 89 ea 89 f0 e8 a7 f7 ff ff 89 c2 53 9d 89 d0 5f 5d
> 5b 5e 5f 5d c3 0f b7 41 0a <8b> 04 82 89 41 0c eb e9 55 57 56 53 83 ec
> 10 89 c1 89 54 24 0c
> Jul 15 23:51:06 lara [  225.775175] Code: 8b 51 0c 85 d2 75 20 89 4c 24
> 04 89 3c 24 83 c9 ff 89 ea 89 f0 e8 a7 f7 ff ff 89 c2 53 9d 89 d0 5f 5d
> 5b 5e 5f 5d c3 0f b7 41 0a <8b> 04 82 89 41 0c eb e9 55 57 56 53 83 ec
> 10 89 c1 89 54 24 0c
> Jul 15 23:51:06 lara [  225.775235] EIP: [<c015d3b8>]
> kmem_cache_alloc+0x4e/0x56 SS:ESP 0068:e69e3ec0
> Jul 15 23:51:06 lara [  225.775235] EIP: [<c015d3b8>]
> kmem_cache_alloc+0x4e/0x56 SS:ESP 0068:e69e3ec0
>
> .....
>
> Second Oops occurred while doing 'ls'.
>
> ( http://194.231.229.228/Oops.txt )
>   


I cannot reproduce this on plain 2.6.22 so I've started to bisect the
problem.

Here the bisect result:

3007e997de91ec59af39a3f9c91595b31ae6e08b is first bad commit
commit 3007e997de91ec59af39a3f9c91595b31ae6e08b
Author: Tejun Heo <htejun@gmail.com>
Date:   Thu Jun 14 04:27:23 2007 +0900

    sysfs: use sysfs_mutex to protect the sysfs_dirent tree

    As kobj sysfs dentries and inodes are gonna be made reclaimable,
    i_mutex can't be used to protect sysfs_dirent tree.  Use sysfs_mutex
    globally instead.  As the whole tree is protected with sysfs_mutex,
    there is no reason to keep sysfs_rename_sem.  Drop it.

    While at it, add docbook comments to functions which require
    sysfs_mutex locking.

    Signed-off-by: Tejun Heo <htejun@gmail.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

:040000 040000 9deba7887752bc343cc4f5dea2dac70e895ea8b6
75340b6e18c1ada500bb1a2b99ee88fd93ebae8c M      fs

I cannot revert while some conflicts and I don't know how to solve the
conflicts manually.

Git bisect log :

$ git bisect log
git-bisect start
# bad: [8d9107e8c50e1c4ff43c91c8841805833f3ecfb9] Revert "SELinux: use
SECINITSID_NETMSG instead of SECINITSID_UNLABELED for NetLabel"
git-bisect bad 8d9107e8c50e1c4ff43c91c8841805833f3ecfb9
# good: [7dcca30a32aadb0520417521b0c44f42d09fe05c] Linux 2.6.22
git-bisect good 7dcca30a32aadb0520417521b0c44f42d09fe05c
# good: [15028aad00ddf241581fbe74a02ec89cbb28d35d] [TG3]: Update version
to 3.78.
git-bisect good 15028aad00ddf241581fbe74a02ec89cbb28d35d
# bad: [39892da44b21b5362eb848ca424d73a25ccc488f] USB: Digi AccelePort
adapted to new tty buffering
git-bisect bad 39892da44b21b5362eb848ca424d73a25ccc488f
# bad: [dc690d8ef842b464f1c429a376ca16cb8dbee6ae] Merge
master.kernel.org:/pub/scm/linux/kernel/git/gregkh/driver-2.6
git-bisect bad dc690d8ef842b464f1c429a376ca16cb8dbee6ae
# good: [82afee684fe3badaf5ee3fc5b6fda687d558bfb5] Merge
master.kernel.org:/pub/scm/linux/kernel/git/cooloney/blackfin-2.6
git-bisect good 82afee684fe3badaf5ee3fc5b6fda687d558bfb5
# good: [380e6fbb729a55b73d5d8409551474884e0d93fc] sysfs: implement
SYSFS_FLAG_REMOVED flag
git-bisect good 380e6fbb729a55b73d5d8409551474884e0d93fc
# good: [c6e54a578133fb353a50fb44d650768b3b9eb18e] libata: remove irq_on
from ata_bus_reset() and ata_std_postreset()
git-bisect good c6e54a578133fb353a50fb44d650768b3b9eb18e
# good: [28fc582cc9b7fc6ed6a9fbf9565a2b1e56eee880] [MIPS] Sparse: Use
NULL for pointer
git-bisect good 28fc582cc9b7fc6ed6a9fbf9565a2b1e56eee880
# bad: [51225039f3cf9d250596d1344494b293274b9169] sysfs: make directory
dentries and inodes reclaimable
git-bisect bad 51225039f3cf9d250596d1344494b293274b9169
# bad: [3007e997de91ec59af39a3f9c91595b31ae6e08b] sysfs: use sysfs_mutex
to protect the sysfs_dirent tree
git-bisect bad 3007e997de91ec59af39a3f9c91595b31ae6e08b
# good: [608e266a2d4e62c1b98c1c573064b6afe8c06a58] sysfs: make kobj
point to sysfs_dirent instead of dentry
git-bisect good 608e266a2d4e62c1b98c1c573064b6afe8c06a58
# good: [5f9953237f684ea1778adb9d26162da00b282225] sysfs: consolidate
sysfs spinlocks
git-bisect good 5f9953237f684ea1778adb9d26162da00b282225


Gabriel




^ permalink raw reply	[flat|nested] 40+ messages in thread

* Re: Oops while modprobing phy fixed module
  2007-07-16 12:17         ` Gabriel C
@ 2007-07-16 15:19           ` Satyam Sharma
  2007-07-16 15:41             ` Gabriel C
                               ` (2 more replies)
  0 siblings, 3 replies; 40+ messages in thread
From: Satyam Sharma @ 2007-07-16 15:19 UTC (permalink / raw)
  To: Gabriel C; +Cc: Linux Kernel Mailing List, Christoph Lameter, htejun, gregkh

Hi Gabriel,

On 7/16/07, Gabriel C <nix.or.die@googlemail.com> wrote:

> ( http://194.231.229.228/Oops.txt )

> I cannot reproduce this on plain 2.6.22 so I've started to bisect the
> problem.

Could you reproduce this oops at will at the "bad" points? [ Note that
git-bisect isn't quite applicable to bugs that are not 100% reproducible.
The ones that passed as "good" may have passed only because the
bug didn't get triggered on that particular test. Also, a perfectly good
commit could get unnecessarily marked "bad" because the bug
happened to get triggered for it ... so it's not quite trust-worthy for
your case. ]

> Here the bisect result:
>
> 3007e997de91ec59af39a3f9c91595b31ae6e08b is first bad commit
> commit 3007e997de91ec59af39a3f9c91595b31ae6e08b
> Author: Tejun Heo <htejun@gmail.com>
> Date:   Thu Jun 14 04:27:23 2007 +0900
>
>     sysfs: use sysfs_mutex to protect the sysfs_dirent tree
>
>     As kobj sysfs dentries and inodes are gonna be made reclaimable,
>     i_mutex can't be used to protect sysfs_dirent tree.  Use sysfs_mutex
>     globally instead.  As the whole tree is protected with sysfs_mutex,
>     there is no reason to keep sysfs_rename_sem.  Drop it.
>
>     While at it, add docbook comments to functions which require
>     sysfs_mutex locking.
>
>     Signed-off-by: Tejun Heo <htejun@gmail.com>
>     Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
>
> :040000 040000 9deba7887752bc343cc4f5dea2dac70e895ea8b6
> 75340b6e18c1ada500bb1a2b99ee88fd93ebae8c M      fs

Hmm, I don't see why this one could introduce an oops in SLUB,
but it's doing some locking-related stuff, and if it didn't get it right,
the resulting races /could/ lead to some oops. But ... a recently
posted patch (http://lkml.org/lkml/2007/7/16/204) from Akinobu
Mita does point to an oops that was introduced by commit
0c096b507f15397da890051ee73de4266d3941fb that belongs to the
same patchset -- kmem_cache_free(NULL) is illegal and so will oops.
A curious coincidence is that you do see sysfs_new_dirent() in the
stack trace there, but the oops there is in kmem_cache_free(), not
kmem_cache_zalloc() as your dmesg output indicated.

Try that patch anyway, but I don't think that'll solve your problem --
if it was, you would've been seeing "unable to handle kernel NULL
pointer dereference" but what you've been posting is "unable to
handle kernel paging request at virtual address <non_null_ptr>" ...

Gaah.

And the worst thing about it all is that we're not able to trigger the
oops with debugging options -- that backtrace is horrible, so I'd
suggest CONFIG_FRAME_POINTER, at the very least. And also
perhaps DEBUG_INFO while we're at it -- that'll make later
analysis easier, if nothing else.

[ BTW I couldn't even get my compiler to generate the same
"Code:" as we saw in your dmesg (I suspect all the oopsen
have occurred with DEBUG=n, yes?) so my earlier analysis
that suspected SLUB's page->lockless_freelist in slab_alloc()
as the source of that invalid kernel address was actually
based on some human-work rather than simple tools doing
their thing. Gaah, again! ]

I'm thoroughly mystified ... Christoph? Tejun? Someone?

Satyam

^ permalink raw reply	[flat|nested] 40+ messages in thread

* Re: Oops while modprobing phy fixed module
  2007-07-16 15:19           ` Satyam Sharma
@ 2007-07-16 15:41             ` Gabriel C
  2007-07-16 16:18               ` Gabriel C
  2007-07-16 16:54               ` Gabriel C
  2007-07-16 18:23             ` Tejun Heo
  2007-07-23 19:52             ` Oops while modprobing phy fixed module Christoph Lameter
  2 siblings, 2 replies; 40+ messages in thread
From: Gabriel C @ 2007-07-16 15:41 UTC (permalink / raw)
  To: Satyam Sharma
  Cc: Linux Kernel Mailing List, Christoph Lameter, htejun, gregkh

Satyam Sharma wrote:
> Hi Gabriel,
>
> On 7/16/07, Gabriel C <nix.or.die@googlemail.com> wrote:
>
>   
>> ( http://194.231.229.228/Oops.txt )
>>     
>
>   
>> I cannot reproduce this on plain 2.6.22 so I've started to bisect the
>> problem.
>>     
>
> Could you reproduce this oops at will at the "bad" points? [ Note that
> git-bisect isn't quite applicable to bugs that are not 100% reproducible.
> The ones that passed as "good" may have passed only because the
> bug didn't get triggered on that particular test. Also, a perfectly good
> commit could get unnecessarily marked "bad" because the bug
> happened to get triggered for it ... so it's not quite trust-worthy for
> your case. ]
>   

Yes all marked 'bad' ponts have the Oops , at least here.

>   
>> Here the bisect result:
>>
>> 3007e997de91ec59af39a3f9c91595b31ae6e08b is first bad commit
>> commit 3007e997de91ec59af39a3f9c91595b31ae6e08b
>> Author: Tejun Heo <htejun@gmail.com>
>> Date:   Thu Jun 14 04:27:23 2007 +0900
>>
>>     sysfs: use sysfs_mutex to protect the sysfs_dirent tree
>>
>>     As kobj sysfs dentries and inodes are gonna be made reclaimable,
>>     i_mutex can't be used to protect sysfs_dirent tree.  Use sysfs_mutex
>>     globally instead.  As the whole tree is protected with sysfs_mutex,
>>     there is no reason to keep sysfs_rename_sem.  Drop it.
>>
>>     While at it, add docbook comments to functions which require
>>     sysfs_mutex locking.
>>
>>     Signed-off-by: Tejun Heo <htejun@gmail.com>
>>     Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
>>
>> :040000 040000 9deba7887752bc343cc4f5dea2dac70e895ea8b6
>> 75340b6e18c1ada500bb1a2b99ee88fd93ebae8c M      fs
>>     
>
> Hmm, I don't see why this one could introduce an oops in SLUB,
> but it's doing some locking-related stuff, and if it didn't get it right,
> the resulting races /could/ lead to some oops. But ... a recently
> posted patch (http://lkml.org/lkml/2007/7/16/204) from Akinobu
> Mita does point to an oops that was introduced by commit
> 0c096b507f15397da890051ee73de4266d3941fb that belongs to the
> same patchset -- kmem_cache_free(NULL) is illegal and so will oops.
> A curious coincidence is that you do see sysfs_new_dirent() in the
> stack trace there, but the oops there is in kmem_cache_free(), not
> kmem_cache_zalloc() as your dmesg output indicated.
>
> Try that patch anyway, but I don't think that'll solve your problem --
> if it was, you would've been seeing "unable to handle kernel NULL
> pointer dereference" but what you've been posting is "unable to
> handle kernel paging request at virtual address <non_null_ptr>" ...
>   

I will try this patch and look whatever it helps.

> Gaah.
>
> And the worst thing about it all is that we're not able to trigger the
> oops with debugging options -- that backtrace is horrible, so I'd
> suggest CONFIG_FRAME_POINTER, at the very least. And also
> perhaps DEBUG_INFO while we're at it -- that'll make later
> analysis easier, if nothing else.
>   

I will enable DEBUG option and reproduce in a bit.

> [ BTW I couldn't even get my compiler to generate the same
> "Code:" as we saw in your dmesg (I suspect all the oopsen
> have occurred with DEBUG=n, yes?) so my earlier analysis
> that suspected SLUB's page->lockless_freelist in slab_alloc()
> as the source of that invalid kernel address was actually
> based on some human-work rather than simple tools doing
> their thing. Gaah, again! ]
>   

My original report ( also first Oops posted here ) was with DEBUG_KERNEL=y
but as I said I will reproduce in a bit with all the DEBUG options you
suggested.

Shall I enable DEBUG_PAGEALLOC too ?

> I'm thoroughly mystified ... Christoph? Tejun? Someone?
>
> Satyam
>
>   

Gabriel


^ permalink raw reply	[flat|nested] 40+ messages in thread

* Re: Oops while modprobing phy fixed module
  2007-07-16 15:41             ` Gabriel C
@ 2007-07-16 16:18               ` Gabriel C
  2007-07-16 16:54               ` Gabriel C
  1 sibling, 0 replies; 40+ messages in thread
From: Gabriel C @ 2007-07-16 16:18 UTC (permalink / raw)
  To: Satyam Sharma
  Cc: Linux Kernel Mailing List, Christoph Lameter, htejun, gregkh

Gabriel C wrote:
> Satyam Sharma wrote:
>   
>> Hi Gabriel,
>>
>> On 7/16/07, Gabriel C <nix.or.die@googlemail.com> wrote:
>>
>>   
>>     
>>> ( http://194.231.229.228/Oops.txt )
>>>     
>>>       
>>   
>>     
>>> I cannot reproduce this on plain 2.6.22 so I've started to bisect the
>>> problem.
>>>     
>>>       
>> Could you reproduce this oops at will at the "bad" points? [ Note that
>> git-bisect isn't quite applicable to bugs that are not 100% reproducible.
>> The ones that passed as "good" may have passed only because the
>> bug didn't get triggered on that particular test. Also, a perfectly good
>> commit could get unnecessarily marked "bad" because the bug
>> happened to get triggered for it ... so it's not quite trust-worthy for
>> your case. ]
>>   
>>     
>
> Yes all marked 'bad' ponts have the Oops , at least here.
>
>   
>>   
>>     
>>> Here the bisect result:
>>>
>>> 3007e997de91ec59af39a3f9c91595b31ae6e08b is first bad commit
>>> commit 3007e997de91ec59af39a3f9c91595b31ae6e08b
>>> Author: Tejun Heo <htejun@gmail.com>
>>> Date:   Thu Jun 14 04:27:23 2007 +0900
>>>
>>>     sysfs: use sysfs_mutex to protect the sysfs_dirent tree
>>>
>>>     As kobj sysfs dentries and inodes are gonna be made reclaimable,
>>>     i_mutex can't be used to protect sysfs_dirent tree.  Use sysfs_mutex
>>>     globally instead.  As the whole tree is protected with sysfs_mutex,
>>>     there is no reason to keep sysfs_rename_sem.  Drop it.
>>>
>>>     While at it, add docbook comments to functions which require
>>>     sysfs_mutex locking.
>>>
>>>     Signed-off-by: Tejun Heo <htejun@gmail.com>
>>>     Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
>>>
>>> :040000 040000 9deba7887752bc343cc4f5dea2dac70e895ea8b6
>>> 75340b6e18c1ada500bb1a2b99ee88fd93ebae8c M      fs
>>>     
>>>       
>> Hmm, I don't see why this one could introduce an oops in SLUB,
>> but it's doing some locking-related stuff, and if it didn't get it right,
>> the resulting races /could/ lead to some oops. But ... a recently
>> posted patch (http://lkml.org/lkml/2007/7/16/204) from Akinobu
>> Mita does point to an oops that was introduced by commit
>> 0c096b507f15397da890051ee73de4266d3941fb that belongs to the
>> same patchset -- kmem_cache_free(NULL) is illegal and so will oops.
>> A curious coincidence is that you do see sysfs_new_dirent() in the
>> stack trace there, but the oops there is in kmem_cache_free(), not
>> kmem_cache_zalloc() as your dmesg output indicated.
>>
>> Try that patch anyway, but I don't think that'll solve your problem --
>> if it was, you would've been seeing "unable to handle kernel NULL
>> pointer dereference" but what you've been posting is "unable to
>> handle kernel paging request at virtual address <non_null_ptr>" ...
>>   
>>     
>
> I will try this patch and look whatever it helps.
>   

With that patch my box is killed right after fixed modules in modprobed
without any trace :|

I try now without again


Gabriel

^ permalink raw reply	[flat|nested] 40+ messages in thread

* Re: Oops while modprobing phy fixed module
  2007-07-16 15:41             ` Gabriel C
  2007-07-16 16:18               ` Gabriel C
@ 2007-07-16 16:54               ` Gabriel C
  1 sibling, 0 replies; 40+ messages in thread
From: Gabriel C @ 2007-07-16 16:54 UTC (permalink / raw)
  To: Satyam Sharma
  Cc: Linux Kernel Mailing List, Christoph Lameter, htejun, gregkh

Gabriel C wrote:
> Satyam Sharma wrote:
>   
>> Hi Gabriel,
>>
>> On 7/16/07, Gabriel C <nix.or.die@googlemail.com> wrote:
>>
>>   
>>     
>>> ( http://194.231.229.228/Oops.txt )
>>>     
>>>       
>>   
>>     
>>> I cannot reproduce this on plain 2.6.22 so I've started to bisect the
>>> problem.
>>>     
>>>       
>> Could you reproduce this oops at will at the "bad" points? [ Note that
>> git-bisect isn't quite applicable to bugs that are not 100% reproducible.
>> The ones that passed as "good" may have passed only because the
>> bug didn't get triggered on that particular test. Also, a perfectly good
>> commit could get unnecessarily marked "bad" because the bug
>> happened to get triggered for it ... so it's not quite trust-worthy for
>> your case. ]
>>   
>>     
>
> Yes all marked 'bad' ponts have the Oops , at least here.
>
>   
>>   
>>     
>>> Here the bisect result:
>>>
>>> 3007e997de91ec59af39a3f9c91595b31ae6e08b is first bad commit
>>> commit 3007e997de91ec59af39a3f9c91595b31ae6e08b
>>> Author: Tejun Heo <htejun@gmail.com>
>>> Date:   Thu Jun 14 04:27:23 2007 +0900
>>>
>>>     sysfs: use sysfs_mutex to protect the sysfs_dirent tree
>>>
>>>     As kobj sysfs dentries and inodes are gonna be made reclaimable,
>>>     i_mutex can't be used to protect sysfs_dirent tree.  Use sysfs_mutex
>>>     globally instead.  As the whole tree is protected with sysfs_mutex,
>>>     there is no reason to keep sysfs_rename_sem.  Drop it.
>>>
>>>     While at it, add docbook comments to functions which require
>>>     sysfs_mutex locking.
>>>
>>>     Signed-off-by: Tejun Heo <htejun@gmail.com>
>>>     Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
>>>
>>> :040000 040000 9deba7887752bc343cc4f5dea2dac70e895ea8b6
>>> 75340b6e18c1ada500bb1a2b99ee88fd93ebae8c M      fs
>>>     
>>>       
>> Hmm, I don't see why this one could introduce an oops in SLUB,
>> but it's doing some locking-related stuff, and if it didn't get it right,
>> the resulting races /could/ lead to some oops. But ... a recently
>> posted patch (http://lkml.org/lkml/2007/7/16/204) from Akinobu
>> Mita does point to an oops that was introduced by commit
>> 0c096b507f15397da890051ee73de4266d3941fb that belongs to the
>> same patchset -- kmem_cache_free(NULL) is illegal and so will oops.
>> A curious coincidence is that you do see sysfs_new_dirent() in the
>> stack trace there, but the oops there is in kmem_cache_free(), not
>> kmem_cache_zalloc() as your dmesg output indicated.
>>
>> Try that patch anyway, but I don't think that'll solve your problem --
>> if it was, you would've been seeing "unable to handle kernel NULL
>> pointer dereference" but what you've been posting is "unable to
>> handle kernel paging request at virtual address <non_null_ptr>" ...
>>   
>>     
>
> I will try this patch and look whatever it helps.
>
>   
>> Gaah.
>>
>> And the worst thing about it all is that we're not able to trigger the
>> oops with debugging options -- that backtrace is horrible, so I'd
>> suggest CONFIG_FRAME_POINTER, at the very least. And also
>> perhaps DEBUG_INFO while we're at it -- that'll make later
>> analysis easier, if nothing else.
>>   
>>     
>
> I will enable DEBUG option and reproduce in a bit.
>
>   
>> [ BTW I couldn't even get my compiler to generate the same
>> "Code:" as we saw in your dmesg (I suspect all the oopsen
>> have occurred with DEBUG=n, yes?) so my earlier analysis
>> that suspected SLUB's page->lockless_freelist in slab_alloc()
>> as the source of that invalid kernel address was actually
>> based on some human-work rather than simple tools doing
>> their thing. Gaah, again! ]
>>   
>>     
>
> My original report ( also first Oops posted here ) was with DEBUG_KERNEL=y
> but as I said I will reproduce in a bit with all the DEBUG options you
> suggested.
>
> Shall I enable DEBUG_PAGEALLOC too ?
>   

Here it is :

Jul 16 18:24:27 lara [  217.417182] Fixed PHY: Registered new driver
Jul 16 18:24:27 lara [  217.417329] Device 'fixed@100:1' does not have a
release() function, it is broken and must be fixed.
Jul 16 18:24:27 lara [  217.417340] WARNING: at drivers/base/core.c:107
device_release()
Jul 16 18:24:27 lara [  217.417348]  [<c0104e3e>]
show_trace_log_lvl+0x1a/0x2f
Jul 16 18:24:27 lara [  217.417369]  [<c01059d4>] show_trace+0x12/0x14
Jul 16 18:24:27 lara [  217.417378]  [<c0105a46>] dump_stack+0x16/0x18
Jul 16 18:24:27 lara [  217.417387]  [<c0234078>] device_release+0x7c/0x7e
Jul 16 18:24:27 lara [  217.417402]  [<c01d3197>] kobject_cleanup+0x45/0x5f
Jul 16 18:24:27 lara [  217.417412]  [<c01d31bc>] kobject_release+0xb/0xd
Jul 16 18:24:27 lara [  217.417421]  [<c01d3dc7>] kref_put+0x63/0x71
Jul 16 18:24:27 lara [  217.417430]  [<c01d3150>] kobject_put+0x14/0x16
Jul 16 18:24:27 lara [  217.417438]  [<c0234276>] put_device+0x11/0x13
Jul 16 18:24:27 lara [  217.417450]  [<c023492c>]
device_unregister+0x12/0x15
Jul 16 18:24:27 lara [  217.417459]  [<e8c432e8>]
fixed_mdio_register_device+0x1dc/0x208 [fixed]
Jul 16 18:24:27 lara [  217.417473]  [<e8c4601e>] fixed_init+0x1e/0x33
[fixed]
Jul 16 18:24:27 lara [  217.417482]  [<c013834f>]
sys_init_module+0x1589/0x1677
Jul 16 18:24:27 lara [  217.417493]  [<c0103e76>]
sysenter_past_esp+0x5f/0x85
Jul 16 18:24:27 lara [  217.417502]  =======================
Jul 16 18:24:27 lara [  217.417545] BUG: unable to handle kernel paging
request at virtual address 58b7e000
Jul 16 18:24:27 lara [  217.417576]  printing eip:
Jul 16 18:24:27 lara [  217.417602] c015e330
Jul 16 18:24:27 lara [  217.417618] *pde = 00000000
Jul 16 18:24:27 lara [  217.417639] Oops: 0000 [#1]
Jul 16 18:24:27 lara [  217.417653] PREEMPT SMP DEBUG_PAGEALLOC
Jul 16 18:24:27 lara [  217.417719] Modules linked in: fixed pc87360
hwmon_vid i2c_isa eeprom adm1021 uhci_hcd sr_mod shpchp pci_hotplug
ohci_hcd iTCO_wdt iTCO_vendor_support intel_agp i82860_edac i2c_i801
ehci_hcd usbcore edac_mc cdrom agpgart 3c59x mii ext4dev jbd2 capability
commoncap loop lp parport_pc parport
Jul 16 18:24:27 lara [  217.418058] CPU:    3
Jul 16 18:24:27 lara [  217.418061] EIP:    0060:[<c015e330>]    Not
tainted VLI
Jul 16 18:24:27 lara [  217.418066] EFLAGS: 00210006  
(2.6.22-g8f41958b-dirty #26)
Jul 16 18:24:27 lara [  217.418096] EIP is at kmem_cache_zalloc+0x73/0x86
Jul 16 18:24:27 lara [  217.418118] eax: 00000000   ebx: 00200282   ecx:
c13eb160   edx: 58b7e000
Jul 16 18:24:27 lara [  217.418145] esi: e7f75840   edi: e78056f8   ebp:
e1221d78   esp: e1221d58
Jul 16 18:24:27 lara [  217.418162] ds: 007b   es: 007b   fs: 00d8  gs:
0033  ss: 0068
Jul 16 18:24:27 lara [  217.418182] Process modprobe (pid: 2161,
ti=e1220000 task=db6a8c20 task.ti=e1220000)
Jul 16 18:24:27 lara [  217.418203] Stack: c014e0cd c0376a85 58b7e000
000000d0 e773b900 c0376a85 db60bc90 e78056f8
Jul 16 18:24:27 lara [  217.418283]        e1221d9c c01999e0 00000002
41ed0000 e78056f8 c01722a9 c0376a85 db60bc90
Jul 16 18:24:27 lara [  217.418334]        c0376a85 e1221dc4 c0199e9c
df58b888 c0199bd5 e1221db4 e1221de0 df58b888
Jul 16 18:24:27 lara [  217.418461] Call Trace:
Jul 16 18:24:27 lara [  217.418474]  [<c0104e3e>]
show_trace_log_lvl+0x1a/0x2f
Jul 16 18:24:27 lara [  217.418506]  [<c0104eee>]
show_stack_log_lvl+0x9b/0xa3
Jul 16 18:24:27 lara [  217.418545]  [<c01050c4>] show_registers+0x1ce/0x2de
Jul 16 18:24:27 lara [  217.418566]  [<c01052f1>] die+0x11d/0x1f6
Jul 16 18:24:27 lara [  217.418582]  [<c0113757>] do_page_fault+0x425/0x4f2
Jul 16 18:24:27 lara [  217.418614]  [<c030c04a>] error_code+0x72/0x78
Jul 16 18:24:27 lara [  217.418662]  [<c01999e0>] sysfs_new_dirent+0x44/0xe1
Jul 16 18:24:27 lara [  217.418693]  [<c0199e9c>] create_dir+0x21/0x93
Jul 16 18:24:27 lara [  217.418714]  [<c0199f84>]
sysfs_create_subdir+0x16/0x1a
Jul 16 18:24:27 lara [  217.418739]  [<c019b30a>]
sysfs_create_group+0x26/0xe8
Jul 16 18:24:27 lara [  217.418771]  [<c0239573>] dpm_sysfs_add+0x12/0x14
Jul 16 18:24:27 lara [  217.418805]  [<c0238fae>] device_pm_add+0x3b/0x79
Jul 16 18:24:27 lara [  217.418845]  [<c0234bf1>] device_add+0x21e/0x3bc
Jul 16 18:24:27 lara [  217.418872]  [<c0234da1>] device_register+0x12/0x15
Jul 16 18:24:27 lara [  217.418894]  [<e8c43283>]
fixed_mdio_register_device+0x177/0x208 [fixed]
Jul 16 18:24:27 lara [  217.418935]  [<e8c4602f>] fixed_init+0x2f/0x33
[fixed]
Jul 16 18:24:27 lara [  217.418955]  [<c013834f>]
sys_init_module+0x1589/0x1677
Jul 16 18:24:27 lara [  217.419004]  [<c0103e76>]
sysenter_past_esp+0x5f/0x85
Jul 16 18:24:27 lara [  217.419032]  =======================
Jul 16 18:24:27 lara [  217.419045] Code: 83 7d e8 00 74 2d 8b 56 08 31
c0 89 d1 c1 e9 02 8b 7d e8 f3 ab f6 c2 02 74 02 66 ab f6 c2 01 74 01 aa
eb 0f 0f b7 41 0a 8b 55 e8 <8b> 04 82 89 41 0c eb cb 8b 45 e8 83 c4 14
5b 5e 5f 5d c3 55 89
Jul 16 18:24:27 lara [  217.419404] EIP: [<c015e330>]
kmem_cache_zalloc+0x73/0x86 SS:ESP 0068:e1221d58
Jul 16 18:24:27 lara [  217.420974] BUG: unable to handle kernel paging
request at virtual address 58b7e000
Jul 16 18:24:27 lara [  217.420986]  printing eip:
Jul 16 18:24:27 lara [  217.420993] c015e330
Jul 16 18:24:27 lara [  217.420997] *pde = 00000000
Jul 16 18:24:27 lara [  217.421007] Oops: 0000 [#2]
Jul 16 18:24:27 lara [  217.421011] PREEMPT SMP DEBUG_PAGEALLOC
Jul 16 18:24:27 lara [  217.421022] Modules linked in: fixed pc87360
hwmon_vid i2c_isa eeprom adm1021 uhci_hcd sr_mod shpchp pci_hotplug
ohci_hcd iTCO_wdt iTCO_vendor_support intel_agp i82860_edac i2c_i801
ehci_hcd usbcore edac_mc cdrom agpgart 3c59x mii ext4dev jbd2 capability
commoncap loop lp parport_pc parport
Jul 16 18:24:27 lara [  217.421100] CPU:    3
Jul 16 18:24:27 lara [  217.421103] EIP:    0060:[<c015e330>]    Not
tainted VLI
Jul 16 18:24:27 lara [  217.421108] EFLAGS: 00010006  
(2.6.22-g8f41958b-dirty #26)
Jul 16 18:24:27 lara [  217.421129] EIP is at kmem_cache_zalloc+0x73/0x86
Jul 16 18:24:27 lara [  217.421140] eax: 00000000   ebx: 00000286   ecx:
c13eb160   edx: 58b7e000
Jul 16 18:24:27 lara [  217.421150] esi: e7f75840   edi: fffffff4   ebp:
e7311ef4   esp: e7311ed4
Jul 16 18:24:27 lara [  217.421160] ds: 007b   es: 007b   fs: 00d8  gs:
0033  ss: 0068
Jul 16 18:24:27 lara [  217.421168] Process udevd (pid: 610, ti=e7310000
task=e7e87840 task.ti=e7310000)
Jul 16 18:24:27 lara [  217.421176] Stack: 000200d0 00000010 58b7e000
000000d0 00000296 ddce8c20 e7e87840 fffffff4
Jul 16 18:24:27 lara [  217.421195]        e7311f00 c0144748 ddce8c20
e7311f50 c0119854 00000202 00000878 00000878
Jul 16 18:24:27 lara [  217.421215]        e7311fb8 bf9e7958 01200011
c0129500 ddce8c20 ddce8c20 e7e23910 00000878
Jul 16 18:24:27 lara [  217.421238] Call Trace:
Jul 16 18:24:27 lara [  217.421243]  [<c0104e3e>]
show_trace_log_lvl+0x1a/0x2f
Jul 16 18:24:27 lara [  217.421258]  [<c0104eee>]
show_stack_log_lvl+0x9b/0xa3
Jul 16 18:24:27 lara [  217.421269]  [<c01050c4>] show_registers+0x1ce/0x2de
Jul 16 18:24:27 lara [  217.421280]  [<c01052f1>] die+0x11d/0x1f6
Jul 16 18:24:27 lara [  217.421288]  [<c0113757>] do_page_fault+0x425/0x4f2
Jul 16 18:24:27 lara [  217.421298]  [<c030c04a>] error_code+0x72/0x78
Jul 16 18:24:27 lara [  217.421313]  [<c0144748>]
__delayacct_tsk_init+0x15/0x2f
Jul 16 18:24:27 lara [  217.421327]  [<c0119854>] copy_process+0x28b/0x118f
Jul 16 18:24:27 lara [  217.421339]  [<c011a9c3>] do_fork+0x99/0x1bf
Jul 16 18:24:27 lara [  217.421347]  [<c010222f>] sys_clone+0x33/0x39
Jul 16 18:24:27 lara [  217.421355]  [<c0103e76>]
sysenter_past_esp+0x5f/0x85
Jul 16 18:24:27 lara [  217.421365]  =======================
Jul 16 18:24:27 lara [  217.421369] Code: 83 7d e8 00 74 2d 8b 56 08 31
c0 89 d1 c1 e9 02 8b 7d e8 f3 ab f6 c2 02 74 02 66 ab f6 c2 01 74 01 aa
eb 0f 0f b7 41 0a 8b 55 e8 <8b> 04 82 89 41 0c eb cb 8b 45 e8 83 c4 14
5b 5e 5f 5d c3 55 89
Jul 16 18:24:27 lara [  217.421489] EIP: [<c015e330>]
kmem_cache_zalloc+0x73/0x86 SS:ESP 0068:e7311ed4

(gdb) l *kmem_cache_zalloc+0x73
0xc015e330 is in kmem_cache_zalloc (mm/slub.c:1499).
1494
1495                    object = __slab_alloc(s, gfpflags, node, addr,
page);
1496
1497            else {
1498                    object = page->lockless_freelist;
1499                    page->lockless_freelist = object[page->offset];
1500            }
1501            local_irq_restore(flags);
1502            return object;
1503    }


(gdb) l *kmem_cache_zalloc+0x73/0x86
0xc015e2bd is in kmem_cache_zalloc (mm/slub.c:2608).
2603            return s;
2604    }
2605    EXPORT_SYMBOL(kmem_cache_create);
2606
2607    void *kmem_cache_zalloc(struct kmem_cache *s, gfp_t flags)
2608    {
2609            void *x;
2610
2611            x = slab_alloc(s, flags, -1, __builtin_return_address(0));
2612            if (x)

If you want any other gdb things let me know and please let me know what
else I can do to help killing this bug.

Used config there : http://194.231.229.228/2.6.22-g8f41958b/config

>   
>> I'm thoroughly mystified ... Christoph? Tejun? Someone?
>>
>> Satyam
>>
>>   
>>     
>
>   

Gabriel

^ permalink raw reply	[flat|nested] 40+ messages in thread

* Re: Oops while modprobing phy fixed module
  2007-07-15 17:42   ` Gabriel C
  2007-07-15 20:32     ` Gabriel C
  2007-07-15 21:14     ` Satyam Sharma
@ 2007-07-16 17:43     ` Vitaly Bordug
  2 siblings, 0 replies; 40+ messages in thread
From: Vitaly Bordug @ 2007-07-16 17:43 UTC (permalink / raw)
  To: Gabriel C
  Cc: Satyam Sharma, Linux Kernel Mailing List, Jeff Garzik, Christoph Lameter

Folks,

I will have the fix and rework to the fixed phy posted by today/tomorrow.
You'll have to modify platform code a bit

Thanks,
-Vitaly


On Sun, 15 Jul 2007 19:42:44 +0200
Gabriel C <nix.or.die@googlemail.com> wrote:

> Satyam Sharma wrote:
> > Hi Gabriel,
> >   
> 
> Hi Satyam ,
> 
> > On 7/14/07, Gabriel C <nix.or.die@googlemail.com> wrote:
> >   
> >> Hi,
> >>
> >> doing a modprobe fixed the driver segfaults and I get this Oops:
> >>
> >>
> >> Jul 14 13:43:30 lara [  157.952915] Fixed PHY: Registered new driver
> >> Jul 14 13:43:30 lara [  157.953010] Device 'fixed@100:1' does not have a
> >> release() function, it is broken and must be fixed.
> >> Jul 14 13:43:30 lara [  157.953019] WARNING: at drivers/base/core.c:107
> >> device_release()
> >> Jul 14 13:43:30 lara [  157.953032]  [<c01cf949>] kobject_cleanup+0x3d/0x54
> >> Jul 14 13:43:30 lara [  157.953050]  [<c01cf960>] kobject_release+0x0/0x8
> >> Jul 14 13:43:30 lara [  157.953060]  [<c01d0530>] kref_put+0x60/0x6d
> >> Jul 14 13:43:30 lara [  157.953068]  [<c022f31c>] device_del+0x1f3/0x215
> >> Jul 14 13:43:30 lara [  157.953083]  [<e8c8f2d5>]
> >> fixed_mdio_register_device+0x1e2/0x20d [fixed]
> >> Jul 14 13:43:30 lara [  157.953108]  [<e8c8701b>] fixed_init+0x1b/0x2f
> >> [fixed]
> >> Jul 14 13:43:30 lara [  157.953119]  [<c01376ab>]
> >> sys_init_module+0x1686/0x175a
> >> Jul 14 13:43:30 lara [  157.953133]  [<c01601e3>] do_sync_read+0x0/0x10a
> >> Jul 14 13:43:30 lara [  157.953180]  [<c0103dee>]
> >> sysenter_past_esp+0x5f/0x85
> >> Jul 14 13:43:30 lara [  157.953195]  [<c0300000>]
> >> packet_setsockopt+0x1c9/0x2f3
> >> Jul 14 13:43:30 lara [  157.953232]  =======================
> >>     
> >
> > This looks unrelated to the oops itself, but still something that
> > needs to be fixed, of course. [ Maintainers added to Cc: ]
> >
> >   
> >> Jul 14 13:43:30 lara [  157.953261] BUG: unable to handle kernel paging
> >> request at virtual address 43b7a800
> >>     
> >
> > 43b7a800 looks suspicious, it could have been a valid kernel
> > address, if only for what looks like a single-bit flip.
> >
> >   
> >> Jul 14 13:43:30 lara [  157.953273]  printing eip:
> >> Jul 14 13:43:30 lara [  157.953278] c015d269
> >> Jul 14 13:43:30 lara [  157.953283] *pde = 00000000
> >> Jul 14 13:43:30 lara [  157.953293] Oops: 0000 [#1]
> >> Jul 14 13:43:30 lara [  157.953301] PREEMPT SMP
> >> Jul 14 13:43:30 lara [  157.953309] Modules linked in: fixed pc87360
> >> hwmon_vid i2c_isa eeprom adm1021 uhci_hcd sr_mod shpchp pci_hotplug
> >> ohci_hcd iTCO_wdt iTCO_vendor_support intel_agp i82860_edac i2c_i801
> >> ehci_hcd usbcore edac_mc cdrom agpgart 3c59x mii ext4dev jbd2 capability
> >> commoncap loop lp parport_pc parport
> >> Jul 14 13:43:30 lara [  157.953386] CPU:    3
> >> Jul 14 13:43:30 lara [  157.953387] EIP:    0060:[<c015d269>]    Not
> >> tainted VLI
> >> Jul 14 13:43:30 lara [  157.953391] EFLAGS: 00210006   (2.6.22-g8d9107e8 #7)
> >> Jul 14 13:43:30 lara [  157.953404] EIP is at kmem_cache_zalloc+0x75/0x89
> >> Jul 14 13:43:30 lara [  157.953412] eax: 00000000   ebx: 00200282   ecx:
> >> c14c8760   edx: 43b7a800
> >> Jul 14 13:43:30 lara [  157.953423] esi: e7f75840   edi: c17937b8   ebp:
> >> 000000d0   esp: db1ced98
> >> Jul 14 13:43:30 lara [  157.953434] ds: 007b   es: 007b   fs: 00d8  gs:
> >> 0033  ss: 0068
> >> Jul 14 13:43:30 lara [  157.953444] Process modprobe (pid: 2164,
> >> ti=db1ce000 task=de78ac20 task.ti=db1ce000)
> >> Jul 14 13:43:30 lara [  157.953450] Stack: c014cfd4 c01cf2f7 43b7a800
> >> c03ae384 c036d990 db150690 c17937b8 c17937b8
> >> Jul 14 13:43:30 lara [  157.953470]        c019752a 00000002 41ed0000
> >> e643bb60 c036d990 db150690 c036d990 e643bb60
> >> Jul 14 13:43:30 lara [  157.953489]        c01979b1 c0197712 db1cede4
> >> 00000000 e643bb60 c036d990 00000000 c03b8e98
> >> Jul 14 13:43:30 lara [  157.953513] Call Trace:
> >> Jul 14 13:43:30 lara [  157.953518]  [<c014cfd4>] kstrdup+0x27/0x47
> >> Jul 14 13:43:30 lara [  157.953530]  [<c01cf2f7>]
> >> ida_get_new_above+0xe6/0x166
> >> Jul 14 13:43:30 lara [  157.953551]  [<c019752a>] sysfs_new_dirent+0x3d/0xdc
> >> Jul 14 13:43:30 lara [  157.953574]  [<c01979b1>] create_dir+0x1e/0x8c
> >> Jul 14 13:43:30 lara [  157.953588]  [<c0197712>]
> >> sysfs_addrm_finish+0x13/0x1d8
> >> Jul 14 13:43:30 lara [  157.953609]  [<c0197a90>]
> >> sysfs_create_subdir+0x13/0x16
> >> Jul 14 13:43:30 lara [  157.953622]  [<c0198dba>]
> >> sysfs_create_group+0x25/0xe7
> >> Jul 14 13:43:30 lara [  157.953642]  [<c0233616>] device_pm_add+0x38/0x72
> >> Jul 14 13:43:30 lara [  157.953655]  [<c022f61d>] device_add+0x230/0x3d8
> >> Jul 14 13:43:30 lara [  157.953678]  [<e8c8f26d>]
> >> fixed_mdio_register_device+0x17a/0x20d [fixed]
> >> Jul 14 13:43:30 lara [  157.953706]  [<e8c8702c>] fixed_init+0x2c/0x2f
> >> [fixed]
> >> Jul 14 13:43:30 lara [  157.953718]  [<c01376ab>]
> >> sys_init_module+0x1686/0x175a
> >> Jul 14 13:43:30 lara [  157.953734]  [<c01601e3>] do_sync_read+0x0/0x10a
> >> Jul 14 13:43:30 lara [  157.953797]  [<c0103dee>]
> >> sysenter_past_esp+0x5f/0x85
> >> Jul 14 13:43:30 lara [  157.953816]  [<c0300000>]
> >> packet_setsockopt+0x1c9/0x2f3
> >> Jul 14 13:43:30 lara [  157.953835]  =======================
> >> Jul 14 13:43:30 lara [  157.953841] Code: 08 00 74 2f 8b 56 08 31 c0 89
> >> d1 c1 e9 02 8b 7c 24 08 f3 ab f6 c2 02 74 02 66 ab f6 c2 01 74 01 aa eb
> >> 10 0f b7 41 0a 8b 54 24 08 <8b> 04 82 89 41 0c eb c8 8b 44 24 08 83 c4
> >> 10 5b 5e 5f 5d c3 57
> >>     
> >
> > Thanks to Randy's wonderful decodecode script, we know this is
> > mov    (%edx,%eax,4),%eax
> >
> >   
> >> Jul 14 13:43:30 lara [  157.953943] EIP: [<c015d269>]
> >> kmem_cache_zalloc+0x75/0x89 SS:ESP 0068:db1ced98
> >>     
> >
> > I think this is slab_alloc() inlined from SLUB's kmem_cache_zalloc():
> >
> > 	page = s->cpu_slab[smp_processor_id()];
> > 	if (unlikely(!page || !page->lockless_freelist ||
> > 			(node != -1 && page_to_nid(page) != node)))
> >
> > 		object = __slab_alloc(s, gfpflags, node, addr, page);
> >
> > 	else {
> > 		object = page->lockless_freelist;
> > 		page->lockless_freelist = object[page->offset];	<=== Oops
> > 	}
> >
> > which shouldn't happen unless you have memory errors. I'd suggest
> > to check with memtest86+.
> >   
> 
> I did so again ( did a 24h memtest run like 2 weeks ago with no errors )
> for 12 hours now an no errors / no ECC errors , so I think my RAM is ok.
> 
> That box is using RDRAM PC800 ECC Rambus.
> 
> Do you want me to try reproduce this Oops with a full debug enabled kernel ?
> 
> > Satyam
> >
> >   
> 
> Gabriel


-- 
Sincerely, 
Vitaly

^ permalink raw reply	[flat|nested] 40+ messages in thread

* Re: Oops while modprobing phy fixed module
  2007-07-16 15:19           ` Satyam Sharma
  2007-07-16 15:41             ` Gabriel C
@ 2007-07-16 18:23             ` Tejun Heo
  2007-07-16 18:32               ` Gabriel C
  2007-07-23 19:52             ` Oops while modprobing phy fixed module Christoph Lameter
  2 siblings, 1 reply; 40+ messages in thread
From: Tejun Heo @ 2007-07-16 18:23 UTC (permalink / raw)
  To: Satyam Sharma
  Cc: Gabriel C, Linux Kernel Mailing List, Christoph Lameter, gregkh

Satyam Sharma wrote:
> On 7/16/07, Gabriel C <nix.or.die@googlemail.com> wrote:
>> Here the bisect result:
>>
>> 3007e997de91ec59af39a3f9c91595b31ae6e08b is first bad commit
>> commit 3007e997de91ec59af39a3f9c91595b31ae6e08b
>> Author: Tejun Heo <htejun@gmail.com>
>> Date:   Thu Jun 14 04:27:23 2007 +0900
>>
>>     sysfs: use sysfs_mutex to protect the sysfs_dirent tree

Hmmm... Weird.  The patch is supposed to make synchronization more
strict not less unless I've forgotten locking at some place.  Gabriel,
can you please choose SLAB and enable CONFIG_DEBUG_SLAB and
DEBUG_SLAB_LEAK and see whether kernel complains about something?

Thanks.

-- 
tejun

^ permalink raw reply	[flat|nested] 40+ messages in thread

* Re: Oops while modprobing phy fixed module
  2007-07-16 18:23             ` Tejun Heo
@ 2007-07-16 18:32               ` Gabriel C
  2007-07-16 19:11                 ` Gabriel C
  0 siblings, 1 reply; 40+ messages in thread
From: Gabriel C @ 2007-07-16 18:32 UTC (permalink / raw)
  To: Tejun Heo
  Cc: Satyam Sharma, Linux Kernel Mailing List, Christoph Lameter, gregkh

Tejun Heo wrote:
> Satyam Sharma wrote:
>   
>> On 7/16/07, Gabriel C <nix.or.die@googlemail.com> wrote:
>>     
>>> Here the bisect result:
>>>
>>> 3007e997de91ec59af39a3f9c91595b31ae6e08b is first bad commit
>>> commit 3007e997de91ec59af39a3f9c91595b31ae6e08b
>>> Author: Tejun Heo <htejun@gmail.com>
>>> Date:   Thu Jun 14 04:27:23 2007 +0900
>>>
>>>     sysfs: use sysfs_mutex to protect the sysfs_dirent tree
>>>       
>
> Hmmm... Weird.  The patch is supposed to make synchronization more
> strict not less unless I've forgotten locking at some place.  Gabriel,
> can you please choose SLAB and enable CONFIG_DEBUG_SLAB and
> DEBUG_SLAB_LEAK and see whether kernel complains about something?
>   

Sure , give me some minutes.

> Thanks.
>
>   


^ permalink raw reply	[flat|nested] 40+ messages in thread

* Re: Oops while modprobing phy fixed module
  2007-07-16 18:32               ` Gabriel C
@ 2007-07-16 19:11                 ` Gabriel C
  2007-07-16 19:13                   ` Gabriel C
  0 siblings, 1 reply; 40+ messages in thread
From: Gabriel C @ 2007-07-16 19:11 UTC (permalink / raw)
  To: Tejun Heo
  Cc: Satyam Sharma, Linux Kernel Mailing List, Christoph Lameter, gregkh

Gabriel C wrote:
> Tejun Heo wrote:
>   
>> Satyam Sharma wrote:
>>   
>>     
>>> On 7/16/07, Gabriel C <nix.or.die@googlemail.com> wrote:
>>>     
>>>       
>>>> Here the bisect result:
>>>>
>>>> 3007e997de91ec59af39a3f9c91595b31ae6e08b is first bad commit
>>>> commit 3007e997de91ec59af39a3f9c91595b31ae6e08b
>>>> Author: Tejun Heo <htejun@gmail.com>
>>>> Date:   Thu Jun 14 04:27:23 2007 +0900
>>>>
>>>>     sysfs: use sysfs_mutex to protect the sysfs_dirent tree
>>>>       
>>>>         
>> Hmmm... Weird.  The patch is supposed to make synchronization more
>> strict not less unless I've forgotten locking at some place.  Gabriel,
>> can you please choose SLAB and enable CONFIG_DEBUG_SLAB and
>> DEBUG_SLAB_LEAK and see whether kernel complains about something?
>>   
>>     
>
> Sure , give me some minutes.
>   

With DEBUG_SLAB_LEAK set ( and a lot other DEBUG options ) I get on
current HEAD
( abce891a10559343d8ac9f79b46d78afdba63a40 ) an Oops too now , just the
box isn't died.

Config and dmesg can be found there :

http://194.231.229.228/2.6.22-gabce891a/

Here it is :

[  199.766878] Fixed PHY: Registered new driver
[  199.768069] BUG: unable to handle kernel paging request at virtual address 6b6b6b87
[  199.768081]  printing eip:
[  199.768085] c01a0796
[  199.768089] *pde = 00000000
[  199.768098] Oops: 0000 [#1]
[  199.768102] PREEMPT SMP DEBUG_PAGEALLOC
[  199.768111] Modules linked in: fixed pc87360 hwmon_vid i2c_isa eeprom adm1021 uhci_hcd sr_mod shpchp pci_hotplug ohci_hcd iTCO_wdt iTCO_vendor_support intel_agp i82860_edac i2c_i801 ehci_hcd usbcore edac_mc cdrom agpgart 3c59x mii ext4dev jbd2 capability commoncap loop lp parport_pc parport
[  199.768182] CPU:    1
[  199.768184] EIP:    0060:[<c01a0796>]    Not tainted VLI
[  199.768188] EFLAGS: 00210202   (2.6.22-gabce891a #27)
[  199.768205] EIP is at __sysfs_remove_dir+0x20/0x64
[  199.768213] eax: 00000000   ebx: de583e04   ecx: e5113728   edx: 6b6b6b6b
[  199.768222] esi: e5113738   edi: e5113728   ebp: de583e20   esp: de583e04
[  199.768230] ds: 007b   es: 007b   fs: 00d8  gs: 0033  ss: 0068
[  199.768238] Process modprobe (pid: 2067, ti=de582000 task=d79174c0 task.ti=de582000)
[  199.768246] Stack: e5113728 00000000 00000000 00000000 d96bcce0 e5113728 00000000 de583e30 
[  199.768271]        c01a0810 d96bcce0 d96bcbf8 de583e3c c01db3eb d96bcce0 de583e50 c023e338 
[  199.768298]        d96bcbf8 d96bcbf8 e0b3eef0 de583e5c c023e365 d96bcbf0 de583e9c e8c472e8 
[  199.768327] Call Trace:
[  199.768333]  [<c0104f86>] show_trace_log_lvl+0x1a/0x2f
[  199.768348]  [<c0105036>] show_stack_log_lvl+0x9b/0xa3
[  199.768359]  [<c010520c>] show_registers+0x1ce/0x2de
[  199.768370]  [<c010543b>] die+0x11f/0x1f8
[  199.768380]  [<c01137a9>] do_page_fault+0x438/0x507
[  199.768392]  [<c031893a>] error_code+0x72/0x78
[  199.768405]  [<c01a0810>] sysfs_remove_dir+0x2c/0x30
[  199.768415]  [<c01db3eb>] kobject_del+0xf/0x19
[  199.768429]  [<c023e338>] device_del+0x228/0x24a
[  199.768442]  [<c023e365>] device_unregister+0xb/0x15
[  199.768452]  [<e8c472e8>] fixed_mdio_register_device+0x1dc/0x208 [fixed]
[  199.768467]  [<e8c4a01e>] fixed_init+0x1e/0x33 [fixed]
[  199.768479]  [<c013d290>] sys_init_module+0x1589/0x1677
[  199.768493]  [<c0103f16>] sysenter_past_esp+0x5f/0x99
[  199.768503]  =======================
[  199.768508] Code: e7 fd ff ff 83 c4 10 5b 5e 5d c3 55 89 e5 57 56 53 83 ec 10 89 c7 85 c0 74 4d 8d 5d e4 89 c2 89 d8 e8 1f fb ff ff 8d 77 10 eb 27 <8b> 42 1c 25 ff 00 00 00 74 1a 83 f8 02 74 15 8b 42 0c 89 06 c7 
[  199.768675] EIP: [<c01a0796>] __sysfs_remove_dir+0x20/0x64 SS:ESP 0068:de583e04



Gabriel





^ permalink raw reply	[flat|nested] 40+ messages in thread

* Re: Oops while modprobing phy fixed module
  2007-07-16 19:11                 ` Gabriel C
@ 2007-07-16 19:13                   ` Gabriel C
  2007-07-18  5:51                     ` Tejun Heo
  2007-07-18  7:14                     ` [PATCH] sysfs: kill an extra put in sysfs_create_link() failure path Tejun Heo
  0 siblings, 2 replies; 40+ messages in thread
From: Gabriel C @ 2007-07-16 19:13 UTC (permalink / raw)
  To: Tejun Heo
  Cc: Satyam Sharma, Linux Kernel Mailing List, Christoph Lameter, gregkh

Gabriel C wrote:
> Gabriel C wrote:
>   
>> Tejun Heo wrote:
>>   
>>     
>>> Satyam Sharma wrote:
>>>   
>>>     
>>>       
>>>> On 7/16/07, Gabriel C <nix.or.die@googlemail.com> wrote:
>>>>     
>>>>       
>>>>         
>>>>> Here the bisect result:
>>>>>
>>>>> 3007e997de91ec59af39a3f9c91595b31ae6e08b is first bad commit
>>>>> commit 3007e997de91ec59af39a3f9c91595b31ae6e08b
>>>>> Author: Tejun Heo <htejun@gmail.com>
>>>>> Date:   Thu Jun 14 04:27:23 2007 +0900
>>>>>
>>>>>     sysfs: use sysfs_mutex to protect the sysfs_dirent tree
>>>>>       
>>>>>         
>>>>>           
>>> Hmmm... Weird.  The patch is supposed to make synchronization more
>>> strict not less unless I've forgotten locking at some place.  Gabriel,
>>> can you please choose SLAB and enable CONFIG_DEBUG_SLAB and
>>> DEBUG_SLAB_LEAK and see whether kernel complains about something?
>>>   
>>>     
>>>       
>> Sure , give me some minutes.
>>   
>>     
>
> With DEBUG_SLAB_LEAK set ( and a lot other DEBUG options ) I get on
> current HEAD
> ( abce891a10559343d8ac9f79b46d78afdba63a40 ) an Oops too now , just the
> box isn't died.
>
> Config and dmesg can be found there :
>
> http://194.231.229.228/2.6.22-gabce891a/
>
> Here it is :
>
> [  199.766878] Fixed PHY: Registered new driver
> [  199.768069] BUG: unable to handle kernel paging request at virtual address 6b6b6b87
> [  199.768081]  printing eip:
> [  199.768085] c01a0796
> [  199.768089] *pde = 00000000
> [  199.768098] Oops: 0000 [#1]
> [  199.768102] PREEMPT SMP DEBUG_PAGEALLOC
> [  199.768111] Modules linked in: fixed pc87360 hwmon_vid i2c_isa eeprom adm1021 uhci_hcd sr_mod shpchp pci_hotplug ohci_hcd iTCO_wdt iTCO_vendor_support intel_agp i82860_edac i2c_i801 ehci_hcd usbcore edac_mc cdrom agpgart 3c59x mii ext4dev jbd2 capability commoncap loop lp parport_pc parport
> [  199.768182] CPU:    1
> [  199.768184] EIP:    0060:[<c01a0796>]    Not tainted VLI
> [  199.768188] EFLAGS: 00210202   (2.6.22-gabce891a #27)
> [  199.768205] EIP is at __sysfs_remove_dir+0x20/0x64
> [  199.768213] eax: 00000000   ebx: de583e04   ecx: e5113728   edx: 6b6b6b6b
> [  199.768222] esi: e5113738   edi: e5113728   ebp: de583e20   esp: de583e04
> [  199.768230] ds: 007b   es: 007b   fs: 00d8  gs: 0033  ss: 0068
> [  199.768238] Process modprobe (pid: 2067, ti=de582000 task=d79174c0 task.ti=de582000)
> [  199.768246] Stack: e5113728 00000000 00000000 00000000 d96bcce0 e5113728 00000000 de583e30 
> [  199.768271]        c01a0810 d96bcce0 d96bcbf8 de583e3c c01db3eb d96bcce0 de583e50 c023e338 
> [  199.768298]        d96bcbf8 d96bcbf8 e0b3eef0 de583e5c c023e365 d96bcbf0 de583e9c e8c472e8 
> [  199.768327] Call Trace:
> [  199.768333]  [<c0104f86>] show_trace_log_lvl+0x1a/0x2f
> [  199.768348]  [<c0105036>] show_stack_log_lvl+0x9b/0xa3
> [  199.768359]  [<c010520c>] show_registers+0x1ce/0x2de
> [  199.768370]  [<c010543b>] die+0x11f/0x1f8
> [  199.768380]  [<c01137a9>] do_page_fault+0x438/0x507
> [  199.768392]  [<c031893a>] error_code+0x72/0x78
> [  199.768405]  [<c01a0810>] sysfs_remove_dir+0x2c/0x30
> [  199.768415]  [<c01db3eb>] kobject_del+0xf/0x19
> [  199.768429]  [<c023e338>] device_del+0x228/0x24a
> [  199.768442]  [<c023e365>] device_unregister+0xb/0x15
> [  199.768452]  [<e8c472e8>] fixed_mdio_register_device+0x1dc/0x208 [fixed]
> [  199.768467]  [<e8c4a01e>] fixed_init+0x1e/0x33 [fixed]
> [  199.768479]  [<c013d290>] sys_init_module+0x1589/0x1677
> [  199.768493]  [<c0103f16>] sysenter_past_esp+0x5f/0x99
> [  199.768503]  =======================
> [  199.768508] Code: e7 fd ff ff 83 c4 10 5b 5e 5d c3 55 89 e5 57 56 53 83 ec 10 89 c7 85 c0 74 4d 8d 5d e4 89 c2 89 d8 e8 1f fb ff ff 8d 77 10 eb 27 <8b> 42 1c 25 ff 00 00 00 74 1a 83 f8 02 74 15 8b 42 0c 89 06 c7 
> [  199.768675] EIP: [<c01a0796>] __sysfs_remove_dir+0x20/0x64 SS:ESP 0068:de583e04
>
>
>
>   

Damn I forgot to paste the gdb output =)


(gdb) l *__sysfs_remove_dir+0x20
0xc01a0796 is in __sysfs_remove_dir (fs/sysfs/dir.c:855).
850             sysfs_addrm_start(&acxt, dir_sd);
851             pos = &dir_sd->s_children;
852             while (*pos) {
853                     struct sysfs_dirent *sd = *pos;
854
855                     if (sysfs_type(sd) && sysfs_type(sd) != SYSFS_DIR) {
856                             *pos = sd->s_sibling;
857                             sd->s_sibling = NULL;
858                             sysfs_remove_one(&acxt, sd);
859                     } else



^ permalink raw reply	[flat|nested] 40+ messages in thread

* Re: Oops while modprobing phy fixed module
  2007-07-16 19:13                   ` Gabriel C
@ 2007-07-18  5:51                     ` Tejun Heo
  2007-07-23 19:53                       ` Christoph Lameter
  2007-07-18  7:14                     ` [PATCH] sysfs: kill an extra put in sysfs_create_link() failure path Tejun Heo
  1 sibling, 1 reply; 40+ messages in thread
From: Tejun Heo @ 2007-07-18  5:51 UTC (permalink / raw)
  To: Gabriel C
  Cc: Satyam Sharma, Linux Kernel Mailing List, Christoph Lameter, gregkh

Okay, successfully reproduced here.  Will hunt down.

-- 
tejun

^ permalink raw reply	[flat|nested] 40+ messages in thread

* [PATCH] sysfs: kill an extra put in sysfs_create_link() failure path
  2007-07-16 19:13                   ` Gabriel C
  2007-07-18  5:51                     ` Tejun Heo
@ 2007-07-18  7:14                     ` Tejun Heo
  2007-07-18  7:38                       ` [PATCH] sysfs: cosmetic clean up on node creation failure paths Tejun Heo
                                         ` (3 more replies)
  1 sibling, 4 replies; 40+ messages in thread
From: Tejun Heo @ 2007-07-18  7:14 UTC (permalink / raw)
  To: Gabriel C
  Cc: Satyam Sharma, Linux Kernel Mailing List, Christoph Lameter,
	gregkh, miles.lane

There is a subtle bug in sysfs_create_link() failure path.  When
symlink creation fails because there's already a node with the same
name, the target sysfs_dirent is put twice - once by failure path of
sysfs_create_link() and once more when the symlink is released.

Fix it by making only the symlink node responsible for putting
target_sd.

Signed-off-by: Tejun Heo <htejun@gmail.com>
---
Gabriel, Miles, please verify this fixes your problem.  Thanks.

 fs/sysfs/symlink.c |    2 ++
 1 file changed, 2 insertions(+)

diff --git a/fs/sysfs/symlink.c b/fs/sysfs/symlink.c
index 2f86e04..d056e96 100644
--- a/fs/sysfs/symlink.c
+++ b/fs/sysfs/symlink.c
@@ -86,7 +86,9 @@ int sysfs_create_link(struct kobject * kobj, struct kobject * target, const char
 	sd = sysfs_new_dirent(name, S_IFLNK|S_IRWXUGO, SYSFS_KOBJ_LINK);
 	if (!sd)
 		goto out_put;
+
 	sd->s_elem.symlink.target_sd = target_sd;
+	target_sd = NULL;	/* reference is now owned by the symlink */
 
 	sysfs_addrm_start(&acxt, parent_sd);
 
diff --git a/net/core/net-sysfs.c b/net/core/net-sysfs.c

^ permalink raw reply related	[flat|nested] 40+ messages in thread

* [PATCH] sysfs: cosmetic clean up on node creation failure paths
  2007-07-18  7:14                     ` [PATCH] sysfs: kill an extra put in sysfs_create_link() failure path Tejun Heo
@ 2007-07-18  7:38                       ` Tejun Heo
  2007-07-18 11:40                         ` Cornelia Huck
  2007-07-18 11:16                       ` [PATCH] sysfs: kill an extra put in sysfs_create_link() failure path Cornelia Huck
                                         ` (2 subsequent siblings)
  3 siblings, 1 reply; 40+ messages in thread
From: Tejun Heo @ 2007-07-18  7:38 UTC (permalink / raw)
  To: Gabriel C
  Cc: Satyam Sharma, Linux Kernel Mailing List, Christoph Lameter,
	gregkh, miles.lane

Node addition failure is detected by testing return value of
sysfs_addfm_finish() which returns the number of added and removed
nodes.  As the function is called as the last step of addition right
on top of error handling block, the if blocks looked like the
following.

	if (sysfs_addrm_finish(&acxt))
		success handling, usually return;
	/* fall through to error handling */

This is the opposite of usual convention in sysfs and makes the code
difficult to understand.  This patch inverts the test and makes those
blocks look more like others.

Signed-off-by: Tejun Heo <htejun@gmail.com>
---
 fs/sysfs/dir.c     |   12 +++++++-----
 fs/sysfs/file.c    |    9 +++++----
 fs/sysfs/symlink.c |   10 ++++++----
 3 files changed, 18 insertions(+), 13 deletions(-)

Index: work/fs/sysfs/dir.c
===================================================================
--- work.orig/fs/sysfs/dir.c
+++ work/fs/sysfs/dir.c
@@ -698,17 +698,19 @@ static int create_dir(struct kobject *ko
 
 	/* link in */
 	sysfs_addrm_start(&acxt, parent_sd);
+
 	if (!sysfs_find_dirent(parent_sd, name)) {
 		sysfs_add_one(&acxt, sd);
 		sysfs_link_sibling(sd);
 	}
-	if (sysfs_addrm_finish(&acxt)) {
-		*p_sd = sd;
-		return 0;
+
+	if (!sysfs_addrm_finish(&acxt)) {
+		sysfs_put(sd);
+		return -EEXIST;
 	}
 
-	sysfs_put(sd);
-	return -EEXIST;
+	*p_sd = sd;
+	return 0;
 }
 
 int sysfs_create_subdir(struct kobject *kobj, const char *name,
Index: work/fs/sysfs/file.c
===================================================================
--- work.orig/fs/sysfs/file.c
+++ work/fs/sysfs/file.c
@@ -410,11 +410,12 @@ int sysfs_add_file(struct sysfs_dirent *
 		sysfs_link_sibling(sd);
 	}
 
-	if (sysfs_addrm_finish(&acxt))
-		return 0;
+	if (!sysfs_addrm_finish(&acxt)) {
+		sysfs_put(sd);
+		return -EEXIST;
+	}
 
-	sysfs_put(sd);
-	return -EEXIST;
+	return 0;
 }
 
 
Index: work/fs/sysfs/symlink.c
===================================================================
--- work.orig/fs/sysfs/symlink.c
+++ work/fs/sysfs/symlink.c
@@ -97,11 +97,13 @@ int sysfs_create_link(struct kobject * k
 		sysfs_link_sibling(sd);
 	}
 
-	if (sysfs_addrm_finish(&acxt))
-		return 0;
+	if (!sysfs_addrm_finish(&acxt)) {
+		error = -EEXIST;
+		goto out_put;
+	}
+
+	return 0;
 
-	error = -EEXIST;
-	/* fall through */
  out_put:
 	sysfs_put(target_sd);
 	sysfs_put(sd);

^ permalink raw reply	[flat|nested] 40+ messages in thread

* Re: [PATCH] sysfs: kill an extra put in sysfs_create_link() failure path
  2007-07-18  7:14                     ` [PATCH] sysfs: kill an extra put in sysfs_create_link() failure path Tejun Heo
  2007-07-18  7:38                       ` [PATCH] sysfs: cosmetic clean up on node creation failure paths Tejun Heo
@ 2007-07-18 11:16                       ` Cornelia Huck
  2007-07-18 14:29                       ` Miles Lane
  2007-07-18 14:48                       ` Satyam Sharma
  3 siblings, 0 replies; 40+ messages in thread
From: Cornelia Huck @ 2007-07-18 11:16 UTC (permalink / raw)
  To: Tejun Heo
  Cc: Gabriel C, Satyam Sharma, Linux Kernel Mailing List,
	Christoph Lameter, gregkh, miles.lane

On Wed, 18 Jul 2007 16:14:45 +0900,
Tejun Heo <htejun@gmail.com> wrote:

> There is a subtle bug in sysfs_create_link() failure path.  When
> symlink creation fails because there's already a node with the same
> name, the target sysfs_dirent is put twice - once by failure path of
> sysfs_create_link() and once more when the symlink is released.
> 
> Fix it by making only the symlink node responsible for putting
> target_sd.
> 
> Signed-off-by: Tejun Heo <htejun@gmail.com>
> ---
> Gabriel, Miles, please verify this fixes your problem.  Thanks.
> 
>  fs/sysfs/symlink.c |    2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/fs/sysfs/symlink.c b/fs/sysfs/symlink.c
> index 2f86e04..d056e96 100644
> --- a/fs/sysfs/symlink.c
> +++ b/fs/sysfs/symlink.c
> @@ -86,7 +86,9 @@ int sysfs_create_link(struct kobject * kobj, struct kobject * target, const char
>  	sd = sysfs_new_dirent(name, S_IFLNK|S_IRWXUGO, SYSFS_KOBJ_LINK);
>  	if (!sd)
>  		goto out_put;
> +
>  	sd->s_elem.symlink.target_sd = target_sd;
> +	target_sd = NULL;	/* reference is now owned by the symlink */
> 
>  	sysfs_addrm_start(&acxt, parent_sd);
> 

A subtle bug indeed. The patch looks sane to me.

Reviewed-by: Cornelia Huck <cornelia.huck@de.ibm.com>

^ permalink raw reply	[flat|nested] 40+ messages in thread

* Re: [PATCH] sysfs: cosmetic clean up on node creation failure paths
  2007-07-18  7:38                       ` [PATCH] sysfs: cosmetic clean up on node creation failure paths Tejun Heo
@ 2007-07-18 11:40                         ` Cornelia Huck
  0 siblings, 0 replies; 40+ messages in thread
From: Cornelia Huck @ 2007-07-18 11:40 UTC (permalink / raw)
  To: Tejun Heo
  Cc: Gabriel C, Satyam Sharma, Linux Kernel Mailing List,
	Christoph Lameter, gregkh, miles.lane

On Wed, 18 Jul 2007 16:38:11 +0900,
Tejun Heo <htejun@gmail.com> wrote:

> Node addition failure is detected by testing return value of
> sysfs_addfm_finish() which returns the number of added and removed
> nodes.  As the function is called as the last step of addition right
> on top of error handling block, the if blocks looked like the
> following.
> 
> 	if (sysfs_addrm_finish(&acxt))
> 		success handling, usually return;
> 	/* fall through to error handling */
> 
> This is the opposite of usual convention in sysfs and makes the code
> difficult to understand.  This patch inverts the test and makes those
> blocks look more like others.
> 
> Signed-off-by: Tejun Heo <htejun@gmail.com>
> ---
>  fs/sysfs/dir.c     |   12 +++++++-----
>  fs/sysfs/file.c    |    9 +++++----
>  fs/sysfs/symlink.c |   10 ++++++----
>  3 files changed, 18 insertions(+), 13 deletions(-)

Looks nice. One thing, though:

sysfs_hash_and_remove() has the same check, but without a cleanup
section. This should follow the (!sysfs_addrm_finish()) pattern as well
(makes pattern matching easier when reading the code).

^ permalink raw reply	[flat|nested] 40+ messages in thread

* Re: [PATCH] sysfs: kill an extra put in sysfs_create_link() failure path
  2007-07-18  7:14                     ` [PATCH] sysfs: kill an extra put in sysfs_create_link() failure path Tejun Heo
  2007-07-18  7:38                       ` [PATCH] sysfs: cosmetic clean up on node creation failure paths Tejun Heo
  2007-07-18 11:16                       ` [PATCH] sysfs: kill an extra put in sysfs_create_link() failure path Cornelia Huck
@ 2007-07-18 14:29                       ` Miles Lane
  2007-07-18 14:48                       ` Satyam Sharma
  3 siblings, 0 replies; 40+ messages in thread
From: Miles Lane @ 2007-07-18 14:29 UTC (permalink / raw)
  To: Tejun Heo
  Cc: Gabriel C, Satyam Sharma, Linux Kernel Mailing List,
	Christoph Lameter, gregkh

On 7/18/07, Tejun Heo <htejun@gmail.com> wrote:
> There is a subtle bug in sysfs_create_link() failure path.  When
> symlink creation fails because there's already a node with the same
> name, the target sysfs_dirent is put twice - once by failure path of
> sysfs_create_link() and once more when the symlink is released.
>
> Fix it by making only the symlink node responsible for putting
> target_sd.
>
> Signed-off-by: Tejun Heo <htejun@gmail.com>
> ---
> Gabriel, Miles, please verify this fixes your problem.  Thanks.
>
>  fs/sysfs/symlink.c |    2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/fs/sysfs/symlink.c b/fs/sysfs/symlink.c
> index 2f86e04..d056e96 100644
> --- a/fs/sysfs/symlink.c
> +++ b/fs/sysfs/symlink.c
> @@ -86,7 +86,9 @@ int sysfs_create_link(struct kobject * kobj, struct kobject * target, const char
>         sd = sysfs_new_dirent(name, S_IFLNK|S_IRWXUGO, SYSFS_KOBJ_LINK);
>         if (!sd)
>                 goto out_put;
> +
>         sd->s_elem.symlink.target_sd = target_sd;
> +       target_sd = NULL;       /* reference is now owned by the symlink */
>
>         sysfs_addrm_start(&acxt, parent_sd);
>
> diff --git a/net/core/net-sysfs.c b/net/core/net-sysfs.c
>

Great!  I tested with both patches applied to 2.6.22-rc6-mm1 and was
able to remove ipw2200 without triggering the BUG.

Thanks,
            Miles

^ permalink raw reply	[flat|nested] 40+ messages in thread

* Re: [PATCH] sysfs: kill an extra put in sysfs_create_link() failure path
  2007-07-18  7:14                     ` [PATCH] sysfs: kill an extra put in sysfs_create_link() failure path Tejun Heo
                                         ` (2 preceding siblings ...)
  2007-07-18 14:29                       ` Miles Lane
@ 2007-07-18 14:48                       ` Satyam Sharma
  2007-07-18 14:57                         ` Tejun Heo
  3 siblings, 1 reply; 40+ messages in thread
From: Satyam Sharma @ 2007-07-18 14:48 UTC (permalink / raw)
  To: Tejun Heo
  Cc: Gabriel C, Linux Kernel Mailing List, Christoph Lameter, gregkh,
	miles.lane

Hi Tejun,

Thanks for tracking this down and fixing it.

On 7/18/07, Tejun Heo <htejun@gmail.com> wrote:
> There is a subtle bug in sysfs_create_link() failure path.  When
> symlink creation fails because there's already a node with the same
> name, the target sysfs_dirent is put twice - once by failure path of
> sysfs_create_link() and once more when the symlink is released.

The "symlink" is released? But the creation of the symlink is
precisely what failed here ... did it not?

> Fix it by making only the symlink node responsible for putting
> target_sd.

And again ... the changelog sounds confusing indeed, perhaps I'm
not familiar enough with sysfs symlink-related terminology/semantics.
Care to elaborate?

>         sd = sysfs_new_dirent(name, S_IFLNK|S_IRWXUGO, SYSFS_KOBJ_LINK);
>         if (!sd)
>                 goto out_put;
> +
>         sd->s_elem.symlink.target_sd = target_sd;
> +       target_sd = NULL;       /* reference is now owned by the symlink */

Wow. This looks like a very mysterious way to fix a mysterious bug :-)
BTW I just looked over at sysfs_create_link() and ... it looks quite ...
unnecessarily complicated/obfuscated ...

Thanks again,
Satyam

^ permalink raw reply	[flat|nested] 40+ messages in thread

* Re: [PATCH] sysfs: kill an extra put in sysfs_create_link() failure path
  2007-07-18 14:48                       ` Satyam Sharma
@ 2007-07-18 14:57                         ` Tejun Heo
  2007-07-18 15:16                           ` Satyam Sharma
  0 siblings, 1 reply; 40+ messages in thread
From: Tejun Heo @ 2007-07-18 14:57 UTC (permalink / raw)
  To: Satyam Sharma
  Cc: Gabriel C, Linux Kernel Mailing List, Christoph Lameter, gregkh,
	miles.lane

Satyam Sharma wrote:
> On 7/18/07, Tejun Heo <htejun@gmail.com> wrote:
>> There is a subtle bug in sysfs_create_link() failure path.  When
>> symlink creation fails because there's already a node with the same
>> name, the target sysfs_dirent is put twice - once by failure path of
>> sysfs_create_link() and once more when the symlink is released.
> 
> The "symlink" is released? But the creation of the symlink is
> precisely what failed here ... did it not?
> 
>> Fix it by making only the symlink node responsible for putting
>> target_sd.
> 
> And again ... the changelog sounds confusing indeed, perhaps I'm
> not familiar enough with sysfs symlink-related terminology/semantics.
> Care to elaborate?
> 
>>         sd = sysfs_new_dirent(name, S_IFLNK|S_IRWXUGO, SYSFS_KOBJ_LINK);
>>         if (!sd)
>>                 goto out_put;
>> +
>>         sd->s_elem.symlink.target_sd = target_sd;
>> +       target_sd = NULL;       /* reference is now owned by the
>> symlink */
> 
> Wow. This looks like a very mysterious way to fix a mysterious bug :-)
> BTW I just looked over at sysfs_create_link() and ... it looks quite ...
> unnecessarily complicated/obfuscated ...

Well, I dunno.  Probably my taste just sucks.  Please feel free to
submit patches and/or suggest better ideas.

-- 
tejun

^ permalink raw reply	[flat|nested] 40+ messages in thread

* Re: [PATCH] sysfs: kill an extra put in sysfs_create_link() failure path
  2007-07-18 14:57                         ` Tejun Heo
@ 2007-07-18 15:16                           ` Satyam Sharma
  2007-07-18 15:30                             ` Satyam Sharma
  2007-07-18 15:43                             ` Tejun Heo
  0 siblings, 2 replies; 40+ messages in thread
From: Satyam Sharma @ 2007-07-18 15:16 UTC (permalink / raw)
  To: Tejun Heo
  Cc: Gabriel C, Linux Kernel Mailing List, Christoph Lameter, gregkh,
	miles.lane

[-- Attachment #1: Type: text/plain, Size: 2615 bytes --]

Hi,

On 7/18/07, Tejun Heo <htejun@gmail.com> wrote:
> Satyam Sharma wrote:
> > On 7/18/07, Tejun Heo <htejun@gmail.com> wrote:
> >> There is a subtle bug in sysfs_create_link() failure path.  When
> >> symlink creation fails because there's already a node with the same
> >> name, the target sysfs_dirent is put twice - once by failure path of
> >> sysfs_create_link() and once more when the symlink is released.
> >
> > The "symlink" is released? But the creation of the symlink is
> > precisely what failed here ... did it not?
> >
> >> Fix it by making only the symlink node responsible for putting
> >> target_sd.
> >
> > And again ... the changelog sounds confusing indeed, perhaps I'm
> > not familiar enough with sysfs symlink-related terminology/semantics.
> > Care to elaborate?
> >
> >>         sd = sysfs_new_dirent(name, S_IFLNK|S_IRWXUGO, SYSFS_KOBJ_LINK);
> >>         if (!sd)
> >>                 goto out_put;
> >> +
> >>         sd->s_elem.symlink.target_sd = target_sd;
> >> +       target_sd = NULL;       /* reference is now owned by the
> >> symlink */
> >
> > Wow. This looks like a very mysterious way to fix a mysterious bug :-)
> > BTW I just looked over at sysfs_create_link() and ... it looks quite ...
> > unnecessarily complicated/obfuscated ...
>
> Well, I dunno.  Probably my taste just sucks.  Please feel free to
> submit patches and/or suggest better ideas.

OK, for example:

sysfs_find_dirent() -- to check for -EEXIST -- should be called
*before* we create the new dentry for the to-be-created symlink
in the first place. [ It's weird to grab a reference on the target
for ourselves (and in fact even allocate the new dirent for the
to-be-created symlink) and /then/ check for erroneous usage,
and then go about undoing all that we should never have done
at all. ] So this test could, and should, be made earlier, IMHO.

And some similar others ... so attached (sorry, Gmail web
interface) please find an attempt to make sysfs_create_link look
a trifle more like what it should look like, IMHO. The code cleanup
also leads to fewer LOC, smaller kernel image (lesser by 308 bytes),
and even speeding up the no-error common case of this function,
apart from the obvious readability benefits ... it's diffed on _top_ of
your bugfix here, but not the other patch. [ Compile-tested only. ]

BTW this bug was clearly *very* subtle. I spent a couple of hours or
so yesterday night on the same resulting use-after-free (which actually
gets triggered in a completely different codepath, and which is
completely temporally disconnected from its actual cause over here).

Thanks,
Satyam

[-- Attachment #2: sanitize-sysfs_create_link-new.txt --]
[-- Type: text/plain, Size: 2848 bytes --]

Signed-off-by: Satyam Sharma <ssatyam@cse.iitk.ac.in>

---

 fs/sysfs/symlink.c |   74 +++++++++++++++++++++++----------------------------
 1 files changed, 33 insertions(+), 41 deletions(-)

diff --git a/fs/sysfs/symlink.c b/fs/sysfs/symlink.c
index d056e96..bec477d 100644
--- a/fs/sysfs/symlink.c
+++ b/fs/sysfs/symlink.c
@@ -50,65 +50,57 @@ static void fill_object_path(struct sysfs_dirent *sd, char *buffer, int length)
  *	@target:	object we're pointing to.
  *	@name:		name of the symlink.
  */
-int sysfs_create_link(struct kobject * kobj, struct kobject * target, const char * name)
+int sysfs_create_link(struct kobject *kobj, struct kobject *target, const char *name)
 {
-	struct sysfs_dirent *parent_sd = NULL;
-	struct sysfs_dirent *target_sd = NULL;
-	struct sysfs_dirent *sd = NULL;
+	struct sysfs_dirent *parent_sd;
+	struct sysfs_dirent *sd;
 	struct sysfs_addrm_cxt acxt;
-	int error;
+	int error = 0;
 
 	BUG_ON(!name);
 
-	if (!kobj) {
-		if (sysfs_mount && sysfs_mount->mnt_sb)
-			parent_sd = sysfs_mount->mnt_sb->s_root->d_fsdata;
-	} else
+	if (kobj)
 		parent_sd = kobj->sd;
+	else if (sysfs_mount && sysfs_mount->mnt_sb)
+		parent_sd = sysfs_mount->mnt_sb->s_root->d_fsdata;
+	else {
+		error = -EFAULT;
+		goto out;
+	}
 
-	error = -EFAULT;
-	if (!parent_sd)
-		goto out_put;
+	if (sysfs_find_dirent(parent_sd, name)) {
+		error = -EEXIST;
+		goto out;
+	}
+
+	sd = sysfs_new_dirent(name, S_IFLNK | S_IRWXUGO, SYSFS_KOBJ_LINK);
+	if (!sd) {
+		error = -ENOMEM;
+		goto out;
+	}
 
 	/* target->sd can go away beneath us but is protected with
-	 * sysfs_assoc_lock.  Fetch target_sd from it.
+	 * sysfs_assoc_lock. Grab us a reference on it.
 	 */
 	spin_lock(&sysfs_assoc_lock);
 	if (target->sd)
-		target_sd = sysfs_get(target->sd);
+		sd->s_elem.symlink.target_sd = sysfs_get(target->sd);
+	else {
+		spin_unlock(&sysfs_assoc_lock);
+		sysfs_put(sd);
+		error = -ENOENT;
+		goto out;
+	}
 	spin_unlock(&sysfs_assoc_lock);
 
-	error = -ENOENT;
-	if (!target_sd)
-		goto out_put;
-
-	error = -ENOMEM;
-	sd = sysfs_new_dirent(name, S_IFLNK|S_IRWXUGO, SYSFS_KOBJ_LINK);
-	if (!sd)
-		goto out_put;
-
-	sd->s_elem.symlink.target_sd = target_sd;
-	target_sd = NULL;	/* reference is now owned by the symlink */
-
 	sysfs_addrm_start(&acxt, parent_sd);
-
-	if (!sysfs_find_dirent(parent_sd, name)) {
-		sysfs_add_one(&acxt, sd);
-		sysfs_link_sibling(sd);
-	}
-
-	if (sysfs_addrm_finish(&acxt))
-		return 0;
-
-	error = -EEXIST;
-	/* fall through */
- out_put:
-	sysfs_put(target_sd);
-	sysfs_put(sd);
+	sysfs_add_one(&acxt, sd);
+	sysfs_link_sibling(sd);
+	sysfs_addrm_finish(&acxt);
+out:
 	return error;
 }
 
-
 /**
  *	sysfs_remove_link - remove symlink in object's directory.
  *	@kobj:	object we're acting for.

^ permalink raw reply related	[flat|nested] 40+ messages in thread

* Re: [PATCH] sysfs: kill an extra put in sysfs_create_link() failure path
  2007-07-18 15:16                           ` Satyam Sharma
@ 2007-07-18 15:30                             ` Satyam Sharma
  2007-07-18 15:53                               ` Tejun Heo
  2007-07-18 16:20                               ` Tejun Heo
  2007-07-18 15:43                             ` Tejun Heo
  1 sibling, 2 replies; 40+ messages in thread
From: Satyam Sharma @ 2007-07-18 15:30 UTC (permalink / raw)
  To: Tejun Heo
  Cc: Gabriel C, Linux Kernel Mailing List, Christoph Lameter, gregkh,
	miles.lane

On 7/18/07, Satyam Sharma <satyam.sharma@gmail.com> wrote:
> Hi,
>
> On 7/18/07, Tejun Heo <htejun@gmail.com> wrote:
> > Satyam Sharma wrote:
> > > On 7/18/07, Tejun Heo <htejun@gmail.com> wrote:
> > >> There is a subtle bug in sysfs_create_link() failure path.  When
> > >> symlink creation fails because there's already a node with the same
> > >> name, the target sysfs_dirent is put twice - once by failure path of
> > >> sysfs_create_link() and once more when the symlink is released.
> > >
> > > The "symlink" is released? But the creation of the symlink is
> > > precisely what failed here ... did it not?
> > >
> > >> Fix it by making only the symlink node responsible for putting
> > >> target_sd.
> > >
> > > And again ... the changelog sounds confusing indeed, perhaps I'm
> > > not familiar enough with sysfs symlink-related terminology/semantics.
> > > Care to elaborate?

BTW, please do explain this one to me, if you can find the time :-)

> > > Wow. This looks like a very mysterious way to fix a mysterious bug :-)
> > > BTW I just looked over at sysfs_create_link() and ... it looks quite ...
> > > unnecessarily complicated/obfuscated ...
> >
> > Well, I dunno.  Probably my taste just sucks.  Please feel free to
> > submit patches and/or suggest better ideas.
>
> OK, for example:
>
> sysfs_find_dirent() -- to check for -EEXIST -- should be called
> *before* we create the new dentry for the to-be-created symlink
> in the first place. [ It's weird to grab a reference on the target
> for ourselves (and in fact even allocate the new dirent for the
> to-be-created symlink) and /then/ check for erroneous usage,
> and then go about undoing all that we should never have done
> at all. ] So this test could, and should, be made earlier, IMHO.

A trivial nit:

The cleanup ignores the return of sysfs_addrm_finish() -- functions
such as those could and should be void-returning. It doesn't even
need to return an int for success / failure ... I went over it's code,
and it's obvious that the function just never fails!

Returning the count of objects actually added / removed is quite
redundant too, because we return "actx->cnt" unconditionally
from inside it, and the caller can know that anyway, without
even calling it. Also, note that nowhere in the present code is
the return of that function ever being used in that sense (i.e. as
a "count") anyway ...

So: best to just make it void-returning. That's what it is.

Satyam

^ permalink raw reply	[flat|nested] 40+ messages in thread

* Re: [PATCH] sysfs: kill an extra put in sysfs_create_link() failure path
  2007-07-18 15:16                           ` Satyam Sharma
  2007-07-18 15:30                             ` Satyam Sharma
@ 2007-07-18 15:43                             ` Tejun Heo
  2007-07-18 16:06                               ` Satyam Sharma
  1 sibling, 1 reply; 40+ messages in thread
From: Tejun Heo @ 2007-07-18 15:43 UTC (permalink / raw)
  To: Satyam Sharma
  Cc: Gabriel C, Linux Kernel Mailing List, Christoph Lameter, gregkh,
	miles.lane

Satyam Sharma wrote:
>> Well, I dunno.  Probably my taste just sucks.  Please feel free to
>> submit patches and/or suggest better ideas.
> 
> OK, for example:
> 
> sysfs_find_dirent() -- to check for -EEXIST -- should be called
> *before* we create the new dentry for the to-be-created symlink
> in the first place. [ It's weird to grab a reference on the target
> for ourselves (and in fact even allocate the new dirent for the
> to-be-created symlink) and /then/ check for erroneous usage,
> and then go about undoing all that we should never have done
> at all. ] So this test could, and should, be made earlier, IMHO.

Locking.  Otherwise, why would the code look like that in the first place?

> And some similar others ... so attached (sorry, Gmail web
> interface) please find an attempt to make sysfs_create_link look
> a trifle more like what it should look like, IMHO. The code cleanup
> also leads to fewer LOC, smaller kernel image (lesser by 308 bytes),
> and even speeding up the no-error common case of this function,
> apart from the obvious readability benefits ... it's diffed on _top_ of
> your bugfix here, but not the other patch. [ Compile-tested only. ]

Compounded if-else vs. flattened if () with common error path is pretty
much matter of being accustomed to.  I prefer the latter because it
scales better (less nesting and less need for extra intelligence as
error case grows).  As I'm already used to it, it's also easier on my
eyes.  So, unless you have more to offer, I'm not really sure whether
the patch improves the situation noticeably.

-- 
tejun

^ permalink raw reply	[flat|nested] 40+ messages in thread

* Re: [PATCH] sysfs: kill an extra put in sysfs_create_link() failure path
  2007-07-18 15:30                             ` Satyam Sharma
@ 2007-07-18 15:53                               ` Tejun Heo
  2007-07-18 16:08                                 ` Satyam Sharma
  2007-07-18 16:20                               ` Tejun Heo
  1 sibling, 1 reply; 40+ messages in thread
From: Tejun Heo @ 2007-07-18 15:53 UTC (permalink / raw)
  To: Satyam Sharma
  Cc: Gabriel C, Linux Kernel Mailing List, Christoph Lameter, gregkh,
	miles.lane

Satyam Sharma wrote:
>> sysfs_find_dirent() -- to check for -EEXIST -- should be called
>> *before* we create the new dentry for the to-be-created symlink
>> in the first place. [ It's weird to grab a reference on the target
>> for ourselves (and in fact even allocate the new dirent for the
>> to-be-created symlink) and /then/ check for erroneous usage,
>> and then go about undoing all that we should never have done
>> at all. ] So this test could, and should, be made earlier, IMHO.
> 
> A trivial nit:
> 
> The cleanup ignores the return of sysfs_addrm_finish() -- functions
> such as those could and should be void-returning. It doesn't even
> need to return an int for success / failure ... I went over it's code,
> and it's obvious that the function just never fails!
> 
> Returning the count of objects actually added / removed is quite
> redundant too, because we return "actx->cnt" unconditionally
> from inside it, and the caller can know that anyway, without
> even calling it. Also, note that nowhere in the present code is
> the return of that function ever being used in that sense (i.e. as
> a "count") anyway ...
> 
> So: best to just make it void-returning. That's what it is.

Oh well, the function was made that way because that made the conversion
easier when add/rm paths were consolidated using sysfs_addrm_cxt and
friends.  So, if you see the detail as a problem, please submit a patch.
 I dunno whether I would agree with the patch or not without seeing one.

Thanks.

-- 
tejun

^ permalink raw reply	[flat|nested] 40+ messages in thread

* Re: [PATCH] sysfs: kill an extra put in sysfs_create_link() failure path
  2007-07-18 15:43                             ` Tejun Heo
@ 2007-07-18 16:06                               ` Satyam Sharma
  2007-07-18 16:30                                 ` Tejun Heo
  0 siblings, 1 reply; 40+ messages in thread
From: Satyam Sharma @ 2007-07-18 16:06 UTC (permalink / raw)
  To: Tejun Heo
  Cc: Gabriel C, Linux Kernel Mailing List, Christoph Lameter, gregkh,
	miles.lane

On 7/18/07, Tejun Heo <htejun@gmail.com> wrote:
> Satyam Sharma wrote:
> >> Well, I dunno.  Probably my taste just sucks.  Please feel free to
> >> submit patches and/or suggest better ideas.
> >
> > OK, for example:
> >
> > sysfs_find_dirent() -- to check for -EEXIST -- should be called
> > *before* we create the new dentry for the to-be-created symlink
> > in the first place. [ It's weird to grab a reference on the target
> > for ourselves (and in fact even allocate the new dirent for the
> > to-be-created symlink) and /then/ check for erroneous usage,
> > and then go about undoing all that we should never have done
> > at all. ] So this test could, and should, be made earlier, IMHO.
>
> Locking.

Well s/sysfs_find_dirent/sysfs_get_dirent/ then. And then simply put
down the reference later.

> Otherwise, why would the code look like that in the first place?


> > And some similar others ... so attached (sorry, Gmail web
> > interface) please find an attempt to make sysfs_create_link look
> > a trifle more like what it should look like, IMHO. The code cleanup
> > also leads to fewer LOC, smaller kernel image (lesser by 308 bytes),
> > and even speeding up the no-error common case of this function,
> > apart from the obvious readability benefits ... it's diffed on _top_ of
> > your bugfix here, but not the other patch. [ Compile-tested only. ]
>
> Compounded if-else vs. flattened if () with common error path is pretty
> much matter of being accustomed to.  I prefer the latter because it
> scales better (less nesting and less need for extra intelligence as
> error case grows).  As I'm already used to it, it's also easier on my
> eyes.

Umm, I don't see any compounded if-else that I added that wasn't
there already ... if any are, they only make the code clearly obvious
as to what it's doing in the first place. And we've still got a common
error path. Just that the error paths do not *need* to share any other
code than the simple "return error;" precisely because it's been
cleaned up. The existing code was just horrible, IMHO.

> So, unless you have more to offer, I'm not really sure whether
> the patch improves the situation noticeably.

Readability, fewer LOC, 308 lesser bytes in kernel image and
faster for the common case -- not good enough for you?! Oh, well.

Satyam

^ permalink raw reply	[flat|nested] 40+ messages in thread

* Re: [PATCH] sysfs: kill an extra put in sysfs_create_link() failure path
  2007-07-18 15:53                               ` Tejun Heo
@ 2007-07-18 16:08                                 ` Satyam Sharma
  0 siblings, 0 replies; 40+ messages in thread
From: Satyam Sharma @ 2007-07-18 16:08 UTC (permalink / raw)
  To: Tejun Heo
  Cc: Gabriel C, Linux Kernel Mailing List, Christoph Lameter, gregkh,
	miles.lane

On 7/18/07, Tejun Heo <htejun@gmail.com> wrote:
> Satyam Sharma wrote:
> > A trivial nit:
> >
> > The cleanup ignores the return of sysfs_addrm_finish() -- functions
> > such as those could and should be void-returning. It doesn't even
> > need to return an int for success / failure ... I went over it's code,
> > and it's obvious that the function just never fails!
> >
> > Returning the count of objects actually added / removed is quite
> > redundant too, because we return "actx->cnt" unconditionally
> > from inside it, and the caller can know that anyway, without
> > even calling it. Also, note that nowhere in the present code is
> > the return of that function ever being used in that sense (i.e. as
> > a "count") anyway ...
> >
> > So: best to just make it void-returning. That's what it is.
>
> Oh well, the function was made that way because that made the conversion
> easier when add/rm paths were consolidated using sysfs_addrm_cxt and
> friends.  So, if you see the detail as a problem, please submit a patch.
>  I dunno whether I would agree with the patch or not without seeing one.

Ok, I'll submit one then.

Thanks,
Satyam

^ permalink raw reply	[flat|nested] 40+ messages in thread

* Re: [PATCH] sysfs: kill an extra put in sysfs_create_link() failure path
  2007-07-18 15:30                             ` Satyam Sharma
  2007-07-18 15:53                               ` Tejun Heo
@ 2007-07-18 16:20                               ` Tejun Heo
  1 sibling, 0 replies; 40+ messages in thread
From: Tejun Heo @ 2007-07-18 16:20 UTC (permalink / raw)
  To: Satyam Sharma
  Cc: Gabriel C, Linux Kernel Mailing List, Christoph Lameter, gregkh,
	miles.lane

Satyam Sharma wrote:
>> On 7/18/07, Tejun Heo <htejun@gmail.com> wrote:
>> > Satyam Sharma wrote:
>> > > On 7/18/07, Tejun Heo <htejun@gmail.com> wrote:
>> > >> There is a subtle bug in sysfs_create_link() failure path.  When
>> > >> symlink creation fails because there's already a node with the same
>> > >> name, the target sysfs_dirent is put twice - once by failure path of
>> > >> sysfs_create_link() and once more when the symlink is released.
>> > >
>> > > The "symlink" is released? But the creation of the symlink is
>> > > precisely what failed here ... did it not?
>> > >
>> > >> Fix it by making only the symlink node responsible for putting
>> > >> target_sd.
>> > >
>> > > And again ... the changelog sounds confusing indeed, perhaps I'm
>> > > not familiar enough with sysfs symlink-related terminology/semantics.
>> > > Care to elaborate?
> 
> BTW, please do explain this one to me, if you can find the time :-)

A symlink node holds two sd's.  Its parent as all other sd nodes and the
sd the symlink point to.  When the symlink is released (its refcnt goes
to zero), it puts both.  In this bug, the symlink is released twice -
once in the error handling path and one more time when symlink is released.

-- 
tejun

^ permalink raw reply	[flat|nested] 40+ messages in thread

* Re: [PATCH] sysfs: kill an extra put in sysfs_create_link() failure path
  2007-07-18 16:06                               ` Satyam Sharma
@ 2007-07-18 16:30                                 ` Tejun Heo
  2007-07-18 16:36                                   ` Satyam Sharma
  2007-07-18 16:41                                   ` Tejun Heo
  0 siblings, 2 replies; 40+ messages in thread
From: Tejun Heo @ 2007-07-18 16:30 UTC (permalink / raw)
  To: Satyam Sharma
  Cc: Gabriel C, Linux Kernel Mailing List, Christoph Lameter, gregkh,
	miles.lane

Satyam Sharma wrote:
>> > sysfs_find_dirent() -- to check for -EEXIST -- should be called
>> > *before* we create the new dentry for the to-be-created symlink
>> > in the first place. [ It's weird to grab a reference on the target
>> > for ourselves (and in fact even allocate the new dirent for the
>> > to-be-created symlink) and /then/ check for erroneous usage,
>> > and then go about undoing all that we should never have done
>> > at all. ] So this test could, and should, be made earlier, IMHO.
>>
>> Locking.
> 
> Well s/sysfs_find_dirent/sysfs_get_dirent/ then. And then simply put
> down the reference later.

Isn't that the current code?

>> > And some similar others ... so attached (sorry, Gmail web
>> > interface) please find an attempt to make sysfs_create_link look
>> > a trifle more like what it should look like, IMHO. The code cleanup
>> > also leads to fewer LOC, smaller kernel image (lesser by 308 bytes),
>> > and even speeding up the no-error common case of this function,
>> > apart from the obvious readability benefits ... it's diffed on _top_ of
>> > your bugfix here, but not the other patch. [ Compile-tested only. ]
>>
>> Compounded if-else vs. flattened if () with common error path is pretty
>> much matter of being accustomed to.  I prefer the latter because it
>> scales better (less nesting and less need for extra intelligence as
>> error case grows).  As I'm already used to it, it's also easier on my
>> eyes.
> 
> Umm, I don't see any compounded if-else that I added that wasn't
> there already ... if any are, they only make the code clearly obvious
> as to what it's doing in the first place. And we've still got a common
> error path. Just that the error paths do not *need* to share any other
> code than the simple "return error;" precisely because it's been
> cleaned up. The existing code was just horrible, IMHO.

I just don't agree with you and with the locking bug fixed, you'll end
up with more code in the error path.

>> So, unless you have more to offer, I'm not really sure whether
>> the patch improves the situation noticeably.
> 
> Readability, fewer LOC, 308 lesser bytes in kernel image and
> faster for the common case -- not good enough for you?! Oh, well.

Sorry, not agreed on readability.  The rest doesn't really matter too
much and please stop making big deal out of this kind of stuff.  Things
like that do matter but not that much.  Mostly it's matter of getting
used to and there are many alternatives.  Some people like things one
way other people like another.  My taste might not be the best around
here but I don't think it's that awful either.  You may find my taste
disgusting but we all have to deal with such issue, don't we?

-- 
tejun

^ permalink raw reply	[flat|nested] 40+ messages in thread

* Re: [PATCH] sysfs: kill an extra put in sysfs_create_link() failure path
  2007-07-18 16:30                                 ` Tejun Heo
@ 2007-07-18 16:36                                   ` Satyam Sharma
  2007-07-18 16:41                                   ` Tejun Heo
  1 sibling, 0 replies; 40+ messages in thread
From: Satyam Sharma @ 2007-07-18 16:36 UTC (permalink / raw)
  To: Tejun Heo
  Cc: Gabriel C, Linux Kernel Mailing List, Christoph Lameter, gregkh,
	miles.lane

On 7/18/07, Tejun Heo <htejun@gmail.com> wrote:
> Satyam Sharma wrote:
> > Readability, fewer LOC, 308 lesser bytes in kernel image and
> > faster for the common case -- not good enough for you?! Oh, well.
>
> Sorry, not agreed on readability.  The rest doesn't really matter too
> much and please stop making big deal out of this kind of stuff.  Things
> like that do matter but not that much.  Mostly it's matter of getting
> used to and there are many alternatives.  Some people like things one
> way other people like another.  My taste might not be the best around
> here but I don't think it's that awful either.  You may find my taste
> disgusting but we all have to deal with such issue, don't we?

Whoops, I didn't mean to get confrontational, and certainly didn't
make any remarks on your taste/etc personally. Just felt that the
present code looked obfuscated, and submitted a cleanup -- the
other things just turned out to be happy side-effects.

Satyam

^ permalink raw reply	[flat|nested] 40+ messages in thread

* Re: [PATCH] sysfs: kill an extra put in sysfs_create_link() failure path
  2007-07-18 16:30                                 ` Tejun Heo
  2007-07-18 16:36                                   ` Satyam Sharma
@ 2007-07-18 16:41                                   ` Tejun Heo
  2007-07-18 16:49                                     ` Satyam Sharma
  1 sibling, 1 reply; 40+ messages in thread
From: Tejun Heo @ 2007-07-18 16:41 UTC (permalink / raw)
  To: Tejun Heo
  Cc: Satyam Sharma, Gabriel C, Linux Kernel Mailing List,
	Christoph Lameter, gregkh, miles.lane

Tejun Heo wrote:
> Satyam Sharma wrote:
>>>> sysfs_find_dirent() -- to check for -EEXIST -- should be called
>>>> *before* we create the new dentry for the to-be-created symlink
>>>> in the first place. [ It's weird to grab a reference on the target
>>>> for ourselves (and in fact even allocate the new dirent for the
>>>> to-be-created symlink) and /then/ check for erroneous usage,
>>>> and then go about undoing all that we should never have done
>>>> at all. ] So this test could, and should, be made earlier, IMHO.
>>> Locking.
>> Well s/sysfs_find_dirent/sysfs_get_dirent/ then. And then simply put
>> down the reference later.
> 
> Isn't that the current code?

Oops, somehow thought you were talking about allocating it first.
Gee... what difference does using sysfs_get_dirent() make?  Do you think
the following code is correct?

	sd = sysfs_get_dirent("some name");
	if (sd != NULL)
		return -EEXIST;
	lock;
	add_new_node("some name");
	unlock;
	sysfs_put_dirent(sd);

-- 
tejun

^ permalink raw reply	[flat|nested] 40+ messages in thread

* Re: [PATCH] sysfs: kill an extra put in sysfs_create_link() failure path
  2007-07-18 16:41                                   ` Tejun Heo
@ 2007-07-18 16:49                                     ` Satyam Sharma
  2007-07-18 16:59                                       ` Miles Lane
  0 siblings, 1 reply; 40+ messages in thread
From: Satyam Sharma @ 2007-07-18 16:49 UTC (permalink / raw)
  To: Tejun Heo
  Cc: Gabriel C, Linux Kernel Mailing List, Christoph Lameter, gregkh,
	miles.lane

On 7/18/07, Tejun Heo <htejun@gmail.com> wrote:
> Tejun Heo wrote:
> > Satyam Sharma wrote:
> >>>> sysfs_find_dirent() -- to check for -EEXIST -- should be called
> >>>> *before* we create the new dentry for the to-be-created symlink
> >>>> in the first place. [ It's weird to grab a reference on the target
> >>>> for ourselves (and in fact even allocate the new dirent for the
> >>>> to-be-created symlink) and /then/ check for erroneous usage,
> >>>> and then go about undoing all that we should never have done
> >>>> at all. ] So this test could, and should, be made earlier, IMHO.
> >>> Locking.
> >> Well s/sysfs_find_dirent/sysfs_get_dirent/ then. And then simply put
> >> down the reference later.
> >
> > Isn't that the current code?
>
> Oops, somehow thought you were talking about allocating it first.
> Gee... what difference does using sysfs_get_dirent() make?  Do you think
> the following code is correct?
>
>         sd = sysfs_get_dirent("some name");
>         if (sd != NULL)
>                 return -EEXIST;
>         lock;
>         add_new_node("some name");
>         unlock;
>         sysfs_put_dirent(sd);

Nopes, it's not, of course. We'd need the parent's i_mutex as well
as the sysfs_mutex around both the EEXIST check as well as the
actual sysfs_add_one(), which is precisely what sysfs_addrm_start
and finish are, so you're right ... I'll factor this in.

Satyam

^ permalink raw reply	[flat|nested] 40+ messages in thread

* Re: [PATCH] sysfs: kill an extra put in sysfs_create_link() failure path
  2007-07-18 16:49                                     ` Satyam Sharma
@ 2007-07-18 16:59                                       ` Miles Lane
  0 siblings, 0 replies; 40+ messages in thread
From: Miles Lane @ 2007-07-18 16:59 UTC (permalink / raw)
  To: Satyam Sharma
  Cc: Tejun Heo, Gabriel C, Linux Kernel Mailing List,
	Christoph Lameter, gregkh

On 7/18/07, Satyam Sharma <satyam.sharma@gmail.com> wrote:
> On 7/18/07, Tejun Heo <htejun@gmail.com> wrote:
> > Tejun Heo wrote:
> > > Satyam Sharma wrote:
> > >>>> sysfs_find_dirent() -- to check for -EEXIST -- should be called
> > >>>> *before* we create the new dentry for the to-be-created symlink
> > >>>> in the first place. [ It's weird to grab a reference on the target
> > >>>> for ourselves (and in fact even allocate the new dirent for the
> > >>>> to-be-created symlink) and /then/ check for erroneous usage,
> > >>>> and then go about undoing all that we should never have done
> > >>>> at all. ] So this test could, and should, be made earlier, IMHO.
> > >>> Locking.
> > >> Well s/sysfs_find_dirent/sysfs_get_dirent/ then. And then simply put
> > >> down the reference later.
> > >
> > > Isn't that the current code?
> >
> > Oops, somehow thought you were talking about allocating it first.
> > Gee... what difference does using sysfs_get_dirent() make?  Do you think
> > the following code is correct?
> >
> >         sd = sysfs_get_dirent("some name");
> >         if (sd != NULL)
> >                 return -EEXIST;
> >         lock;
> >         add_new_node("some name");
> >         unlock;
> >         sysfs_put_dirent(sd);
>
> Nopes, it's not, of course. We'd need the parent's i_mutex as well
> as the sysfs_mutex around both the EEXIST check as well as the
> actual sysfs_add_one(), which is precisely what sysfs_addrm_start
> and finish are, so you're right ... I'll factor this in.

I tried to apply the patch you sent earlier, but it was rejected
(2.6.22-rc6-mm1 + Tejun's patch + your patch).  When you and
Tejun agree on an additional patch, I'd be happy to test it for you.

       Miles

^ permalink raw reply	[flat|nested] 40+ messages in thread

* Re: Oops while modprobing phy fixed module
  2007-07-16 15:19           ` Satyam Sharma
  2007-07-16 15:41             ` Gabriel C
  2007-07-16 18:23             ` Tejun Heo
@ 2007-07-23 19:52             ` Christoph Lameter
  2 siblings, 0 replies; 40+ messages in thread
From: Christoph Lameter @ 2007-07-23 19:52 UTC (permalink / raw)
  To: Satyam Sharma; +Cc: Gabriel C, Linux Kernel Mailing List, htejun, gregkh

On Mon, 16 Jul 2007 20:49:03 +0530
"Satyam Sharma" <satyam.sharma@gmail.com> wrote:


> I'm thoroughly mystified ... Christoph? Tejun? Someone?

It would help to boot with "slub_debug" to find out what corrupted the
data.

^ permalink raw reply	[flat|nested] 40+ messages in thread

* Re: Oops while modprobing phy fixed module
  2007-07-18  5:51                     ` Tejun Heo
@ 2007-07-23 19:53                       ` Christoph Lameter
  2007-07-24  6:35                         ` Tejun Heo
  0 siblings, 1 reply; 40+ messages in thread
From: Christoph Lameter @ 2007-07-23 19:53 UTC (permalink / raw)
  To: Tejun Heo; +Cc: Gabriel C, Satyam Sharma, Linux Kernel Mailing List, gregkh

On Wed, 18 Jul 2007 14:51:14 +0900
Tejun Heo <htejun@gmail.com> wrote:

> Okay, successfully reproduced here.  Will hunt down.

Next time simply boot with "slub_debug". It will save a lot of time.


^ permalink raw reply	[flat|nested] 40+ messages in thread

* Re: Oops while modprobing phy fixed module
  2007-07-23 19:53                       ` Christoph Lameter
@ 2007-07-24  6:35                         ` Tejun Heo
  0 siblings, 0 replies; 40+ messages in thread
From: Tejun Heo @ 2007-07-24  6:35 UTC (permalink / raw)
  To: Christoph Lameter
  Cc: Gabriel C, Satyam Sharma, Linux Kernel Mailing List, gregkh

Christoph Lameter wrote:
> On Wed, 18 Jul 2007 14:51:14 +0900
> Tejun Heo <htejun@gmail.com> wrote:
> 
>> Okay, successfully reproduced here.  Will hunt down.
> 
> Next time simply boot with "slub_debug". It will save a lot of time.

Alright, thanks.

-- 
tejun

^ permalink raw reply	[flat|nested] 40+ messages in thread

end of thread, other threads:[~2007-07-24  6:35 UTC | newest]

Thread overview: 40+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-07-14 12:18 Oops while modprobing phy fixed module Gabriel C
2007-07-14 12:44 ` Gabriel C
2007-07-15  5:39 ` Satyam Sharma
2007-07-15 17:42   ` Gabriel C
2007-07-15 20:32     ` Gabriel C
2007-07-15 21:14     ` Satyam Sharma
2007-07-15 22:19       ` Gabriel C
2007-07-16 12:17         ` Gabriel C
2007-07-16 15:19           ` Satyam Sharma
2007-07-16 15:41             ` Gabriel C
2007-07-16 16:18               ` Gabriel C
2007-07-16 16:54               ` Gabriel C
2007-07-16 18:23             ` Tejun Heo
2007-07-16 18:32               ` Gabriel C
2007-07-16 19:11                 ` Gabriel C
2007-07-16 19:13                   ` Gabriel C
2007-07-18  5:51                     ` Tejun Heo
2007-07-23 19:53                       ` Christoph Lameter
2007-07-24  6:35                         ` Tejun Heo
2007-07-18  7:14                     ` [PATCH] sysfs: kill an extra put in sysfs_create_link() failure path Tejun Heo
2007-07-18  7:38                       ` [PATCH] sysfs: cosmetic clean up on node creation failure paths Tejun Heo
2007-07-18 11:40                         ` Cornelia Huck
2007-07-18 11:16                       ` [PATCH] sysfs: kill an extra put in sysfs_create_link() failure path Cornelia Huck
2007-07-18 14:29                       ` Miles Lane
2007-07-18 14:48                       ` Satyam Sharma
2007-07-18 14:57                         ` Tejun Heo
2007-07-18 15:16                           ` Satyam Sharma
2007-07-18 15:30                             ` Satyam Sharma
2007-07-18 15:53                               ` Tejun Heo
2007-07-18 16:08                                 ` Satyam Sharma
2007-07-18 16:20                               ` Tejun Heo
2007-07-18 15:43                             ` Tejun Heo
2007-07-18 16:06                               ` Satyam Sharma
2007-07-18 16:30                                 ` Tejun Heo
2007-07-18 16:36                                   ` Satyam Sharma
2007-07-18 16:41                                   ` Tejun Heo
2007-07-18 16:49                                     ` Satyam Sharma
2007-07-18 16:59                                       ` Miles Lane
2007-07-23 19:52             ` Oops while modprobing phy fixed module Christoph Lameter
2007-07-16 17:43     ` Vitaly Bordug

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).