From: Hans Verkuil <hverkuil@xs4all.nl>
To: Sergey Senozhatsky <senozhatsky@chromium.org>
Cc: Hans Verkuil <hans.verkuil@cisco.com>,
Tomasz Figa <tfiga@chromium.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Kyungmin Park <kyungmin.park@samsung.com>,
Marek Szyprowski <m.szyprowski@samsung.com>,
Sakari Ailus <sakari.ailus@iki.fi>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Pawel Osciak <posciak@chromium.org>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCHv4 01/11] videobuf2: add cache management members
Date: Sat, 7 Mar 2020 12:47:00 +0100 [thread overview]
Message-ID: <a4d85ac3-0eea-bc19-cd44-0c8f5b71f6bc@xs4all.nl> (raw)
In-Reply-To: <20200307112838.GA125961@google.com>
On 07/03/2020 12:28, Sergey Senozhatsky wrote:
> On (20/03/07 11:10), Hans Verkuil wrote:
> [..]
>>>>> @@ -564,6 +573,7 @@ struct vb2_queue {
>>>>> unsigned requires_requests:1;
>>>>> unsigned uses_qbuf:1;
>>>>> unsigned uses_requests:1;
>>>>> + unsigned allow_cache_hints:1;
>>>
>>> Shall I use "unsigned int" here instead of "unsigned"?
>>
>> The vb2_queue bitfields are the only places in that header were 'unsigned' is
>> used. I think that that should be fixed in a separate patch. It's nice to have
>> it consistent.
>>
>> Put that patch in the beginning of the series, that way I can pick it up in the
>> next pull request.
>
> OK, done.
>
> For the time being the series has moved to github public repo [0],
> I'll try to run more 'twisty' cases and re-submit once it survives
> beating.
Create those tests in v4l2-compliance: that's where they belong.
You need these tests:
For non-MMAP modes:
1) test that V4L2_BUF_CAP_SUPPORTS_CACHE_HINTS is never set.
If V4L2_BUF_CAP_SUPPORTS_CACHE_HINTS is not set, then:
1) attempting to use V4L2_FLAG_MEMORY_NON_CONSISTENT will clear the flag
upon return (test with both reqbufs and create_bufs).
2) attempting to use V4L2_BUF_FLAG_NO_CACHE_INVALIDATE or V4L2_BUF_FLAG_NO_CACHE_CLEAN
will clear those flags upon return (do we actually do that in the patch series?).
If V4L2_BUF_CAP_SUPPORTS_CACHE_HINTS is set, then:
1) set V4L2_FLAG_MEMORY_NON_CONSISTENT in reqbufs, but clear in create_bufs:
this should fail.
2) clear V4L2_FLAG_MEMORY_NON_CONSISTENT in reqbufs, but set in create_bufs:
this should fail.
3) set V4L2_FLAG_MEMORY_NON_CONSISTENT in both reqbufs and create_bufs: this should
work.
4) clear V4L2_FLAG_MEMORY_NON_CONSISTENT in both reqbufs and create_bufs: this should
work.
5) you can use V4L2_BUF_FLAG_NO_CACHE_INVALIDATE or V4L2_BUF_FLAG_NO_CACHE_CLEAN
without these flags being cleared in v4l2_buffer.
All these tests can be done in testReqBufs().
Regards,
Hans
>
> [0] https://github.com/sergey-senozhatsky/v4l2-mmap-cache-flags
>
> -ss
>
next prev parent reply other threads:[~2020-03-07 11:47 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-02 4:12 [PATCHv4 00/11] Implement V4L2_BUF_FLAG_NO_CACHE_* flags Sergey Senozhatsky
2020-03-02 4:12 ` [PATCHv4 01/11] videobuf2: add cache management members Sergey Senozhatsky
2020-03-06 13:57 ` Hans Verkuil
2020-03-07 5:22 ` Sergey Senozhatsky
2020-03-07 9:46 ` Sergey Senozhatsky
2020-03-07 10:10 ` Hans Verkuil
2020-03-07 11:28 ` Sergey Senozhatsky
2020-03-07 11:47 ` Hans Verkuil [this message]
2020-03-09 3:27 ` Sergey Senozhatsky
2020-03-09 3:44 ` Sergey Senozhatsky
2020-03-09 7:21 ` Hans Verkuil
2020-03-09 7:25 ` Sergey Senozhatsky
2020-03-09 7:28 ` Hans Verkuil
2020-03-09 7:39 ` Sergey Senozhatsky
2020-03-09 8:58 ` Tomasz Figa
2020-03-09 9:08 ` Sergey Senozhatsky
2020-03-09 9:17 ` Tomasz Figa
2020-03-09 9:29 ` Sergey Senozhatsky
2020-03-09 4:03 ` Sergey Senozhatsky
2020-03-09 7:17 ` Hans Verkuil
2020-03-02 4:12 ` [PATCHv4 02/11] videobuf2: handle V4L2 buffer cache flags Sergey Senozhatsky
2020-03-02 4:12 ` [PATCHv4 03/11] videobuf2: add V4L2_FLAG_MEMORY_NON_CONSISTENT flag Sergey Senozhatsky
2020-03-06 13:58 ` Hans Verkuil
2020-03-07 8:09 ` Sergey Senozhatsky
2020-03-02 4:12 ` [PATCHv4 04/11] videobuf2: add queue memory consistency parameter Sergey Senozhatsky
2020-03-06 14:04 ` Hans Verkuil
2020-03-07 7:50 ` Sergey Senozhatsky
2020-03-07 10:03 ` Hans Verkuil
2020-03-20 13:46 ` Dafna Hirschfeld
2020-03-24 2:39 ` Sergey Senozhatsky
2020-03-24 10:17 ` Ezequiel Garcia
2020-03-25 2:32 ` Sergey Senozhatsky
2020-03-27 11:27 ` Tomasz Figa
2020-03-02 4:12 ` [PATCHv4 05/11] videobuf2: handle V4L2_FLAG_MEMORY_NON_CONSISTENT flag Sergey Senozhatsky
2020-03-06 15:30 ` Hans Verkuil
2020-03-07 7:51 ` Sergey Senozhatsky
2020-03-07 9:38 ` Sergey Senozhatsky
2020-03-07 10:05 ` Hans Verkuil
2020-03-02 4:12 ` [PATCHv4 06/11] videobuf2: factor out planes prepare/finish functions Sergey Senozhatsky
2020-03-02 4:12 ` [PATCHv4 07/11] videobuf2: do not sync caches when we are allowed not to Sergey Senozhatsky
2020-03-02 4:12 ` [PATCHv4 08/11] videobuf2: check ->synced flag in prepare() and finish() Sergey Senozhatsky
2020-03-02 4:12 ` [PATCHv4 09/11] videobuf2: add begin/end cpu_access callbacks to dma-contig Sergey Senozhatsky
2020-03-02 4:12 ` [PATCHv4 10/11] videobuf2: add begin/end cpu_access callbacks to dma-sg Sergey Senozhatsky
2020-03-06 14:04 ` Hans Verkuil
2020-03-07 5:26 ` Sergey Senozhatsky
2020-03-07 9:32 ` Hans Verkuil
2020-03-07 9:39 ` Sergey Senozhatsky
2020-03-02 4:12 ` [PATCHv4 11/11] videobuf2: don't test db_attach in dma-contig prepare and finish Sergey Senozhatsky
2020-03-06 14:18 ` [PATCHv4 00/11] Implement V4L2_BUF_FLAG_NO_CACHE_* flags Hans Verkuil
2020-03-07 8:08 ` Sergey Senozhatsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a4d85ac3-0eea-bc19-cd44-0c8f5b71f6bc@xs4all.nl \
--to=hverkuil@xs4all.nl \
--cc=hans.verkuil@cisco.com \
--cc=kyungmin.park@samsung.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=mchehab@kernel.org \
--cc=posciak@chromium.org \
--cc=sakari.ailus@iki.fi \
--cc=senozhatsky@chromium.org \
--cc=tfiga@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).