linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Reinette Chatre <reinette.chatre@intel.com>
To: Maciej Wieczor-Retman <maciej.wieczor-retman@intel.com>,
	<shuah@kernel.org>, <fenghua.yu@intel.com>
Cc: <linux-kselftest@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<ilpo.jarvinen@linux.intel.com>
Subject: Re: [PATCH v6 3/5] selftests/resctrl: Split validate_resctrl_feature_request()
Date: Tue, 20 Feb 2024 12:51:38 -0800	[thread overview]
Message-ID: <a52637c3-e5b8-4ef8-b9de-8c7dd0868630@intel.com> (raw)
In-Reply-To: <79e6f4b5bcaf36214289e56167fe1d5657cb4d24.1708072203.git.maciej.wieczor-retman@intel.com>

Hi Maciej,

On 2/16/2024 12:35 AM, Maciej Wieczor-Retman wrote:
> validate_resctrl_feature_request() is used to test both if a resource is
> present in the info directory, and if a passed monitoring feature is
> present in the mon_features file.
> 
> Refactor validate_resctrl_feature_request() into two smaller functions
> that each accomplish one check to give feature checking more
> granularity:
> - Resource directory presence in the /sys/fs/resctrl/info directory.
> - Feature name presence in the /sys/fs/resctrl/info/<RESOURCE>/mon_features
>   file.
> 
> Signed-off-by: Maciej Wieczor-Retman <maciej.wieczor-retman@intel.com>
> ---

Thank you.

Reviewed-by: Reinette Chatre <reinette.chatre@intel.com>

Reinette

  parent reply	other threads:[~2024-02-20 20:51 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-16  8:34 [PATCH v6 0/5] selftests/resctrl: Add non-contiguous CBMs in Intel CAT selftest Maciej Wieczor-Retman
2024-02-16  8:34 ` [PATCH v6 1/5] selftests/resctrl: Add test groups and name L3 CAT test L3_CAT Maciej Wieczor-Retman
2024-02-16  8:35 ` [PATCH v6 2/5] selftests/resctrl: Add a helper for the non-contiguous test Maciej Wieczor-Retman
2024-02-16  8:35 ` [PATCH v6 3/5] selftests/resctrl: Split validate_resctrl_feature_request() Maciej Wieczor-Retman
2024-02-16 11:21   ` Ilpo Järvinen
2024-02-20 20:51   ` Reinette Chatre [this message]
2024-02-16  8:35 ` [PATCH v6 4/5] selftests/resctrl: Add resource_info_file_exists() Maciej Wieczor-Retman
2024-02-20 20:52   ` Reinette Chatre
2024-02-16  8:35 ` [PATCH v6 5/5] selftests/resctrl: Add non-contiguous CBMs CAT test Maciej Wieczor-Retman
2024-02-16 11:22   ` Ilpo Järvinen
2024-02-22 17:05 ` [PATCH v6 0/5] selftests/resctrl: Add non-contiguous CBMs in Intel CAT selftest Reinette Chatre
2024-02-23 22:29   ` Shuah Khan
2024-02-23 22:33     ` Reinette Chatre
2024-02-23 22:37       ` Shuah Khan
2024-02-23 23:11         ` Reinette Chatre
2024-02-26  9:28         ` Maciej Wieczor-Retman
2024-02-28  0:08           ` Shuah Khan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a52637c3-e5b8-4ef8-b9de-8c7dd0868630@intel.com \
    --to=reinette.chatre@intel.com \
    --cc=fenghua.yu@intel.com \
    --cc=ilpo.jarvinen@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=maciej.wieczor-retman@intel.com \
    --cc=shuah@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).