From: Reinette Chatre <reinette.chatre@intel.com>
To: Shuah Khan <skhan@linuxfoundation.org>,
Maciej Wieczor-Retman <maciej.wieczor-retman@intel.com>,
<shuah@kernel.org>, <fenghua.yu@intel.com>
Cc: <linux-kselftest@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<ilpo.jarvinen@linux.intel.com>
Subject: Re: [PATCH v6 0/5] selftests/resctrl: Add non-contiguous CBMs in Intel CAT selftest
Date: Fri, 23 Feb 2024 15:11:11 -0800 [thread overview]
Message-ID: <ede77e93-1bb3-4bd1-9c05-919ad512c2e1@intel.com> (raw)
In-Reply-To: <a8f1f104-c5c1-400c-873e-99b01cde1d88@linuxfoundation.org>
Hi Shuah,
On 2/23/2024 2:37 PM, Shuah Khan wrote:
> Okay ran a quick test. Why does this test leave "/sys/fs/resctrl"
> mounted when it exits. Can we fix this to unmount before the test
> exits?
This is unexpected. The test should unmount resctrl when done and I am
not able to reproduce what you are seeing. I tried with resctrl mounted
as well as unmounted before the test run. Could you please send the output
of your test run to hopefully get some hints about what is going on?
Please do note that resctrl does create the mountpoint upon initialization
so you should always, for example, see /sys/fs/resctrl, but it should
be unmounted and empty after a test run.
Below is what I am seeing when I try latest from kselftest next and mount
resctrl before the test. I see same state after test if I do not mount
resctrl before the test run.
../dev/linux$ mount | grep resctrl #not mounted
../dev/linux$ ls /sys/fs/resctrl/ #empty
../dev/linux$ sudo mount -t resctrl resctrl /sys/fs/resctrl/
../dev/linux$ ls /sys/fs/resctrl/ #has contents after mount
cpus cpus_list info mode mon_data mon_groups schemata size tasks
../dev/linux$ mount | grep resctrl #shows as mounted
resctrl on /sys/fs/resctrl type resctrl (rw,relatime)
../dev/linux$ git show -s --pretty='format:%h (\"%s\")'
ae638551ab64 (\"selftests/resctrl: Add non-contiguous CBMs CAT test\")
../dev/linux$ make -C tools/testing/selftests/resctrl/
make: Entering directory '/home/reinette/dev/linux/tools/testing/selftests/resctrl'
gcc -g -Wall -O2 -D_FORTIFY_SOURCE=2 -D_GNU_SOURCE -isystem /home/reinette/dev/linux/tools/testing/selftests/../../../usr/include resctrl_tests.c cache.c cat_test.c cmt_test.c fill_buf.c mba_test.c mbm_test.c resctrlfs.c resctrl.h resctrl_val.c -o /home/reinette/dev/linux/tools/testing/selftests/resctrl/resctrl_tests
make: Leaving directory '/home/reinette/dev/linux/tools/testing/selftests/resctrl'
../dev/linux$ sudo ./tools/testing/selftests/resctrl/resctrl_tests
[SNIP]
../dev/linux$ mount | grep resctrl #umounted after test run
../dev/linux$ ls /sys/fs/resctrl/ #empty
../dev/linux$
>
> Please send a patch on top of linux-kselftest next.
Will do, as soon as I can figure out what is going on.
Reinette
next prev parent reply other threads:[~2024-02-23 23:11 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-16 8:34 [PATCH v6 0/5] selftests/resctrl: Add non-contiguous CBMs in Intel CAT selftest Maciej Wieczor-Retman
2024-02-16 8:34 ` [PATCH v6 1/5] selftests/resctrl: Add test groups and name L3 CAT test L3_CAT Maciej Wieczor-Retman
2024-02-16 8:35 ` [PATCH v6 2/5] selftests/resctrl: Add a helper for the non-contiguous test Maciej Wieczor-Retman
2024-02-16 8:35 ` [PATCH v6 3/5] selftests/resctrl: Split validate_resctrl_feature_request() Maciej Wieczor-Retman
2024-02-16 11:21 ` Ilpo Järvinen
2024-02-20 20:51 ` Reinette Chatre
2024-02-16 8:35 ` [PATCH v6 4/5] selftests/resctrl: Add resource_info_file_exists() Maciej Wieczor-Retman
2024-02-20 20:52 ` Reinette Chatre
2024-02-16 8:35 ` [PATCH v6 5/5] selftests/resctrl: Add non-contiguous CBMs CAT test Maciej Wieczor-Retman
2024-02-16 11:22 ` Ilpo Järvinen
2024-02-22 17:05 ` [PATCH v6 0/5] selftests/resctrl: Add non-contiguous CBMs in Intel CAT selftest Reinette Chatre
2024-02-23 22:29 ` Shuah Khan
2024-02-23 22:33 ` Reinette Chatre
2024-02-23 22:37 ` Shuah Khan
2024-02-23 23:11 ` Reinette Chatre [this message]
2024-02-26 9:28 ` Maciej Wieczor-Retman
2024-02-28 0:08 ` Shuah Khan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ede77e93-1bb3-4bd1-9c05-919ad512c2e1@intel.com \
--to=reinette.chatre@intel.com \
--cc=fenghua.yu@intel.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=maciej.wieczor-retman@intel.com \
--cc=shuah@kernel.org \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).