* [PATCH] ata: simplify the return expression of brcm_ahci_remove
@ 2022-05-05 2:21 cgel.zte
2022-05-09 11:44 ` Damien Le Moal
0 siblings, 1 reply; 2+ messages in thread
From: cgel.zte @ 2022-05-05 2:21 UTC (permalink / raw)
To: damien.lemoal; +Cc: linux-ide, linux-kernel, Minghao Chi, Zeal Robot
From: Minghao Chi <chi.minghao@zte.com.cn>
Simplify the return expression.
Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: Minghao Chi <chi.minghao@zte.com.cn>
---
drivers/ata/ahci_brcm.c | 7 +------
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/drivers/ata/ahci_brcm.c b/drivers/ata/ahci_brcm.c
index ab8552b1ff2a..f61795c546cf 100644
--- a/drivers/ata/ahci_brcm.c
+++ b/drivers/ata/ahci_brcm.c
@@ -549,15 +549,10 @@ static int brcm_ahci_remove(struct platform_device *pdev)
struct ata_host *host = dev_get_drvdata(&pdev->dev);
struct ahci_host_priv *hpriv = host->private_data;
struct brcm_ahci_priv *priv = hpriv->plat_data;
- int ret;
brcm_sata_phys_disable(priv);
- ret = ata_platform_remove_one(pdev);
- if (ret)
- return ret;
-
- return 0;
+ return ata_platform_remove_one(pdev);
}
static void brcm_ahci_shutdown(struct platform_device *pdev)
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ata: simplify the return expression of brcm_ahci_remove
2022-05-05 2:21 [PATCH] ata: simplify the return expression of brcm_ahci_remove cgel.zte
@ 2022-05-09 11:44 ` Damien Le Moal
0 siblings, 0 replies; 2+ messages in thread
From: Damien Le Moal @ 2022-05-09 11:44 UTC (permalink / raw)
To: cgel.zte; +Cc: linux-ide, linux-kernel, Minghao Chi, Zeal Robot
On 2022/05/05 11:21, cgel.zte@gmail.com wrote:
> From: Minghao Chi <chi.minghao@zte.com.cn>
>
> Simplify the return expression.
>
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: Minghao Chi <chi.minghao@zte.com.cn>
> ---
> drivers/ata/ahci_brcm.c | 7 +------
> 1 file changed, 1 insertion(+), 6 deletions(-)
>
> diff --git a/drivers/ata/ahci_brcm.c b/drivers/ata/ahci_brcm.c
> index ab8552b1ff2a..f61795c546cf 100644
> --- a/drivers/ata/ahci_brcm.c
> +++ b/drivers/ata/ahci_brcm.c
> @@ -549,15 +549,10 @@ static int brcm_ahci_remove(struct platform_device *pdev)
> struct ata_host *host = dev_get_drvdata(&pdev->dev);
> struct ahci_host_priv *hpriv = host->private_data;
> struct brcm_ahci_priv *priv = hpriv->plat_data;
> - int ret;
>
> brcm_sata_phys_disable(priv);
>
> - ret = ata_platform_remove_one(pdev);
> - if (ret)
> - return ret;
> -
> - return 0;
> + return ata_platform_remove_one(pdev);
> }
>
> static void brcm_ahci_shutdown(struct platform_device *pdev)
Applied to for-5.19. Thanks !
--
Damien Le Moal
Western Digital Research
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-05-09 11:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-05 2:21 [PATCH] ata: simplify the return expression of brcm_ahci_remove cgel.zte
2022-05-09 11:44 ` Damien Le Moal
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).