From: Kishon Vijay Abraham I <kishon@ti.com>
To: Bjorn Andersson <bjorn.andersson@linaro.org>,
Nathan Chancellor <natechancellor@gmail.com>
Cc: Andy Gross <agross@kernel.org>, <linux-arm-msm@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
<clang-built-linux@googlegroups.com>
Subject: Re: [PATCH] phy: qualcomm: Adjust indentation in read_poll_timeout
Date: Fri, 20 Dec 2019 16:55:07 +0530 [thread overview]
Message-ID: <a5743631-5e45-ef36-d1b5-61f445fd7018@ti.com> (raw)
In-Reply-To: <20191218062906.GB3755841@builder>
On 18/12/19 11:59 am, Bjorn Andersson wrote:
> On Tue 17 Dec 17:36 PST 2019, Nathan Chancellor wrote:
>
>> Clang warns:
>>
>> ../drivers/phy/qualcomm/phy-qcom-apq8064-sata.c:83:4: warning:
>> misleading indentation; statement is not part of the previous 'if'
>> [-Wmisleading-indentation]
>> usleep_range(DELAY_INTERVAL_US, DELAY_INTERVAL_US + 50);
>> ^
>> ../drivers/phy/qualcomm/phy-qcom-apq8064-sata.c:80:3: note: previous
>> statement is here
>> if (readl_relaxed(addr) & mask)
>> ^
>> 1 warning generated.
>>
>> This warning occurs because there is a space after the tab on this line.
>> Remove it so that the indentation is consistent with the Linux kernel
>> coding style and clang no longer warns.
>>
>
> Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
merged, thanks!
-Kishon
>
>> Fixes: 1de990d8a169 ("phy: qcom: Add driver for QCOM APQ8064 SATA PHY")
>> Link: https://github.com/ClangBuiltLinux/linux/issues/816
>> Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
>> ---
>> drivers/phy/qualcomm/phy-qcom-apq8064-sata.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/phy/qualcomm/phy-qcom-apq8064-sata.c b/drivers/phy/qualcomm/phy-qcom-apq8064-sata.c
>> index 42bc5150dd92..febe0aef68d4 100644
>> --- a/drivers/phy/qualcomm/phy-qcom-apq8064-sata.c
>> +++ b/drivers/phy/qualcomm/phy-qcom-apq8064-sata.c
>> @@ -80,7 +80,7 @@ static int read_poll_timeout(void __iomem *addr, u32 mask)
>> if (readl_relaxed(addr) & mask)
>> return 0;
>>
>> - usleep_range(DELAY_INTERVAL_US, DELAY_INTERVAL_US + 50);
>> + usleep_range(DELAY_INTERVAL_US, DELAY_INTERVAL_US + 50);
>> } while (!time_after(jiffies, timeout));
>>
>> return (readl_relaxed(addr) & mask) ? 0 : -ETIMEDOUT;
>> --
>> 2.24.1
>>
prev parent reply other threads:[~2019-12-20 11:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-18 1:36 [PATCH] phy: qualcomm: Adjust indentation in read_poll_timeout Nathan Chancellor
2019-12-18 6:29 ` Bjorn Andersson
2019-12-20 11:25 ` Kishon Vijay Abraham I [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a5743631-5e45-ef36-d1b5-61f445fd7018@ti.com \
--to=kishon@ti.com \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=clang-built-linux@googlegroups.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=natechancellor@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).