* [PATCH] ACPI: button: Add a DMI quirk for Razer Blade Stealth 13 late 2019 lid-switch
@ 2019-12-06 17:54 Jason Ekstrand
2019-12-08 14:05 ` Hans de Goede
2020-01-02 20:27 ` Jason Ekstrand
0 siblings, 2 replies; 7+ messages in thread
From: Jason Ekstrand @ 2019-12-06 17:54 UTC (permalink / raw)
Cc: hdegoede, Jason Ekstrand, Rafael J. Wysocki, Len Brown,
linux-acpi, linux-kernel
Running evemu-record on the lid switch event shows that the lid reports
the first close but then never reports an open. This causes systemd to
continuously re-suspend the laptop every 30s. Resetting the _LID to
open fixes the issue.
Signed-off-by: Jason Ekstrand <jason@jlekstrand.net>
---
Re-sending due to a typo in my own e-mail address. :(
drivers/acpi/button.c | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/drivers/acpi/button.c b/drivers/acpi/button.c
index 662e07afe9a1..f7ca94e41c48 100644
--- a/drivers/acpi/button.c
+++ b/drivers/acpi/button.c
@@ -122,6 +122,17 @@ static const struct dmi_system_id dmi_lid_quirks[] = {
},
.driver_data = (void *)(long)ACPI_BUTTON_LID_INIT_OPEN,
},
+ {
+ /*
+ * Razer Blade Stealth 13 late 2019, _LID reports the first
+ * close but never resets to open.
+ */
+ .matches = {
+ DMI_MATCH(DMI_SYS_VENDOR, "Razer"),
+ DMI_MATCH(DMI_PRODUCT_NAME, "Razer Blade Stealth 13 Late 2019"),
+ },
+ .driver_data = (void *)(long)ACPI_BUTTON_LID_INIT_OPEN,
+ },
{}
};
--
2.23.0
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] ACPI: button: Add a DMI quirk for Razer Blade Stealth 13 late 2019 lid-switch
2019-12-06 17:54 [PATCH] ACPI: button: Add a DMI quirk for Razer Blade Stealth 13 late 2019 lid-switch Jason Ekstrand
@ 2019-12-08 14:05 ` Hans de Goede
[not found] ` <CAOFGe95h-eKPiS-7D8_Lg3wcOR-yuQQNkunw21K_rQ64DtCMJw@mail.gmail.com>
2020-01-02 20:27 ` Jason Ekstrand
1 sibling, 1 reply; 7+ messages in thread
From: Hans de Goede @ 2019-12-08 14:05 UTC (permalink / raw)
To: Jason Ekstrand; +Cc: Rafael J. Wysocki, Len Brown, linux-acpi, linux-kernel
Hi,
On 06-12-2019 18:54, Jason Ekstrand wrote:
> Running evemu-record on the lid switch event shows that the lid reports
> the first close but then never reports an open. This causes systemd to
> continuously re-suspend the laptop every 30s. Resetting the _LID to
> open fixes the issue.
Sorry to be a bit nitpicky here, but the LID does work normally right,
so it does signal an event when it gets closed a second time right?
Your current commit message and comment suggest closing the LID only
works once. So perhaps something like this for the comment:
/*
* Razer Blade Stealth 13 late 2019, _LID always reports closed,
* even when opened.
*/
And adjust the comment accordingly.
Regards,
Hans
> Signed-off-by: Jason Ekstrand <jason@jlekstrand.net>
> ---
>
> Re-sending due to a typo in my own e-mail address. :(
>
> drivers/acpi/button.c | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> diff --git a/drivers/acpi/button.c b/drivers/acpi/button.c
> index 662e07afe9a1..f7ca94e41c48 100644
> --- a/drivers/acpi/button.c
> +++ b/drivers/acpi/button.c
> @@ -122,6 +122,17 @@ static const struct dmi_system_id dmi_lid_quirks[] = {
> },
> .driver_data = (void *)(long)ACPI_BUTTON_LID_INIT_OPEN,
> },
> + {
> + /*
> + * Razer Blade Stealth 13 late 2019, _LID reports the first
> + * close but never resets to open.
> + */
> + .matches = {
> + DMI_MATCH(DMI_SYS_VENDOR, "Razer"),
> + DMI_MATCH(DMI_PRODUCT_NAME, "Razer Blade Stealth 13 Late 2019"),
> + },
> + .driver_data = (void *)(long)ACPI_BUTTON_LID_INIT_OPEN,
> + },
> {}
> };
>
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] ACPI: button: Add a DMI quirk for Razer Blade Stealth 13 late 2019 lid-switch
2019-12-06 17:54 [PATCH] ACPI: button: Add a DMI quirk for Razer Blade Stealth 13 late 2019 lid-switch Jason Ekstrand
2019-12-08 14:05 ` Hans de Goede
@ 2020-01-02 20:27 ` Jason Ekstrand
2020-01-02 21:27 ` Hans de Goede
1 sibling, 1 reply; 7+ messages in thread
From: Jason Ekstrand @ 2020-01-02 20:27 UTC (permalink / raw)
Cc: hdegoede, Jason Ekstrand, Rafael J. Wysocki, Len Brown,
linux-acpi, linux-kernel
Running evemu-record on the lid switch event shows that the lid reports
the first close but then never reports an open. This causes systemd to
continuously re-suspend the laptop every 30s. Resetting the _LID to
open fixes the issue.
v2: Updated the comment to better describe the behavior of ACPI
Signed-off-by: Jason Ekstrand <jason@jlekstrand.net>
---
drivers/acpi/button.c | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/drivers/acpi/button.c b/drivers/acpi/button.c
index 662e07afe9a1..ef5d473e7992 100644
--- a/drivers/acpi/button.c
+++ b/drivers/acpi/button.c
@@ -122,6 +122,17 @@ static const struct dmi_system_id dmi_lid_quirks[] = {
},
.driver_data = (void *)(long)ACPI_BUTTON_LID_INIT_OPEN,
},
+ {
+ /*
+ * Razer Blade Stealth 13 late 2019, notification of the LID device
+ * only happens on close, not on open and _LID always returns closed.
+ */
+ .matches = {
+ DMI_MATCH(DMI_SYS_VENDOR, "Razer"),
+ DMI_MATCH(DMI_PRODUCT_NAME, "Razer Blade Stealth 13 Late 2019"),
+ },
+ .driver_data = (void *)(long)ACPI_BUTTON_LID_INIT_OPEN,
+ },
{}
};
--
2.23.0
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] ACPI: button: Add a DMI quirk for Razer Blade Stealth 13 late 2019 lid-switch
2020-01-02 20:27 ` Jason Ekstrand
@ 2020-01-02 21:27 ` Hans de Goede
2020-01-07 10:53 ` Rafael J. Wysocki
0 siblings, 1 reply; 7+ messages in thread
From: Hans de Goede @ 2020-01-02 21:27 UTC (permalink / raw)
To: Jason Ekstrand; +Cc: Rafael J. Wysocki, Len Brown, linux-acpi, linux-kernel
Hi,
On 02-01-2020 21:27, Jason Ekstrand wrote:
> Running evemu-record on the lid switch event shows that the lid reports
> the first close but then never reports an open. This causes systemd to
> continuously re-suspend the laptop every 30s. Resetting the _LID to
> open fixes the issue.
>
> v2: Updated the comment to better describe the behavior of ACPI
>
> Signed-off-by: Jason Ekstrand <jason@jlekstrand.net>
Thanks, looks good to me now:
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Regards,
Hans
> ---
> drivers/acpi/button.c | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> diff --git a/drivers/acpi/button.c b/drivers/acpi/button.c
> index 662e07afe9a1..ef5d473e7992 100644
> --- a/drivers/acpi/button.c
> +++ b/drivers/acpi/button.c
> @@ -122,6 +122,17 @@ static const struct dmi_system_id dmi_lid_quirks[] = {
> },
> .driver_data = (void *)(long)ACPI_BUTTON_LID_INIT_OPEN,
> },
> + {
> + /*
> + * Razer Blade Stealth 13 late 2019, notification of the LID device
> + * only happens on close, not on open and _LID always returns closed.
> + */
> + .matches = {
> + DMI_MATCH(DMI_SYS_VENDOR, "Razer"),
> + DMI_MATCH(DMI_PRODUCT_NAME, "Razer Blade Stealth 13 Late 2019"),
> + },
> + .driver_data = (void *)(long)ACPI_BUTTON_LID_INIT_OPEN,
> + },
> {}
> };
>
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] ACPI: button: Add a DMI quirk for Razer Blade Stealth 13 late 2019 lid-switch
2020-01-02 21:27 ` Hans de Goede
@ 2020-01-07 10:53 ` Rafael J. Wysocki
0 siblings, 0 replies; 7+ messages in thread
From: Rafael J. Wysocki @ 2020-01-07 10:53 UTC (permalink / raw)
To: Hans de Goede, Jason Ekstrand
Cc: Rafael J. Wysocki, Len Brown, ACPI Devel Maling List,
Linux Kernel Mailing List
On Thu, Jan 2, 2020 at 10:27 PM Hans de Goede <hdegoede@redhat.com> wrote:
>
> Hi,
>
> On 02-01-2020 21:27, Jason Ekstrand wrote:
> > Running evemu-record on the lid switch event shows that the lid reports
> > the first close but then never reports an open. This causes systemd to
> > continuously re-suspend the laptop every 30s. Resetting the _LID to
> > open fixes the issue.
> >
> > v2: Updated the comment to better describe the behavior of ACPI
> >
> > Signed-off-by: Jason Ekstrand <jason@jlekstrand.net>
>
> Thanks, looks good to me now:
>
> Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Applied as 5.6 material, thanks!
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] ACPI: button: Add a DMI quirk for Razer Blade Stealth 13 late 2019 lid-switch
@ 2019-12-06 17:47 Jason Ekstrand
0 siblings, 0 replies; 7+ messages in thread
From: Jason Ekstrand @ 2019-12-06 17:47 UTC (permalink / raw)
Cc: hdegoede, Jason Ekstrand, Rafael J. Wysocki, Len Brown,
linux-acpi, linux-kernel
From: Jason Ekstrand <jason@jekstrand.net>
Running evemu-record on the lid switch event shows that the lid reports
the first close but then never reports an open. This causes systemd to
continuously re-suspend the laptop every 30s. Resetting the _LID to
open fixes the issue.
Signed-off-by: Jason Ekstrand <jason@jekstrand.net>
---
drivers/acpi/button.c | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/drivers/acpi/button.c b/drivers/acpi/button.c
index 662e07afe9a1..f7ca94e41c48 100644
--- a/drivers/acpi/button.c
+++ b/drivers/acpi/button.c
@@ -122,6 +122,17 @@ static const struct dmi_system_id dmi_lid_quirks[] = {
},
.driver_data = (void *)(long)ACPI_BUTTON_LID_INIT_OPEN,
},
+ {
+ /*
+ * Razer Blade Stealth 13 late 2019, _LID reports the first
+ * close but never resets to open.
+ */
+ .matches = {
+ DMI_MATCH(DMI_SYS_VENDOR, "Razer"),
+ DMI_MATCH(DMI_PRODUCT_NAME, "Razer Blade Stealth 13 Late 2019"),
+ },
+ .driver_data = (void *)(long)ACPI_BUTTON_LID_INIT_OPEN,
+ },
{}
};
--
2.23.0
^ permalink raw reply related [flat|nested] 7+ messages in thread
end of thread, other threads:[~2020-01-07 10:53 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-06 17:54 [PATCH] ACPI: button: Add a DMI quirk for Razer Blade Stealth 13 late 2019 lid-switch Jason Ekstrand
2019-12-08 14:05 ` Hans de Goede
[not found] ` <CAOFGe95h-eKPiS-7D8_Lg3wcOR-yuQQNkunw21K_rQ64DtCMJw@mail.gmail.com>
2019-12-20 10:33 ` Hans de Goede
2020-01-02 20:27 ` Jason Ekstrand
2020-01-02 21:27 ` Hans de Goede
2020-01-07 10:53 ` Rafael J. Wysocki
-- strict thread matches above, loose matches on Subject: below --
2019-12-06 17:47 Jason Ekstrand
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).