* [PATCH -next] scsi: lpfc: Use list_move_tail instead of list_del/list_add_tail
@ 2021-06-08 0:51 Zou Wei
2021-06-08 15:44 ` James Smart
2021-06-16 2:26 ` Martin K. Petersen
0 siblings, 2 replies; 3+ messages in thread
From: Zou Wei @ 2021-06-08 0:51 UTC (permalink / raw)
To: james.smart, dick.kennedy, jejb, martin.petersen
Cc: linux-scsi, linux-kernel, Zou Wei
Using list_move_tail() instead of list_del() + list_add_tail().
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Zou Wei <zou_wei@huawei.com>
---
drivers/scsi/lpfc/lpfc_sli.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/scsi/lpfc/lpfc_sli.c b/drivers/scsi/lpfc/lpfc_sli.c
index e2cfb86..84a9101 100644
--- a/drivers/scsi/lpfc/lpfc_sli.c
+++ b/drivers/scsi/lpfc/lpfc_sli.c
@@ -20162,8 +20162,7 @@ lpfc_cleanup_pending_mbox(struct lpfc_vport *vport)
(mb->u.mb.mbxCommand != MBX_REG_VPI))
continue;
- list_del(&mb->list);
- list_add_tail(&mb->list, &mbox_cmd_list);
+ list_move_tail(&mb->list, &mbox_cmd_list);
}
/* Clean up active mailbox command with the vport */
mb = phba->sli.mbox_active;
--
2.6.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH -next] scsi: lpfc: Use list_move_tail instead of list_del/list_add_tail
2021-06-08 0:51 [PATCH -next] scsi: lpfc: Use list_move_tail instead of list_del/list_add_tail Zou Wei
@ 2021-06-08 15:44 ` James Smart
2021-06-16 2:26 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: James Smart @ 2021-06-08 15:44 UTC (permalink / raw)
To: Zou Wei, james.smart, dick.kennedy, jejb, martin.petersen
Cc: linux-scsi, linux-kernel
On 6/7/2021 5:51 PM, Zou Wei wrote:
> Using list_move_tail() instead of list_del() + list_add_tail().
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Zou Wei <zou_wei@huawei.com>
> ---
> drivers/scsi/lpfc/lpfc_sli.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/scsi/lpfc/lpfc_sli.c b/drivers/scsi/lpfc/lpfc_sli.c
> index e2cfb86..84a9101 100644
> --- a/drivers/scsi/lpfc/lpfc_sli.c
> +++ b/drivers/scsi/lpfc/lpfc_sli.c
> @@ -20162,8 +20162,7 @@ lpfc_cleanup_pending_mbox(struct lpfc_vport *vport)
> (mb->u.mb.mbxCommand != MBX_REG_VPI))
> continue;
>
> - list_del(&mb->list);
> - list_add_tail(&mb->list, &mbox_cmd_list);
> + list_move_tail(&mb->list, &mbox_cmd_list);
> }
> /* Clean up active mailbox command with the vport */
> mb = phba->sli.mbox_active;
>
Thanks
Reviewed-by: James Smart <jsmart2021@gmail.com>
-- james
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH -next] scsi: lpfc: Use list_move_tail instead of list_del/list_add_tail
2021-06-08 0:51 [PATCH -next] scsi: lpfc: Use list_move_tail instead of list_del/list_add_tail Zou Wei
2021-06-08 15:44 ` James Smart
@ 2021-06-16 2:26 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Martin K. Petersen @ 2021-06-16 2:26 UTC (permalink / raw)
To: Zou Wei
Cc: james.smart, dick.kennedy, jejb, martin.petersen, linux-scsi,
linux-kernel
Zou,
> Using list_move_tail() instead of list_del() + list_add_tail().
Applied to 5.14/scsi-staging, thanks!
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-06-16 2:26 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-08 0:51 [PATCH -next] scsi: lpfc: Use list_move_tail instead of list_del/list_add_tail Zou Wei
2021-06-08 15:44 ` James Smart
2021-06-16 2:26 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).