* [PATCH] drm/radeon/kms: crtc_ omitted in display assignments in radeon_atom_mode_fixup()?
@ 2010-01-15 14:11 Roel Kluin
2010-01-15 14:27 ` Alex Deucher
0 siblings, 1 reply; 2+ messages in thread
From: Roel Kluin @ 2010-01-15 14:11 UTC (permalink / raw)
To: David Airlie, dri-devel, Andrew Morton, LKML
The crtc_ prefix was omitted in h/vdisplay assignments
Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
---
Not sure, but maybe the change below is needed? please ack/nack.
diff --git a/drivers/gpu/drm/radeon/radeon_encoders.c b/drivers/gpu/drm/radeon/radeon_encoders.c
index 82eb551..a9dc073 100644
--- a/drivers/gpu/drm/radeon/radeon_encoders.c
+++ b/drivers/gpu/drm/radeon/radeon_encoders.c
@@ -233,8 +233,8 @@ static bool radeon_atom_mode_fixup(struct drm_encoder *encoder,
if (!ASIC_IS_AVIVO(rdev)) {
adjusted_mode->hdisplay = mode->hdisplay;
adjusted_mode->vdisplay = mode->vdisplay;
- adjusted_mode->crtc_hdisplay = mode->hdisplay;
- adjusted_mode->crtc_vdisplay = mode->vdisplay;
+ adjusted_mode->crtc_hdisplay = mode->crtc_hdisplay;
+ adjusted_mode->crtc_vdisplay = mode->crtc_vdisplay;
}
adjusted_mode->base.id = mode_id;
}
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] drm/radeon/kms: crtc_ omitted in display assignments in radeon_atom_mode_fixup()?
2010-01-15 14:11 [PATCH] drm/radeon/kms: crtc_ omitted in display assignments in radeon_atom_mode_fixup()? Roel Kluin
@ 2010-01-15 14:27 ` Alex Deucher
0 siblings, 0 replies; 2+ messages in thread
From: Alex Deucher @ 2010-01-15 14:27 UTC (permalink / raw)
To: Roel Kluin; +Cc: David Airlie, dri-devel, Andrew Morton, LKML
On Fri, Jan 15, 2010 at 9:11 AM, Roel Kluin <roel.kluin@gmail.com> wrote:
> The crtc_ prefix was omitted in h/vdisplay assignments
>
> Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
> ---
> Not sure, but maybe the change below is needed? please ack/nack.
NAK. the code is correct as is.
>
> diff --git a/drivers/gpu/drm/radeon/radeon_encoders.c b/drivers/gpu/drm/radeon/radeon_encoders.c
> index 82eb551..a9dc073 100644
> --- a/drivers/gpu/drm/radeon/radeon_encoders.c
> +++ b/drivers/gpu/drm/radeon/radeon_encoders.c
> @@ -233,8 +233,8 @@ static bool radeon_atom_mode_fixup(struct drm_encoder *encoder,
> if (!ASIC_IS_AVIVO(rdev)) {
> adjusted_mode->hdisplay = mode->hdisplay;
> adjusted_mode->vdisplay = mode->vdisplay;
> - adjusted_mode->crtc_hdisplay = mode->hdisplay;
> - adjusted_mode->crtc_vdisplay = mode->vdisplay;
> + adjusted_mode->crtc_hdisplay = mode->crtc_hdisplay;
> + adjusted_mode->crtc_vdisplay = mode->crtc_vdisplay;
> }
> adjusted_mode->base.id = mode_id;
> }
>
> ------------------------------------------------------------------------------
> Throughout its 18-year history, RSA Conference consistently attracts the
> world's best and brightest in the field, creating opportunities for Conference
> attendees to learn about information security's most important issues through
> interactions with peers, luminaries and emerging and established companies.
> http://p.sf.net/sfu/rsaconf-dev2dev
> --
> _______________________________________________
> Dri-devel mailing list
> Dri-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/dri-devel
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-01-15 14:27 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-01-15 14:11 [PATCH] drm/radeon/kms: crtc_ omitted in display assignments in radeon_atom_mode_fixup()? Roel Kluin
2010-01-15 14:27 ` Alex Deucher
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).